Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Dec 20, 2011
  1. @dhh

    Party like its R-C-UNO!

    dhh authored
Commits on Dec 16, 2011
  1. @josevalim

    Merge pull request #4007 from exviva/expand_cache_key_for_one_element…

    josevalim authored
    Fix expanding cache key for single element arrays
  2. @exviva

    Fix expanding cache key for single element arrays

    exviva authored
    In short:
    expand_cache_key(element) should not equal expand_cache_key([element])
    This way a fragment cache key for an index page with only a single
    element in the collection is different than a fragment cache for a
    typical show page for that element.
Commits on Dec 13, 2011
  1. @josevalim

    Merge pull request #3963 from lest/logger-missing-require

    josevalim authored
    missing require in buffered logger
  2. @josevalim
  3. @lest
  4. @josevalim
  5. @lest
Commits on Dec 12, 2011
  1. @josevalim

    Merge pull request #3954 from bdurand/null_store_2

    josevalim authored
    Add ActiveSupport::Cache::NullStore for testing and development
  2. @josevalim

    Speed up development by only reloading classes if dependencies files …

    josevalim authored
    This can be turned off by setting `config.reload_classes_only_on_change` to false.
    Extensions like Active Record should add their respective files like db/schema.rb and db/structure.sql to `config.watchable_files` if they want their changes to affect classes reloading.
    Thanks to and Pastorino for the inspiration. <3
  3. @josevalim
  4. @bdurand

    Add ActiveSupport::Cache::NullStore to expose caching interface witho…

    bdurand authored
    …ut actually caching for development and test environments.
  5. @josevalim
  6. @josevalim
Commits on Dec 11, 2011
  1. @jeremy
  2. @jeremy

    Use 1.9 native XML escaping to speed up html_escape and shush regexp …

    jeremy authored
            length      user     system      total        real
    before  6      0.010000   0.000000   0.010000 (  0.012378)
    after   6      0.010000   0.000000   0.010000 (  0.012866)
    before  60     0.040000   0.000000   0.040000 (  0.046273)
    after   60     0.040000   0.000000   0.040000 (  0.036421)
    before  600    0.390000   0.000000   0.390000 (  0.390670)
    after   600    0.210000   0.000000   0.210000 (  0.209094)
    before  6000   3.750000   0.000000   3.750000 (  3.751008)
    after   6000   1.860000   0.000000   1.860000 (  1.857901)
  3. @azimux
  4. @tenderlove
Commits on Dec 10, 2011
  1. @josevalim

    Fix AS test suite.

    josevalim authored
  2. @tenderlove

    * ActiveSupport::BufferedLogger#silence is deprecated. If you want to…

    tenderlove authored
    … squelch
        logs for a certain block, change the log level for that block.
    *   ActiveSupport::BufferedLogger#open_log is deprecated.  This method should
        not have been public in the first place.
    *   ActiveSupport::BufferedLogger's behavior of automatically creating the
        directory for your log file is deprecated.  Please make sure to create the
        directory for your log file before instantiating.
    *   ActiveSupport::BufferedLogger#auto_flushing is deprecated.  Either set the
        sync level on the underlying file handle like this:
            f ='foo.log', 'w')
            f.sync = true
        Or tune your filesystem.  The FS cache is now what controls flushing.
    *   ActiveSupport::BufferedLogger#flush is deprecated.  Set sync on your
        filehandle, or tune your filesystem.
Commits on Dec 8, 2011
  1. @vijaydev

    fix nodocs

    vijaydev authored
  2. @josevalim

    Remove NilClass whiners feature.

    josevalim authored
    Removing this feature causes boost in performance when using Ruby 1.9.
    Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str`
    in some STDLIB methods (like Array#join). To do such implicit conversions,
    Ruby 1.9 always dispatches the method and rescues the NoMethodError exception
    in case one is raised.
    Therefore, since the whiners feature defined NilClass#method_missing, such
    implicit conversions for nil became much, much slower. In fact, just defining
    NilClass#method_missing (even without the whiners feature) already causes a
    massive slow down. Here is a snippet that shows such slow down:
        require "benchmark"
        Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
        class NilClass
          def method_missing(*args)
            raise NoMethodError
        Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
  3. @mark-rushakoff
Commits on Dec 6, 2011
  1. @josevalim

    Just track "require" if we have something in the watching stack.

    josevalim authored
    A patch has been provided earlier and we have asked for feedback:
    Except one case, all other cases showed improvements in boot time.
  2. @tenderlove
  3. @tenderlove
Commits on Dec 4, 2011
  1. @tenderlove

    Merge pull request #3845 from sumbach/test-return-value-from-require

    tenderlove authored
    Add tests for the return value of require
Commits on Dec 3, 2011
  1. @sumbach

    Simplify load and require tests

    sumbach authored
    - These tests don't use autoloading so there's no need to add anything to autoload_paths
  2. @sumbach
  3. @sumbach
  4. @sumbach

    Test return value of ActiveSupport::Dependencies::Loadable#require

    sumbach authored
    - Add tests to protect from regressions in require's return value behavior
    - See a10606c (require needs to return true or false) for the original bug fix
  5. @jenseng @josevalim

    Restore performance of ERB::Util.html_escape

    jenseng authored josevalim committed
    Revert html_escape to do a single gsub again, but add the "n" flag (no
    language, i.e. not multi-byte) to protect against XSS via invalid utf8
    Signed-off-by: José Valim <>
Commits on Dec 2, 2011
  1. @dhh
Commits on Nov 30, 2011
  1. @tenderlove
  2. @josevalim

    Revert "Implement ArraySerializer and move old serialization API to a…

    josevalim authored
    … new namespace."
    This reverts commit 8896b4f.
Something went wrong with that request. Please try again.