Skip to content
This repository

Dec 29, 2011

  1. Jo Liss

    Document that index names are made up of all columns, not just the fi…

    …rst.
    
    index_name has been using the following expression
    
        "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}"
    
    since at least 2006 (bc7f231), and that's how they come out in my DB.
    
    Please check that this is correct before merging into master, perhaps
    I'm misunderstanding the section I changed.
    authored vijaydev committed

Dec 13, 2011

  1. Jon Leighton

    Revert naive O(1) table_exists? implementation.

    It was a bad idea to rescue exceptions here. This can interfere with
    transaction rollbacks which seems to be the cause of current CI
    failure.
    
    Instead, each adapter should implement its own DB-specific O(1)
    implementation, and we fall back on the generic, slower, implementation
    otherwise.
    authored

Dec 09, 2011

  1. Aaron Patterson

    don't need a begin / end.

    authored
  2. Aaron Patterson

    squelch table exists? queries.

    authored

Dec 08, 2011

  1. Aaron Patterson

    Exceptions should read from the spec configu

    authored
  2. Vijay Dev

    fix nodocs

    authored
  3. Vijay Dev

    fix comments

    authored
  4. Aaron Patterson

    Use a hash to look up column definitions

    authored
  5. Aaron Patterson

    try to normalize the objects passed to column()

    authored
  6. Aaron Patterson

    automatically add the column definition to the columns list if creati…

    …ng a new one
    authored

Dec 07, 2011

  1. Aaron Patterson

    stop calling String#to_s so frequently

    authored

Dec 05, 2011

  1. Aaron Patterson

    Quitoting the table name before querying.

    authored
  2. Jade Rubick

    Speed up table_exists? for databases with a large number of tables

    At New Relic, we have hundreds of thousands of tables, and our migrations took 30 minutes without this similar patch. This cuts it down to a more reasonable amount of time.
    
    The rescue false part is ugly, but necessary as far as I can tell. I don't know of a cross-database statement you can make that will work without trapping errors.
    authored

Nov 29, 2011

  1. Aaron Patterson

    push synchronization in to each method. Reduces method calls and makes

    it clear which methods are synchronized.
    authored
  2. Aaron Patterson

    Automatic closure of connections in threads is deprecated. For example

    the following code is deprecated:
    
    Thread.new { Post.find(1) }.join
    
    It should be changed to close the database connection at the end of
    the thread:
    
    Thread.new {
      Post.find(1)
      Post.connection.close
    }.join
    
    Only people who spawn threads in their application code need to worry
    about this change.
    authored
  3. Aaron Patterson

    AbstractAdapter#close can be called to add the connection back to the

    pool.
    authored
  4. Aaron Patterson

    Start implementing @reserved_connections in terms of connection leases.

    authored
  5. Aaron Patterson

    Rename `checked_out` to more descriptive `active_connections`

    authored
  6. Aaron Patterson

    Use connection lease to determine "checked_out" connections

    authored
  7. Jon Leighton

    Deprecate set_primary_key in favour of self.primary_key=

    authored
  8. Aaron Patterson

    respond_to? information of AR is not the responsibility of the spec

    resolver.
    authored

Nov 28, 2011

  1. Aaron Patterson

    remove unused instance variable

    authored
  2. Aaron Patterson

    just check in all connections

    authored
  3. Aaron Patterson

    Move connection resoluion logic to it's own testable class.

    authored
  4. Aaron Patterson

    clean up string => hash conversion for connection pool

    authored
  5. Aaron Patterson

    pools are 1:1 with spec now rather than 1:1 with class

    authored
  6. Aaron Patterson

    break establish_connection to smaller methods

    authored

Nov 20, 2011

  1. Aaron Patterson

    oops! I suck! :bomb:

    authored
  2. Aaron Patterson

    pushing caching and visitors down to the connection

    authored

Nov 17, 2011

  1. Aaron Patterson

    Revert "Merge pull request #1163 from amatsuda/sexier_migration_31"

    This reverts commit 0e407a9, reversing
    changes made to 533a9f8.
    
    Conflicts:
    
    	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
    	activerecord/test/cases/migration_test.rb
    authored
  2. Aaron Patterson

    Revert "Merge pull request #3603 from vijaydev/change_table_without_b…

    …lock_arg"
    
    This reverts commit 81fad6a, reversing
    changes made to 23101de.
    
    Conflicts:
    
    	activerecord/test/cases/migration_test.rb
    authored

Nov 16, 2011

  1. Aaron Patterson

    Adding a deprecation warning for use of the schema_info table.

    authored

Nov 13, 2011

  1. Noé Froidevaux

    Fix pull request #3609

    authored

Nov 11, 2011

  1. Noé Froidevaux

    Prevent multiple SHOW TABLES calls when a table don't exists in datab…

    …ase.
    authored

Nov 10, 2011

  1. Vijay Dev

    Modify change_table to remove the need for the block argument.

    authored
Something went wrong with that request. Please try again.