Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Dec 29, 2011
  1. Jo Liss Vijay Dev

    Document that index names are made up of all columns, not just the fi…

    joliss authored vijaydev committed
    …rst.
    
    index_name has been using the following expression
    
        "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}"
    
    since at least 2006 (bc7f231), and that's how they come out in my DB.
    
    Please check that this is correct before merging into master, perhaps
    I'm misunderstanding the section I changed.
Commits on Dec 13, 2011
  1. Jon Leighton

    Revert naive O(1) table_exists? implementation.

    jonleighton authored
    It was a bad idea to rescue exceptions here. This can interfere with
    transaction rollbacks which seems to be the cause of current CI
    failure.
    
    Instead, each adapter should implement its own DB-specific O(1)
    implementation, and we fall back on the generic, slower, implementation
    otherwise.
Commits on Dec 9, 2011
  1. Aaron Patterson

    don't need a begin / end.

    tenderlove authored
  2. Aaron Patterson
Commits on Dec 8, 2011
  1. Aaron Patterson
  2. Vijay Dev

    fix nodocs

    vijaydev authored
  3. Vijay Dev

    fix comments

    vijaydev authored
  4. Aaron Patterson
  5. Aaron Patterson
  6. Aaron Patterson
Commits on Dec 7, 2011
  1. Aaron Patterson
Commits on Dec 5, 2011
  1. Aaron Patterson
  2. Jade Rubick

    Speed up table_exists? for databases with a large number of tables

    jadeforrest authored
    At New Relic, we have hundreds of thousands of tables, and our migrations took 30 minutes without this similar patch. This cuts it down to a more reasonable amount of time.
    
    The rescue false part is ugly, but necessary as far as I can tell. I don't know of a cross-database statement you can make that will work without trapping errors.
Commits on Nov 29, 2011
  1. Aaron Patterson

    push synchronization in to each method. Reduces method calls and makes

    tenderlove authored
    it clear which methods are synchronized.
  2. Aaron Patterson

    Automatic closure of connections in threads is deprecated. For example

    tenderlove authored
    the following code is deprecated:
    
    Thread.new { Post.find(1) }.join
    
    It should be changed to close the database connection at the end of
    the thread:
    
    Thread.new {
      Post.find(1)
      Post.connection.close
    }.join
    
    Only people who spawn threads in their application code need to worry
    about this change.
  3. Aaron Patterson
  4. Aaron Patterson
  5. Aaron Patterson
  6. Aaron Patterson
  7. Jon Leighton
  8. Aaron Patterson
Commits on Nov 28, 2011
  1. Aaron Patterson
  2. Aaron Patterson
  3. Aaron Patterson
  4. Aaron Patterson
  5. Aaron Patterson
  6. Aaron Patterson
Commits on Nov 20, 2011
  1. Aaron Patterson

    oops! I suck! :bomb:

    tenderlove authored
  2. Aaron Patterson
Commits on Nov 17, 2011
  1. Aaron Patterson

    Revert "Merge pull request #1163 from amatsuda/sexier_migration_31"

    tenderlove authored
    This reverts commit 0e407a9, reversing
    changes made to 533a9f8.
    
    Conflicts:
    
    	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
    	activerecord/test/cases/migration_test.rb
  2. Aaron Patterson

    Revert "Merge pull request #3603 from vijaydev/change_table_without_b…

    tenderlove authored
    …lock_arg"
    
    This reverts commit 81fad6a, reversing
    changes made to 23101de.
    
    Conflicts:
    
    	activerecord/test/cases/migration_test.rb
Commits on Nov 16, 2011
  1. Aaron Patterson
Commits on Nov 13, 2011
  1. Noé Froidevaux

    Fix pull request #3609

    noefroidevaux authored
Commits on Nov 11, 2011
  1. Noé Froidevaux
Commits on Nov 10, 2011
  1. Vijay Dev
Something went wrong with that request. Please try again.