Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Dec 23, 2012
  1. @tenderlove

    bumping version to 3.2.10

    tenderlove authored
  2. @tenderlove
  3. @tenderlove

    updating changelog

    tenderlove authored
  4. @tenderlove
  5. @claudiob @tenderlove

    Add release date of Rails 3.2.9 to documentation

    claudiob authored tenderlove committed
    Conflicts:
    	actionpack/CHANGELOG.md
    	activerecord/CHANGELOG.md
    	activesupport/CHANGELOG.md
Commits on Nov 12, 2012
  1. @spastorino

    Bump to 3.2.9

    spastorino authored
Commits on Nov 9, 2012
  1. @spastorino

    Bump up to 3.2.9.rc3

    spastorino authored
Commits on Nov 1, 2012
  1. @spastorino

    Bump to 3.2.9.rc2

    spastorino authored
  2. @carlosantoniodasilva
  3. @carlosantoniodasilva

    Fix issue with collection associations and first(n)/last(n)

    carlosantoniodasilva authored
    When calling first(n) or last(n) in a collection, Active Record was
    improperly trying to set the inverse of instance in case that option
    existed. This change was introduced by
    fdf4eae.
    
    In such cases we don't need to do that "manually", since the way
    collection will be loaded will already handle that, so we just skip
    setting the inverse association when any argument is given to
    first(n)/last(n).
    
    The test included ensures that these scenarios will have the inverse of
    instance set properly.
    
    Fixes #8087, Closes #8094.
Commits on Oct 31, 2012
  1. @fxn

    relaxes assertion

    fxn authored
    This method returns the status of the operation,
    but as we generally do in the code base it does
    not commit to any particular exact value. Hence,
    we do not have to check for a singleton, because
    if the implementation changes and returns some
    other true value the test should pass.
  2. @saks
Commits on Oct 30, 2012
  1. @rafaelfranca

    Add CHANGELOG entry to #8032 fix

    rafaelfranca authored
    e6b4184 fixes that issue too.
    
    [ci skip]
  2. @rafaelfranca

    Fix typo :bomb: [ci skip]

    rafaelfranca authored
  3. @rafaelfranca

    Fix bug when Column is trying to type cast boolean values to integer.

    rafaelfranca authored
    This can occur if the user is using :integer columns to store boolean
    values. Now we are handling the boolean values but it still raises if
    the value can't type cast to integer and is not a boolean. See #7509.
    
    Fixes #8067.
Commits on Oct 29, 2012
  1. @rafaelfranca

    Merge pull request #8009 from graceliu/3-2-fix_database_url_support

    rafaelfranca authored
    fixed support for DATABASE_URL for rake db tasks
  2. @graceliu @rafaelfranca

    fixed support for DATABASE_URL for rake db tasks

    graceliu authored rafaelfranca committed
    Backport for #7521
    
    - added tests to confirm establish_connection uses DATABASE_URL and
      Rails.env correctly even when no arguments are passed in.
    - updated rake db tasks to support DATABASE_URL, and added tests to
      confirm correct behavior for these rake tasks.  (Removed
      establish_connection call from some tasks since in those cases
      the :environment task already made sure the function would be called)
    - updated Resolver so that when it resolves the database url, it
      removes hash values with empty strings from the config spec (e.g.
      to support connection to postgresql when no username is specified).
    - updated ResolverTest to use current_adapter? to check the type of
      the current adapter.
  3. @spastorino

    Bump to 3.2.9.rc1

    spastorino authored
  4. @rafaelfranca

    Merge pull request #8057 from frodsan/fix_sqlite_mutate_arg

    rafaelfranca authored
    SQLite3Adapter#type_cast should not mutate arguments
    Conflicts:
    	activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
  5. @carlosantoniodasilva @rafaelfranca

    Merge pull request #8053 from henrik/update_columns_with_primary_key

    carlosantoniodasilva authored rafaelfranca committed
    Unbreak update_column/update_columns for the primary key attribute.
    Conflicts:
    	activerecord/CHANGELOG.md
    	activerecord/lib/active_record/persistence.rb
    	activerecord/test/cases/persistence_test.rb
  6. @rafaelfranca

    Make Active Record tests pass in isolation

    rafaelfranca authored
    Also remove the feature detecting for Ruby 1.9
  7. @rafaelfranca

    Fix the skip code.

    rafaelfranca authored
    Checking for the constant doesn't work
  8. @rafaelfranca

    Merge pull request #7593 from veader/patch-1

    rafaelfranca authored
    Decode attributes pulled from URI.parse
    Conflicts:
    	activerecord/CHANGELOG.md
    	activerecord/lib/active_record/connection_adapters/connection_specification.rb
Commits on Oct 22, 2012
  1. @tenderlove
Commits on Oct 18, 2012
  1. @Grandrath

    Use `Rails.env` instead of `ENV['RAILS_ENV']`; #7951

    Grandrath authored
    `ENV['RAILS_ENV']` is not defined unless explicitly specified on the
    command line when running `rake db:structure:load`. This patch lets
    the rake task retrieve the environment from `Rails.env` which defaults
    to "development".
  2. @spastorino @rafaelfranca

    Merge pull request #7371 from csmuc/fix_dup_validation_errors

    spastorino authored rafaelfranca committed
    Dup'ed ActiveRecord objects may not share the errors object
    Conflicts:
    	activerecord/CHANGELOG.md
    	activerecord/test/cases/dup_test.rb
Commits on Oct 15, 2012
  1. @tenderlove
Commits on Oct 14, 2012
  1. @arturopie

    7914 Using a better way to get the defaults from db.

    arturopie authored
    Changes:
    
    * According to postgreSQL documentation:
    (http://www.postgresql.org/docs/8.2/static/catalog-pg-attrdef.html)
    we should not be using 'adsrc' field because this field is unaware of
    outside changes that could affect the way that default values are
    represented. Thus, I changed the queries to use
    "pg_get_expr(adbin, adrelid)" instead of the historical "adsrc" field.
    
    * Remove parsing of character type default values for 8.1 formatting since
    Rails doesn't support postgreSQL 8.1 anymore.
    
    * Remove misleading comment unrelated to code.
  2. @arturopie

    #7914 get default value when type uses schema name

    arturopie authored
    PostgreSQL adapter properly parses default values when using multiple
    schemas and domains.
    
    When using domains across schemas, PostgresSQL prefixes the type of the
    default value with the name of the schema where that type (or domain) is.
    
    For example, this query:
    ```
    SELECT a.attname, d.adsrc
    FROM pg_attribute a LEFT JOIN pg_attrdef d
    ON a.attrelid = d.adrelid AND a.attnum = d.adnum
    WHERE a.attrelid = "defaults"'::regclass
    AND a.attnum > 0 AND NOT a.attisdropped
    ORDER BY a.attnum;
    ```
    
    could return something like "'<default_value>'::pg_catalog.text" or
    "(''<default_value>'::pg_catalog.text)::text" for the text columns with
    defaults.
    
    I modified the regexp used to parse this value so that it ignores
    anything between ':: and \b(?:character varying|bpchar|text), and it
    allows to have optional parens like in the above second example.
Commits on Oct 12, 2012
  1. @ernie

    Fix has_many assocation w/select load after create

    ernie authored
    If you create a new record via a collection association proxy that has
    not loaded its target, and which selects additional attributes through
    the association, then when the proxy loads its target, it will
    inadvertently trigger a deprecation notice during attribute writing when
    CollectionAssociation#merge_target_lists attempts to do its thing, since
    the newly loaded records will possess attributes the created record does
    not.
Commits on Oct 10, 2012
  1. @jfirebaugh

    Eager autoload Preloader classes

    jfirebaugh authored
    Without eager autoloading, these would be autoloaded
    only when #preloader_for is called, which is too late
    in threaded applications.
  2. @michaelfairley @jfirebaugh

    Eager autoload ActiveRecord association helpers

    michaelfairley authored jfirebaugh committed
Commits on Oct 6, 2012
  1. @rafaelfranca

    Merge pull request #7850 from senny/5920_postgres_adapter_table_with_…

    rafaelfranca authored
    …capital_letters
    
    postgres, quote table names when fetching the primary key (#5920)
    Conflicts:
    	activerecord/CHANGELOG.md
    	activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
Commits on Oct 4, 2012
  1. @rafaelfranca

    Merge pull request #6978 from frodsan/count_nosql_unsaved_parent

    rafaelfranca authored
    Count returns 0 without querying if parent is not saved
Commits on Oct 3, 2012
  1. @spastorino @rafaelfranca

    Refactor

    spastorino authored rafaelfranca committed
    Conflicts:
    	activerecord/lib/active_record/counter_cache.rb
Something went wrong with that request. Please try again.