Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 29, 2012
  1. graceliu Rafael Mendonça França

    fixed support for DATABASE_URL for rake db tasks

    graceliu authored rafaelfranca committed
    Backport for #7521
    
    - added tests to confirm establish_connection uses DATABASE_URL and
      Rails.env correctly even when no arguments are passed in.
    - updated rake db tasks to support DATABASE_URL, and added tests to
      confirm correct behavior for these rake tasks.  (Removed
      establish_connection call from some tasks since in those cases
      the :environment task already made sure the function would be called)
    - updated Resolver so that when it resolves the database url, it
      removes hash values with empty strings from the config spec (e.g.
      to support connection to postgresql when no username is specified).
    - updated ResolverTest to use current_adapter? to check the type of
      the current adapter.
  2. Rafael Mendonça França

    Make Active Record tests pass in isolation

    rafaelfranca authored
    Also remove the feature detecting for Ruby 1.9
  3. Rafael Mendonça França

    Merge pull request #7593 from veader/patch-1

    rafaelfranca authored
    Decode attributes pulled from URI.parse
    Conflicts:
    	activerecord/CHANGELOG.md
    	activerecord/lib/active_record/connection_adapters/connection_specification.rb
Commits on Oct 15, 2012
  1. Aaron Patterson
Commits on Sep 24, 2012
  1. Jonathan Rochkind

    ConnectionPool accepts spec key 'checkout_timeout'

    jrochkind authored
    Backport of #6441 cb6f839 . Old 'wait_timeout' is still supported,
    but conflicts with mysql2 using that spec key for different thing.
    'checkout_timeout' can now be used taking precedence for ConnectionPool
    over 'wait_timeout'.
Commits on Sep 20, 2012
  1. Rafael Mendonça França

    Revert "backport fair connection pool 02b2335 to 3-2-stable"

    rafaelfranca authored
    This reverts commit 0693e07.
    
    Revert "Cache columns metadata to avoid extra while testing"
    
    This reverts commit a82f1e3.
    
    Reason: This is causing failures in the postgresql build.
    See http://travis-ci.org/#!/rails/rails/builds/2485584
    
    Related with #7675
Commits on Sep 17, 2012
  1. Jonathan Rochkind
Commits on Aug 18, 2012
  1. Joe Rafaniello
Commits on Jul 6, 2012
  1. Rafael Mendonça França

    Merge pull request #6985 from sidonath/disable-query-cache-for-locks

    rafaelfranca authored
    Disable query cache for lock queries
    Conflicts:
    	activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb
Commits on Jun 28, 2012
  1. Carlos Antonio da Silva

    Merge pull request #6900 from cbandy/issue-6898

    carlosantoniodasilva authored
    Require URI in ConnectionSpecification
    Conflicts:
    	activerecord/lib/active_record/connection_adapters/connection_specification.rb
Commits on May 23, 2012
  1. Synchronize the ConnectionPool#release method to avoid thread safety …

    Andrew Selder authored
    …issues [#6464]
    
    Fixes #6464
    
    Synchronize the contents of the release method in ConnectionPool due to
    errors when running in high concurrency environments.
    
        Detected invalid hash contents due to unsynchronized modifications
    with concurrent users
        org/jruby/RubyHash.java:1356:in `keys'
    /usr/local/rvm/gems/jruby-1.6.7@new_import/gems/activerecord-3.2.3/lib/a
    ctive_record/connection_adapters/abstract/connection_pool.rb:294:in
    `release'
    
    /usr/local/rvm/gems/jruby-1.6.7@new_import/gems/activerecord-3.2.3/lib/a
    ctive_record/connection_adapters/abstract/connection_pool.rb:282:in
    `checkin'
Commits on May 19, 2012
  1. Aaron Patterson

    Merge pull request #6398 from pmahoney/threadsafe-connection-pool

    tenderlove authored
    Synchronize read and modification of @reserved_connections
Commits on May 9, 2012
  1. Carlos Antonio da Silva

    Stop showing deprecations for Ruby 1.8.7 with remove_column

    carlosantoniodasilva authored
    String is Enumerable in 1.8.7, which means that passing a String to
    remove_column was generating deprecation warnings during tests.
Commits on May 2, 2012
  1. Piotr Sarnacki
Commits on Mar 13, 2012
  1. Jonathan Rochkind

    ConnectionPool.checkout takes account of ruby using 'non-blocking con…

    jrochkind authored
    …dition variables' in mutex ConditionVariables
Commits on Mar 12, 2012
  1. Aaron Patterson
  2. Jonathan Rochkind

    inline docs for clear_active_connections! no longer says it cleans de…

    jrochkind authored
    …ad threads, it doesn't since 3.2.0
Commits on Mar 8, 2012
  1. Aaron Patterson

    make active_connection? return true only if there is an open connecti…

    tenderlove authored
    …on in use for the current thread. fixes #5330
Commits on Mar 2, 2012
  1. Xavier Noria

    revert setting NOT NULL constraints in add_timestamps

    fxn authored
    Commit 3dbedd2 added NOT NULL constraints both to table
    creation and modification. For creation the new default
    makes sense, but the generic situation for changing a
    table is that there exist records. Those records have
    no creation or modification timestamps, and in the
    general case you don't even know them, so when updating
    a table these constraints are not going to work. See
    a bug report for this use case in #3334.
Commits on Feb 26, 2012
  1. Rafael Mendonça França Aaron Patterson

    Revert "No need to pass options which is never used"

    rafaelfranca authored tenderlove committed
    Options is needed for some Rails extensions to determine when
    referential integrity should be disabled
    
    This reverts commit bcb466c.
    
    Fixes #5052
Commits on Feb 22, 2012
  1. Aaron Patterson
Commits on Feb 3, 2012
  1. densya203

    Fix Issue #4819

    skult authored
    'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1'
    
    Just a typo of 'ActiveSupport::...'
Commits on Jan 30, 2012
  1. Xavier Noria
Commits on Dec 29, 2011
  1. Jo Liss Vijay Dev

    Document that index names are made up of all columns, not just the fi…

    joliss authored vijaydev committed
    …rst.
    
    index_name has been using the following expression
    
        "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}"
    
    since at least 2006 (bc7f231), and that's how they come out in my DB.
    
    Please check that this is correct before merging into master, perhaps
    I'm misunderstanding the section I changed.
Commits on Dec 13, 2011
  1. Jon Leighton

    Revert naive O(1) table_exists? implementation.

    jonleighton authored
    It was a bad idea to rescue exceptions here. This can interfere with
    transaction rollbacks which seems to be the cause of current CI
    failure.
    
    Instead, each adapter should implement its own DB-specific O(1)
    implementation, and we fall back on the generic, slower, implementation
    otherwise.
Commits on Dec 9, 2011
  1. Aaron Patterson

    don't need a begin / end.

    tenderlove authored
  2. Aaron Patterson
Commits on Dec 8, 2011
  1. Aaron Patterson
  2. Vijay Dev

    fix nodocs

    vijaydev authored
  3. Vijay Dev

    fix comments

    vijaydev authored
  4. Aaron Patterson
  5. Aaron Patterson
  6. Aaron Patterson
Commits on Dec 7, 2011
  1. Aaron Patterson
Commits on Dec 5, 2011
  1. Aaron Patterson
Something went wrong with that request. Please try again.