Skip to content
This repository

Oct 22, 2012

  1. Aaron Patterson

    frozen state should be restored after txn is aborted

    tenderlove authored

Aug 30, 2012

  1. Xavier Noria

    documents after_(commit|rollback)

    fxn authored

Aug 12, 2012

  1. Rafael Mendonça França

    Merge pull request #6073 from daveyeu/restore-state-on-record-invalid

    Restore state on create when ActiveRecord::RecordInvalid is raised
    Conflicts:
    	activerecord/CHANGELOG.md
    rafaelfranca authored

May 22, 2012

  1. Godfrey Chan

    Restore the frozen state on rollback. Fixes #6417.

    This is a 3-2-stable backport for #6420 which was merged into master.
    
    Currently, when saving a frozen record, an exception would be thrown
    which causes a rollback. However, there is a bug in active record that
    "defrost" the record as a side effect:
    
        >> t = Topic.new
        => #<Topic id: nil, ...>
        >> t.freeze
        => #<Topic id: nil, ...>
        >> t.save
        RuntimeError: can't modify a frozen Hash
        >> t.frozen?
        => false
        >> t.save
        => true
    
    This patch fixes the bug by explictly restoring the frozen state on the
    attributes Hash after every rollback.

Dec 08, 2011

  1. Vijay Dev

    fix nodocs

    vijaydev authored

Oct 05, 2011

  1. Jon Leighton

    Revert "Raise error on unknown primary key."

    This reverts commit ee2be43.
    jonleighton authored
  2. Jon Leighton

    Raise error on unknown primary key.

    If we don't have a primary key when we ask for it, it's better to fail
    fast. Fixes GH #2307.
    jonleighton authored

Jun 01, 2011

  1. dafaqisdat

    Edited activerecord/lib/active_record/transactions.rb via GitHub

    dafaqisdat authored
  2. dafaqisdat

    The URL http://dev.mysql.com/doc/refman/5.0/en/savepoints.html is no …

    …longer available
    dafaqisdat authored

Apr 04, 2011

  1. Emilio Tagua

    Use IM when trying to load records using ID.

    Signed-off-by: José Valim <jose.valim@gmail.com>
    miloops authored josevalim committed

Feb 15, 2011

  1. Emilio Tagua

    Merge remote branch 'rails/master' into identity_map

    Conflicts:
    	activerecord/examples/performance.rb
    	activerecord/lib/active_record/association_preload.rb
    	activerecord/lib/active_record/associations.rb
    	activerecord/lib/active_record/associations/association_proxy.rb
    	activerecord/lib/active_record/autosave_association.rb
    	activerecord/lib/active_record/base.rb
    	activerecord/lib/active_record/nested_attributes.rb
    	activerecord/test/cases/relations_test.rb
    miloops authored

Jan 31, 2011

  1. John Firebaugh

    Use run_callbacks; the generated _run_<name>_callbacks method is not …

    …a public interface.
    
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
    jfirebaugh authored spastorino committed

Jan 18, 2011

  1. Aaron Patterson

    remove useless conditional

    tenderlove authored

Dec 28, 2010

  1. Santiago Pastorino

    Allow primary_key to be an attribute when the model is a new record

    spastorino authored

Dec 20, 2010

  1. Emilio Tagua

    Merge remote branch 'rails/master' into identity_map

    Conflicts:
    	activerecord/lib/active_record/associations/association_proxy.rb
    	activerecord/lib/active_record/autosave_association.rb
    	activerecord/lib/active_record/base.rb
    	activerecord/lib/active_record/persistence.rb
    miloops authored

Dec 10, 2010

  1. Xavier Noria

    reviews commit 53bbbcc

    fxn authored

Dec 08, 2010

  1. Ivan Evtuhovich

    Fix doc about nested transaction rollback

    Because AR::Rollback do not reraise and inner transaction is not "real"
    nothing rollback at all
    evtuhovich authored

Nov 28, 2010

  1. José Valim

    Partialy revert f1c13b0

    josevalim authored

Nov 19, 2010

  1. Emilio Tagua

    Remove object from identity map if transaction failed.

    miloops authored

Nov 09, 2010

  1. Santiago Pastorino

    Don't check if persisted is defined just initialize it properly

    spastorino authored
  2. David Chelimsky

    use persisted? instead of new_record? wherever possible

    - persisted? is the API defined in ActiveModel
    - makes it easier for extension libraries to conform to ActiveModel APIs
      without concern for whether the extended object is specifically
      ActiveRecord
    
    [#5927 state:committed]
    
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
    dchelimsky authored spastorino committed

Oct 15, 2010

  1. Carl Lerche

    #transaction on the instance level should take options as well

    carllerche authored

Jun 20, 2010

  1. Xavier Noria

    Merge remote branch 'rails/master'

    Conflicts:
    	actionpack/lib/abstract_controller/base.rb
    fxn authored

Jun 18, 2010

  1. Brian Durand

    Fix bug with rolling back frozen attributes.

    [#2991]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    bdurand authored jeremy committed

Jun 16, 2010

  1. Rizwan Reza

    Adds title to the rest of the files in activerecord/lib

    rizwanreza authored

Jun 08, 2010

  1. Brian Durand

    Make logic for after_commit and after_rollback :on option work like i…

    …t does for validation callbacks.
    
    [#2991 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    bdurand authored jeremy committed
  2. Jeremy Kemper

    Revert "Temporarily revert "Update after_commit and after_rollback do…

    …cs and tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction.""
    
    This reverts commit 1b2941c.
    
    [#2991]
    jeremy authored
  3. Jeremy Kemper

    Temporarily revert "Update after_commit and after_rollback docs and t…

    …ests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction."
    
    This reverts commits d2a49e4 and da840d1.
    
    [#2991]
    
    Conflicts:
    
    	activerecord/CHANGELOG
    	activerecord/lib/active_record/transactions.rb
    	activerecord/test/cases/transaction_callbacks_test.rb
    jeremy authored

May 08, 2010

  1. Yehuda Katz

    eliminate alias_method_chain from ActiveRecord

    wycats authored

May 01, 2010

  1. Xavier Noria

    edit pass in the transactions preamble rdoc

    fxn authored

Apr 30, 2010

  1. Xavier Noria

    after_(commit|rollback) rdoc, edit pass

    fxn authored
  2. Brian Durand

    Update after_commit and after_rollback docs and tests to use new styl…

    …e API with an :on options instead of on_* suffix.
    
    [#2991]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    bdurand authored jeremy committed

Apr 29, 2010

  1. Brian Durand

    Add after_commit and after_rollback callbacks to ActiveRecord that ar…

    …e called after transactions either commit or rollback on all records saved or destroyed in the transaction.
    
    [#2991 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    bdurand authored jeremy committed

Jan 17, 2010

  1. José Valim

    save(false) is gone, use save(:validate => false) instead.

    josevalim authored

May 28, 2009

  1. Joshua Peek

    Break up DependencyModule's dual function of providing a "depend_on" …

    …DSL and "included" block DSL into separate modules. But, unify both approaches under AS::Concern.
    josh authored
Something went wrong with that request. Please try again.