Skip to content
This repository

Mar 02, 2012

  1. Carlos Antonio da Silva

    Stop SafeBuffer#clone_empty from issuing warnings

    Logic in clone_empty method was dealing with old @dirty variable, which
    has changed by @html_safe in this commit:
    139963c
    
    This was issuing a "not initialized variable" warning - related to:
    #5237
    
    The logic applied by this method is already handled by the [] override,
    so there is no need to reset the variable here.
    carlosantoniodasilva authored drogus committed

Mar 01, 2012

  1. Aaron Patterson

    Merge branch '3-2-2' into 3-2-stable

    * 3-2-2:
      bumping to 3.2.2
      Ensure [] respects the status of the buffer.
      Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_prepare
      Merge pull request #5084 from johndouthat/patch-1
      updating RAILS_VERSION
      delete vulnerable AS::SafeBuffer#[]
      use AS::SafeBuffer#clone_empty for flushing the output_buffer
      add AS::SafeBuffer#clone_empty
      fix output safety issue with select options
    tenderlove authored
  2. José Valim

    Ensure [] respects the status of the buffer.

    josevalim authored tenderlove committed

Feb 27, 2012

  1. Aaron Patterson

    call binmode on the tempfile for Ruby 1.8 compatibility

    tenderlove authored

Feb 25, 2012

  1. RalphShnelvar

    Fixing Windows asset tag helper test failure

    In asset_tag_helper_test.rb there is an assert on the number of bytes in a
    concatenated file.  This test failed because Windows converts \n to \r\n as
    the default for "w".  This is different than in *nix systems where there is
    no conversion done.
    
    THe test that failed was test_caching_stylesheet_link_tag_when_caching_on
    
    Using bin mode fixes this behavior on windows and makes no change on the
    *nix systems.
    RalphShnelvar authored

Feb 21, 2012

  1. Akira Matsuda

    delete vulnerable AS::SafeBuffer#[]

    amatsuda authored tenderlove committed
  2. Akira Matsuda

    add AS::SafeBuffer#clone_empty

    amatsuda authored tenderlove committed

Feb 18, 2012

  1. Eric Oestrich

    Update Time#change docs to reflect the options it uses

    [ci skip]
    oestrich authored vijaydev committed

Feb 05, 2012

  1. Toshinori Kajihara

    GH #4883. Optional start_day argument for Time#all_week

    kennyj authored

Jan 25, 2012

  1. Vijay Dev

    Merge pull request #4673 from carlosantoniodasilva/validation-guides-…

    …update-3-2
    
    Validation guides update 3 2
    vijaydev authored
  2. Carlos Antonio da Silva

    Change ActiveRecord::Errors to ActiveModel::Errors in guides

    Use ActiveModel::Errors in inflection example docs as well.
    
    Also fixes wrong information and link to locale file related to
    Errors#full_messages in I18n guide.

Jan 24, 2012

  1. Aaron Patterson

    Merge pull request #4514 from brainopia/update_timezone_offets

    Update time zone offset information
    tenderlove authored

Jan 15, 2012

  1. Semyon Perepelitsa

    Pass a symbol instead of a block. This is faster and more concise.

    At least Ruby 1.8.7 is required which is ok since 3.2.
    
    Benchmark:
    
    ```ruby
    require "benchmark"
    
    enum = 1..10_000
    N = 100
    Benchmark.bm do |x|
      x.report "inject block" do
        N.times do
          enum.inject { |sum, n| sum + n }
        end
      end
    
      x.report "inject symbol" do
        N.times do
          enum.inject(:+)
        end
      end
    end
    ```
    
    Result:
    
    ```
           user     system      total        real
    inject block   0.160000   0.000000   0.160000 (  0.179723)
    inject symbol  0.090000   0.000000   0.090000 (  0.095667)
    ```
    semaperepelitsa authored

Jan 12, 2012

  1. Vijay Dev

    fixes in api docs

    vijaydev authored

Jan 03, 2012

  1. Aaron Patterson

    Merge pull request #4283 from lest/fix-singleton-checking

    use correct variant of checking whether class is a singleton
    tenderlove authored

Dec 30, 2011

  1. Xavier Noria

    adds a comments that clarifies why Range#include? chooses the compari…

    …son operator
    fxn authored
  2. Sergey Nartimov

    refactor Range#include? to handle ranges with floats

    Conflicts:
    
    	activesupport/lib/active_support/core_ext/range/include_range.rb
    lest authored fxn committed

Dec 28, 2011

  1. Jon Leighton

    Revert "Further simplify singleton_class checking in class_attribute"

    This reverts commit 520918a.
    
    Reason: build failure
    jonleighton authored
  2. James Miller

    Further simplify singleton_class checking in class_attribute

    bensie authored tenderlove committed

Dec 24, 2011

  1. Aaron Patterson

    delegating and deprecating logger#silence. fixes #4159

    tenderlove authored

Dec 22, 2011

  1. Aaron Patterson

    Revert "Added Enumerable#pluck to wrap the common pattern of collect(…

    …&:method) *DHH*"
    
    This reverts commit 4d20de8.
    tenderlove authored

Dec 11, 2011

  1. Jeremy Kemper

    Remove duplicate html_escape docs

    jeremy authored
  2. Jeremy Kemper

    Use 1.9 native XML escaping to speed up html_escape and shush regexp …

    …warnings
    
            length      user     system      total        real
    before  6      0.010000   0.000000   0.010000 (  0.012378)
    after   6      0.010000   0.000000   0.010000 (  0.012866)
    before  60     0.040000   0.000000   0.040000 (  0.046273)
    after   60     0.040000   0.000000   0.040000 (  0.036421)
    before  600    0.390000   0.000000   0.390000 (  0.390670)
    after   600    0.210000   0.000000   0.210000 (  0.209094)
    before  6000   3.750000   0.000000   3.750000 (  3.751008)
    after   6000   1.860000   0.000000   1.860000 (  1.857901)
    jeremy authored

Dec 08, 2011

  1. Vijay Dev

    fix nodocs

    vijaydev authored

Dec 03, 2011

  1. Jon Jensen

    Restore performance of ERB::Util.html_escape

    Revert html_escape to do a single gsub again, but add the "n" flag (no
    language, i.e. not multi-byte) to protect against XSS via invalid utf8
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    jenseng authored josevalim committed

Dec 02, 2011

  1. David Heinemeier Hansson

    Added Enumerable#pluck to wrap the common pattern of collect(&:method…

    …) *DHH*
    dhh authored

Nov 29, 2011

  1. Aaron Patterson

    Module#synchronize is deprecated with no replacement. Please use `mon…

    …itor` from ruby's standard library.
    tenderlove authored

Nov 27, 2011

  1. Yehuda Katz

    Merge pull request #3767 from tadast/object_in

    Object#in? also accepts multiple parameters
    wycats authored

Nov 26, 2011

  1. Tadas Tamošauskas

    Object#in? also accepts multiple parameters

    tadast authored
  2. Vijay Dev

    Adds Time#sunday method

    vijaydev authored
  3. Vijay Dev

    Convert aliases monday and sunday to methods

    A recent change to beginning_of_week and end_of_week added an argument
    that can be used to specify the week's starting day as a symbol. Now
    these methods were aliased as monday and sunday respectively which as a
    consequence of the argument addition, made calls like obj.monday(:sunday)
    possible. This commit makes them methods on their own.
    vijaydev authored
  4. Vijay Dev

    minor doc changes

    vijaydev authored

Nov 25, 2011

  1. Xavier Noria

    some tweaks to PR#3547. [Closes #3547]

    fxn authored
  2. Innokenty Mikhailov

    API docstrings updated with default value info

    gregolsen authored fxn committed
  3. Innokenty Mikhailov

    beginning_of_week extended in both Time and Date so that to return we…

    …ek start based on start day that is monday by default
    gregolsen authored fxn committed
Something went wrong with that request. Please try again.