Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Mar 15, 2012
  1. @tenderlove

    Merge pull request #5437 from kennyj/fix_5430

    tenderlove authored
    Fix GH #5430. A Payload name for schema_search_path should be SCHEMA.
Commits on Mar 13, 2012
  1. @jrochkind

    ConnectionPool.checkout takes account of ruby using 'non-blocking con…

    jrochkind authored
    …dition variables' in mutex ConditionVariables
Commits on Mar 12, 2012
  1. @tenderlove
  2. @jrochkind

    inline docs for clear_active_connections! no longer says it cleans de…

    jrochkind authored
    …ad threads, it doesn't since 3.2.0
Commits on Mar 8, 2012
  1. @tenderlove

    make active_connection? return true only if there is an open connecti…

    tenderlove authored
    …on in use for the current thread. fixes #5330
Commits on Mar 2, 2012
  1. @tenderlove

    only log an error if there is a logger. fixes #5226

    tenderlove authored
    Conflicts:
    
    	activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
  2. @fxn

    revert setting NOT NULL constraints in add_timestamps

    fxn authored
    Commit 3dbedd2 added NOT NULL constraints both to table
    creation and modification. For creation the new default
    makes sense, but the generic situation for changing a
    table is that there exist records. Those records have
    no creation or modification timestamps, and in the
    general case you don't even know them, so when updating
    a table these constraints are not going to work. See
    a bug report for this use case in #3334.
Commits on Feb 28, 2012
  1. @kennyj
Commits on Feb 26, 2012
  1. @rafaelfranca @tenderlove

    Revert "No need to pass options which is never used"

    rafaelfranca authored tenderlove committed
    Options is needed for some Rails extensions to determine when
    referential integrity should be disabled
    
    This reverts commit bcb466c.
    
    Fixes #5052
Commits on Feb 22, 2012
  1. @tenderlove
Commits on Feb 21, 2012
  1. @tenderlove
  2. @tenderlove
  3. @tenderlove

    Merge pull request #5096 from lawso017/master

    tenderlove authored
    Restoring ability to derive id/sequence from tables with nonstandard sequences for primary keys
Commits on Feb 8, 2012
  1. @paul @josevalim

    Handle nil in add_index :length option in MySQL

    paul authored josevalim committed
    Our schema.rb is being generated with an `add_index` line similar to this:
    
        add_index "foo", ["foo", "bar"], :name => "xxx", :length => {"foo"=>8, "bar=>nil}
    
    This is the same as it was on Rails 3.1.3, however, now when that
    schema.rb is evaluated, its generating bad SQL in MySQL:
    
        Mysql::Error: You have an error in your SQL syntax; check the manual
        that corresponds to your MySQL server version for the right syntax
        to use near '))' at line 1: CREATE UNIQUE INDEX
        `xxx` ON `foo` (`foo`(8), `bar`())
    
    This commit adds a check for nil on the length attribute to prevent the
    empty parens from being output.
    
    Conflicts:
    
    	activerecord/test/cases/migration/index_test.rb
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Feb 3, 2012
  1. @skult

    Fix Issue #4819

    skult authored
    'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1'
    
    Just a typo of 'ActiveSupport::...'
Commits on Feb 2, 2012
  1. @tenderlove

    Merge pull request #4809 from cfeist/feist-sqlite-binary-corruption

    tenderlove authored
    Fix for SQLite binary data corrupter (to master branch)
Commits on Jan 31, 2012
  1. @jonleighton

    Merge pull request #4763 from kennyj/fix_4754

    jonleighton authored
    [MySQL] Fix GH #4754. Remove double-quote characters around PK when using sql_mode=ANSI_QUOTES
Commits on Jan 30, 2012
  1. @fxn
Commits on Jan 12, 2012
  1. @spastorino
Commits on Dec 29, 2011
  1. @joliss @vijaydev

    Document that index names are made up of all columns, not just the fi…

    joliss authored vijaydev committed
    …rst.
    
    index_name has been using the following expression
    
        "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}"
    
    since at least 2006 (bc7f231), and that's how they come out in my DB.
    
    Please check that this is correct before merging into master, perhaps
    I'm misunderstanding the section I changed.
Commits on Dec 16, 2011
  1. @jonleighton
  2. @jonleighton
  3. @jonleighton
  4. @jonleighton

    Cache columns at the model level.

    jonleighton authored
    Allows two models to use the same table but have different primary keys.
Commits on Dec 13, 2011
  1. @jonleighton

    Revert naive O(1) table_exists? implementation.

    jonleighton authored
    It was a bad idea to rescue exceptions here. This can interfere with
    transaction rollbacks which seems to be the cause of current CI
    failure.
    
    Instead, each adapter should implement its own DB-specific O(1)
    implementation, and we fall back on the generic, slower, implementation
    otherwise.
Commits on Dec 9, 2011
  1. @tenderlove
  2. @tenderlove

    don't need a begin / end.

    tenderlove authored
  3. @tenderlove
Commits on Dec 8, 2011
  1. @tenderlove
  2. @vijaydev

    fix nodocs

    vijaydev authored
  3. @vijaydev

    fix comments

    vijaydev authored
  4. @tenderlove
  5. @tenderlove
  6. @tenderlove
Commits on Dec 7, 2011
  1. @tenderlove
Something went wrong with that request. Please try again.