Skip to content
Commits on May 28, 2012
  1. @tenderlove

    bumping to 3.2.4.rc1

    tenderlove committed May 28, 2012
Commits on May 27, 2012
  1. @drogus

    Fix railties_order when application object is passed

    drogus committed May 27, 2012
    railites_order method, introduced in 40b19e0, had a bug that was causing
    loading application instance twice in initializers if railties_order
    already included application instance. So for example
    
        railties_order = [Foo::Engine, :main_app, Bar::Engine]
    
    would result in such railties array:
    
        [MyApp::Application, Foo::Engine, MyAppApplication, Bar::Engine]
    
    In order to fix it, we need to check for existence of application in
    both railties_order and railties arrays.
Commits on May 22, 2012
  1. @drogus

    Use require_dependency in generated controllers

    drogus committed May 22, 2012
    Using require in development mode will prevent required files from
    reloading, even if they're changed. In order to keep namespaced
    application_controller reloadable, we need to use require_dependency
    instead of require.
Commits on May 21, 2012
  1. @drogus

    Fix generators to help with ambiguous `ApplicationController` issue

    drogus committed May 20, 2012
    In development mode, dependencies are loaded dynamically at runtime,
    using `const_missing`. Because of that, when one of the constants is
    already loaded and `const_missing` is not triggered, user can end up
    with unexpected results.
    
    Given such file in an Engine:
    
    ```ruby
    module Blog
      class PostsController < ApplicationController
      end
    end
    ```
    
    If you load it first, before loading any application files, it will
    correctly load `Blog::ApplicationController`, because second line will
    hit `const_missing`. However if you load `ApplicationController` first,
    the constant will be loaded already, `const_missing` hook will not be
    fired and in result `PostsController` will inherit from
    `ApplicationController` instead of `Blog::ApplicationController`.
    
    Since it can't be fixed in `AS::Dependencies`, the easiest fix is to
    just explicitly load application controller.
    
    closes #6413
Commits on May 16, 2012
  1. @bcardarella

    Changing the indentation level of the block comment close for SASS

    bcardarella committed May 15, 2012
    If one wants to use use SASS for application.css.sass the comment block indentation is invalid.
Commits on May 14, 2012
  1. @josevalim
  2. @homakov @josevalim

    Update railties/lib/rails/generators/rails/app/templates/config/appli…

    homakov committed with josevalim May 12, 2012
    …cation.rb
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on May 5, 2012
  1. @drogus
Commits on Apr 27, 2012
  1. @tenderlove

    Merge pull request #4528 from j-manu/log-tailer-fix

    tenderlove committed Jan 20, 2012
    Fix for log tailer when the log file doesn't exist.
Commits on Apr 21, 2012
  1. @joevandyk

    Only include Rake::DSL if it's defined.

    joevandyk committed Apr 21, 2012
    rake < 0.9 doesn't define Rake::DSL.
Commits on Apr 18, 2012
  1. @spastorino
Commits on Apr 17, 2012
  1. @asanghi

    Replace ruby-debug19 which doesnt work on 1.9.3 out of the box with a…

    asanghi committed Apr 17, 2012
    … more maintained debugger gem
Commits on Apr 13, 2012
  1. @alekseykulikov @drogus
Commits on Apr 12, 2012
  1. @sikachu @vijaydev
Commits on Apr 1, 2012
  1. @drogus

    Usage file in generators shouldn't be fetched only based on source_root

    drogus committed Apr 1, 2012
    In case `source_roout` is not set, `default_source_root` is used,
    which includes also `templates` directory. If there is no `templates`
    directory, `default_source_root` is not available and USAGE will not
    be displayed. USAGE should be also checked based on default
    directory excluding `templates`.
Commits on Mar 30, 2012
  1. @spastorino
  2. @spastorino

    Bump up to 3.2.3

    spastorino committed Mar 30, 2012
Commits on Mar 29, 2012
  1. @spastorino

    Bumping to 3.2.3.rc2

    spastorino committed Mar 29, 2012
  2. @vijaydev @spastorino
  3. @vijaydev
Commits on Mar 28, 2012
  1. @andhapp

    Changed the config.assets.manifest to nil in the comments in the prod…

    andhapp committed Mar 28, 2012
    …uction config template.
Commits on Mar 27, 2012
  1. @tenderlove

    adding a branch to arel

    tenderlove committed Mar 27, 2012
  2. @spastorino

    Bumping to 3.2.3.rc1

    spastorino committed Mar 27, 2012
Commits on Mar 23, 2012
  1. @tenderlove
Commits on Mar 17, 2012
  1. @drogus
Commits on Mar 15, 2012
  1. @drogus
Commits on Mar 13, 2012
  1. @rafaelfranca

    Use Ruby 1.8 hash syntax

    rafaelfranca committed Mar 13, 2012
  2. @rafaelfranca
  3. @rafaelfranca
  4. @parndt

    Fixed problem when fixture_path is not always defined (incidentally, …

    parndt committed Mar 13, 2012
    …only when ActiveRecord is according to test_help.rb).
  5. @parndt
Commits on Mar 8, 2012
  1. @caius @vijaydev

    Fix typo in isolated engine docs

    caius committed with vijaydev Mar 6, 2012
Commits on Mar 5, 2012
  1. @rafaelfranca

    Only add the whitelist_attributes option if ActiveRecord is present

    rafaelfranca committed Mar 4, 2012
    Conflicts:
    
    	railties/test/generators/app_generator_test.rb
    	railties/test/isolation/abstract_unit.rb
Commits on Mar 4, 2012
  1. @NZKoz

    Whitelist all attribute assignment by default.

    NZKoz committed Mar 5, 2012
    Change the default for newly generated applications to whitelist all attribute assignment.  Also update the generated model classes so users are reminded of the importance of attr_accessible.
Commits on Mar 1, 2012
  1. @tenderlove

    bumping to 3.2.2

    tenderlove committed Mar 1, 2012
Something went wrong with that request. Please try again.