Skip to content
Commits on Jun 12, 2012
  1. @tenderlove

    updating changelogs

    tenderlove committed
Commits on Jun 11, 2012
  1. @tenderlove

    bumping version numbers

    tenderlove committed
  2. @tenderlove
  3. @tenderlove
Commits on Jun 9, 2012
  1. @arunagw

    Duplicate tests removed.

    arunagw committed
Commits on Jun 7, 2012
  1. @drogus

    Fix railties test suite

    drogus committed
    Apparently asset_environment should not be invoked if it's not needed.
    This fixes broken build by getting back to the code more similar to the
    version changed here: 5b0a891
  2. @drogus

    Fix asset tags for files with more than one dot

    drogus committed
    After the fix done in 39f9f02, there are cases that will not work
    correctly. If you have file with "2 extensions", like foo.min.js and you
    reference the file without extension, like:
    
        javascript_include_tag "foo.min"
    
    it will fail because sprockets finds foo.min.js with foo.min argument.
    
    This commit fixes this case and will get the right file even when
    referrencing it without extension.
    
    (closes #6598)
Commits on Jun 5, 2012
  1. @rafaelfranca

    Revert "fix the Flash middleware loading the session on every request…

    rafaelfranca committed
    … (very dangerous especially with Rack::Cache), it should only be loaded when the flash method is called"
    
    This reverts commits e3069c6 and 2b2983d.
    
    Reason: This add a non-backward compatible change in the way that flash
    works now (swept in every request).
  2. @rafaelfranca

    Add test to flash sweep after two redirects

    rafaelfranca committed
    This test is needed to avoid regressions in the way that flash works
    now (swept in every request).
  3. @carlosgaldino

    Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` op…

    carlosgaldino committed
    …tion
    
    This deprecation applies to:
    `button_to`
    `button_tag`
    `image_submit_tag`
    `link_to`
    `submit_tag`
    
    As :confirm is an UI specific option is better to use the data attributes,
    teaching users about unobtrusive JavaScript and how Rails works with it.
Commits on Jun 1, 2012
  1. @drogus

    Allow to use mounted helpers in ActionView::TestCase

    drogus committed
    Similarly to 6525002, this allows to use routes helpers for mounted
    helpers, but this time in ActionView::TestCase
  2. @josevalim

    Merge pull request #6588 from nbibler/polymorphic_to_model

    josevalim committed
    Correct the use of to_model in polymorphic routing
  3. @nbibler
  4. @rafaelfranca
  5. @drogus

    Include routes.mounted_helpers into integration tests

    drogus committed
    In integration tests, you might want to use helpers from engines that
    you mounted in your application. It's not hard to add it by yourself,
    but it's unneeded boilerplate. mounted_helpers are now included by
    default. That means that given engine mounted like:
    
        mount Foo::Engine => "/foo", :as => "foo"
    
    you will be able to use paths from this engine in tests this way:
    
        foo.root_path #=> "/foo"
    
    (closes #6573)
  6. @tenderlove

    bumping to 3.2.5

    tenderlove committed
Commits on May 31, 2012
  1. @tenderlove

    bumping to 3.2.4

    tenderlove committed
  2. @tenderlove
  3. @tenderlove

    Merge branch '3-2-stable-sec' into 3-2-rel

    tenderlove committed
    * 3-2-stable-sec:
      Strip [nil] from parameters hash. Thanks to Ben Murphy for reporting this!
      predicate builder should not recurse for determining where columns. Thanks to Ben Murphy for reporting this
  4. @tenderlove

    updating changelogs

    tenderlove committed
Commits on May 30, 2012
  1. @tenderlove

    Strip [nil] from parameters hash.

    tenderlove committed
    Thanks to Ben Murphy for reporting this!
    
    CVE-2012-2660
Commits on May 28, 2012
  1. @tenderlove

    bumping to 3.2.4.rc1

    tenderlove committed
Commits on May 26, 2012
  1. @bdurand @pwim
Commits on May 21, 2012
  1. @lest

    Assets: don't add extension if other given and file exists

    lest committed
    We should lookup if asset without appended extension exists.
    When sprockets are disabled the asset tag helpers incorporate
    this logic. When sprockets are enabled we should have the same
    logic.
    
    For example, we have style.ext file in app/assets/stylesheets and
    we use stylesheet_link_tag in the layout. In this case we should
    have /assets/style.ext instead of /assets/style.ext.css in the
    output.
    
    Closes #6310
Commits on May 20, 2012
  1. @rafaelfranca

    Merge pull request #6410 from Bodacious/tag_helper_data_fix_3-2-stable

    rafaelfranca committed
    TagHelper creates invalid data attributes when value is a BigDecimal
  2. @josevalim

    Merge pull request #6407 from pinetops/565c1b0a0772ac6cf91c77e9285806…

    josevalim committed
    …f7b028614c
    
    Template concurrency fixes
  3. @Bodacious
  4. @pinetops
Commits on May 19, 2012
  1. @carlosantoniodasilva

    Use right option for excerpt text helper in tests, fix build

    carlosantoniodasilva committed
    `excerpt` text helper uses `:radius`, not `line_width` (that is used by
    `word_wrap` helper).
    
    Also cleanup some whitespaces.
Commits on May 18, 2012
  1. @josevalim @rafaelfranca

    Merge pull request #5020 from KL-7/fix-blank-image_tag-source

    josevalim committed with rafaelfranca
    Render img tag with empty src if empty string is passed to image_tag.
  2. @iHiD
Commits on May 14, 2012
  1. Deprecate `:disable_with` for `button_tag` too

    Carlos Galdino + Rafael Mendonça França committed
  2. Fix typo

    Carlos Galdino + Rafael Mendonça França committed
  3. Deprecate `:disable_with` in favor of `'data-disable-with'` option fo…

    Carlos Galdino + Rafael Mendonça França committed
    …r `button_to` and `submit_tag` helpers.
Commits on May 13, 2012
  1. @rafaelfranca
Something went wrong with that request. Please try again.