Skip to content
Commits on Jun 11, 2012
  1. @tenderlove

    bumping version numbers

    tenderlove committed Jun 11, 2012
  2. @ernie @tenderlove

    Additional fix for CVE-2012-2661

    ernie committed with tenderlove Jun 8, 2012
    While the patched PredicateBuilder in 3.1.5 prevents a user
    from specifying a table name using the `table.column` format,
    it doesn't protect against the nesting of hashes changing the
    table context in the next call to build_from_hash. This fix
    covers this case as well.
  3. @kennyj @tenderlove

    Fix GH #3163. Should quote database on mysql/mysql2.

    kennyj committed with tenderlove Mar 3, 2012
    Conflicts:
    
    	activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
  4. @rafaelfranca

    Merge pull request #6698 from yahonda/address_ora_911_master

    rafaelfranca committed Jun 10, 2012
    Address ORA-00911 errors because of the heading underscore.
  5. @rafaelfranca

    Merge pull request #6521 from Empact/throw-result

    rafaelfranca committed Jun 10, 2012
    Fix that #exists? can blow up with ThrowResult exception
    Conflicts:
    	activerecord/lib/active_record/relation/finder_methods.rb
Commits on Jun 10, 2012
  1. @iaddict @rafaelfranca

    Minimal change to query generation of exists? that makes SQLServer an…

    iaddict committed with rafaelfranca May 19, 2011
    …d others happy that do not work without a column alias.
    
    Conflicts:
    	activerecord/lib/active_record/relation/finder_methods.rb
  2. @rafaelfranca

    Merge pull request #6695 from kennyj/fix_6635

    rafaelfranca committed Jun 10, 2012
    Fix #6635. We should call Scoping methods, before calling Array methods.
Commits on Jun 9, 2012
  1. @tiegz
Commits on Jun 7, 2012
  1. @jonleighton

    Revert "Perf: Don't load the association for #delete_all."

    jonleighton committed Jun 7, 2012
    This reverts commit b98d1e2.
    
    Closes #6609
    
    Conflicts:
    
    	activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb
Commits on Jun 4, 2012
  1. @kennyj
Commits on Jun 1, 2012
  1. @tenderlove

    bumping to 3.2.5

    tenderlove committed May 31, 2012
  2. @pixeltrix

    Restore behavior of Active Record 3.2.3 scopes

    pixeltrix committed Jun 1, 2012
    A series of commits relating to preloading and scopes caused a regression.
    Cloning the relation calls initialize_copy which resets a number of instance
    variables to nil. Without this the scope thinks that it is already loaded
    when it is called again.
    
    Reverts the following commits:
    13f1401
    8491740
    dffbb52
    
    Fixes #6575, #6576 & #6577
Commits on May 31, 2012
  1. @tenderlove

    Merge branch '3-2-rel' into 3-2-stable

    tenderlove committed May 31, 2012
    * 3-2-rel:
      bumping to 3.2.4
      adding security notifications to CHANGELOGs
      updating changelogs
      Merge pull request #6558 from parndt/fix_regression
  2. @tenderlove

    Merge branch '3-2-stable-sec' into 3-2-stable

    tenderlove committed May 31, 2012
    * 3-2-stable-sec:
      Strip [nil] from parameters hash. Thanks to Ben Murphy for reporting this!
      predicate builder should not recurse for determining where columns. Thanks to Ben Murphy for reporting this
      bumping to 3.2.4.rc1
  3. @tenderlove

    bumping to 3.2.4

    tenderlove committed May 31, 2012
  4. @tenderlove

    Merge branch '3-2-stable-sec' into 3-2-rel

    tenderlove committed May 31, 2012
    * 3-2-stable-sec:
      Strip [nil] from parameters hash. Thanks to Ben Murphy for reporting this!
      predicate builder should not recurse for determining where columns. Thanks to Ben Murphy for reporting this
  5. @tenderlove

    Merge pull request #6558 from parndt/fix_regression

    tenderlove committed May 30, 2012
    Fix regression
  6. @parndt

    Revert "Removes unneeded caching from ActiveRecord::Base.relation"

    parndt committed May 31, 2012
    This reverts commit ebfa58a.
    
    This change caused a regression in my application's tests:
    
    * Failing build http://travis-ci.org/#!/resolve/refinerycms/builds/1461242
    
    Broken tests pass after this change is reverted.
Commits on May 30, 2012
  1. @tenderlove

    predicate builder should not recurse for determining where columns.

    tenderlove committed May 30, 2012
    Thanks to Ben Murphy for reporting this
    
    CVE-2012-2661
  2. @rafaelfranca

    Merge pull request #6477 from steveklabnik/close_discovered_pg_connec…

    rafaelfranca committed May 30, 2012
    …tion
    
    Properly discover a connection is closed in postgresql_adapter
  3. @tenderlove @rafaelfranca

    Merge pull request #5810 from kennyj/fix_5797

    tenderlove committed with rafaelfranca May 30, 2012
    Fix #5797. Error calling dup method on AR model with serialized field
    Conflicts:
    	activerecord/lib/active_record/core.rb
Commits on May 28, 2012
  1. @tenderlove

    bumping to 3.2.4.rc1

    tenderlove committed May 28, 2012
Commits on May 25, 2012
  1. @rafaelfranca

    Merge pull request #5244 from fotos/myqsl2_wait_timeout

    rafaelfranca committed May 25, 2012
    Maximum wait_timeout on Windows is 2147483
Commits on May 24, 2012
  1. @carlosantoniodasilva

    Merge pull request #5925 from Juanmcuello/pg_structure_dump

    carlosantoniodasilva committed May 24, 2012
    Quote arguments in db:structure:dump for PostgreSQL.
Commits on May 23, 2012
  1. Synchronize the ConnectionPool#release method to avoid thread safety …

    Andrew Selder committed May 23, 2012
    …issues [#6464]
    
    Fixes #6464
    
    Synchronize the contents of the release method in ConnectionPool due to
    errors when running in high concurrency environments.
    
        Detected invalid hash contents due to unsynchronized modifications
    with concurrent users
        org/jruby/RubyHash.java:1356:in `keys'
    /usr/local/rvm/gems/jruby-1.6.7@new_import/gems/activerecord-3.2.3/lib/a
    ctive_record/connection_adapters/abstract/connection_pool.rb:294:in
    `release'
    
    /usr/local/rvm/gems/jruby-1.6.7@new_import/gems/activerecord-3.2.3/lib/a
    ctive_record/connection_adapters/abstract/connection_pool.rb:282:in
    `checkin'
  2. @Juanmcuello
Commits on May 22, 2012
  1. @chancancode

    Restore the frozen state on rollback. Fixes #6417.

    chancancode committed May 22, 2012
    This is a 3-2-stable backport for #6420 which was merged into master.
    
    Currently, when saving a frozen record, an exception would be thrown
    which causes a rollback. However, there is a bug in active record that
    "defrost" the record as a side effect:
    
        >> t = Topic.new
        => #<Topic id: nil, ...>
        >> t.freeze
        => #<Topic id: nil, ...>
        >> t.save
        RuntimeError: can't modify a frozen Hash
        >> t.frozen?
        => false
        >> t.save
        => true
    
    This patch fixes the bug by explictly restoring the frozen state on the
    attributes Hash after every rollback.
Commits on May 21, 2012
  1. @pwnall
Commits on May 20, 2012
  1. @drogus

    Fix uniqueness validator with `allow_nil: false` also for mysql

    drogus committed May 19, 2012
    MySQL's adapter was changing value for case sensitive comparison. We
    don't need to do it for `nil`.
  2. @drogus

    Fix `validates_uniqueness_off :field, :allow_nil => false`

    drogus committed May 19, 2012
    Closes (#5853)
    
    Uniqueness validator was not properly checking if there are any existing
    records, when value was `nil` and column was text type. `nil` was
    converted to string, which resulted in queries looking like:
    
    ```sql
    SELECT 1 FROM "posts" WHERE "posts"."title" = '' LIMIT 1
    ```
    
    instead of
    
    ```sql
    SELECT 1 FROM "posts" WHERE "posts"."title" IS NULL LIMIT 1
    ```
Commits on May 19, 2012
  1. @tenderlove

    Merge pull request #6398 from pmahoney/threadsafe-connection-pool

    tenderlove committed May 19, 2012
    Synchronize read and modification of @reserved_connections
  2. @drogus

    Ensure that CollectionAssociation#replace returns proper target

    drogus committed May 18, 2012
    The fix commited in e2a070c was returning the `new_target`, as
    a try to return whatever user replaced association with. The
    problem is, the resulting association target may be ordered
    differently. In such case we want to return the target that
    will be later used for that association.
Commits on May 18, 2012
  1. @ernie
  2. @jonleighton
  3. @jonleighton

    Perf: Don't load the association for #delete_all.

    jonleighton committed May 18, 2012
    Bug #6289
    
    Conflicts:
    
    	activerecord/test/cases/associations/has_many_associations_test.rb
Something went wrong with that request. Please try again.