Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Dec 16, 2011
  1. @fxn
Commits on Dec 4, 2011
  1. @fxn

    Merge branch 'explain'

    fxn authored
  2. @fxn

    implements a much faster auto EXPLAIN, closes #3843 [José Valim & Xav…

    fxn authored
    …ier Noria]
    
    This commit vastly reduces the impact of auto
    explain logging when enabled, while keeping
    a negligible cost when disabled.
    
    The first implementation was based on the idea
    of subscribing to "sql.active_record" when
    needed, and unsubscribing once done. This is
    the idea behind AR::Relation#explain. Subscribe,
    collect, unsubscribe.
    
    But with the current implementation of notifications
    unsubscribing is costly, because it wipes an internal
    cache and that puts a penalty on the next event.
    
    So we are switching to an approach where a long-running
    subscriber is listening. Instead of collecting the
    queries with a closure in a dedicated subscriber, now
    we setup a thread local.
    
    If the feature is disabled by setting the threshold
    to nil, the subscriber will call a method that does
    nothing. That's totally cheap.
Commits on Dec 3, 2011
  1. @fxn

    removes the convenience instance version of AR::Base.silence_auto_exp…

    fxn authored
    …lain
    
    Rationale: As discussed with José and Jon, this convenience
    shortcut is not clearly justified and it could let the user
    thing the disabled EXPLAINs are related to the model instance
    rather than being globally disabled.
Commits on Dec 2, 2011
  1. @fxn
  2. @fxn
Commits on Aug 13, 2011
  1. @fxn

    Merge branch 'master' of github.com:lifo/docrails

    fxn authored
    Conflicts:
    	RELEASING_RAILS.rdoc
    	actionpack/lib/sprockets/railtie.rb
    	actionpack/test/template/sprockets_helper_test.rb
    	activerecord/test/cases/calculations_test.rb
    	railties/guides/source/3_1_release_notes.textile
    	railties/guides/source/active_resource_basics.textile
    	railties/guides/source/command_line.textile
  2. @fxn

    Revert "Explicitly included hashes in sentence regarding SQL-injectio…

    fxn authored
    …n-safe forms"
    
    Reason: The hash form is secure, and preferred over the array form if possible.
    
    This reverts commit 6dc7495.
Commits on Aug 4, 2011
  1. @fxn

    Revert "Explicitly included hashes in sentence regarding SQL-injectio…

    fxn authored
    …n-safe forms"
    
    Reason: The hash form is secure, and preferred over the array form if possible.
    
    This reverts commit 6dc7495.
Commits on Jul 23, 2011
  1. @fxn

    Merge pull request #2086 from amatsuda/date_multiparameter_nil

    fxn authored
    convert multiple Date parameters into a nil if any of its bits were blank
  2. @fxn
Commits on May 21, 2011
  1. @fxn

    Merge pull request #1180 from Karunakar/documentation_change

    fxn authored
    Documentation Error Fixed for ticket #839
Commits on May 4, 2011
  1. @fxn
Commits on Feb 18, 2011
  1. @fxn

    merges docrails

    fxn authored
  2. @fxn
Commits on Feb 2, 2011
  1. @fxn
Commits on Nov 25, 2010
  1. @fxn
Commits on Nov 23, 2010
  1. @fxn
Commits on Nov 16, 2010
  1. @fxn

    revises RDoc of AR::Base#==

    fxn authored
Commits on Aug 24, 2010
  1. @fxn
  2. @fxn
Commits on Aug 12, 2010
  1. @fxn
Commits on Aug 4, 2010
  1. @fxn
Commits on Jul 7, 2010
  1. @fxn
Commits on Jun 20, 2010
  1. @fxn

    Merge remote branch 'rails/master'

    fxn authored
    Conflicts:
    	actionpack/lib/abstract_controller/base.rb
Commits on Jun 14, 2010
  1. @fxn
Commits on Apr 13, 2010
  1. @fxn

    removes unnecessary assignment and local variable in AR::Base#subclas…

    fxn authored
    …ses, and revises its rdoc
Commits on Apr 5, 2010
  1. @fxn

    moves Object#singleton_class to Kernel#singleton_class to match Ruby …

    fxn authored
    …also there, same for #class_eval to simplify, and adds coverage for class_eval
Commits on Mar 31, 2010
  1. @fxn

    Merge commit 'rails/master'

    fxn authored
Commits on Mar 28, 2010
  1. @fxn
  2. @fxn
Commits on Nov 9, 2009
  1. @fxn
Commits on Jun 12, 2009
  1. @fxn @jeremy

    uses Object#metaclass and Object#class_eval in a few spots

    fxn authored jeremy committed
    [#2797 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Dec 28, 2008
  1. @fxn @lifo

    Inline code comments for class_eval/module_eval [#1657 state:resolved]

    fxn authored lifo committed
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Commits on May 2, 2008
  1. @fxn @lifo

    Improve documentation coverage and markup

    fxn authored lifo committed
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Something went wrong with that request. Please try again.