Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 7, 2012
  1. @jonleighton

    Fix attribute_before_type_cast for serialized attributes. Fixes #4837.

    jonleighton authored
    Conflicts:
    
    	activerecord/lib/active_record/core.rb
Commits on Jan 20, 2012
  1. @jonleighton

    Fix another race condition.

    jonleighton authored
    From 2c667f6.
    
    Thanks @pwnall for the heads-up.
    
    Conflicts:
    
    	activerecord/lib/active_record/core.rb
Commits on Dec 22, 2011
  1. @jonleighton
Commits on Dec 15, 2011
  1. @jonleighton
  2. @jonleighton
  3. @jonleighton
Commits on Dec 14, 2011
  1. @jonleighton

    Cache column defaults on model. ~30% on Model.new due to avoiding rep…

    jonleighton authored
    …eatedly fetching connection.
Commits on Dec 4, 2011
  1. @jonleighton

    Merge pull request #3851 from ebeigarts/fix_sequence_name

    jonleighton authored
    Fix sequence name with abstract classes.
Commits on Dec 1, 2011
  1. @jonleighton

    Remove the need for type_cast_attribute.

    jonleighton authored
    This is good because it reduces duplication.
  2. @jonleighton
  3. @jonleighton

    Add hackery to make Syck use encode_with/init_with. Fixes 1.8 after r…

    jonleighton authored
    …ecent changes to attribute serialization.
Commits on Nov 30, 2011
  1. @jonleighton

    omg computer science!

    jonleighton authored
    Implement a mini state machine for serialized attributes. This means we
    do not have to deserialize the values upon initialization, which means
    that if we never actually access the attribute, we never have to
    deserialize it.
  2. @jonleighton
  3. @jonleighton
Commits on Nov 29, 2011
  1. @jonleighton
  2. @jonleighton

    Deprecated `define_attr_method` in `ActiveModel::AttributeMethods`

    jonleighton authored
    This only existed to support methods like `set_table_name` in Active
    Record, which are themselves being deprecated.
  3. @jonleighton
  4. @jonleighton

    extract method

    jonleighton authored
  5. @jonleighton
  6. @jonleighton
  7. @jonleighton
  8. @jonleighton
  9. @jonleighton

    Merge pull request #3636 from joshsusser/master

    jonleighton authored
    association methods are now generated in modules
Commits on Nov 5, 2011
  1. @jonleighton
Commits on Oct 5, 2011
  1. @jonleighton

    Revert "Raise error on unknown primary key."

    jonleighton authored
    This reverts commit ee2be43.
  2. @jonleighton

    Raise error on unknown primary key.

    jonleighton authored
    If we don't have a primary key when we ask for it, it's better to fail
    fast. Fixes GH #2307.
Commits on Sep 26, 2011
  1. @jonleighton
Commits on Sep 13, 2011
  1. @jonleighton

    Rename first_or_new to first_or_initialize.

    jonleighton authored
    For consistency with find_or_initialize_by. Also remove first_or_build
    alias.
Commits on Sep 12, 2011
  1. @jonleighton

    Always generate attribute methods on the base class.

    jonleighton authored
    This fixes a situation I encountered where a subclass would cache the
    name of a generated attribute method in @_defined_class_methods. Then,
    when the superclass has it's attribute methods undefined, the subclass
    would always have to dispatch through method_missing, because the
    presence of the attribute in @_defined_class_methods would mean that it
    is never generated again, even if undefine_attribute_methods is called
    on the subclass.
    
    There various other confusing edge cases like this. STI classes share
    columns, so let's just keep all the attribute method generation state
    isolated to the base class.
Commits on Aug 29, 2011
  1. @jonleighton
Commits on Aug 16, 2011
  1. @jonleighton

    In 1efd882, ConnectionAdapters was put under eager_autoload. Due to t…

    jonleighton authored
    …he requires in that file, this caused ConnectionSpecification to be loaded, which references ActiveRecord::Base, which means the database connection is established. We do not want to connect to the database when Active Record is loaded, only when ActiveRecord::Base is first referenced by the user.
Commits on Aug 13, 2011
  1. @jonleighton
  2. @jonleighton
Commits on Aug 8, 2011
  1. @jonleighton
  2. @jonleighton

    Make it the responsibility of the connection to hold onto an ARel vis…

    jonleighton authored
    …itor for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
Something went wrong with that request. Please try again.