Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Dec 15, 2011
  1. @josevalim
Commits on Dec 8, 2011
  1. @josevalim

    Remove NilClass whiners feature.

    josevalim authored
    Removing this feature causes boost in performance when using Ruby 1.9.
    
    Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str`
    in some STDLIB methods (like Array#join). To do such implicit conversions,
    Ruby 1.9 always dispatches the method and rescues the NoMethodError exception
    in case one is raised.
    
    Therefore, since the whiners feature defined NilClass#method_missing, such
    implicit conversions for nil became much, much slower. In fact, just defining
    NilClass#method_missing (even without the whiners feature) already causes a
    massive slow down. Here is a snippet that shows such slow down:
    
        require "benchmark"
        Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
    
        class NilClass
          def method_missing(*args)
            raise NoMethodError
          end
        end
    
        Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
Commits on May 10, 2011
  1. @josevalim
Commits on May 7, 2011
  1. @josevalim
  2. @josevalim
Commits on May 6, 2011
  1. @josevalim

    Revert the merge because tests did not pass.

    josevalim authored
    Revert "Merge pull request #423 from richardiux/master"
    
    This reverts commit b8f08c4, reversing
    changes made to fd9df1b.
  2. @josevalim

    Merge pull request #423 from richardiux/master

    josevalim authored
    Identity Map caching bug
Commits on Dec 27, 2010
  1. @josevalim

    No need to symbolize these.

    josevalim authored
Commits on Nov 28, 2010
  1. @josevalim

    Partialy revert f1c13b0

    josevalim authored
Commits on Sep 2, 2010
  1. @josevalim

    Revert "Setup explicit requires for files with exceptions. Removed th…

    josevalim authored
    …em from autoloading."
    
    Booting a new Rails application does not work after this commit [#5359 state:open]
    
    This reverts commit 38a421b.
Commits on Jun 30, 2010
  1. @josevalim
Commits on Jun 29, 2010
  1. @josevalim
  2. @josevalim

    Add scoping and unscoped as the syntax to replace the old with_scope …

    josevalim authored
    …and with_exclusive_scope. A few examples:
    
    * with_scope now should be scoping:
    
    Before:
    
      Comment.with_scope(:find => { :conditions => { :post_id => 1 } }) do
        Comment.first #=> SELECT * FROM comments WHERE post_id = 1
      end
    
    After:
    
      Comment.where(:post_id => 1).scoping do
        Comment.first #=> SELECT * FROM comments WHERE post_id = 1
      end
    
    * with_exclusive_scope now should be unscoped:
    
      class Post < ActiveRecord::Base
        default_scope :published => true
      end
    
      Post.all #=> SELECT * FROM posts WHERE published = true
    
    Before:
    
      Post.with_exclusive_scope do
        Post.all #=> SELECT * FROM posts
      end
    
    After:
    
      Post.unscoped do
        Post.all #=> SELECT * FROM posts
      end
    
    Notice you can also use unscoped without a block and it will return an anonymous scope with default_scope values:
    
      Post.unscoped.all #=> SELECT * FROM posts
Commits on Jun 24, 2010
  1. @josevalim

    Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing f…

    josevalim authored
    …rameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved]
Commits on Jun 19, 2010
  1. @josevalim
  2. @josevalim
Commits on Apr 28, 2010
  1. @josevalim

    Fix failing test.

    josevalim authored
Commits on Mar 29, 2010
  1. @josevalim
Commits on Feb 21, 2010
  1. @josevalim

    Require persisted? in ActiveModel::Lint and remove new_record? and de…

    josevalim authored
    …stroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
Commits on Jan 17, 2010
  1. @josevalim
Commits on Jan 13, 2010
  1. @josevalim
Commits on Dec 30, 2009
  1. @josevalim
Commits on Oct 21, 2009
  1. @josevalim

    Move validator, human_name and human_attribute_name to ActiveModel, r…

    josevalim authored Carl Lerche committed
    …emove deprecated error messages and add i18n_scope and lookup_ancestors.
    
    Signed-off-by: Carl Lerche <carllerche@mac.com>
Commits on Oct 15, 2009
  1. @josevalim

    Unify benchmark APIs.

    josevalim authored
  2. @josevalim
Commits on Sep 8, 2009
  1. @josevalim @josh

    Changed ActiveRecord to use new callbacks and speed up observers by o…

    josevalim authored josh committed
    …nly notifying events that are actually being consumed.
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
Commits on Aug 7, 2009
  1. @josevalim

    Add destroyed? to ActiveRecord, include tests for polymorphic urls fo…

    josevalim authored
    …r destroyed objects and refactor mime responds tests and documentation.
Something went wrong with that request. Please try again.