Skip to content
This repository

Aug 01, 2012

  1. Santiago Pastorino

    Bump to 3.2.8.rc1

    spastorino authored
  2. Rafael Mendonça França

    Fix CHANGELOGS

    rafaelfranca authored
  3. Xavier Noria

    removes the deprecation of update_attribute

    Applying the new policy here to not deprecate stuff in point releases.
    fxn authored
  4. Xavier Noria

    revises the deprecation warning of update_attribute

    We have decided not to drop this important method in 4.0 and give
    it a longer deprecation cycle. On the other hand we do not expect
    to have update_column around for a long time, it is going to be
    replaced in favor of update_columns.
    fxn authored
  5. Rafael Mendonça França

    Revert "Deprecating composed_of in ActiveRecord"

    This reverts commit 44b313b.
    rafaelfranca authored
  6. Jon Leighton

    Revert "Deprecate :finder_sql, :counter_sql, :insert_sql, :delete_sql."

    This reverts commit a79bfa9.
    
    Conflicts:
    	activerecord/CHANGELOG.md
    
    We shouldn't introducing deprecations in point releases.
    It will be deprecated in 4.0 instead.
    jonleighton authored
  7. Santiago Pastorino

    Add missing CHANGELOG entries

    [ci skip]
    spastorino authored

Jul 31, 2012

  1. Rafael Mendonça França

    Add CHANGELOG entry [ci skip]

    rafaelfranca authored

Jul 30, 2012

  1. Rafael Mendonça França

    Revert "Add update_columns and the suggestion of using update_columns

    instead of update_column"
    
    This reverts commit 9fa06c3.
    
    This reverts commit 17a64de.
    
    This reverts commit def9c85, reversing
    changes made to 6b7d26c.
    
    Reason: This was supposed to be released with 3.2.7 before the
    suggestion to use update_column. Since it was not release now is not
    good to suggest to use another method because it will confusing the
    people.
    rafaelfranca authored

Jul 28, 2012

  1. Xavier Noria

    removes the AR session store from eager loaded code [fixes #7160]

    See the comment in the file activerecord/lib/active_record.rb
    added by this patch for the rationale.
    fxn authored
  2. Xavier Noria

    missing require: the AR session store depends on the AP abstract store

    This require makes the dependency even more clear.
    In particular we are eager loading the session
    store but that does not work if AR is used
    outside Rails, this patch is preliminary work
    in fixing #7160.
    fxn authored

Jul 27, 2012

  1. Rafael Mendonça França

    Only require the `:rails_env` task where is needed.

    `:rails_env` tasks is not needed in all the tasks that depends of
    `load_config`, only in the tasks that uses `Rails.env`.
    
    Since `:rails_env` task set the `Rails.env` to be "development" if it is
    not set we don't need the `||` statements too
    
    Fix #7175.
    rafaelfranca authored

Jul 26, 2012

  1. Aaron Patterson

    Merge branch '3-2-rel' into 3-2-stable

    * 3-2-rel:
      updating release date
      bumping to 3.2.7
      updating the changelog
      * Do not convert digest auth strings to symbols. CVE-2012-3424
      updating the version
      updating changelogs
    tenderlove authored
  2. Aaron Patterson

    updating release date

    tenderlove authored
  3. Aaron Patterson

    bumping to 3.2.7

    tenderlove authored
  4. Philip Arndt

    Switched update_column recommendation in changelog to update_columns

    This is related to #7159
    parndt authored
  5. Carlos Antonio da Silva

    Fix AR#update_columns tests on Ruby 1.8.7

Jul 25, 2012

  1. Philip Arndt

    Suggest using update_columns instead of update_column.

    update_column is deprecated in Rails 4.0 so it makes no sense to
    recommend adopting it only to require changing to update_columns
    in the very next release.
    parndt authored
  2. Sebastian Martinez

    New #update_columns method.

    smartinez87 authored parndt committed

Jul 23, 2012

  1. Aaron Patterson

    updating the version

    tenderlove authored

Jul 20, 2012

  1. Jon Leighton

    Deprecate :finder_sql, :counter_sql, :insert_sql, :delete_sql.

    jonleighton authored
  2. Carlos Antonio da Silva

    Merge pull request #6616 from dpassage/fix_resolver_test_sqlite3

    Resolver tests fail if mysql adapter not installed

Jul 17, 2012

  1. John Firebaugh

    AR::Integration must be included after AM::Conversion

    Integration's definition of #to_param must override
    Conversion's. Otherwise, there is a regression from
    3.1 in the behavior of a non-persisted AR::Base instance
    which nevertheless has an id.
    jfirebaugh authored
  2. Rafael Mendonça França

    Merge pull request #4396 from kennyj/fix_4259

    Fix GH #4259. When we execute schema dumper, we must remove table_name_prefix and table_name_suffix.
    rafaelfranca authored

Jul 13, 2012

  1. Aaron Patterson

    fixing tests to deal with data differences between prepared statement…

    …s and non-prepared statements
    tenderlove authored
  2. Jeremy Cole

    Fixing texts; down to three failing tests.

    jeremycole authored
  3. Jeremy Cole

    Only use prepared statements when bind variables are present

    Prepared statements (prepare/execute/close) were being used unnecessarily
    when no bind variables were present, and disabling prepared statement using
    prepared_statements:false was principally broken. While bind variables were
    correctly substituted with prepared_statements:false, the prepared statement
    interface was still used, costing an extra two round trips per query.
    
    In addition to making this behavioral change, I also cleaned up the internals
    of exec_stmt and exec_without_stmt so that they behave the same (calling log
    and constructing the ActiveRecord::Result in the same way).
    
    Moving the check for binds.empty? to exec_query also will mean that several
    code paths explicitly calling exec_without_stmt could be cleaned up to once
    again call exec_query instead. I have also left the check for binds.empty? in
    exec_stmt, since it is not a private method and could be called directly with
    an empty binds array. For the sake of clarity in this patch, I have not made
    those changes.
    
    = The previous behavior =
    
    When issuing a Foo.find(1) with prepared_statements:true, the bind variable
    is present in the prepared query, and execute shows a value passed:
    
        Connect	root@localhost on rails_test
        Query	SET SQL_AUTO_IS_NULL=0
        Statistics
        Query	SHOW FULL FIELDS FROM `foos`
        Query	SHOW TABLES LIKE 'foos'
        Query	SHOW CREATE TABLE `foos`
        Prepare	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = ? LIMIT 1
        Execute	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
        Close stmt
        Quit
    
    When issuing a Foo.find(1) with prepared_statements:false, the bind variable
    has already been removed and substituted with the value, but the prepared
    statement interface is used anyway:
    
        Connect	root@localhost on rails_test
        Query	SET SQL_AUTO_IS_NULL=0
        Statistics
        Query	SHOW FULL FIELDS FROM `foos`
        Query	SHOW TABLES LIKE 'foos'
        Query	SHOW CREATE TABLE `foos`
        Prepare	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
        Execute	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
        Close stmt
        Quit
    
    = With this patch applied =
    
    When issuing a Foo.find(1) with prepared_statements:true, the bind variable
    is present in the prepared query, and execute shows a value passed:
    
        Connect	root@localhost on rails_test
        Query	SET SQL_AUTO_IS_NULL=0
        Statistics
        Query	SHOW FULL FIELDS FROM `foos`
        Query	SHOW TABLES LIKE 'foos'
        Query	SHOW CREATE TABLE `foos`
        Prepare	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = ? LIMIT 1
        Execute	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
        Close stmt
        Quit
    
    When issuing a Foo.find(1) with prepared_statements:false, the bind variable
    has been removed and substituted with the value, and the query interface is
    used instead of the prepared statement interface:
    
        Connect	root@localhost on rails_test
        Query	SET SQL_AUTO_IS_NULL=0
        Statistics
        Query	SHOW FULL FIELDS FROM `foos`
        Query	SHOW TABLES LIKE 'foos'
        Query	SHOW CREATE TABLE `foos`
        Query	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
        Quit
    jeremycole authored

Jul 11, 2012

  1. Robb Kidd

    Update psql adapter to rename a default pkey sequence during rename_t…

    …able.
    robbkidd authored

Jul 06, 2012

  1. Rafael Mendonça França

    Merge pull request #6985 from sidonath/disable-query-cache-for-locks

    Disable query cache for lock queries
    Conflicts:
    	activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb
    rafaelfranca authored

Jul 02, 2012

  1. Francesco Rodríguez

    Backport #3329 to 3-2-stable

    Fix bug with autosave collection association on new record with a marked
    for destroy record in autosave collection.
    
    Fixes #6918.
    frodsan authored

Jun 28, 2012

  1. Rafael Mendonça França

    Merge pull request #6878 from masarakki/master

    fix bug in limit of enum columns of mysql
    
    Closes #6432
    rafaelfranca authored
  2. Carlos Antonio da Silva

    Merge pull request #6900 from cbandy/issue-6898

    Require URI in ConnectionSpecification
    Conflicts:
    	activerecord/lib/active_record/connection_adapters/connection_specification.rb

Jun 25, 2012

  1. Carlos Antonio da Silva

    Ensure Arel columns are typecasted properly when grouping with calcul…

    …ation
    
    Fix build issue with postgresql.
    
    Conflicts:
    	activerecord/lib/active_record/relation/calculations.rb
    	activerecord/test/cases/calculations_test.rb

Jun 24, 2012

  1. Rafael Mendonça França

    Merge pull request #6842 from ernie/handle-non-strings-in-grouped-cal…

    …culations
    
    Stop assuming strings for grouped calculations
    Conflicts:
    	activerecord/lib/active_record/relation/calculations.rb
    rafaelfranca authored

Jun 21, 2012

  1. Rafael Mendonça França

    Remove waning of unused variable

    rafaelfranca authored
Something went wrong with that request. Please try again.