Skip to content
This repository

Jul 17, 2012

  1. John Firebaugh

    AR::Integration must be included after AM::Conversion

    Integration's definition of #to_param must override
    Conversion's. Otherwise, there is a regression from
    3.1 in the behavior of a non-persisted AR::Base instance
    which nevertheless has an id.
    jfirebaugh authored

May 31, 2012

  1. Philip Arndt

    Revert "Removes unneeded caching from ActiveRecord::Base.relation"

    This reverts commit ebfa58a.
    
    This change caused a regression in my application's tests:
    
    * Failing build http://travis-ci.org/#!/resolve/refinerycms/builds/1461242
    
    Broken tests pass after this change is reverted.
    parndt authored

May 30, 2012

  1. Aaron Patterson

    Merge pull request #5810 from kennyj/fix_5797

    Fix #5797. Error calling dup method on AR model with serialized field
    Conflicts:
    	activerecord/lib/active_record/core.rb
    tenderlove authored rafaelfranca committed

Apr 19, 2012

  1. Benedikt Deicke

    Removes unneeded caching from ActiveRecord::Base.relation

    benedikt authored

Mar 13, 2012

  1. Toshinori Kajihara

    [3-2-stable] Fix GH #5399. connection_pools's keys are ActiveRecord::…

    …Base::ConnectionSpecification objects.
    kennyj authored

Mar 12, 2012

  1. Andrew White

    Add documentation for find_or_create_by_{attribute}! method.

    pixeltrix authored

Feb 07, 2012

  1. Jon Leighton

    Fix attribute_before_type_cast for serialized attributes. Fixes #4837.

    Conflicts:
    
    	activerecord/lib/active_record/core.rb
    jonleighton authored

Jan 20, 2012

  1. Jon Leighton

    Fix another race condition.

    From 2c667f6.
    
    Thanks @pwnall for the heads-up.
    
    Conflicts:
    
    	activerecord/lib/active_record/core.rb
    jonleighton authored

Dec 22, 2011

  1. Jon Leighton

    Make read_attribute code path accessible at the class level

    jonleighton authored

Dec 16, 2011

  1. Xavier Noria

    AS::Concern is not really needed for AR::Explain

    fxn authored

Dec 15, 2011

  1. Jon Leighton

    Move DefaultScope and NamedScope under Scoping

    jonleighton authored
  2. Jon Leighton

    Let AttributeMethods do its own including etc

    jonleighton authored
  3. Jon Leighton

    Split out most of the AR::Base code into separate modules :cake:

    jonleighton authored
  4. José Valim

    Make with_scope public so we stop using send :bomb:

    josevalim authored
  5. Andrew Kaspick

    Allow nested attributes in associations to update values in it's owne…

    …r object. Fixes a regression from 3.0.x
    akaspick authored

Dec 14, 2011

  1. Jon Leighton

    Cache column defaults on model. ~30% on Model.new due to avoiding rep…

    …eatedly fetching connection.
    jonleighton authored

Dec 09, 2011

  1. Aaron Patterson

    Use `table_exists?` from the schema cache.

    tenderlove authored

Dec 08, 2011

  1. José Valim

    Remove NilClass whiners feature.

    Removing this feature causes boost in performance when using Ruby 1.9.
    
    Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str`
    in some STDLIB methods (like Array#join). To do such implicit conversions,
    Ruby 1.9 always dispatches the method and rescues the NoMethodError exception
    in case one is raised.
    
    Therefore, since the whiners feature defined NilClass#method_missing, such
    implicit conversions for nil became much, much slower. In fact, just defining
    NilClass#method_missing (even without the whiners feature) already causes a
    massive slow down. Here is a snippet that shows such slow down:
    
        require "benchmark"
        Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
    
        class NilClass
          def method_missing(*args)
            raise NoMethodError
          end
        end
    
        Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
    josevalim authored

Dec 04, 2011

  1. Jon Leighton

    Merge pull request #3851 from ebeigarts/fix_sequence_name

    Fix sequence name with abstract classes.
    jonleighton authored
  2. Xavier Noria

    Merge branch 'explain'

    fxn authored
  3. Xavier Noria

    implements a much faster auto EXPLAIN, closes #3843 [José Valim & Xav…

    …ier Noria]
    
    This commit vastly reduces the impact of auto
    explain logging when enabled, while keeping
    a negligible cost when disabled.
    
    The first implementation was based on the idea
    of subscribing to "sql.active_record" when
    needed, and unsubscribing once done. This is
    the idea behind AR::Relation#explain. Subscribe,
    collect, unsubscribe.
    
    But with the current implementation of notifications
    unsubscribing is costly, because it wipes an internal
    cache and that puts a penalty on the next event.
    
    So we are switching to an approach where a long-running
    subscriber is listening. Instead of collecting the
    queries with a closure in a dedicated subscriber, now
    we setup a thread local.
    
    If the feature is disabled by setting the threshold
    to nil, the subscriber will call a method that does
    nothing. That's totally cheap.
    fxn authored
  4. Edgars Beigarts

    Fix sequence name with abstract classes.

    ebeigarts authored
  5. Carlos Antonio da Silva

    Refactor readonly attributes conditional

Dec 03, 2011

  1. Xavier Noria

    removes the convenience instance version of AR::Base.silence_auto_exp…

    …lain
    
    Rationale: As discussed with José and Jon, this convenience
    shortcut is not clearly justified and it could let the user
    thing the disabled EXPLAINs are related to the model instance
    rather than being globally disabled.
    fxn authored

Dec 02, 2011

  1. Xavier Noria

    implements AR::Base(.|#)silence_auto_explain

    fxn authored
  2. Xavier Noria

    implements automatic EXPLAIN logging for slow queries

    fxn authored

Dec 01, 2011

  1. Jon Leighton

    Remove the need for type_cast_attribute.

    This is good because it reduces duplication.
    jonleighton authored
  2. Jon Leighton

    Get rid of the underscore versions of attribute methods!

    This makes me happy!
    jonleighton authored
  3. David Heinemeier Hansson

    Revert "Added ActiveRecord::Base#last_modified to work with the new f…

    …resh_when/stale? conditional get methods from Action Pack"
    
    Needless indirection with no added value.
    
    This reverts commit 535853e.
    dhh authored
  4. David Heinemeier Hansson

    Added ActiveRecord::Base#last_modified to work with the new fresh_whe…

    …n/stale? conditional get methods from Action Pack
    dhh authored
  5. Jon Leighton

    Add hackery to make Syck use encode_with/init_with. Fixes 1.8 after r…

    …ecent changes to attribute serialization.
    jonleighton authored

Nov 30, 2011

  1. Jon Leighton

    omg computer science!

    Implement a mini state machine for serialized attributes. This means we
    do not have to deserialize the values upon initialization, which means
    that if we never actually access the attribute, we never have to
    deserialize it.
    jonleighton authored
  2. Jon Leighton

    Move some serialization stuff out of Base

    jonleighton authored
  3. Jon Leighton

    Extract attribute serialization code into a separate module

    jonleighton authored
  4. Bogdan Gusiev

    ActiveRecord::Relation#pluck method

    bogdan authored
Something went wrong with that request. Please try again.