Skip to content
Commits on Jun 7, 2012
  1. @jonleighton

    Revert "Perf: Don't load the association for #delete_all."

    jonleighton committed
    This reverts commit b98d1e2.
    
    Closes #6609
    
    Conflicts:
    
    	activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb
Commits on May 18, 2012
  1. @ernie
  2. @jonleighton
  3. @jonleighton

    Perf: Don't load the association for #delete_all.

    jonleighton committed
    Bug #6289
    
    Conflicts:
    
    	activerecord/test/cases/associations/has_many_associations_test.rb
Commits on Dec 14, 2011
  1. @jonleighton
Commits on Aug 8, 2011
  1. @jonleighton

    Make it the responsibility of the connection to hold onto an ARel vis…

    jonleighton committed
    …itor for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
Commits on May 31, 2011
  1. @jonleighton
Commits on Mar 10, 2011
  1. @jonleighton

    Move the code which builds a scope for through associations into a ge…

    jonleighton committed
    …neric AssociationScope class which is capable of building a scope for any association.
Commits on Feb 21, 2011
  1. @jonleighton @tenderlove

    Delegate Association#options to the reflection, and replace 'reflecti…

    jonleighton committed with tenderlove
    …on.options' with 'options'. Also add through_options and source_options methods for through associations.
  2. @jonleighton @tenderlove

    Associations - where possible, call attributes methods rather than di…

    jonleighton committed with tenderlove
    …rectly accessing the instance variables
Commits on Feb 18, 2011
  1. @jonleighton

    Split AssociationProxy into an Association class (and subclasses) whi…

    jonleighton committed
    …ch manages the association, and a CollectionProxy class which is *only* a proxy. Singular associations no longer have a proxy. See CHANGELOG for more.
Commits on Feb 14, 2011
  1. @jonleighton
  2. @jonleighton

    Add interpolation of association conditions back in, in the form of p…

    jonleighton committed
    …roc { ... } rather than instance_eval-ing strings
Commits on Feb 7, 2011
  1. @jonleighton

    Refactor the implementations of AssociatioCollection#delete and #dest…

    jonleighton committed
    …roy to be more consistent with each other, and to stop passing blocks around, thus making the execution easier to follow.
  2. @jonleighton

    Make record.association.destroy(*records) on habtm and hm:t only dele…

    jonleighton committed
    …te records in the join table. This is to make the destroy method more consistent across the different types of associations. For more details see the CHANGELOG entry.
Commits on Jan 30, 2011
  1. @jonleighton
  2. @jonleighton
Commits on Jan 16, 2011
  1. @jonleighton @tenderlove

    Removed support for accessing attributes on a has_and_belongs_to_many…

    jonleighton committed with tenderlove
    … join table. This has been documented as deprecated behaviour since April 2006. Please use has_many :through instead. A deprecation warning will be added to the 3-0-stable branch for the 3.0.4 release.
Commits on Jan 7, 2011
  1. @jonleighton @tenderlove

    Construct an actual ActiveRecord::Relation object for the association…

    jonleighton committed with tenderlove
    … scope, rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.
Commits on Jan 5, 2011
  1. @tenderlove
  2. @tenderlove
  3. @tenderlove
  4. @tenderlove
Commits on Jan 4, 2011
  1. @rsim

    Explicitly select * from has_and_belongs_to_many association tables, …

    rsim committed
    …simplify exists? query
    
    Previous version (after commit 3103296) was generating wrong SQL for Oracle when calling exists? method on HABTM association.
  2. @jonleighton @tenderlove
  3. @jonleighton @tenderlove

    Let AssociationCollection#find use #scoped to do its finding. Note th…

    jonleighton committed with tenderlove
    …at I am removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
Commits on Dec 31, 2010
  1. @jonleighton

    Rename AssociationReflection#primary_key_name to foreign_key, since t…

    jonleighton committed
    …he options key which it relates to is :foreign_key
Commits on Dec 26, 2010
  1. @jonleighton @tenderlove
  2. @jonleighton

    Associations: DRY up the code which is generating conditions, and mak…

    jonleighton committed
    …e it all use arel rather than SQL strings
Commits on Dec 20, 2010
  1. @jonleighton @tenderlove

    Remove unnecessary overloaded methods create, create! and create_reco…

    jonleighton committed with tenderlove
    …rd from HasAndBelongsToManyAssociation
  2. @jonleighton @tenderlove

    Specify insert_record with NotImplementedError in AssociationCollecti…

    jonleighton committed with tenderlove
    …on, to indicate that subclasses should implement it. Also add save_record to reduce duplication.
Commits on Dec 2, 2010
  1. @tenderlove
  2. @tenderlove
Commits on Nov 28, 2010
  1. @josevalim

    Partialy revert f1c13b0

    josevalim committed
Commits on Nov 25, 2010
  1. @miloops @spastorino

    Remove explicit return.

    miloops committed with spastorino
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Something went wrong with that request. Please try again.