Skip to content
This repository

Oct 29, 2012

  1. Rafael Mendonça França

    Make Active Record tests pass in isolation

    Also remove the feature detecting for Ruby 1.9
    rafaelfranca authored
  2. Rafael Mendonça França

    Merge pull request #7593 from veader/patch-1

    Decode attributes pulled from URI.parse
    Conflicts:
    	activerecord/CHANGELOG.md
    	activerecord/lib/active_record/connection_adapters/connection_specification.rb
    rafaelfranca authored

Oct 15, 2012

  1. Aaron Patterson

    Synchronize around deleting from the reserved connections hash.

    Fixes #7955
    tenderlove authored

Sep 24, 2012

  1. Jonathan Rochkind

    ConnectionPool accepts spec key 'checkout_timeout'

    Backport of #6441 cb6f839 . Old 'wait_timeout' is still supported,
    but conflicts with mysql2 using that spec key for different thing.
    'checkout_timeout' can now be used taking precedence for ConnectionPool
    over 'wait_timeout'.
    jrochkind authored

Sep 20, 2012

  1. Rafael Mendonça França

    Revert "backport fair connection pool 02b2335 to 3-2-stable"

    This reverts commit 0693e07.
    
    Revert "Cache columns metadata to avoid extra while testing"
    
    This reverts commit a82f1e3.
    
    Reason: This is causing failures in the postgresql build.
    See http://travis-ci.org/#!/rails/rails/builds/2485584
    
    Related with #7675
    rafaelfranca authored

Sep 17, 2012

  1. Jonathan Rochkind

    backport fair connection pool 02b2335 to 3-2-stable

    jrochkind authored

Aug 18, 2012

  1. Joe Rafaniello

    Table#remove passed an array to remove_column, which is deprecated.

    jrafanie authored

Jul 06, 2012

  1. Rafael Mendonça França

    Merge pull request #6985 from sidonath/disable-query-cache-for-locks

    Disable query cache for lock queries
    Conflicts:
    	activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb
    rafaelfranca authored

Jun 28, 2012

  1. Carlos Antonio da Silva

    Merge pull request #6900 from cbandy/issue-6898

    Require URI in ConnectionSpecification
    Conflicts:
    	activerecord/lib/active_record/connection_adapters/connection_specification.rb

May 23, 2012

  1. Synchronize the ConnectionPool#release method to avoid thread safety …

    …issues [#6464]
    
    Fixes #6464
    
    Synchronize the contents of the release method in ConnectionPool due to
    errors when running in high concurrency environments.
    
        Detected invalid hash contents due to unsynchronized modifications
    with concurrent users
        org/jruby/RubyHash.java:1356:in `keys'
    /usr/local/rvm/gems/jruby-1.6.7@new_import/gems/activerecord-3.2.3/lib/a
    ctive_record/connection_adapters/abstract/connection_pool.rb:294:in
    `release'
    
    /usr/local/rvm/gems/jruby-1.6.7@new_import/gems/activerecord-3.2.3/lib/a
    ctive_record/connection_adapters/abstract/connection_pool.rb:282:in
    `checkin'
    Andrew Selder authored

May 19, 2012

  1. Aaron Patterson

    Merge pull request #6398 from pmahoney/threadsafe-connection-pool

    Synchronize read and modification of @reserved_connections
    tenderlove authored

May 09, 2012

  1. Carlos Antonio da Silva

    Stop showing deprecations for Ruby 1.8.7 with remove_column

    String is Enumerable in 1.8.7, which means that passing a String to
    remove_column was generating deprecation warnings during tests.

May 02, 2012

  1. Piotr Sarnacki

    Deprecate remove_column with array as an argument

    drogus authored

Mar 13, 2012

  1. Jonathan Rochkind

    ConnectionPool.checkout takes account of ruby using 'non-blocking con…

    …dition variables' in mutex ConditionVariables
    jrochkind authored

Mar 12, 2012

  1. Aaron Patterson

    make sure connections returned after close are marked as in_use

    tenderlove authored
  2. Jonathan Rochkind

    inline docs for clear_active_connections! no longer says it cleans de…

    …ad threads, it doesn't since 3.2.0
    jrochkind authored

Mar 08, 2012

  1. Aaron Patterson

    make active_connection? return true only if there is an open connecti…

    …on in use for the current thread. fixes #5330
    tenderlove authored

Mar 02, 2012

  1. Xavier Noria

    revert setting NOT NULL constraints in add_timestamps

    Commit 3dbedd2 added NOT NULL constraints both to table
    creation and modification. For creation the new default
    makes sense, but the generic situation for changing a
    table is that there exist records. Those records have
    no creation or modification timestamps, and in the
    general case you don't even know them, so when updating
    a table these constraints are not going to work. See
    a bug report for this use case in #3334.
    fxn authored

Feb 26, 2012

  1. Rafael Mendonça França

    Revert "No need to pass options which is never used"

    Options is needed for some Rails extensions to determine when
    referential integrity should be disabled
    
    This reverts commit bcb466c.
    
    Fixes #5052
    rafaelfranca authored tenderlove committed

Feb 22, 2012

  1. Aaron Patterson

    prepared statements can be disabled

    tenderlove authored

Feb 03, 2012

  1. densya203

    Fix Issue #4819

    'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1'
    
    Just a typo of 'ActiveSupport::...'
    skult authored

Jan 30, 2012

  1. Xavier Noria

    query cache instrumentation should included the bindings in the paylo…

    …ad [closes #4750]
    fxn authored

Dec 29, 2011

  1. Jo Liss

    Document that index names are made up of all columns, not just the fi…

    …rst.
    
    index_name has been using the following expression
    
        "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}"
    
    since at least 2006 (bc7f231), and that's how they come out in my DB.
    
    Please check that this is correct before merging into master, perhaps
    I'm misunderstanding the section I changed.
    joliss authored vijaydev committed

Dec 13, 2011

  1. Jon Leighton

    Revert naive O(1) table_exists? implementation.

    It was a bad idea to rescue exceptions here. This can interfere with
    transaction rollbacks which seems to be the cause of current CI
    failure.
    
    Instead, each adapter should implement its own DB-specific O(1)
    implementation, and we fall back on the generic, slower, implementation
    otherwise.
    jonleighton authored

Dec 09, 2011

  1. Aaron Patterson

    don't need a begin / end.

    tenderlove authored
  2. Aaron Patterson

    squelch table exists? queries.

    tenderlove authored

Dec 08, 2011

  1. Aaron Patterson

    Exceptions should read from the spec configu

    tenderlove authored
  2. Vijay Dev

    fix nodocs

    vijaydev authored
  3. Vijay Dev

    fix comments

    vijaydev authored
  4. Aaron Patterson

    Use a hash to look up column definitions

    tenderlove authored
  5. Aaron Patterson

    try to normalize the objects passed to column()

    tenderlove authored
  6. Aaron Patterson

    automatically add the column definition to the columns list if creati…

    …ng a new one
    tenderlove authored

Dec 07, 2011

  1. Aaron Patterson

    stop calling String#to_s so frequently

    tenderlove authored

Dec 05, 2011

  1. Aaron Patterson

    Quitoting the table name before querying.

    tenderlove authored
  2. Jade Rubick

    Speed up table_exists? for databases with a large number of tables

    At New Relic, we have hundreds of thousands of tables, and our migrations took 30 minutes without this similar patch. This cuts it down to a more reasonable amount of time.
    
    The rescue false part is ugly, but necessary as far as I can tell. I don't know of a cross-database statement you can make that will work without trapping errors.
    jadeforrest authored
Something went wrong with that request. Please try again.