Skip to content
Commits on Jun 7, 2012
  1. @jonleighton

    Revert "Perf: Don't load the association for #delete_all."

    jonleighton committed Jun 7, 2012
    This reverts commit b98d1e2.
    Closes #6609
Commits on May 18, 2012
  1. @jonleighton

    Perf: Don't load the association for #delete_all.

    jonleighton committed May 18, 2012
    Bug #6289
Commits on Dec 14, 2011
  1. @jonleighton
Commits on Nov 25, 2011
  1. @samsonasu

    load has_many associations keyed off a custom primary key if that key…

    samsonasu committed Nov 24, 2011
    … is present but the record is unsaved
Commits on Nov 19, 2011
  1. @jonleighton

    Perf fix

    jonleighton committed Nov 19, 2011
    If we're deleting all records in an association, don't add a IN(..)
    clause to the query.
    Fixes #3672.
Commits on May 31, 2011
  1. @jonleighton
Commits on May 23, 2011
  1. @smartinez87
Commits on Mar 10, 2011
  1. @jonleighton

    Move the code which builds a scope for through associations into a ge…

    jonleighton committed Mar 10, 2011
    …neric AssociationScope class which is capable of building a scope for any association.
Commits on Feb 21, 2011
  1. @jonleighton @tenderlove

    Use proper objects to do the work to build the associations (adding m…

    jonleighton committed with tenderlove Feb 21, 2011
    …ethods, callbacks etc) rather than calling a whole bunch of methods with rather long names.
  2. @jonleighton @tenderlove

    Delegate Association#options to the reflection, and replace 'reflecti…

    jonleighton committed with tenderlove Feb 20, 2011
    …on.options' with 'options'. Also add through_options and source_options methods for through associations.
  3. @jonleighton @tenderlove

    Associations - where possible, call attributes methods rather than di…

    jonleighton committed with tenderlove Feb 20, 2011
    …rectly accessing the instance variables
Commits on Feb 18, 2011
  1. @jonleighton

    Split AssociationProxy into an Association class (and subclasses) whi…

    jonleighton committed Feb 17, 2011
    …ch manages the association, and a CollectionProxy class which is *only* a proxy. Singular associations no longer have a proxy. See CHANGELOG for more.
Commits on Feb 14, 2011
  1. @jonleighton
Commits on Feb 7, 2011
  1. @jonleighton

    Refactor the implementations of AssociatioCollection#delete and #dest…

    jonleighton committed Feb 6, 2011
    …roy to be more consistent with each other, and to stop passing blocks around, thus making the execution easier to follow.
  2. @jonleighton

    Correctly update counter caches on deletion for has_many :through [#2824

    jonleighton committed Feb 5, 2011
     state:resolved]. Also fixed a bunch of other counter cache bugs in the process, as once I fixed this one others started appearing like nobody's business.
  3. @jonleighton

    Make record.association.destroy(*records) on habtm and hm:t only dele…

    jonleighton committed Jan 30, 2011
    …te records in the join table. This is to make the destroy method more consistent across the different types of associations. For more details see the CHANGELOG entry.
Commits on Jan 30, 2011
  1. @jonleighton
  2. @jonleighton
Commits on Jan 7, 2011
  1. @jonleighton @tenderlove

    Construct an actual ActiveRecord::Relation object for the association…

    jonleighton committed with tenderlove Jan 6, 2011
    … scope, rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.
Commits on Jan 4, 2011
  1. @jonleighton @tenderlove
  2. @jonleighton @tenderlove
  3. @jonleighton @tenderlove

    Let AssociationCollection#find use #scoped to do its finding. Note th…

    jonleighton committed with tenderlove Jan 2, 2011
    …at I am removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
Commits on Dec 31, 2010
  1. @jonleighton

    Rename AssociationReflection#primary_key_name to foreign_key, since t…

    jonleighton committed Dec 31, 2010
    …he options key which it relates to is :foreign_key
  2. @jonleighton
Commits on Dec 26, 2010
  1. @jonleighton @tenderlove
  2. @jonleighton

    Associations: DRY up the code which is generating conditions, and mak…

    jonleighton committed Dec 24, 2010
    …e it all use arel rather than SQL strings
  3. @jonleighton
Commits on Dec 20, 2010
  1. @jonleighton @tenderlove
  2. @jonleighton @tenderlove

    has_many associations with :dependent => :delete_all should update th…

    jonleighton committed with tenderlove Dec 17, 2010
    …e counter cache when deleting records
  3. @jonleighton @tenderlove
  4. @jonleighton @tenderlove

    Specify insert_record with NotImplementedError in AssociationCollecti…

    jonleighton committed with tenderlove Dec 16, 2010
    …on, to indicate that subclasses should implement it. Also add save_record to reduce duplication.
Commits on Dec 2, 2010
  1. @tenderlove
Commits on Nov 24, 2010
  1. @tenderlove

    reduce method calls

    tenderlove committed Nov 23, 2010
  2. @tenderlove

    removing ternary

    tenderlove committed Nov 23, 2010
Commits on Nov 23, 2010
  1. @miloops @tenderlove
Something went wrong with that request. Please try again.