Skip to content
Commits on Oct 29, 2012
  1. @graceliu @rafaelfranca

    fixed support for DATABASE_URL for rake db tasks

    graceliu committed with rafaelfranca
    Backport for #7521
    - added tests to confirm establish_connection uses DATABASE_URL and
      Rails.env correctly even when no arguments are passed in.
    - updated rake db tasks to support DATABASE_URL, and added tests to
      confirm correct behavior for these rake tasks.  (Removed
      establish_connection call from some tasks since in those cases
      the :environment task already made sure the function would be called)
    - updated Resolver so that when it resolves the database url, it
      removes hash values with empty strings from the config spec (e.g.
      to support connection to postgresql when no username is specified).
    - updated ResolverTest to use current_adapter? to check the type of
      the current adapter.
  2. @rafaelfranca

    Make Active Record tests pass in isolation

    rafaelfranca committed
    Also remove the feature detecting for Ruby 1.9
  3. @rafaelfranca

    Merge pull request #7593 from veader/patch-1

    rafaelfranca committed
    Decode attributes pulled from URI.parse
Commits on Oct 15, 2012
  1. @tenderlove
Commits on Sep 24, 2012
  1. @jrochkind

    ConnectionPool accepts spec key 'checkout_timeout'

    jrochkind committed
    Backport of #6441 cb6f839 . Old 'wait_timeout' is still supported,
    but conflicts with mysql2 using that spec key for different thing.
    'checkout_timeout' can now be used taking precedence for ConnectionPool
    over 'wait_timeout'.
Commits on Sep 20, 2012
  1. @rafaelfranca

    Revert "backport fair connection pool 02b2335 to 3-2-stable"

    rafaelfranca committed
    This reverts commit 0693e07.
    Revert "Cache columns metadata to avoid extra while testing"
    This reverts commit a82f1e3.
    Reason: This is causing failures in the postgresql build.
    Related with #7675
Commits on Sep 17, 2012
  1. @jrochkind
Commits on Aug 18, 2012
  1. @jrafanie
Commits on Jul 6, 2012
  1. @rafaelfranca

    Merge pull request #6985 from sidonath/disable-query-cache-for-locks

    rafaelfranca committed
    Disable query cache for lock queries
Commits on Jun 28, 2012
  1. @carlosantoniodasilva

    Merge pull request #6900 from cbandy/issue-6898

    carlosantoniodasilva committed
    Require URI in ConnectionSpecification
Commits on May 23, 2012
  1. Synchronize the ConnectionPool#release method to avoid thread safety …

    Andrew Selder committed
    …issues [#6464]
    Fixes #6464
    Synchronize the contents of the release method in ConnectionPool due to
    errors when running in high concurrency environments.
        Detected invalid hash contents due to unsynchronized modifications
    with concurrent users
        org/jruby/ `keys'
Commits on May 19, 2012
  1. @tenderlove

    Merge pull request #6398 from pmahoney/threadsafe-connection-pool

    tenderlove committed
    Synchronize read and modification of @reserved_connections
Commits on May 9, 2012
  1. @carlosantoniodasilva

    Stop showing deprecations for Ruby 1.8.7 with remove_column

    carlosantoniodasilva committed
    String is Enumerable in 1.8.7, which means that passing a String to
    remove_column was generating deprecation warnings during tests.
Commits on May 2, 2012
  1. @drogus
Commits on Mar 13, 2012
  1. @jrochkind

    ConnectionPool.checkout takes account of ruby using 'non-blocking con…

    jrochkind committed
    …dition variables' in mutex ConditionVariables
Commits on Mar 12, 2012
  1. @tenderlove
  2. @jrochkind

    inline docs for clear_active_connections! no longer says it cleans de…

    jrochkind committed
    …ad threads, it doesn't since 3.2.0
Commits on Mar 8, 2012
  1. @tenderlove

    make active_connection? return true only if there is an open connecti…

    tenderlove committed
    …on in use for the current thread. fixes #5330
Commits on Mar 2, 2012
  1. @fxn

    revert setting NOT NULL constraints in add_timestamps

    fxn committed
    Commit 3dbedd2 added NOT NULL constraints both to table
    creation and modification. For creation the new default
    makes sense, but the generic situation for changing a
    table is that there exist records. Those records have
    no creation or modification timestamps, and in the
    general case you don't even know them, so when updating
    a table these constraints are not going to work. See
    a bug report for this use case in #3334.
Commits on Feb 26, 2012
  1. @rafaelfranca @tenderlove

    Revert "No need to pass options which is never used"

    rafaelfranca committed with tenderlove
    Options is needed for some Rails extensions to determine when
    referential integrity should be disabled
    This reverts commit bcb466c.
    Fixes #5052
Commits on Feb 22, 2012
  1. @tenderlove
Commits on Feb 3, 2012
  1. @skult

    Fix Issue #4819

    skult committed
    'uninitialized constant ActiveRecord::Deprecation in Rails3.2.1'
    Just a typo of 'ActiveSupport::...'
Commits on Jan 30, 2012
  1. @fxn
Commits on Dec 29, 2011
  1. @joliss @vijaydev

    Document that index names are made up of all columns, not just the fi…

    joliss committed with vijaydev
    index_name has been using the following expression
        "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}"
    since at least 2006 (bc7f231), and that's how they come out in my DB.
    Please check that this is correct before merging into master, perhaps
    I'm misunderstanding the section I changed.
Commits on Dec 13, 2011
  1. @jonleighton

    Revert naive O(1) table_exists? implementation.

    jonleighton committed
    It was a bad idea to rescue exceptions here. This can interfere with
    transaction rollbacks which seems to be the cause of current CI
    Instead, each adapter should implement its own DB-specific O(1)
    implementation, and we fall back on the generic, slower, implementation
Commits on Dec 9, 2011
  1. @tenderlove

    don't need a begin / end.

    tenderlove committed
  2. @tenderlove
Commits on Dec 8, 2011
  1. @tenderlove
  2. @vijaydev

    fix nodocs

    vijaydev committed
  3. @vijaydev

    fix comments

    vijaydev committed
  4. @tenderlove
  5. @tenderlove
  6. @tenderlove
Commits on Dec 7, 2011
  1. @tenderlove
Commits on Dec 5, 2011
  1. @tenderlove
Something went wrong with that request. Please try again.