Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 25, 2013
  1. @fxn

    typo

    fxn authored
  2. @fxn
  3. @rafaelfranca
  4. @yaotti
  5. @dhh

    Preparing for 4.0.0.beta1 release

    dhh authored
  6. @senny
  7. @wangjohn

    Raising an ActiveRecordError when one tries to use .touch(name) on a new

    wangjohn authored
    object that has not yet been persisted. This behavior follows the
    precedent set by update_columns.
Commits on Feb 24, 2013
  1. @carlosantoniodasilva
  2. @senny

    don't apply invalid ordering when preloading hmt associations.

    senny authored
    closes #8663.
    
    When preloading a hmt association there two possible scenarios:
    
    1.) preload with 2 queries: first hm association, then hmt with id IN ()
    2.) preload with join: hmt association is loaded with a join on the hm association
    
    The bug was happening in scenario 1.) with a normal order clause on the hmt association.
    The ordering was also applied when loading the hm association, which resulted in the error.
    
    This patch only applies the ordering the the hm-relation if we are performing a join (2).
    Otherwise the order will only appear in the second query (1).
  3. @fxn

    Merge pull request #9400 from senny/remove_auto_explain_threshold_in_…

    fxn authored
    …seconds
    
    remove config.auto_explain_threshold_in_seconds
  4. @senny

    remove AR auto-explain (config.auto_explain_threshold_in_seconds)

    senny authored
    We discussed that the auto explain feature is rarely used.
    This PR removes only the automatic explain. You can still display
    the explain output for any given relation using `ActiveRecord::Relation#explain`.
    
    As a side-effect this should also fix the connection problem during
    asset compilation (#9385). The auto explain initializer in the `ActiveRecord::Railtie`
    forced a connection.
  5. @rafaelfranca

    Do not type cast all the database url values.

    rafaelfranca authored
    We should only type cast when we need to use.
    
    Related to 4b005fb
Commits on Feb 21, 2013
  1. @senny
Commits on Feb 20, 2013
  1. @fxn
  2. @fxn
  3. @fxn
  4. @fxn
  5. @senny
  6. @senny

    also rename indexes when a table or column is renamed

    senny authored
    When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
  7. @fxn
  8. @senny

    reserve index name chars for internal rails operations

    senny authored
    Some adapter (SQLite3) need to perform renaming operations to support
    the rails DDL. These rename prefixes operate with prefixes. When an
    index name already uses up the full space provieded by
    `index_name_length` these internal operations will fail. This patch
    introduces `allowed_index_name_length` which respects the amount of
    characters used for internal operations. It will always be <=
    `index_name_length` and every adapter can define how many characters
    need to be reserved.
  9. @rafaelfranca

    Merge pull request #9332 from wangjohn/adding_documentation_to_error_…

    rafaelfranca authored
    …raising_in_query_methods
    
    Tests to make sure empty arguments in WhereChain raise errors
  10. @wangjohn

    Added comments about the check_empty_arguments method which is called

    wangjohn authored
    for query methods in a where_clause. Also, modified the CHANGELOG entry
    because it had false information and added tests.
  11. @wangjohn

    Reduced memory leak problem in transactions by lazily updating AR obj…

    wangjohn authored
    …ects with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
  12. @senny
Commits on Feb 19, 2013
  1. @fxn

    s/revertible/reversible/

    fxn authored
  2. @fxn
  3. @fxn

    small tweaks in the AR CHANGELOG

    fxn authored
  4. Raise an error when query methods have blank arguments, and when blan…

    John J Wang authored John J Wang committed
    …k arguments are meaningless.
Commits on Feb 17, 2013
  1. @pixeltrix

    Add CHANGELOG entry for 41ff6a1

    pixeltrix authored
    [ci skip]
Commits on Feb 14, 2013
  1. @senny
Commits on Feb 13, 2013
  1. @bensie
Commits on Feb 11, 2013
  1. @lest

    define Active Record Store accessors in a module

    lest authored
    Allow store accessors to be overrided like other attribute methods,
    e.g.:
    
        class User < ActiveRecord::Base
          store :settings, accessors: [ :color, :homepage ], coder: JSON
    
          def color
            super || 'red'
          end
        end
Commits on Feb 9, 2013
  1. @guilleiguaran
Commits on Feb 8, 2013
  1. @guilleiguaran
Something went wrong with that request. Please try again.