Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 19, 2013
  1. Andrew White

    Revert "Deprecate the `eager_load_paths` configuration"

    pixeltrix authored
    Because of the possibility of lib being unintentionally eager loaded
    it's been agreed that we'll leave autoload paths and eager load paths
    separate for Rails 4.0.
    
    This reverts commit 0757b33.
    
    Conflicts:
    	railties/CHANGELOG.md
Commits on Jan 24, 2013
  1. Andrew White

    Deprecate the `eager_load_paths` configuration

    pixeltrix authored
    Since the default in Rails 4.0 is to run in 'threadsafe' mode we need
    to eager load all of the paths in `autoload_paths` so we alias
    `eager_load_paths` to it. This may have unintended consequences if
    you have added 'lib' to `autoload_paths` such as loading unneeded
    code or code intended only for development and/or test environments.
    If this applies to your application you should thoroughly check what
    is being eager loaded.
Commits on Jan 22, 2013
  1. Rafael Mendonça França

    Merge pull request #8557 from timraymond/add_back_engines_and_deprecate

    rafaelfranca authored
    Adding Back Rails::Engine::Railties#engines
    
    Conflicts:
    	railties/CHANGELOG.md
Commits on Jan 8, 2013
  1. Vijay Dev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	guides/source/getting_started.md
Commits on Jan 7, 2013
  1. Carlos Antonio da Silva

    Revert some warning removals related to Ruby 2.0

    carlosantoniodasilva authored
    These warnings were actually a bug in Ruby 2.0, the accessors should not
    be raising such warnings, they are only meant for ivars.
    
    -
    
    Revert "fix warnings in Ruby 2.0"
    
    This reverts commit 26702a6.
    
    -
    
    Revert "Merge pull request #8282 from arunagw/warning_removed_for_ruby2"
    
    This reverts commit f63d654, reversing
    changes made to 3a89068.
Commits on Jan 6, 2013
  1. Gosha Arinich
Commits on Jan 3, 2013
  1. Timothy J. Raymond

    Adding Back Rails::Engine::Railties#engines

    timraymond authored
    Removing it breaks functionality with gems such as Thinking Sphinx.
    This restores it with a deprecation warning. Closes #8551
Commits on Jan 2, 2013
  1. Gosha Arinich
Commits on Nov 29, 2012
  1. Rafael Mendonça França

    Remove observers and sweepers

    rafaelfranca authored
    They was extracted from a plugin.
    
    See https://github.com/rails/rails-observers
    
    [Rafael Mendonça França + Steve Klabnik]
Commits on Nov 20, 2012
  1. Arun Agrawal
Commits on Oct 14, 2012
  1. Robin Dupret
Commits on Sep 21, 2012
  1. Stephan Hagemann
Commits on Aug 21, 2012
  1. José Valim

    Get rid of config.preload_frameworks in favor of config.eager_load_na…

    josevalim authored
    …mespaces
    
    The new option allows any Ruby namespace to be registered and set
    up for eager load. We are effectively exposing the structure existing
    in Rails since v3.0 for all developers in order to make their applications
    thread-safe and CoW friendly.
Commits on Aug 10, 2012
  1. Piotr Sarnacki

    Fix handling SCRIPT_NAME from within mounted engine's

    drogus authored
    When you mount your application at a path, for example /myapp, server
    should set SCRIPT_NAME to /myapp. With such information, rails
    application knows that it's mounted at /myapp path and it should generate
    routes relative to that path.
    
    Before this patch, rails handled SCRIPT_NAME correctly only for regular
    apps, but it failed to do it for mounted engines. The solution was to
    hardcode default_url_options[:script_name], which is not the best answer
    - it will work only when application is mounted at a fixed path.
    
    This patch fixes the situation by respecting original value of
    SCRIPT_NAME when generating application's routes from engine and the
    other way round - when you generate engine's routes from application.
    
    This is done by using one of 2 pieces of information in env - current
    SCRIPT_NAME or SCRIPT_NAME for a corresponding router. This is because
    we have 2 cases to handle:
    
    - generating engine's route from application: in this situation
      SCRIPT_NAME is basically SCRIPT_NAME set by the server and it
      indicates the place where application is mounted, so we can just pass
      it as :original_script_name in url_options. :original_script_name is
      used because if we use :script_name, router will ignore generating
      prefix for engine
    
    - generating application's route from engine: in this situation we
      already lost information about the SCRIPT_NAME that server used. For
      example if application is mounted at /myapp and engine is mounted at
      /blog, at this point SCRIPT_NAME is equal /myapp/blog. Because of that
      we need to keep reference to /myapp SCRIPT_NAME by binding it to the
      current router. Later on we can extract it and use when generating url
    
    Please note that starting from now you *should not* use
    default_url_options[:script_name] explicitly if your server already
    passes correct SCRIPT_NAME to rack env.
    
    (closes #6933)
Commits on Jul 4, 2012
  1. Wojciech Wnętrzak
Commits on Jun 29, 2012
  1. José Valim

    Revert "Allow loading external route files from the router"

    josevalim authored
    This reverts commit 6acebb3.
    
    Usage of this feature did not reveal any improvement in existing apps.
    
    Conflicts:
    
    	actionpack/lib/action_dispatch/routing/mapper.rb
    	guides/source/routing.textile
    	railties/lib/rails/engine.rb
    	railties/lib/rails/paths.rb
    	railties/test/paths_test.rb
  2. José Valim

    Remove unused responsibilities and add a few load definitions to engines

    josevalim authored
    Since plugins were removed, we can clean up a few methods in engines.
    We also use this opportunity to move `load_console`, `load_tasks` and
    `load_runner` to Rails::Engine. This means that, if someone wants to
    improve script/rails for engines to support console or runner commands,
    part of the work is already done.
  3. José Valim
Commits on May 29, 2012
  1. Toshinori Kajihara

    Add support runner hook.

    kennyj authored
Commits on May 24, 2012
  1. Philip Arndt

    Fixed backward incompatibility for engines.

    parndt authored
    - Many engines rely on being able to join directories to the Rails root:
    
        Rails.root.join('somedir')
    
    - This was now impossible because Rails.root returned a String:
    
        NoMethodError: undefined method `join' for "/code/myrailsapp":String
    
    - This was broken in 4001835
Commits on May 23, 2012
  1. Aaron Patterson

    removing more pathnameisms

    tenderlove authored
  2. Aaron Patterson
  3. Aaron Patterson
Commits on May 22, 2012
  1. Aaron Patterson
  2. Aaron Patterson
Commits on May 16, 2012
  1. Piotr Sarnacki
Commits on May 14, 2012
  1. Francesco Rodríguez
Commits on May 4, 2012
  1. Piotr Sarnacki

    Merge pull request #5821 from Deradon/fix-engine-tasks

    drogus authored
    Provided fix for calling rake tasks within mountable engines
Commits on May 1, 2012
  1. Vijay Dev
Commits on Apr 28, 2012
  1. Piotr Sarnacki
  2. Roman V. Babenko Piotr Sarnacki

    Engine#routes? method has been fixed

    romanvbabenko authored drogus committed
  3. Mark Rushakoff
Commits on Apr 26, 2012
  1. Yehuda Katz
Commits on Apr 25, 2012
  1. Yehuda Katz

    Fix the build

    wycats authored
  2. Yehuda Katz

    Allow loading external route files from the router

    wycats authored
    This feature enables the ability to load an
    external routes file from the router via:
      draw :filename
    
    External routes files go in +config/routes+. This
    feature works in both engines and applications.
Something went wrong with that request. Please try again.