Skip to content
Commits on Apr 29, 2013
  1. @dhh

    Bump version to rc1

    dhh committed Apr 29, 2013
  2. @rafaelfranca
  3. @jeremy

    Merge pull request #10372 from jeremy/statement-invalid-wraps-underly…

    …ing-exception
    
    StatementInvalid takes WrappedDatabaseException's place
    jeremy committed Apr 28, 2013
  4. @jeremy
  5. @carlosantoniodasilva
Commits on Apr 28, 2013
  1. @jeremy

    Merge pull request #10364 from wangjohn/refactoring_activesupport_cache

    Making the retrieval of the cache store class a method
    jeremy committed Apr 28, 2013
  2. @carlosantoniodasilva

    Merge pull request #10361 from teeparham/patch-1

    Fix travis links in readme [ci skip]
    carlosantoniodasilva committed Apr 28, 2013
  3. @guilleiguaran

    Merge pull request #10368 from demands/fix-typo

    Fix typo in serialized_attribute_test. [ci skip]
    guilleiguaran committed Apr 28, 2013
  4. @demands
  5. @carlosantoniodasilva
  6. @wangjohn

    Making the retrieval of the cache store class a method, also wrote

    comments for the expand_cache_key method.
    wangjohn committed Apr 27, 2013
  7. @fxn
  8. @fxn

    pass over the code comments

    * Highlights the requirement of an attributes method.
    * Removes some details that depend on the implementation of the class including the module.
    * Applies guidelines here and there.
    fxn committed Apr 28, 2013
Commits on Apr 27, 2013
  1. @pixeltrix
Commits on Apr 26, 2013
  1. @tenderlove
  2. @fxn

    Module#delegate checks nilness rather that falsehood if :allow_nil is…

    … true, and avoids multiple evaluation of the target method
    
    Notes:
    
    1) I hope nilness is a word.
    
    2) See rationale for avoiding multiple evaluation in a comment in the patch, credit goes to @jeremy for pointing out this gotcha in the existing implementation.
    
    3) Embeds a little joke dedicated to @pixeltrix (it could be worse! :D).
    
    References #10347.
    fxn committed Apr 26, 2013
  3. @teeparham

    fix travis links in readme

    links were redirects
    teeparham committed Apr 26, 2013
  4. @pixeltrix

    Merge pull request #9980 from stouset/patch-1

    Improve poor security recommendation in docs
    
    [ci skip]
    pixeltrix committed Apr 26, 2013
  5. @fxn

    Merge pull request #10351 from JonRowe/update_as_date_next_week_to_do…

    …cument_intent
    
    Propose better documentation for ActiveSupports `next_week` functionaility
    fxn committed Apr 26, 2013
  6. @JonRowe

    formatting

    JonRowe committed Apr 26, 2013
  7. @guilleiguaran

    Merge pull request #10347 from lellisga/delegation_bug_documentation

    Delegation method bug
    guilleiguaran committed Apr 25, 2013
  8. @lellisga

    Delegation method bug

    Add documentation and test to delegation method that make sure we're
    aware that when a delegated object is not nil or false and doesn't
    respond to the method it will still raise a NoMethodError exception.
    lellisga committed Apr 25, 2013
Commits on Apr 25, 2013
  1. @JonRowe
  2. @fxn

    ActiveRecord -> Active Record

    fxn committed Apr 25, 2013
  3. @fxn

    fixes warning in the AR test suite

    fxn committed Apr 25, 2013
  4. @rafaelfranca

    Revert "Merge pull request #10337 from eimermusic/fix_template_digest…

    …or_lookup"
    
    This reverts commit b423962, reversing
    changes made to f99ce3c.
    
    Reason: This broke the build
    https://travis-ci.org/rails/rails/jobs/6629894
    rafaelfranca committed Apr 25, 2013
  5. @rafaelfranca

    Merge pull request #10337 from eimermusic/fix_template_digestor_lookup

    Fix ActionView::Digestor to correctly pass format to LookupContext
    
    Conflicts:
    	actionpack/CHANGELOG.md
    rafaelfranca committed Apr 25, 2013
  6. @pixeltrix

    Add support for extra options to `force_ssl`

    This commit adds support for passing additional url options along
    with a :status option and any of the flash-related options to
    `redirect_to` (i.e. :flash, :alert & :notice).
    
    Closes #7570.
    pixeltrix committed Apr 25, 2013
  7. @eimermusic

    AV Digestor correctly passes format to LookupContext

    ActionView::Digestor now passes arguments correctly to
    LookupContext::find method. This makes cache digests
    respect the format option correctly.
    
    FixtureFinder in tests also changed to reflect this.
    eimermusic committed Apr 25, 2013
  8. @pixeltrix

    Use `request.fullpath` to build redirect url in `force_ssl`

    The `force_ssl` command now builds the redirect url from `request.fullpath`.
    This ensures that the format is maintained and it doesn't redirect to a route
    that has the same parameters but is defined earlier in `routes.rb`. Also any
    optional segments are maintained.
    
    Fixes #7528.
    Fixes #9061.
    Fixes #10305.
    pixeltrix committed Apr 25, 2013
Commits on Apr 24, 2013
  1. @carlosantoniodasilva
  2. @rafaelfranca

    Merge pull request #10333 from ikataitsev/move-test-method-to-tests

    Move method used only in the test to the test code itself
    rafaelfranca committed Apr 24, 2013
  3. @carlosantoniodasilva
  4. @ikataitsev
  5. @rafaelfranca

    Merge pull request #10332 from vipulnsward/number_helper

    refactor number helper
    rafaelfranca committed Apr 24, 2013
Something went wrong with that request. Please try again.