Permalink
Switch branches/tags
Commits on Oct 23, 2016
  1. Merge release note entry for Date/Time/DateTime extensions

    carlosantoniodasilva committed Oct 23, 2016
    The first release note entry mentioned #on_weekday?, but that was only
    added by the second PR mentioned there. To simplify reading the notes
    just merge the two, since they are related methods. [ci skip]
Commits on Sep 19, 2015
  1. Merge pull request #21674 from amitsuroliya/comment_fix

    carlosantoniodasilva committed Sep 19, 2015
    Replace `#=>` with `# =>` [ci skip]
Commits on Sep 3, 2015
  1. Merge pull request #21435 from justanshulsharma/unicode-version

    carlosantoniodasilva committed Sep 3, 2015
    Update Unicode Version to 8.0.0
  2. Merge pull request #21473 from akihiro17/remove-unused-require

    carlosantoniodasilva committed Sep 3, 2015
    Remove unnecessary require in associations_test.rb
  3. Merge pull request #21481 from prakashlaxkar/remove_config

    carlosantoniodasilva committed Sep 3, 2015
    Removed unused config from activemodel test
Commits on Sep 1, 2015
  1. Fix failure introduced by #17351 due to the new mocks implementation

    carlosantoniodasilva committed Sep 1, 2015
    It was not expecting the new `case_insensitive` option to be passed to
    `generate_message`, instead of fixing the test we can just not pass this
    option down since it is specific to the confirmation validator and not
    necessary for the error message.
  2. Merge pull request #21443 from jashank/fix-17351

    carlosantoniodasilva committed Sep 1, 2015
    Fix syntax error introduced by #17351.
Commits on Aug 29, 2015
  1. Merge pull request #21423 from y-yagi/rails_test_opts

    carlosantoniodasilva committed Aug 29, 2015
    make `ENV` a required argument
Commits on Aug 24, 2015
  1. Merge pull request #21339 from deepj/unused-block-arguments

    carlosantoniodasilva committed Aug 24, 2015
    Remove unused block arguments
Commits on Jul 28, 2015
  1. Merge pull request #21049 from y-yagi/fix_i18n_validation_test

    carlosantoniodasilva committed Jul 28, 2015
    pass the correct argument to mock on a test of `validates_length_of`
Commits on May 20, 2015
Commits on May 14, 2015
  1. Merge pull request #20155 from y-yagi/remove_warning_from_integer_ext…

    carlosantoniodasilva committed May 14, 2015
    …_test
    
    remove warning from integer ext test
Commits on May 13, 2015
  1. Remove not used `options` argument from `ActiveSupport::JSON.decode`

    carlosantoniodasilva committed May 13, 2015
    In Rails 4.0, json decoding relied on MultiJson. This changed from 4.1
    forward since it reached its end of life, and this extra argument was
    kept for compatibility. We are safe to remove it now.
Commits on May 11, 2015
  1. Merge pull request #20100 from claudiob/don-t-skip-rbx-test

    carlosantoniodasilva committed May 11, 2015
    Stop skipping a test that now works on Rubinius
Commits on Apr 28, 2015
  1. Merge pull request #19935 from eliotsykes/clarify-configuring-default…

    carlosantoniodasilva committed Apr 28, 2015
    …-test-order
    
    Clarify test_order default configuration behaviour [ci skip]
  2. Merge pull request #19937 from tak1n/master

    carlosantoniodasilva committed Apr 28, 2015
    Fixed typo in documentation
Commits on Apr 26, 2015
  1. Merge pull request #19909 from prathamesh-sonpatki/rm-unused-code

    carlosantoniodasilva committed Apr 26, 2015
    Removed unused code from request_forgery_protection tests
Commits on Apr 14, 2015
  1. Merge pull request #19752 from yuki24/use-prepend-rather-than-alias

    carlosantoniodasilva committed Apr 14, 2015
    Use #prepend rather than using 2 aliases
Commits on Apr 13, 2015
  1. Merge pull request #19742 from vngrs/config_autoload_paths_wrong_doc

    carlosantoniodasilva committed Apr 13, 2015
    Fix the wrong documentation about config.autoload_paths [ci skip]
Commits on Apr 11, 2015
Commits on Apr 1, 2015
  1. Remove old mri platform entries from our Gemfile

    carlosantoniodasilva committed Apr 1, 2015
    Since we now only support Ruby 2.2+, we can safely remove the old mri
    entries from the Gemfile.
    
    This also allows us not to lock to a specific bundler version, since
    :mri_22 was defined only on 1.7.11.
    
    Closes #19611.
Commits on Mar 31, 2015
  1. Merge pull request #19599 from y-yagi/application_job_template

    carlosantoniodasilva committed Mar 31, 2015
    remove extra newline from ApplicationJob template
Commits on Mar 24, 2015
  1. Merge pull request #19452 from pinglamb/fix-referencing-wrong-alias-w…

    carlosantoniodasilva committed Mar 24, 2015
    …hen-joining-tables-of-has-many-through-association
    
    Fix referencing wrong aliases while joining tables of has many through association
Commits on Mar 22, 2015
  1. Simplify setting button form options

    carlosantoniodasilva committed Mar 22, 2015
    No need to merge hashes when simply setting options does the job.
  2. Fix arguments order on assertion

    carlosantoniodasilva committed Mar 22, 2015
    The expected value comes first. Related to #19465.
  3. Merge pull request #19455 from jonatack/patch-1

    carlosantoniodasilva committed Mar 22, 2015
    [ci skip] Consistent spacing inside hash brackets in Action View guide.
Commits on Mar 21, 2015
  1. Merge pull request #19443 from radanskoric/fix-am-errors-deprecation

    carlosantoniodasilva committed Mar 21, 2015
    Fix ActiveModel::Errors deprecation messages failing when used on its own
  2. Rework form helper example to use Person.new

    carlosantoniodasilva committed Mar 21, 2015
    The previous change 92a3c8d improved
    this example, but calling .create + #valid? ends up running validations
    twice, and we don't want to showcase that.
    
    Lets use the normal use case of building a new object and calling #save
    on it, which is what a basic scaffold with Active Record does.
    
    [ci skip]
Commits on Mar 18, 2015
  1. Remove additional handling of boolean attributes on button to helper

    carlosantoniodasilva committed Mar 18, 2015
    This logic was just doing duplicated work, since the button_to helper
    relies on tag/content_tag to generate the button html, which already
    handles all boolean attributes it knows about.
    
    The code dates back to 2005: 43c470f.
Commits on Mar 14, 2015
  1. Merge pull request #19336 from tchandy/cleaning_actionview_tests

    carlosantoniodasilva committed Mar 14, 2015
    Cleaning actionview tests
Commits on Mar 12, 2015
  1. Merge pull request #19301 from Empact/default-scopes

    carlosantoniodasilva committed Mar 12, 2015
    Isolate access to .default_scopes in ActiveRecord::Scoping::Default
Commits on Mar 3, 2015