Skip to content
Permalink
Branch: master
Commits on Dec 6, 2019
Commits on Nov 28, 2019
  1. Merge pull request #37826 from schlick/number-to-phone-example-typo

    carlosantoniodasilva committed Nov 28, 2019
    Fix minor typo in pattern example for number_to_phone [ci skip]
Commits on Nov 21, 2019
  1. Merge pull request #37696 from sidonath/fix-failure-screenshot-path

    carlosantoniodasilva committed Nov 21, 2019
    Prevent nesting failure screenshots into dirs
Commits on Nov 19, 2019
  1. Merge pull request #37753 from yoones/add_has_member_to_strong_parame…

    carlosantoniodasilva committed Nov 19, 2019
    …ters
    
    Add params.member? to mimic Hash behavior
Commits on Nov 5, 2019
  1. Merge pull request #37636 from artinboghosian/patch-1

    carlosantoniodasilva committed Nov 5, 2019
    Use singular, `instance`, in deprecation warning.
Commits on Oct 4, 2019
  1. Merge pull request #37353 from lxxxvi/correct-information-about-recor…

    carlosantoniodasilva committed Oct 4, 2019
    …d-identification-for-form-helper
    
    correct information about record identification in form helper [ci skip]
Commits on Oct 2, 2019
  1. Update Gemfile.lock with newly added `activesupport` dependencies

    carlosantoniodasilva committed Oct 2, 2019
    Reference: 3b23c64
  2. Require `minitest/mock` since we rely on `stub` in this test file

    carlosantoniodasilva committed Oct 2, 2019
    Otherwise running the test file directly like this:
    
        $ be ruby -w -Ilib:test test/models/variant_test.rb
    
    Fails with:
    
        Error:
        ActiveStorage::VariantTest#test_passes_content_type_on_upload:
        NoMethodError: undefined method `stub' for #<ActiveStorage::Service::DiskService:0x00007fd53ba89ef0>
            test/models/variant_test.rb:207:in `block in <class:VariantTest>'
Commits on Oct 1, 2019
Commits on Sep 24, 2019
  1. Merge pull request #37287 from bknarendra/fix_documentation_in_action…

    carlosantoniodasilva committed Sep 24, 2019
    …_cable_test_case
    
    Fixed typo in comment in ActionCable::Connection::TestCase [ci skip]
  2. Fix queue adapter class delegation to point to `self.class`

    carlosantoniodasilva committed Sep 24, 2019
    Using `self` works by essentially pointing to the included class, in
    this case `ActiveJob::Base`, so that'd end up delegating to
    `ActiveJob::Base.queue_adapter` instead.
Commits on Sep 22, 2019
  1. Merge pull request #37265 from nobu/Reduce-stat-calls

    carlosantoniodasilva committed Sep 22, 2019
    Reduce stat(2) calls
Commits on Sep 20, 2019
  1. Merge pull request #37178 from pond/fix-boundless-range-extensions

    carlosantoniodasilva committed Sep 20, 2019
    Fix issues with ActiveSupport Range extensions on boundless Ranges
    
    Closes #37177
Commits on Sep 19, 2019
  1. Fix ignore fixture tests causing random AR failures

    carlosantoniodasilva committed Sep 19, 2019
    Since #36303 we allow to ignore specific fixtures from being loaded, but
    because that introduced a new fixture `other_books` that uses the same
    underlying model `Book`, sometimes depending on the run order the tests
    might end up not loading the actual `books` fixtures thinking they are
    already cached/loaded. Disabling the transactional fixtures for that
    test that was introduced above for the ignore fixtures feature fixes
    that.
    
    Closes #37244.
    Closes #37245.
    Thanks @yahonda for finding a way to reproduce these failures.
Commits on Sep 12, 2019
  1. Merge pull request #37175 from adammw/patch-1

    carlosantoniodasilva committed Sep 12, 2019
    Fix typo in connection specification error handling
Commits on Sep 5, 2019
  1. Merge pull request #37139 from Shopify/define-url-helper-patch

    carlosantoniodasilva committed Sep 5, 2019
    Optimize UrlHelper.optimize_helper?
Commits on Aug 29, 2019
Commits on Aug 27, 2019
  1. Merge pull request #37053 from yahonda/ignore_sqlite3_parallel_testin…

    carlosantoniodasilva committed Aug 27, 2019
    …g_databases
    
    Ignore SQLite3 database files generated by parallel testing
Commits on Aug 21, 2019
  1. Merge pull request #37001 from abhaynikam/36996-remove-unused-null-co…

    carlosantoniodasilva committed Aug 21, 2019
    …ntent-type-header
    
    Removed unused NullContentTypeHeader after changes in #36996
  2. Generate new apps with latest puma version

    carlosantoniodasilva committed Aug 19, 2019
Commits on Aug 19, 2019
  1. Merge pull request #36978 from tgwizard/fix-doc-typo

    carlosantoniodasilva committed Aug 19, 2019
    Fix minor typo in rails/engine docs [ci skip]
  2. Merge pull request #36967 from ohbarye/refactor_max_age_seconds

    carlosantoniodasilva committed Aug 19, 2019
    Remove unnecessary `Duration#seconds` called before `#to_i`
Commits on Aug 16, 2019
Commits on Aug 10, 2019
  1. Merge pull request #36906 from wjessop/fix_collection_rendering_docs

    carlosantoniodasilva committed Aug 10, 2019
    Remove misleading documentation [ci skip]
Commits on Aug 9, 2019
  1. Merge pull request #36900 from akshaymohite/gemfile-lock-changes

    carlosantoniodasilva committed Aug 9, 2019
    Rails HTML sanitizer update changes to Gemfile lock on bundle install.
Commits on Aug 7, 2019
  1. Fix typo in test name

    carlosantoniodasilva committed Aug 7, 2019
Commits on Aug 1, 2019
  1. Merge pull request #36831 from akshaymohite/fix-form-helpers-document…

    carlosantoniodasilva committed Aug 1, 2019
    …ation-comment
    
    Added missing comment notation for the example of form_with in form_helpers.md documentation. [ci skip]
Commits on Jul 29, 2019
  1. Call raise with parentheses like a normal method call with arguments

    carlosantoniodasilva committed Jul 29, 2019
    Using `(raise FooError, "error")` is like forcing a "new scope" around
    the `raise` call, it's simpler to just wrap the `raise` arguments with
    parentheses just like any other method call would.
Commits on Jul 27, 2019
Commits on Jul 26, 2019
  1. Merge pull request #36781 from pietro-moro/phone_to_tests_followup

    carlosantoniodasilva committed Jul 26, 2019
    Change test description with the correct URL name
Older
You can’t perform that action at this time.