Permalink
Commits on Feb 23, 2017
  1. 🙈 :nodoc: `AS::Duration::ISO8601Serializer`

    This class should not be used directly, the public API is `AS::Duration#iso8601`.
    chancancode committed on GitHub Feb 23, 2017
Commits on Feb 19, 2017
  1. Merge pull request #28013 from iguchi1124/fix-missing-namespace-wrapper

    Add missing module namespacing wrapper
    chancancode committed on GitHub Feb 19, 2017
Commits on Feb 15, 2017
  1. Merge pull request #27605 from mtsmfm/fix-generator-command-for-neste…

    …d-rails-engine-take-2
    
    Fix generator command for nested (namespaced) rails engine (take 2)
    chancancode committed on GitHub Feb 15, 2017
Commits on Oct 15, 2016
  1. Merge pull request #26792 from rails/benchmark-template

    Introduce a benchmark template
    chancancode committed on GitHub Oct 15, 2016
  2. Introduce a benchmark template [ci skip]

    This replaces boilerplate in the “benchmark your code” section of the
    contributors’ guide with an executable template. I also amended the text
    to encourage best practices and codified it in the template.
    
    For now this is only good for relatively self-contained changes that can
    be inlined into a simple script. In the future, this can be expanded to
    cover how to measure the difference between two commits.
    
    The output looks like this:
    
    ```
    ==================================== Empty =====================================
    
    Warming up --------------------------------------
                  blank?   225.963k i/100ms
             fast_blank?   238.147k i/100ms
    Calculating -------------------------------------
                  blank?      8.825M (± 6.4%) i/s -     44.063M in   5.014824s
             fast_blank?      9.311M (± 6.3%) i/s -     46.439M in   5.009153s
    
    Comparison:
             fast_blank?:  9310694.8 i/s
                  blank?:  8824801.7 i/s - same-ish: difference falls within error
    
    
    ================================= Single Space =================================
    
    Warming up --------------------------------------
                  blank?    56.581k i/100ms
             fast_blank?   232.774k i/100ms
    Calculating -------------------------------------
                  blank?    813.985k (±16.7%) i/s -      4.017M in   5.076576s
             fast_blank?      9.547M (± 5.2%) i/s -     47.719M in   5.013204s
    
    Comparison:
             fast_blank?:  9547414.0 i/s
                  blank?:   813985.0 i/s - 11.73x  slower
    
    
    ================================== Two Spaces ==================================
    
    Warming up --------------------------------------
                  blank?    58.265k i/100ms
             fast_blank?   244.056k i/100ms
    Calculating -------------------------------------
                  blank?    823.343k (±16.2%) i/s -      4.020M in   5.014213s
             fast_blank?      9.484M (± 4.9%) i/s -     47.347M in   5.005339s
    
    Comparison:
             fast_blank?:  9484021.6 i/s
                  blank?:   823343.1 i/s - 11.52x  slower
    
    
    =============================== Mixed Whitspaces ===============================
    
    Warming up --------------------------------------
                  blank?    53.919k i/100ms
             fast_blank?   237.103k i/100ms
    Calculating -------------------------------------
                  blank?    763.435k (±16.8%) i/s -      3.720M in   5.018029s
             fast_blank?      9.672M (± 5.8%) i/s -     48.369M in   5.019356s
    
    Comparison:
             fast_blank?:  9672467.2 i/s
                  blank?:   763435.4 i/s - 12.67x  slower
    
    
    =============================== Very Long String ===============================
    
    Warming up --------------------------------------
                  blank?    34.037k i/100ms
             fast_blank?   240.366k i/100ms
    Calculating -------------------------------------
                  blank?    409.731k (± 8.9%) i/s -      2.042M in   5.028235s
             fast_blank?      9.794M (± 4.3%) i/s -     49.035M in   5.016328s
    
    Comparison:
             fast_blank?:  9794225.2 i/s
                  blank?:   409731.4 i/s - 23.90x  slower
    ```
    chancancode committed Oct 15, 2016
Commits on Jun 27, 2016
Commits on Jun 26, 2016
  1. Merge pull request #25526 from tricknotes/pathname-as-json

    Define `Pathname#as_json`
    chancancode committed on GitHub Jun 26, 2016
Commits on Jun 25, 2016
  1. Merge pull request #25350 from tricknotes/uri-generic-as-json

    Define `URI::Generic#as_json`
    chancancode committed on GitHub Jun 25, 2016
  2. Merge pull request #23011 from arnvald/bugfix/correctly_parse_date

    Use correct timezone when parsing date in json
    chancancode committed Jun 25, 2016
  3. Merge pull request #25287 from marekkirejczyk/fix_25267

    Make select_year work with include_position: true option, fix #25267
    chancancode committed on GitHub Jun 25, 2016
Commits on Mar 1, 2016
  1. Support `:any` variants lookup in `PathResolver`

    `OptimizedFileSystemResolver` (which most Rails apps use), but did not
    implement the feature on the more generic `PathResolver`, which is often
    used in tests etc.
    
    Fixes #23881
    chancancode committed Mar 1, 2016
Commits on Feb 25, 2016
  1. Merge pull request #23827 from rails/new_implicit_render

    Lock down new `ImplicitRender` behavior for 5.0 RC
    chancancode committed Feb 25, 2016
  2. Lock down new `ImplicitRender` behavior for 5.0 RC

    1. Conceptually revert #20276
    
       The feature was implemented for the `responders` gem. In the end,
       they did not need that feature, and have found a better fix (see
       plataformatec/responders#131).
    
       `ImplicitRender` is the place where Rails specifies our default
       policies for the case where the user did not explicitly tell us
       what to render, essentially describing a set of heuristics. If
       the gem (or the user) knows exactly what they want, they could
       just perform the correct `render` to avoid falling through to
       here, as `responders` did (the user called `respond_with`).
    
       Reverting the patch allows us to avoid exploding the complexity
       and defining “the fallback for a fallback” policies.
    
    2. `respond_to` and templates are considered exhaustive enumerations
    
       If the user specified a list of formats/variants in a `respond_to`
       block, anything that is not explicitly included should result
       in an `UnknownFormat` error (which is then caught upstream to
       mean “406 Not Acceptable” by default). This is already how it
       works before this commit.
    
       Same goes for templates – if the user defined a set of templates
       (usually in the file system), that set is now considered exhaustive,
       which means that “missing” templates are considered `UnknownFormat`
       errors (406).
    
    3. To keep API endpoints simple, the implicit render behavior for
       actions with no templates defined at all (regardless of formats,
       locales, variants, etc) are defaulted to “204 No Content”. This
       is a strictly narrower version of the feature landed in #19036 and
       #19377.
    
    4. To avoid confusion when interacting in the browser, these actions
       will raise an `UnknownFormat` error for “interactive” requests
       instead. (The precise definition of “interactive” requests might
       change – the spirit here is to give helpful messages and avoid
       confusions.)
    
    Closes #20666, #23062, #23077, #23564
    
    [Godfrey Chan, Jon Moss, Kasper Timm Hansen, Mike Clark, Matthew Draper]
    chancancode committed Feb 23, 2016
Commits on Jan 20, 2016
  1. Merge pull request #17573 from zerothabhishek/master

    Response etags to always be weak: Prefixed 'W/' to value returned by Act...
    chancancode committed Jan 20, 2016
Commits on Jan 15, 2016
  1. Merge pull request #22278 from poporul/master

    Allow to store .keep file in cache directory
    chancancode committed Jan 15, 2016
Commits on Nov 27, 2015
  1. Partially revert 14b20ce

    The failure have returned, so disabling the tests again. (The upgrade is
    fine to keep.)
    chancancode committed Nov 27, 2015
Commits on Nov 26, 2015
  1. Upgrade to listen 3.0.5, re-enable tests

    In listen 3.0.4 and below, the `#stop` method on the notification
    backends are a no-op, meaning that we are leaking them per test. This
    ended up triggering another bug in Ruby that causes our builds to fail
    randomly on CI.
    
    listen bug: guard/listen#353
    ruby bug: https://bugs.ruby-lang.org/issues/11744
    chancancode committed Nov 26, 2015
  2. Only run listen tests in isolation, for now

    There is a known issue with the listen tests that casuses files to be
    incorrectly GC'ed even when they are still in-use. The current is to
    only run them in isolation to avoid randomly failing our test suite.
    chancancode committed Nov 26, 2015
Commits on Nov 8, 2015
  1. Merge pull request #22222 from y-yagi/fix_application_controller_requ…

    …ire_dependency_path_in_api
    
    fix application_controller require_dependency path generated by api scaffold generator
    chancancode committed Nov 8, 2015
Commits on Sep 27, 2015
  1. Merge pull request #21784 from yui-knk/fix_reademe_rails

    [ci skip] Add `Active Model` to a list of independently used modules.
    chancancode committed Sep 27, 2015
Commits on Sep 18, 2015
  1. Merge pull request #21666 from ronakjangir47/enum_refactoring

    DRY enum conflict detection
    chancancode committed Sep 18, 2015
Commits on Sep 2, 2015
  1. Merge pull request #21475 from y-yagi/add_description_of_return_value

    add a description of the return value that was missing [ci skip]
    chancancode committed Sep 2, 2015
Commits on Aug 21, 2015
Commits on Aug 11, 2015
Commits on Jul 27, 2015
  1. Merge pull request #21035 from radar/ryan-bigg-has-changed-jobs

    Ryan Bigg has changed jobs
    chancancode committed Jul 27, 2015
Commits on Jul 11, 2015
Commits on May 30, 2015
  1. Merge pull request #20370 from manishspuri/master

    Add tmp directory before touching
    chancancode committed May 30, 2015
Commits on May 19, 2015
  1. Small stylistic tweaks for `Delegator#try` patch

    * Rename `ActiveSupport::Try` => `ActiveSupport::Tryable`
    * Include the modules inline
    * `private` indentation
    chancancode committed May 19, 2015
Commits on Apr 29, 2015
  1. Revert "Merge pull request #19817 from tpitale/4_2-release-notes-fix"

    This reverts commit 00aa1af, reversing
    changes made to b584cc6.
    
    Reason:
    
    As far as we can tell, this should not be the case. Both localhost, 127.0.0.1
    and ::1 is "supposed to work", so this is probably a bug somewhere.
    
    Reopening #19815 instead.
    chancancode committed Apr 29, 2015
Commits on Apr 26, 2015
  1. Merge pull request #19884 from chancancode/uncomment-byebug

    Uncomment byebug in framework Gemfile
    chancancode committed Apr 26, 2015
Commits on Apr 24, 2015
  1. Uncomment byebug in framework Gemfile

    History:
    
    1. `debugger` was there until d2ed433 where it was commented out, and I
       couldn't figure out why
    
    2. Since then we inherited that when switching to `byebug` in 93559da
    
    Reasons:
    
    1. It's nice to have a debugger when working on framework bugs
    
    2. It's an uncommented dependency in app Gemfiles since Rails 4.2 (see fbe38c9)
    chancancode committed Apr 24, 2015