Skip to content
Permalink
Branch: master
Commits on Dec 6, 2019
  1. Go through ActiveStorage::Blob::Representable#variant to pick up trac…

    georgeclaghorn committed Dec 6, 2019
    …king
  2. Add resolved route for ActiveStorage::VariantWithRecord

    georgeclaghorn committed Dec 6, 2019
  3. Correct migration name

    georgeclaghorn committed Dec 6, 2019
  4. Track Active Storage variants in the database

    georgeclaghorn committed Dec 6, 2019
Commits on Dec 5, 2019
  1. Switch to the writer DB to generate ASt previews

    georgeclaghorn committed Dec 5, 2019
  2. Style

    georgeclaghorn committed Dec 5, 2019
Commits on Nov 16, 2019
  1. Provide the whole response

    georgeclaghorn committed Nov 16, 2019
  2. Use per-thread CPU time clock

    georgeclaghorn committed Nov 16, 2019
    Fixes #37441.
Commits on Nov 8, 2019
  1. Fix configuring a cache store with ActiveSupport::OrderedOptions

    georgeclaghorn committed Nov 8, 2019
    9845cd6 broke configuring a cache store like so:
    
        config.cache_store = :redis_cache_store, config_for("redis/cache")
    
    Rails::Application#config_for returns an ActiveSupport::OrderedOptions. By default, the Array#extract_options! core extension won't extract instances of Hash subclasses. Add ActiveSupport::OrderedOptions#extractable_options? and have it return true to fix.
  2. Defer Active Storage service configuration until use

    georgeclaghorn committed Nov 8, 2019
Commits on Nov 6, 2019
  1. Add load hook for ActionDispatch::Request

    georgeclaghorn committed Nov 6, 2019
Commits on Nov 4, 2019
  1. Provide the whole request

    georgeclaghorn committed Nov 4, 2019
  2. Add :uuid to process_action.action_controller payloads

    georgeclaghorn committed Nov 4, 2019
  3. Add :location to process_action.action_controller payloads

    georgeclaghorn committed Nov 4, 2019
Commits on Oct 26, 2019
Commits on Oct 9, 2019
  1. Document CORS configuration for direct uploads

    georgeclaghorn committed Oct 9, 2019
    Closes #32581.
    Closes #34028.
    Closes #37343.
Commits on Sep 30, 2019
  1. Allow providing a custom key per blob

    georgeclaghorn committed Sep 30, 2019
    Closes #37315.
Commits on Sep 29, 2019
  1. Use Module#deprecate

    georgeclaghorn committed Sep 29, 2019
  2. Avoid Element.closest() for IE 9 compatibility

    georgeclaghorn committed Sep 29, 2019
    Fixes #37234.
Commits on Sep 28, 2019
  1. Correct test class name

    georgeclaghorn committed Sep 28, 2019
  2. Discard ActiveStorage::AnalyzeJobs on ActiveRecord::RecordNotFound

    georgeclaghorn committed Sep 28, 2019
    Fixes #37305.
Commits on Sep 24, 2019
  1. Remove errant default option

    georgeclaghorn committed Sep 24, 2019
  2. Add ActionController::Base.log_at

    georgeclaghorn committed Sep 24, 2019
    Allow setting a different log level per request.
  3. Fix typo: overwrittein → overwritten

    georgeclaghorn committed Sep 24, 2019
  4. Shush deprecation warnings in ASt tests

    georgeclaghorn committed Sep 24, 2019
Commits on Sep 23, 2019
  1. Delegate ActiveJob::Base#queue_adapter to class

    georgeclaghorn committed Sep 23, 2019
  2. Extract ActiveJob::Instrumentation

    georgeclaghorn committed Sep 23, 2019
Commits on Sep 19, 2019
  1. Fix establishing connections for models with custom connection specif…

    georgeclaghorn committed Sep 19, 2019
    …ication names
    
    We have an internal engine whose models, for backwards compatibility with older Rails versions, override #connection_specification_name to connect to a shared DB rather than using Rails 6 multi-DB support.
    
    b8fc015 changed ActiveRecord::ConnectionAdapters::ConnectionPool#retrieve_connection_pool to pass ActiveRecord::DatabaseConfigurations::DatabaseConfig#config_hash to #establish_connection where it previously passed ActiveRecord::ConnectionAdapters::ConnectionSpecification#to_hash. But DatabaseConfig#config_hash does not include the specification name, so #establish_connection falls back to `"primary"`. The host app's primary DB connections and our engine's shared DB connections get mixed in the same pool as a result. Engine models will sometimes erroneously check out app DB connections and app models will sometimes check out engine DB connections.
    
    To fix, we merge the connection specification name into the DB config hash before passing it into ConnectionPool#establish_connection.
  2. Merge pull request #37240 from dylanahsmith/add-describe-to-mysql-rea…

    georgeclaghorn committed Sep 19, 2019
    …d-queries
    
    Allow DESCRIBE queries on read-only connections
Commits on Sep 17, 2019
  1. Merge pull request #37214 from mperham/patch-1

    georgeclaghorn committed Sep 17, 2019
    Allow Sidekiq access to the underlying Job class
Commits on Sep 13, 2019
  1. Move ActiveJob::LogSubscriber into its own file

    georgeclaghorn committed Sep 13, 2019
  2. Prefer assert_not_includes

    georgeclaghorn committed Sep 13, 2019
Older
You can’t perform that action at this time.