Skip to content
Permalink
Branch: master
Commits on Nov 18, 2019
  1. Merge pull request #37707 from jhawthorn/execute_batch

    jhawthorn committed Nov 18, 2019
    Change execute_batch to take array of statements
  2. Change execute_batch to take array of statements

    jhawthorn committed Nov 9, 2019
    Adapters don't necessarily have the ability to execute a batch of
    statements.
    
    Previously execute_batch took a single string of statements separated by
    ';', this meant that the adapter had to have the ability to execute
    batch statements.
    
    Instead, this commit changes the method to take an array of statements.
    Adapters which support batched queries can do the join there. For
    adapters which don't we provide a fallback implementation: executing
    each statement one at a time.
    
    This also improves the implementation for the mysql2 adapter, which
    understands that there is a maximium query length. Previously the caller
    needed to split the statements before passing them to execute_batch, now
    execute_batch itself is responsible for splitting the queries.
Commits on Nov 15, 2019
  1. Merge pull request #37721 from jhawthorn/fix_ci3

    jhawthorn committed Nov 15, 2019
    Fix yarn issues on CI
  2. Run yarn install in template dir

    jhawthorn committed Nov 15, 2019
    We want to yarn install in the template dir so that templates get a
    yarn.lock copied over.
  3. Fix relative file paths building app template

    jhawthorn committed Nov 14, 2019
    The app template is in a higher-level directory than
    test/isolation/assets, so these paths wern't accurate.
Commits on Nov 14, 2019
  1. Use rails() instead of system()

    jhawthorn committed Nov 14, 2019
  2. Fail with output if shell commands fail

    jhawthorn committed Nov 14, 2019
Commits on Nov 13, 2019
  1. Merge pull request #37708 from jhawthorn/fix_ci2

    jhawthorn committed Nov 13, 2019
    Fix undefined method `start_with?' for :to_json
  2. Fix undefined method `start_with?' for :to_json

    jhawthorn committed Nov 13, 2019
Commits on Nov 8, 2019
  1. Merge pull request #37590 from jhawthorn/deprecation_threadsafe

    jhawthorn committed Nov 8, 2019
    Make AS::Deprecation.silence block thread-local
Commits on Oct 25, 2019
  1. Make AS::Deprecation.silence block thread-local

    jhawthorn committed Oct 25, 2019
    Previouly `ActiveSupport::Deprecation.silence { ... }` would silence
    deprecations from all threads, which I think is undesirable in a
    mutli-threaded environment.
    
    This leaves `ActiveSupport::Deprecation.silenced=` as setting a global
    option, which might be a little confusing, but I think that these are
    used in different ways, and this best preserves how they are generally
    used. `silence {}` is used to silence a small section of code,
    `silenced=` is usually used to set a default in an initializer or test
    helper.
    
    I somewhat think that `ActiveSupport::Deprecation.silenced=` should be
    deprecated in favour of `ActiveSupport::Deprecation.behavior = :silence`
  2. Add changelog for IN empty array

    jhawthorn committed Oct 25, 2019
    Forgot to add a changelog when this was merged in #37266.
  3. Merge pull request #37445 from jhawthorn/optimize_content_tag

    jhawthorn committed Oct 25, 2019
    Make content_tag a bit faster
Commits on Oct 11, 2019
  1. Convert two hash lookups into one

    jhawthorn committed Oct 10, 2019
Commits on Oct 10, 2019
  1. Merge pull request #37419 from jhawthorn/sprockets_fixes

    jhawthorn committed Oct 10, 2019
    Fix Railties test suite for Sprockets 4.0
  2. Sprockets uses debug. not self. now

    jhawthorn committed Oct 10, 2019
  3. Link .js from manifest.js in assets_test

    jhawthorn committed Oct 10, 2019
    We no longer link JS by default, we need to modify manifest.js for that
    now.
  4. Use a stylesheet instead of a javascript in test

    jhawthorn committed Oct 10, 2019
    We no longer link all js by default, so we should do this test with a
    css instead (we don't care about that specifics of the dir just that its
    in the manifest and in this dir).
  5. Add a few more assertions

    jhawthorn committed Oct 10, 2019
  6. Bundle update

    jhawthorn committed Oct 10, 2019
Commits on Oct 9, 2019
  1. Merge pull request #37395 from jhawthorn/check_pending_file_watcher3

    jhawthorn committed Oct 9, 2019
    Use FileUpdateChecker for Migration::CheckPending
Commits on Oct 8, 2019
  1. Use FileUpdateChecker for Migration::CheckPending

    jhawthorn committed Oct 4, 2019
    Migration::CheckPending is a rack middleware normally used in
    development to raise an exception if there pending migrations.
    
    This commit replaces the existing caching, which avoided checking all
    migrations if the newest migration (by version number) hadn't changed.
    Instead, we now use FileUpdateChecker, which has two advantages: it can
    detect new migrations which aren't the highest version, and it is
    faster.
Commits on Oct 7, 2019
  1. Merge pull request #37357 from jhawthorn/backtrace_relative_paths

    jhawthorn committed Oct 7, 2019
    Don't modify relative ./ paths in BacktraceCleaner
Commits on Oct 3, 2019
  1. Don't modify relative ./ paths in BacktraceCleaner

    jhawthorn committed Oct 3, 2019
    Previously a path starting with ./ would be replaced to start with /.
    IMO this didn't particularly make sense since / reads as though it's
    from the root of the filesystem.
    
    This commit removes that filter, preserves ./, and updates the silencer
    not to remove lines starting with ./
  2. Merge pull request #37348 from jhawthorn/backtrace_shared_strings

    jhawthorn committed Oct 3, 2019
    Avoid string allocations in BacktraceCleaner
  3. Avoid string allocations in BacktraceCleaner

    jhawthorn committed Apr 15, 2019
    Our backtraces tend to be fairly large so this operates over quite a few
    strings.
    
    Previously, each filter would call `String#sub`, which always returns a
    new string object, and uses a new string buffer any time it modifies the
    string.
    
    String#slice allows Ruby to share the same internal string buffer, which
    should be faster and use less memory. In cases where changes aren't
    necessary we can also reuse the same string object.
    
    This should not change behaviour except for the last filter which
    changes from sub(/\.\//, "") to sub(/\A\.\//, ""), which I think was the
    original intention.
Commits on Sep 30, 2019
  1. Merge pull request #37266 from jhawthorn/avoid_query_on_empty_in

    jhawthorn committed Sep 30, 2019
    Avoid making query when using `where(attr: [])`
  2. Avoid making query when using `where(attr: [])`

    jhawthorn committed Sep 21, 2019
  3. Merge pull request #37330 from eugeneius/active_storage_key_length

    jhawthorn committed Sep 30, 2019
    Always use 28 characters for Active Storage keys
  4. Fix fraction float assertions in time_ext_test

    jhawthorn committed Sep 30, 2019
    These failed previously because decimals floats don't make perfect
    decimal numbers and Rational represents them exactly (either as decimal
    or the inexact float value).
    
    This changes the asserts to match that value.
Commits on Sep 25, 2019
  1. Merge pull request #37216 from jhawthorn/avoid_file_watcher

    jhawthorn committed Sep 25, 2019
    Avoid setting up file watcher on cache_classes
Older
You can’t perform that action at this time.