Skip to content
Permalink
Branch: master
Commits on Dec 6, 2019
  1. Merge pull request #37898 from tgxworld/revert_evented_routes_reloader

    kamipo committed Dec 6, 2019
    Revert "Use `app.config.file_watcher` for watcher in `RoutesReloader`"
  2. Merge pull request #37792 from glaszig/fix/actiondispatch/non-headles…

    kamipo committed Dec 6, 2019
    …s-driver-options
    
    system tests: properly set driver options for non-headless drivers
  3. Merge pull request #37853 from tgxworld/use_proper_file_watcher

    kamipo committed Dec 6, 2019
    Use `app.config.file_watcher` for watcher in `RoutesReloader`
  4. Merge pull request #37896 from tgxworld/upgrade_listen

    kamipo committed Dec 6, 2019
    Upgrade listen to 3.2.1 for darwin fixes
Commits on Dec 5, 2019
  1. Merge pull request #37693 from elia/patch-1

    kamipo committed Dec 5, 2019
    Don't parse DB specific locking docs as code
    
    [ci skip]
  2. Merge pull request #37744 from seejohnrun/around_action-docs

    kamipo committed Dec 5, 2019
    Add guide for inline around_action
Commits on Dec 4, 2019
  1. Merge pull request #37886 from tjschuck/retry_on_wait_jitter_doc_fixes

    kamipo committed Dec 4, 2019
    Small doc fixes for ActiveJob::Exceptions::ClassMethods#retry_on
    
    [ci skip]
  2. Merge pull request #37882 from kamipo/should_keep_zero_duration_parts

    kamipo committed Dec 4, 2019
    Should keep the original parts for zero duration
  3. Should keep the original parts for zero duration

    kamipo committed Dec 4, 2019
    Follow up to #37849 (comment).
    
    Without this, `0.days` is considered as `0.seconds` due to #31310.
    We should not lose the original parts.
  4. Merge pull request #37878 from kamipo/nodoc_internal_methods

    kamipo committed Dec 4, 2019
    Hide internal utility methods in the public API doc [ci skip]
  5. Merge pull request #37879 from tomily1/update-initialization-guide

    kamipo committed Dec 4, 2019
    [skip ci] Update initialization guide start method to include change
  6. Hide internal utility methods in the public API doc [ci skip]

    kamipo committed Dec 4, 2019
    I digged the history for the internal utility methods (`convert_key`,
    `convert_value`, and `set_defaults`), I believe it is apparently not
    intended to appear them in the public API doc.
    
    * `convert_key`, `convert_value`: 7174211
    * `set_defaults`: #20828
    
    https://api.rubyonrails.org/v6.0.1/classes/ActiveSupport/HashWithIndifferentAccess.html
    
    Since we sometimes makes breaking change for internal methods (e.g.
    #37870), so that methods should not be leaked to the public API doc.
Commits on Dec 3, 2019
  1. Merge pull request #37866 from giraffate/correct_default_value_of_unk…

    kamipo committed Dec 3, 2019
    …nown_asset_fallback
    
    Correct default value of `unknown_asset_fallback` [ci skip]
  2. Merge pull request #37862 from giraffate/fix_random_ci_failure

    kamipo committed Dec 3, 2019
    Fix random CI failure due to non-deterministic sorting order
Commits on Dec 2, 2019
  1. Merge pull request #37849 from kamipo/fix_since_and_ago

    kamipo committed Dec 2, 2019
    Fix `since` and `ago` with a duration which has empty parts
  2. Fix `since` and `ago` with a duration which has empty parts

    kamipo committed Dec 2, 2019
    Related #37839.
    
    Sometimes divisions of `ActiveSupport::Duration` makes the instance's
    parts attribute empty, but it has a value actually (e.g. `(1.minute /
    60) # => @value=1 (second), but empty parts`).
    
    In that case we should respect `value` as the source of seconds.
Commits on Nov 30, 2019
  1. Merge pull request #37839 from ttanimichi/modify-inspect-of-activesup…

    kamipo committed Nov 30, 2019
    …port-duration-with-no-parts
    
    The return value of `ActiveSupport::Duration#inspect` is wrong when its parts are empty
  2. Merge pull request #37842 from tkusuki/fix-typo-in-options-for-render

    kamipo committed Nov 30, 2019
    Fix typo in "Options for render" section [ci skip]
Commits on Nov 28, 2019
  1. Merge pull request #37819 from orien/changelog-uri

    kamipo committed Nov 28, 2019
    Add Rails changelog URI
  2. Merge pull request #37821 from yahonda/bump_rubocop_077

    kamipo committed Nov 28, 2019
    Bump RuboCop version to 0.77
Commits on Nov 27, 2019
  1. Merge pull request #37809 from yahonda/split_bundle_install_and_rubocop

    kamipo committed Nov 27, 2019
    Easy to show `bundle exec rubocop` output at GitHub Actions
Commits on Nov 24, 2019
  1. Merge pull request #37789 from dr-itz/fix/ar-test-fork

    kamipo committed Nov 24, 2019
    fix(test): only test reaper with fork when fork is available
  2. Merge pull request #37788 from eregon/update-listen

    kamipo committed Nov 24, 2019
    Update to listen 3.2
  3. Add missing period

    kamipo committed Nov 24, 2019
  4. Titleize header [ci skip]

    kamipo committed Nov 24, 2019
    Sync style with Basic Authentication and Digest Authentication headers.
  5. Auto-correct rubocop offences

    kamipo committed Nov 24, 2019
  6. Enable `Layout/ClosingHeredocIndentation` cop

    kamipo committed Nov 24, 2019
  7. Fixup CHANGELOGs [ci skip]

    kamipo committed Nov 24, 2019
  8. Follow up 997770f

    kamipo committed Nov 24, 2019
    [ci skip]
Commits on Nov 23, 2019
  1. Merge pull request #37784 from larskanis/cached-plan-changed

    kamipo committed Nov 23, 2019
    PostgreSQL: Make detection of invalid plan locale-independent
Commits on Nov 21, 2019
  1. Merge pull request #37772 from dylnclrk/fix-rspec-typo-in-guide

    kamipo committed Nov 21, 2019
    Fix RSpec capitalization typo ("Rspec" -> "RSpec")
    
    [ci skip]
  2. Merge pull request #37771 from dylanahsmith/add-missing-require-for-c…

    kamipo committed Nov 21, 2019
    …ompact-blank
    
    activerecord: Add missing require for compact_blank
  3. Merge pull request #37764 from giraffate/remove_unused_connection_han…

    kamipo committed Nov 21, 2019
    …dler
    
    Remove an unused connection handler in a test
Commits on Nov 19, 2019
  1. Merge pull request #37747 from bradleyprice/check-association-loaded-…

    kamipo committed Nov 19, 2019
    …across-collection-on-preload
    
    Check that entire collection has been loaded before short circuiting
Commits on Nov 16, 2019
  1. Merge pull request #37727 from kamipo/improve_deprecation_message

    kamipo committed Nov 16, 2019
    Improve deprecation message for leaking scope
Older
You can’t perform that action at this time.