Permalink
Commits on Sep 24, 2016
  1. Merge pull request #26597 from tbalthazar/26580

    Fix ActiveSupport::TimeWithZone#in
    pixeltrix committed on GitHub Sep 24, 2016
Commits on Sep 20, 2016
  1. Merge pull request #26558 from kamipo/restore_gemfile_lock_entries

    Restore missing Gemfile.lock entries
    pixeltrix committed on GitHub Sep 20, 2016
Commits on Sep 6, 2016
  1. Merge pull request #26394 from kamipo/remove_redundant_condition

    Remove redundant `!loaded?` condition
    pixeltrix committed on GitHub Sep 6, 2016
Commits on Sep 5, 2016
  1. Merge pull request #26370 from yahonda/rails26368

    Move `require "models/post"` before `require "models/comment"`
    pixeltrix committed on GitHub Sep 5, 2016
  2. Merge pull request #26391 from y-yagi/use_descendants_to_get_all_subc…

    …lasses
    
    use `descendants` to get class that inherited `ActiveJob::Base`
    pixeltrix committed on GitHub Sep 5, 2016
  3. Merge pull request #26379 from kamipo/remove_unnecessary_query_scope

    Remove unnecessary `query_scope`
    pixeltrix committed on GitHub Sep 5, 2016
Commits on Sep 1, 2016
  1. Cache to_datetime for performance

    As demonstrated in #25880 the to_time method converts the utc time
    instance to a local time instance which is an expensive operation.
    Since to_datetime involves similar expensive operations we should
    also cache it to speed up comparison with lots of values.
    pixeltrix committed Sep 1, 2016
Commits on Aug 30, 2016
  1. Merge pull request #25880 from ryandv/fix_performance_regression_in_t…

    …imewithzone_to_time
    
    Fix performance regression in `TimeWithZone#to_time`
    pixeltrix committed on GitHub Aug 30, 2016
Commits on Aug 29, 2016
  1. Merge pull request #26318 from alexcameron89/contributing-doc-update

    [ci skip] Update branch version in Contributing Guide
    pixeltrix committed on GitHub Aug 29, 2016
Commits on Aug 10, 2016
  1. Remove unused method

    In c546a2b parameter handling in AC test cases was changed to
    round tripping through encoders/decoders so that they matched
    reality and in 0adb8f8 the old methods were removed but the
    `html_format?` method was overlooked.
    pixeltrix committed Aug 10, 2016
Commits on Aug 5, 2016
  1. Add note about limitations of Windows Subsystem for Linux

    Due to the limited support for inotify (Microsoft/BashOnWindows#216) in
    WSL the best thing to do at moment is add a note about skipping spring
    and listen when generating your application in the Getting Started guide.
    
    [skip ci]
    
    Fixes #26054.
    pixeltrix committed Aug 5, 2016
Commits on Aug 3, 2016
  1. Add :weeks to the list of variable duration parts

    Since 434df00 week durations are no longer converted to days. This means
    we need to add :weeks to the parts that ActiveSupport::TimeWithZone will
    consider being of variable duration to take account of DST transitions.
    
    Fixes #26039.
    pixeltrix committed Aug 3, 2016
Commits on May 5, 2016
  1. Merge pull request #24780 from rails/run-as-test-in-both-to-time-modes

    Run Active Support tests in both `to_time` modes
    pixeltrix committed May 5, 2016
  2. Run Active Support tests when preserving timezones

    Add to the matrix of Travis tests an entry that runs the Active Support
    tests when `ActiveSupport.to_time_preserves_timezone = true`.
    pixeltrix committed with pixeltrix Apr 28, 2016
  3. Fix tests when preserving timezones

    These two tests are explicitly testing that to_time is returning times
    with the sytem timezone's UTC offset, therefore they will fail when
    running them with `ActiveSupport.to_time_preserves_timezone = true`.
    pixeltrix committed with pixeltrix Apr 28, 2016
  4. Fix to_yaml test when run individually

    The to_yaml method is undefined when running the test as:
    
      $ ruby -I lib:test test/core_ext/string_ext_test.rb
    
    Doesn't fail when running rake test:isolated presumably because
    something else has required 'yaml' already.
    pixeltrix committed with pixeltrix Apr 28, 2016
Commits on Apr 29, 2016
  1. Merge pull request #24762 from Envek/solid_durations_2

    [FIX] Change 1.week to create 1 week durations instead of 7 days durations.
    pixeltrix committed Apr 29, 2016
Commits on Apr 25, 2016
  1. Merge pull request #24729 from Fryguy/date_and_time_depends_on_mattr_…

    …accessor
    
    Add require of mattr_accessor since Compatibility relies on it.
    pixeltrix committed Apr 25, 2016
Commits on Apr 23, 2016
  1. Make getlocal and getutc always return instances of Time

    Previously these methods could return either a DateTime or a Time
    depending on how the ActiveSupport::TimeWithZone instance had
    been constructed. Changing to always return an instance of Time
    eliminates a possible stack level too deep error in to_time where
    it was wrapping a DateTime instance.
    
    As a consequence of this the internal time value is now always an
    instance of Time in the UTC timezone, whether that's as the UTC
    time directly or a representation of the local time in the timezone.
    
    There should be no consequences of this internal change and if
    there are it's a bug due to leaky abstractions.
    pixeltrix committed Apr 23, 2016
  2. Add DateTime#subsec

    Mirrors the Time#subsec method by returning the fraction
    of the second as a Rational.
    pixeltrix committed Apr 23, 2016
  3. Change Time#sec_fraction to use subsec

    Time instances can have fractional parts smaller than a nanosecond.
    pixeltrix committed Apr 23, 2016
  4. Add CHANGELOG entry for #24700

    pixeltrix committed Apr 23, 2016
  5. Add Time#sec_fraction

    Mirrors the DateTime#sec_fraction method by returning the fraction
    of the second as a Rational.
    pixeltrix committed Apr 23, 2016
  6. Merge pull request #24700 from yui-knk/refactor_localtime

    Move `DateTime#getlocal` to `/core_ext/date_time/calculations.rb`
    pixeltrix committed Apr 23, 2016
  7. Add compatibility for Ruby 2.4 `to_time` changes

    In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will
    preserve the timezone of the receiver when converting to an instance
    of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we
    need to introduce a compatibility layer so that apps that upgrade do
    not break. New apps will have a config initializer file that defaults
    to match the new Ruby 2.4 behavior going forward.
    
    For information about the changes to Ruby see:
    https://bugs.ruby-lang.org/issues/12189
    https://bugs.ruby-lang.org/issues/12271
    
    Fixes #24617.
    pixeltrix committed Apr 23, 2016
Commits on Apr 4, 2016
Commits on Apr 3, 2016
  1. Merge pull request #24247 from ypxing/refactor_substitute_values

    enhance ActiveRecord#substitute_values to loop values just once
    pixeltrix committed Apr 3, 2016
  2. Call super instead of returning nil for DateTime#<=>

    The native DateTime#<=> implementation can be used to compare instances
    with numeric values being considered as astronomical julian day numbers
    so we should call that instead of returning nil.
    
    Fixes #24228.
    pixeltrix committed Apr 3, 2016
  3. Use block form of Dir.mktmpdir to ensure tidy up

    If the test run was interrupted in some way then it left temporary
    directories inside of test causing the git worktree to be in a dirty
    state. By overriding the run method we can use the block form of
    Dir.mktmpdir to ensure that the directories are cleaned up no matter
    which way the test run is exited.
    pixeltrix committed Apr 3, 2016
  4. Prevent void context warnings

    The constant reference A::B used to trigger autoloading causes a warning
    to be logged about the possible use of :: in a void context so assign it
    to the _ variable to prevent the warnings from being triggered.
    pixeltrix committed Apr 3, 2016
Commits on Mar 29, 2016
  1. Merge pull request #24315 from kenta-s/add_empty_to_finder_methods

    Delegate some additional methods in querying.rb
    pixeltrix committed Mar 29, 2016
Commits on Mar 12, 2016
  1. Merge pull request #24171 from bdewater/strong_parameters_anaf_doc

    Add explanation about accepts_nested_attributes_for keys in the strong parameters docs
    pixeltrix committed Mar 12, 2016
  2. Merge pull request #24166 from kamipo/fix_warning_method_redefined

    Fix `warning: method redefined; discarding old female`
    pixeltrix committed Mar 12, 2016