Skip to content
Permalink
Branch: master
Commits on Dec 6, 2019
  1. Merge pull request #37892 from Edouard-chin/ec-bring-back-drawing-ext…

    rafaelfranca committed Dec 6, 2019
    …ernal-routes
    
    Bring back feature that allows loading external route files:
Commits on Dec 4, 2019
  1. Merge pull request #37834 from Shopify/handle-unrelated-name-error-in…

    rafaelfranca committed Dec 4, 2019
    …-router
    
    Distinguish missing controller exceptions from unrelated NameError
  2. Merge pull request #37876 from Shopify/remove-deprecated-non-symbol-a…

    rafaelfranca committed Dec 4, 2019
    …ccess-to-config_for
    
    Remove deprecated non-symbol access to nested config_for hashes
Commits on Dec 3, 2019
  1. Merge pull request #37870 from Shopify/revert-binding-access-in-conve…

    rafaelfranca committed Dec 3, 2019
    …rt-value
    
    Avoid allocating Binding instance in HWIA#convert_value
Commits on Nov 27, 2019
  1. Fix release task

    rafaelfranca committed Nov 27, 2019
Commits on Nov 22, 2019
  1. Merge pull request #37617 from Edouard-chin/ec-respond-to-contenttype

    rafaelfranca committed Nov 22, 2019
    Modify respond_to behaviour always setting the response's content type based on the request format
  2. Merge pull request #37756 from plentz/patch-1

    rafaelfranca committed Nov 22, 2019
    Eager load translations during initialization
Commits on Nov 16, 2019
  1. Also avoid deprecation warnings if command fails

    rafaelfranca committed Nov 16, 2019
    See parent commit for more info.
  2. Prepare to thor 1.0

    rafaelfranca committed Nov 16, 2019
    Thor will show a deprecation if a command fails and this method is not
    define. We should investigate which command we want to return a non-zero
    status when it fails but for now I'm just disabling the warning and
    keeping the old behavior.
Commits on Nov 8, 2019
  1. Controller can be symbols as well

    rafaelfranca committed Nov 8, 2019
    Symbol doesn't respond to `start_with?` so we need to change it to
    string before doing the comparison.
  2. Merge pull request #37660 from rails/rm-add-way-to-disable-argument-l…

    rafaelfranca committed Nov 8, 2019
    …ogging-jobs
    
    Add an option to disable logging for jobs with sensitive arguments
  3. Add an option to disable logging for jobs with sensitive arguments

    rafaelfranca committed Nov 7, 2019
        class SensitiveJob < ApplicationJob
          self.log_arguments = false
    
          def perform(my_sensitive_argument)
          end
        end
    
    When dealing with sensitive arugments as password and tokens it is
    now possible to configure the job to not put the sensitive argument
    in the logs.
    
    Closes #34438.
Commits on Nov 4, 2019
  1. No need to break the line

    rafaelfranca committed Nov 4, 2019
  2. Merge pull request #37504 from utilum/no_implicit_conversion_of_nil

    rafaelfranca committed Nov 4, 2019
    TypeError Regexp#match?(nil) in Ruby Head
Commits on Oct 30, 2019
  1. Merge pull request #37599 from Shopify/activestorage-zeitwerk-require…

    rafaelfranca committed Oct 30, 2019
    …-dependency
    
    Avoid using require_dependency is Zeitwerk is enabled
Commits on Oct 29, 2019
  1. Merge pull request #37587 from Shopify/fix-local-cache-leak

    rafaelfranca committed Oct 29, 2019
    Duplicate the cached value before writing it in the local cache
Commits on Oct 17, 2019
  1. Merge pull request #37500 from rafaelfranca/rm-sti-config

    rafaelfranca committed Oct 17, 2019
    Add methods to the public API of ActiveRecord::Inheritance
  2. Add methods to the public API of ActiveRecord::Inheritance

    rafaelfranca committed Oct 17, 2019
    Those methods make possible to extend STI and Polymorphic associations.
    
    They are useful for cases where you renamed a class and the name of the
    class doesn't match the data in the database.
    
    You can now implement those methods in your model to load records with
    name of classes that don't exist anymore.
    
    A simple implementation would look like:
    
        class Animal < ActiveRecord::Base
          @@old_names = {
            "Lion" => "BigCat"
          }
          def self.sti_name
            name = super
            @@old_names[name] || name
          end
    
          def self.sti_class_for(type_name)
            @@old_names.inverse[type_name]&.constantize || super
          end
        end
Commits on Oct 15, 2019
  1. Merge pull request #37447 from jonathankwok/i18n-error-lookup-for-ind…

    rafaelfranca committed Oct 15, 2019
    …exed-attribute
    
    Support ActiveModel::Error translation lookup on indexed attributes.
Commits on Oct 7, 2019
  1. Merge pull request #37313 from Shopify/block-assertions

    rafaelfranca committed Oct 7, 2019
    Implicitly assert no exception is raised in block assertions
Commits on Oct 1, 2019
  1. Remove any precision problem by comparing the float values

    rafaelfranca committed Oct 1, 2019
    Rational values are move precise than float values so when comparing
    rationals values may be off by a few units that are hard to assert
    equality. Let's make sure we are comparing the float value with float
    values.
Commits on Sep 30, 2019
  1. Decrease the precision of the sec_fraction in the tests

    rafaelfranca committed Sep 30, 2019
    We were using picoseconds as precision but some Ruby implementations
    only support up to nanoseconds. Since that much precision was not needed
    to test the feature I decreased the precision.
  2. Merge pull request #37327 from Shopify/fork-tracker-fixes

    rafaelfranca committed Sep 30, 2019
    Fork tracker fixes
  3. Merge pull request #35915 from bernardoamc/allow-has-secure-token-len…

    rafaelfranca committed Sep 30, 2019
    …gth-manipulation
    
    Allow token length configuration for has_secure_token method
Commits on Sep 26, 2019
  1. Skip test is all Ruby implementations that don't support fork

    rafaelfranca committed Sep 26, 2019
Commits on Sep 24, 2019
  1. Merge pull request #37288 from Shopify/fix-load-schema

    rafaelfranca committed Sep 24, 2019
    Better double checked locking in load_schema
Commits on Sep 19, 2019
  1. Merge pull request #34809 from bogdanvlviv/fix-select-with-nil

    rafaelfranca committed Sep 19, 2019
    `ActionView::Helpers::FormOptionsHelper#select` should mark option for `nil` as selected
Commits on Sep 16, 2019
  1. Merge pull request #37210 from jonhyman/feature-fix-36956-rebased

    rafaelfranca committed Sep 16, 2019
    Fixes #36956 by dup'ing the value and entry object returned from MemoryStore.
Commits on Sep 12, 2019
  1. Merge pull request #37184 from dylanahsmith/read-query-comment-prefix

    rafaelfranca committed Sep 12, 2019
    activerecord: Allow comment prefix in queries when preventing writes
Commits on Sep 6, 2019
  1. Merge pull request #37146 from Shopify/refactor-define-url-helper

    rafaelfranca committed Sep 6, 2019
    Refactor `define_url_helper` to share the same instance between _path and _url
Commits on Sep 5, 2019
  1. Merge pull request #37105 from Shopify/optimize-module-delegate

    rafaelfranca committed Sep 5, 2019
    Optimize Module#delegate to no longer be linear
Commits on Aug 19, 2019
  1. Generate keep file in tmp/pids

    rafaelfranca committed Aug 19, 2019
    Since 9c91311, if you run `rackup`
    in a machine that doesn't have that folder, the server will not start.
    
    This doesn't happen on `rails s` because we create that folder when
    starting the server on
    https://github.com/rails/rails/blob/8c8b02784a637570451d7810fd3dfed4eae9a77d/railties/lib/rails/commands/server/server_command.rb#L70-L74.
  2. Keep the name of the releases note consistent

    rafaelfranca committed Aug 19, 2019
    [Rafael Mendonça França + bogdanvlviv]
  3. Merge pull request #36981 from tsuka/fix-tag-builder

    rafaelfranca committed Aug 19, 2019
    Prevent TagBuilder modify options
  4. Merge pull request #36983 from dylanahsmith/avoid-name-string-allocat…

    rafaelfranca committed Aug 19, 2019
    …ion-in-current-attributes
    
    activesupport: Memoize name object allocation in CurrentAttributes.instance
Older
You can’t perform that action at this time.