Permalink
Commits on Mar 28, 2017
  1. No need to duplicate 5-1-stable CHANGELOG. [ci skip]

    The `master` changelog refer back to the `5-1-stable` changelog as a
    base. No need to duplicate backported entries in the changelogs on
    `master`.
    senny committed Mar 28, 2017
Commits on Mar 26, 2017
  1. add field ids when generating a scaffold form.

    This is a follow up to a6d065e. When using `form_with` you must supply
    field ids manually. Since the scaffold generator is using labels we
    need to make sure that they are linked up properly.
    senny committed Mar 26, 2017
Commits on Feb 17, 2017
  1. Merge pull request #28047 from Erol/fix-i18n-documentation-typo

    Fix typo in I18n Guide [ci skip]
    senny committed on GitHub Feb 17, 2017
Commits on Jan 26, 2017
  1. Merge pull request #27805 from y-yagi/fix_ruby_warning

    remove warning from `bin/setup` test
    senny committed on GitHub Jan 26, 2017
Commits on Jan 10, 2017
  1. Merge pull request #27621 from dylanahsmith/mysql2-nil-connection-test

    activerecord/test: Fix Mysql2ConnectionTest#test_execute_after_disconnect
    senny committed on GitHub Jan 10, 2017
Commits on Nov 22, 2016
  1. Merge pull request #27133 from rails/reload_singular_associations

    Introduce `reload_<association>` reader for singular associations.
    senny committed on GitHub Nov 22, 2016
  2. Introduce `reload_<association>` reader for singular associations.

    This patch brings back the functionality of passing true to the
    association proxy. The behavior was deprecated with #20888 and scheduled
    for removal in Rails 5.1.
    
    The deprecation mentioned that instead of `Article.category(true)` one
    should use `article#reload.category`. Unfortunately the alternative does
    not expose the same behavior as passing true to the reader
    did. Specifically reloading the parent record throws unsaved changes and
    other caches away. Passing true only affected the association.
    
    This is problematic and there is no easy workaround. I propose to bring
    back the old functionality by introducing this new reader method for
    singular associations.
    senny committed Nov 21, 2016
Commits on Nov 21, 2016
  1. update bin/test scripts to prevent double runs.

    The test runner was updated to make use of autorun. This caused the
    `bin/test` scripts to run Minitest twice.
    senny committed Nov 21, 2016
  2. changelog entry for fc4c15d [ci skip]

    senny committed Nov 21, 2016
  3. `eager_autoload` needs to be triggered for nested constants.

    When `ActiveRecord::Associations.eager_load!` is called, it eager loads
    the `Preloader` but does not trigger a `eager_load!` on the `Preloader`
    itself. A eager loaded component is responsible to forward the
    `eager_load!` call to nested constants that make use of `eager_autoload`
    as well.
    
    This will also resolve the occasional `NameError` that we've observed in
    production:
    
    ```
    NameError: uninitialized constant ActiveRecord::Associations::Preloader::BelongsTo
    ```
    senny committed Nov 21, 2016
Commits on Nov 16, 2016
  1. docs, add `update_all` example with SQL fragment. [ci skip]

    The relation method `update_all` allows you to pass a SQL fragment. The
    functionality is already mentioned in the prose but the examples section
    does not cover it.
    senny committed Nov 16, 2016
Commits on Oct 20, 2016
  1. doc, hide non-public methods form the api docs. [ci skip]

    This is a follow up to #25681, specifically this comment:
    #25681 (comment)
    
    The way the thread local variable is stored is an implementation detail
    and subject to change. It makes no sense to only generate a reader or
    writer as you'd have to know where to read from or where it writes to.
    senny committed Oct 20, 2016
  2. guides, include note about modifiers when using the CLI.

    [ci skip]
    
    This was pointed out on
    #15583 (comment)
    
    The comment was lost in the changes made by
    fcd0ac0 and
    3e1373a
    senny committed Oct 20, 2016
Commits on Sep 3, 2016
  1. Merge pull request #26381 from kamipo/extract_duplicated_create_for_a…

    …ssociation
    
    Extract duplicated `create` and `create!` definition for association
    senny committed on GitHub Sep 3, 2016
Commits on Aug 10, 2016
  1. Merge pull request #26102 from gsamokovarov/schema-statements-typo

    Fix a NoMethodError schema_statements.rb
    senny committed on GitHub Aug 10, 2016
Commits on Aug 8, 2016
  1. Merge pull request #26067 from yahonda/oracle_can_use_fetch_first

    Use `FETCH FIRST` for Oracle12 and test `ROWNUM <=` for Oracle 11g or older version to test sql limit behavior
    senny committed on GitHub Aug 8, 2016
  2. Merge pull request #25681 from willnet/fix-thread_mattr_accessor

    Fix `thread_mattr_accessor` share variable superclass with subclass
    senny committed Aug 8, 2016
Commits on Jul 27, 2016
  1. Merge pull request #25958 from kamipo/should_be_target_loaded

    Add an assertion to the tests that should be loaded the target.
    senny committed on GitHub Jul 27, 2016
  2. Merge pull request #25408 from kamipo/should_not_reuse_quoted_true

    Quoting booleans should return a frozen string
    senny committed on GitHub Jul 27, 2016
Commits on Jul 21, 2016
  1. Merge pull request #25907 from gsamokovarov/lock-web-console-for-5.0

    Enforce minimal web-console version for Rails 5
    senny committed on GitHub Jul 21, 2016
Commits on Jul 7, 2016
  1. Merge pull request #25731 from chen7897499/fix_typo

    Fix typo: caches_pages to caches_page. [ci skip]
    senny committed on GitHub Jul 7, 2016
Commits on Jun 3, 2016
  1. Merge pull request #25243 from sukesan1984/add_i18n_validation_test

    Add i18n_validation_test
    senny committed Jun 3, 2016
Commits on Apr 19, 2016
  1. Merge pull request #24619 from BenMorganIO/use-rails-5-in-rails-engin…

    …e-bin
    
    remove rails 4 specification in bin/rails for plugins [ci skip]
    senny committed Apr 19, 2016
Commits on Apr 18, 2016
  1. Merge pull request #24581 from vipulnsward/add-reference-named-unique…

    …-index-test
    
    Add test to verify named unique index, when creating reference via add_reference
    senny committed Apr 18, 2016
Commits on Apr 12, 2016
  1. Merge pull request #24494 from vipulnsward/guides-changelog-pass

    Guides changelog pass [ci skip]
    senny committed Apr 12, 2016
Commits on Apr 11, 2016
  1. Merge pull request #24497 from vipulnsward/am-changelog-pass

    Pass over AM changelog [ci skip]
    senny committed Apr 11, 2016
Commits on Apr 8, 2016
  1. Merge pull request #24474 from djunzu/fix_welcome_page_docs

    Remove reference to non existing link in the welcome page [ci skip]
    senny committed Apr 8, 2016
  2. Merge pull request #24467 from javiervidal/20160409

    Fix broken link in 'Ruby on Rails 3.1 Release Notes' [ci skip]
    senny committed Apr 8, 2016
Commits on Mar 22, 2016
  1. Merge pull request #24271 from vipulnsward/grammar-fix-changelog

    Fixed abrupt start of sentence in changelog [ci skip]
    senny committed Mar 22, 2016
  2. guides, sync 5.0 release notes with changelogs

    [ci skip]
    
    Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft.
    This is a follow up to c94045d and contains changes made since the
    release of beta1.
    senny committed Mar 22, 2016
  3. guides, sync railties and AP changelogs with 5.0 release notes.

    [ci skip]
    
    This updates the 5.0 release notes guide to reflect changes that
    happened after beta1 has been released.
    
    I'll sync the other changelogs later today but I'll push this batch to
    prevent against cumbersome merge conflicts.
    senny committed Mar 22, 2016
Commits on Mar 8, 2016
Commits on Mar 7, 2016
  1. Merge pull request #24086 from yui-knk/do_not_ad_integration_test_class

    Prevent not-intended loading of `ActionDispatch::IntegrationTest`
    senny committed Mar 7, 2016