Branch: master
-
Merge pull request #37822 from y-yagi/call_initializer_before_use_met…
…hods Call `MonitorMixin` initializer before use methods provided by `MonitorMixin`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Call `MonitorMixin` initializer before use methods provided by `Monit…
…orMixin` `MonitorMixin` setup internal variables in `initialize`, so need to call that before use. `ActionController::Live::Buffer` only use methods that do not depend on those internal variables, so works expertly. But since Ruby 2.7, methods that were not originally the case also depend on internal variables. As a result, some tests fail in Ruby 2.7. https://buildkite.com/rails/rails/builds/65193#02e136eb-edea-4367-aee0-77e0a82f8531/990-1200 I'm not sure if this should be considered Ruby incompatible, but I fixed this because its usage is wrong. Related to [Feature #16255: Make `monitor.rb` built-in](https://bugs.ruby-lang.org/issues/16255)
-
Merge pull request #37761 from y-yagi/fix_broken_github_actions
Fix broken check on GitHub actions
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Update packages before install
Without it, it seems to be an error trying to install an older version. Ref: https://github.com/rails/rails/commit/ea303d012e6638c99f528c68ee9144a83e836e27/checks?check_suite_id=321223550#step:4:29
-
Check the actual constant used
Follow up 0454d2c.
-
Merge pull request #37661 from giraffate/suppress_deprecation_warning…
…_in_generating_guides Suppress deprecation warning in generating the guide `index.html`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Merge pull request #37644 from ryan-robeson/fix-37543-generator-class…
…-collision Fix the collision check for the scaffold generator
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Merge pull request #37612 from yahonda/enable_actions_cache
Cache gems for GitHub Actions
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Merge pull request #37558 from brookjordan/patch-1
`bin/yarn` exec `"yarn"` rather than `"yarnpkg"`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Explicitly require `active_record/migration`
This test class uses `ActiveRecord::IllegalMigrationNameError`. So without this require, tests fail randomly. https://buildkite.com/rails/rails/builds/63965#15e634e0-49a7-4658-9076-e6663458bee5/1119-1129
-
Merge pull request #37262 from nobu/Update-for-Time#inspect
Update for `Time#inspect`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
The option name is `enroll` since f1f5024.
-
System tests depend on Capybara 3.26 or newer. Ref: #36615.
-
Fix document formatting of `Rails.group` [ci skip]
y-yagi committedSep 5, 2019 -
Merge pull request #37114 from iainbeeston/patch-1
Don't use Process#clock_gettime CLOCK_PROCESS_CPUTIME_ID on Solaris
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Merge pull request #37102 from y-yagi/fixes_37011
Correctly classify the files and directories that pass to watcher
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Merge pull request #37083 from swrobel/patch-5
Add title tag to mailer previews
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Correctly classify the files and directories that pass to watcher
Currently, autoload paths pass to the watcher as directories. If using evented watcher, this possibly pass as it is to `Listen`. But autoload paths include files and `Listen` raise an error when was passed file. So, it is necessary to classify files and directories correctly. Fixes #37011.
-
Remove feature policy initializer in API only apps
Because `FeaturePolicy::Middleware` is not loaded in API only apps. Ref: https://github.com/rails/rails/blob/646dd8c51fc438bf935d4192ba0479e439c1ec54/railties/lib/rails/application/default_middleware_stack.rb#L69-L72
-
Merge pull request #36849 from yahonda/use_assert_nil
Address `DEPRECATED: Use assert_nil if expecting nil`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Do not use the same test class in different tests
This fixes the following warnings. ``` actionmailer/test/base_test.rb:272: warning: method redefined; discarding old welcome actionmailer/test/base_test.rb:260: warning: previous definition of welcome was here ```
-
Avoid to use a method that acts on the hash
To avoid a deprecation warning.
-
Do not use the same temp file in different tests
It causes unexpected results when running tests in parallel. Ref: https://buildkite.com/rails/rails/builds/62610#0165f6d9-b9c8-4948-9319-07b58bfbfd4f/989-998
-
Fix "warning: ambiguous first argument; put parentheses or a space ev…
…en after `/' operator"
-
Use correct variable in `secure_compare!`
`Messages::Rotator` has `@on_rotation` not `@rotation`. https://github.com/rails/rails/blob/72bc0806a7b378cd544e8fbf7ab22d74b7913ffb/activesupport/lib/active_support/messages/rotator.rb#L11
-
Merge pull request #36747 from y-yagi/add_mention_about_collection_ca…
…che_versioning Add mention about `active_record.collection_cache_versioning` to the `new_framework_defaults.rb`
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Add mention about `active_record.collection_cache_versioning` to the …
…`new_framework_defaults.rb` All other recommended new configurations that set in `load_defaults` are already mentioned in `new_framework_defaults.rb`. So `active_record.collection_cache_versioning` should also be mentioned.
-
Merge pull request #35285 from masakazutakewaka/fix_railtie_add_newli…
…ne_to_gemfile_insertion Add a newline at the end of a Gemfile when it doesn't end with a newline
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Merge pull request #36703 from y-yagi/script-src-xxx_and_style-src-xxx
Add support for script-src-attr / elem and style-src-attr / elem directives
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Add support for script-src-attr / elem and style-src-attr / elem dire…
…ctives These directives can be used in Chrome 75. Ref: https://www.chromestatus.com/feature/5141352765456384
-
Merge pull request #36603 from y-yagi/add_skip_collision_check_option
Add `skip-collision-check` option to generator
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Merge pull request #36679 from jacobbednarz/update-feature-policy-exa…
…mple-config Use reserved domain for example configuration
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits