Skip to content
Permalink
Branch: master
Commits on Dec 4, 2019
  1. Revert "Merge pull request #37881 from pierredemilly/patch-1"

    y-yagi committed Dec 4, 2019
    This reverts commit 5bbb2a6, reversing
    changes made to f9e4906.
    
    Reason: Since #36866, we use `azure-storage-blob` gem. So the original
    description is correct.
Commits on Nov 28, 2019
  1. Merge pull request #37822 from y-yagi/call_initializer_before_use_met…

    y-yagi committed Nov 28, 2019
    …hods
    
    Call `MonitorMixin` initializer before use methods provided by `MonitorMixin`
  2. Call `MonitorMixin` initializer before use methods provided by `Monit…

    y-yagi committed Nov 28, 2019
    …orMixin`
    
    `MonitorMixin` setup internal variables in `initialize`, so need to call
    that before use.
    `ActionController::Live::Buffer` only use methods that do not depend on those
    internal variables, so works expertly.
    
    But since Ruby 2.7, methods that were not originally the case also depend on
    internal variables. As a result, some tests fail in Ruby 2.7.
    https://buildkite.com/rails/rails/builds/65193#02e136eb-edea-4367-aee0-77e0a82f8531/990-1200
    
    I'm not sure if this should be considered Ruby incompatible, but I fixed
    this because its usage is wrong.
    
    Related to [Feature #16255: Make `monitor.rb` built-in](https://bugs.ruby-lang.org/issues/16255)
Commits on Nov 21, 2019
  1. Merge pull request #37761 from y-yagi/fix_broken_github_actions

    y-yagi committed Nov 21, 2019
    Fix broken check on GitHub actions
  2. Update packages before install

    y-yagi committed Nov 21, 2019
Commits on Nov 16, 2019
  1. Check the actual constant used

    y-yagi committed Nov 16, 2019
    Follow up 0454d2c.
Commits on Nov 8, 2019
  1. Merge pull request #37661 from giraffate/suppress_deprecation_warning…

    y-yagi committed Nov 8, 2019
    …_in_generating_guides
    
    Suppress deprecation warning in generating the guide `index.html`
  2. Merge pull request #37644 from ryan-robeson/fix-37543-generator-class…

    y-yagi committed Nov 8, 2019
    …-collision
    
    Fix the collision check for the scaffold generator
Commits on Nov 4, 2019
  1. Fix "warning: instance variable @db_config not initialized"

    y-yagi committed Nov 4, 2019
Commits on Nov 1, 2019
  1. Merge pull request #37612 from yahonda/enable_actions_cache

    y-yagi committed Nov 1, 2019
    Cache gems for GitHub Actions
Commits on Oct 27, 2019
  1. Merge pull request #37558 from brookjordan/patch-1

    y-yagi committed Oct 27, 2019
    `bin/yarn` exec `"yarn"` rather than `"yarnpkg"`
Commits on Sep 28, 2019
  1. Explicitly require `active_record/migration`

    y-yagi committed Sep 28, 2019
    This test class uses `ActiveRecord::IllegalMigrationNameError`.
    So without this require, tests fail randomly.
    https://buildkite.com/rails/rails/builds/63965#15e634e0-49a7-4658-9076-e6663458bee5/1119-1129
Commits on Sep 21, 2019
  1. Merge pull request #37262 from nobu/Update-for-Time#inspect

    y-yagi committed Sep 21, 2019
    Update for `Time#inspect`
Commits on Sep 17, 2019
  1. Partially revert 4a9ef5e

    y-yagi committed Sep 17, 2019
Commits on Sep 12, 2019
  1. Fix `credentials:diff` option

    y-yagi committed Sep 12, 2019
    The option name is `enroll` since f1f5024.
Commits on Sep 6, 2019
  1. Bump Capybara require version

    y-yagi committed Sep 6, 2019
    System tests depend on Capybara 3.26 or newer. Ref: #36615.
Commits on Sep 5, 2019
  1. Merge pull request #37114 from iainbeeston/patch-1

    y-yagi committed Sep 5, 2019
    Don't use Process#clock_gettime CLOCK_PROCESS_CPUTIME_ID on Solaris
Commits on Sep 2, 2019
  1. Merge pull request #37102 from y-yagi/fixes_37011

    y-yagi committed Sep 2, 2019
    Correctly classify the files and directories that pass to watcher
  2. Merge pull request #37083 from swrobel/patch-5

    y-yagi committed Sep 2, 2019
    Add title tag to mailer previews
  3. Correctly classify the files and directories that pass to watcher

    y-yagi committed Sep 1, 2019
    Currently, autoload paths pass to the watcher as directories. If using evented
    watcher, this possibly pass as it is to `Listen`.
    But autoload paths include files and `Listen` raise an error when was passed
    file. So, it is necessary to classify files and directories correctly.
    
    Fixes #37011.
Commits on Aug 8, 2019
Commits on Aug 3, 2019
  1. Merge pull request #36849 from yahonda/use_assert_nil

    y-yagi committed Aug 3, 2019
    Address `DEPRECATED: Use assert_nil if expecting nil`
Commits on Aug 1, 2019
  1. Do not use the same test class in different tests

    y-yagi committed Aug 1, 2019
    This fixes the following warnings.
    
    ```
    actionmailer/test/base_test.rb:272: warning: method redefined; discarding old welcome
    actionmailer/test/base_test.rb:260: warning: previous definition of welcome was here
    ```
Commits on Jul 27, 2019
  1. Avoid to use a method that acts on the hash

    y-yagi committed Jul 27, 2019
    To avoid a deprecation warning.
  2. Do not use the same temp file in different tests

    y-yagi committed Jul 27, 2019
    It causes unexpected results when running tests in parallel.
    Ref: https://buildkite.com/rails/rails/builds/62610#0165f6d9-b9c8-4948-9319-07b58bfbfd4f/989-998
  3. Fix "warning: ambiguous first argument; put parentheses or a space ev…

    y-yagi committed Jul 27, 2019
    …en after `/' operator"
Commits on Jul 26, 2019
  1. Merge pull request #36747 from y-yagi/add_mention_about_collection_ca…

    y-yagi committed Jul 26, 2019
    …che_versioning
    
    Add mention about `active_record.collection_cache_versioning` to the `new_framework_defaults.rb`
Commits on Jul 24, 2019
  1. Add mention about `active_record.collection_cache_versioning` to the …

    y-yagi committed Jul 24, 2019
    …`new_framework_defaults.rb`
    
    All other recommended new configurations that set in `load_defaults` are
    already mentioned in `new_framework_defaults.rb`.
    So `active_record.collection_cache_versioning` should also be mentioned.
Commits on Jul 20, 2019
  1. Merge pull request #35285 from masakazutakewaka/fix_railtie_add_newli…

    y-yagi committed Jul 20, 2019
    …ne_to_gemfile_insertion
    
    Add a newline at the end of a Gemfile when it doesn't end with a newline
Commits on Jul 18, 2019
  1. Merge pull request #36703 from y-yagi/script-src-xxx_and_style-src-xxx

    y-yagi committed Jul 18, 2019
    Add support for script-src-attr / elem and style-src-attr / elem directives
  2. Add support for script-src-attr / elem and style-src-attr / elem dire…

    y-yagi committed Jul 18, 2019
    …ctives
    
    These directives can be used in Chrome 75.
    Ref: https://www.chromestatus.com/feature/5141352765456384
Commits on Jul 17, 2019
  1. Merge pull request #36603 from y-yagi/add_skip_collision_check_option

    y-yagi committed Jul 17, 2019
    Add `skip-collision-check` option to generator
Commits on Jul 14, 2019
  1. Merge pull request #36679 from jacobbednarz/update-feature-policy-exa…

    y-yagi committed Jul 14, 2019
    …mple-config
    
    Use reserved domain for example configuration
Older
You can’t perform that action at this time.