Permalink
Commits on Sep 25, 2016
  1. Fix console tests.

    kaspth committed Sep 15, 2016
  2. Remove the old command files.

    Wash out your old! These adhoc scripts are replaced by the new
    commands.
    kaspth committed Sep 12, 2016
  3. Per Dr. Eileen's orders :)

    Prescribed some review fixes for myself!
    kaspth committed Sep 7, 2016
  4. Simplify auxiliary command files directory finding.

    Still vulnerable to different file structures. We likely want something
    more robust when we tackle in app commands.
    kaspth committed Sep 7, 2016
  5. Initial command structure.

    kaspth committed May 28, 2016
  6. Merge pull request #26579 from y-yagi/remove_unnecessary_rails_env_se…

    …tting
    
    remove unnecessary `RAILS_ENV` setting
    kaspth committed on GitHub Sep 25, 2016
  7. Merge pull request #26619 from maclover7/jm-a502703-notes

    Add info about a502703 to Rails 5 release notes
    maclover7 committed on GitHub Sep 25, 2016
  8. Add info about a502703 to Rails 5 release notes

    [ci skip]
    maclover7 committed Sep 25, 2016
  9. Use autorun when running via Rake.

    Makes sure we get support for `Minitest.after_run` hooks and don't
    accidentally run tests twice.
    
    Requires overriding minitest `run` to respect the TESTOPTS variable.
    kaspth committed Sep 25, 2016
  10. Revise setting of run_with_rails_extension.

    The Rails test runner supports three ways to run tests: directly, via rake, or ruby.
    
    When Running with Ruby ala `ruby -Itest test/models/post_test.rb` our test file would
    be evaluated first, requiring `test_helper` and then `active_support/testing/autorun`
    that would then require the test file (which it hadn't been before) thus reevaluating
    it. This caused exceptions if using Active Support's declarative syntax.
    
    Fix this by shifting around when we set the how we're run to closer mimick the require
    order.
    
    If we're running with `bin/rails test` the test command file is run first and we then
    set `run_with_rails_extension`, later we hit `active_support/testing/autorun` and do
    nothing — because we've been run elsewhere.
    
    If we at this point haven't set `run_with_rails_extension` we've been running with
    `ruby` this whole time and thus we set that.
    
    We should always trigger `Minitest.autorun` as it doesn't hurt to call it twice.
    
    Consolidate the two methods into a single one that better brings out the intent of
    why they're there.
    kaspth committed Sep 25, 2016
  11. Require `active_support/testing/autorun`.

    Revise the require in the test command to use `active_support/testing/autorun`
    and spare us the minitest spec syntax as detailed in 5da4d51.
    
    Also move the require to the top of the file for consistency with the rest of
    Rails' requires across the project.
    kaspth committed Sep 25, 2016
  12. Merge pull request #26613 from adamcrown/save-validate-rdoc-formatting

    Fix code formatting in `#save` RDoc [ci skip]
    prathamesh-sonpatki committed on GitHub Sep 25, 2016
  13. Fix code formatting in `#save` RDoc [ci skip]

    Noticed that the `validate: false` option for `ActiveRecord::Persistence#save` and `#save!` were not formatted as code like the other examples in the documentation.
    adamcrown committed on GitHub Sep 25, 2016
Commits on Sep 24, 2016
  1. Merge pull request #26610 from mechanicles/as-to-active-support

    AS => Active Support [ci skip]
    maclover7 committed on GitHub Sep 24, 2016
  2. Merge pull request #26597 from tbalthazar/26580

    Fix ActiveSupport::TimeWithZone#in
    pixeltrix committed on GitHub Sep 24, 2016
  3. Fix ActiveSupport::TimeWithZone#in

    Previously calls to `in` were being sent to the non-DST aware
    method `Time#since` via `method_missing`. It is now aliased to
    the DST aware `ActiveSupport::TimeWithZone#+` which handles
    transitions across DST boundaries, e.g:
    
        Time.zone = "US/Eastern"
    
        t = Time.zone.local(2016,11,6,1)
        # => Sun, 06 Nov 2016 01:00:00 EDT -05:00
    
        t.in(1.hour)
        # => Sun, 06 Nov 2016 01:00:00 EST -05:00
    tbalthazar committed Sep 23, 2016
  4. Merge pull request #26515 from grosser/grosser/after_run

    support minitest after_run
    arthurnn committed on GitHub Sep 24, 2016
  5. switch to autorun to support after_run and patch less

    grosser committed Sep 24, 2016
Commits on Sep 23, 2016
  1. Merge pull request #26607 from matthewd/skip-fixture-path

    Only search fixture_path for files that can't be found directly
    matthewd committed on GitHub Sep 23, 2016
  2. Only search fixture_path for files that can't be found directly

    When passed an already-valid file name, prepending the path is likely to
    create problems.
    
    This is particularly relevant for #26384, which adds fixture_path
    handling to test classes that previously didn't have it: any existing
    caller must have been manually locating the file, and we don't want to
    break them.
    matthewd committed Sep 23, 2016
  3. Merge pull request #26591 from philipqnguyen/changelog-fix-etag-template

    Add #25546 and #25817 to changelog [ci skip]
    claudiob committed on GitHub Sep 23, 2016
  4. Merge pull request #26605 from mjhoy/fix-controller-tests-guides-get-…

    …action
    
    Fix docs for allowed params to `get` in controller tests  [ci skip]
    prathamesh-sonpatki committed on GitHub Sep 23, 2016
  5. Merge pull request #25670 from tdtran/fix-nil-json

    Serialize JSON attribute value nil as SQL NULL, not JSON 'null'
    tenderlove committed on GitHub Sep 23, 2016
  6. Serialize JSON attribute value nil as SQL NULL, not JSON 'null'

    Test: JSON attribute value nil can be used in where(attr: nil)
    
    Add changelog entry
    tdtran committed Jul 3, 2016
  7. Merge pull request #26563 from knugie/fix_issue_26430

    Prevent circular require of proxy_wrappers.rb, Fixes #26430
    tenderlove committed on GitHub Sep 23, 2016
  8. Merge pull request #26595 from prathamesh-sonpatki/fix-26593

    Return true if attribute is not changed for update_attribute
    tenderlove committed on GitHub Sep 23, 2016
  9. Return true if attribute is not changed for update_attribute

    - If the attribute is not changed, then update_attribute does not run
      SQL query, this effectively means that no change was made to the
      attribute.
    - This change was made in 0fcd4cf
      to avoid a SQL call.
    - But the change resulted into `nil` being returned when there was no
      change in the attribute value.
    - This commit corrects the behavior to return true if there is no change
      in attribute value. This is same as previous behavior of Rails 4.2
      plus benefit of no additional SQL call.
    - Fixes #26593.
    prathamesh-sonpatki committed Sep 23, 2016
  10. Merge pull request #26594 from y-yagi/fix_formatting_of_define_callbacks

    fix formatting of `define_callbacks` doc [ci skip]
    vipulnsward committed on GitHub Sep 23, 2016
  11. fix formatting of `define_callbacks` doc [ci skip]

    Single backticks don't work with rdoc.
    y-yagi committed Sep 23, 2016
Commits on Sep 22, 2016
  1. Merge pull request #26589 from kirs/ad-test-request-method

    Fix memoization bug on ActionDispatch::TestRequest#request_method=
    arthurnn committed on GitHub Sep 22, 2016