Skip to content
This repository
  • 8,404 commits
  • 217 files changed
  • 48 contributors
This comparison is big! We're only showing the most recent 250 commits
Jul 21, 2010
José Valim No need to delegate. Simply include the whole RecordIdentifier module. c565f00
José Valim Remove old install.rb files. f1082bd
José Valim Improve contribuition guide. cd15368
José Valim Rework a bit README files. b70062f
José Valim Add .rdoc extension to README files. 508fba9
José Valim Reuse already existing classes for ActiveModel tests. 5331061
José Valim Fix failing railties tests. 0a729b0
Neeraj Singh - without the id test is passing even if I change :allow_destroy from…
… 'false' - adding more tests to strengthen the test suite

Signed-off-by: José Valim <>
Subba Rao Pasupuleti In nested_attributes when association is not loaded and association
record is saved and then in memory record attributes should be saved

[#5053 state:resolved]

Signed-off-by: José Valim <>
Szeto Bo association load target shouldn't replace records
from db if it is already loaded by nested attributes assignment

[#5053 state:resolved]

Signed-off-by: José Valim <>
Subba Rao Pasupuleti Strengthening the test for nested_attribute
Loading the associate target in nested_attributes
should load most recent attributes for child
records marked for destruction

Signed-off-by: José Valim <>
José Valim Revert "save on parent should not cascade to child unless child chang…
…ed [#3353 state:open]"

Please check Lighthouse for more information.

This reverts commit 4a0d7c1.
Neeraj Singh Timestamp columns of HABTM join table should record timestamps
[#5161 state:resolved]
José Valim Ensure all join table attributes will be in the same timestamp. f3e4229
Thiago Pradi rake db:seed should check if the database have pending migrations [#5163

Signed-off-by: José Valim <>
Neeraj Singh update_attribute should not update readonly attributes
[#5106 state:resolved]

Signed-off-by: José Valim <>
Subba Rao Pasupuleti eagerly loaded association records should respect default_scope [#2931

Signed-off-by: José Valim <>
José Valim Ensure default_scope can be overwriten by association conditions. 7131244
José Valim Ensure insert_before in middleware stack raises a meaningful error me…
…ssage [#3679 state:resolved]
José Valim Use capture instead of yield in link_to_unless.
[#5162 state:resolved]
Neeraj Singh renaming tests by removing proxy_options from names
Signed-off-by: José Valim <>
Jeroen van Dijk Mention that ActionMailer::Base.default_url_options is now deprecated 24c0bc5
Santiago Pastorino We are doing the same in this conditions
Signed-off-by: José Valim <>
Santiago Pastorino Make config.generators accept string namespaces, you can do now confi…
…g.generators.test_framework 'rspec' for instance

Signed-off-by: José Valim <>
Santiago Pastorino Make use of tap to return a previously used var
Signed-off-by: José Valim <>
Andrew Kaspick remote_function patch with more detailed test
Signed-off-by: wycats <>
Greg Hurrell doc: form_for does return output rather than merely evaluate its block 680f045
Brian Rose Fixed a globbed route issue where slashes were being escaped, causing…
… assert_routing to fail. [#5135 state:resolved]

Signed-off-by: José Valim <>
Subba Rao Pasupuleti removing unused models from tests
[#5153 state:resolved]

Signed-off-by: José Valim <>
Aaron Patterson adding tests for sessions and clearing up warnings 1f8edb9
Aaron Patterson initializing instance variables bdbe390
Aaron Patterson starting sql bypass test, fixing create_table and drop_table! ba0d2a9
Aaron Patterson readability is hip 4e6cf42
Aaron Patterson reducing function calls in the session store f5de56f
Aaron Patterson testing new_record? and converting to an attribute 87a319c
Aaron Patterson testing loaded? method and reducing funcalls a78547a
Santiago Pastorino options could be of any kind of Hash (Hash, HashWithIndifferentAccess…
… or OrderedHash) this way we keep the properties of the options passed as an argument
Santiago Pastorino These tests are trusting in the order of the elements so use OrderedH…
…ash instead of Hash
Bobby Wilson Changed code style that was incorrectly rendering block style instead…
… of inline.
Jul 22, 2010
Santiago Pastorino Change some missing README -> README.rdoc d16c5cc
Xavier Noria routing guide: a "photo" resource has by convention paths under "phot…
…os", in plural
Santiago Pastorino Hash#to_param is doesn't use sort anymore, some tests added for Hash#…
Santiago Pastorino Test Hash#to_param escapes keys and values 6cbd085
Xavier Noria routing guide: say "path" when you mean path 5cba663
Xavier Noria camelize and underscore are sort of inverse of each other, but not in…
… a mathematical sense [#5174 state:resolved]
Neeraj Singh replacing around with for in the comments for callbacks aa2235b
Mislav Marohnić correct typos in Routing examples efdfcf1
Neeraj Singh expanded comment for update_attribute method 5c13793
Jaime Iniesta Active Record Validations and Callbacks guide: Fixed typos and rephra…
…sed some paragraphs for clarity
Jaime Iniesta non-singleton true and false should go on regular font 6f7402d
Jeroen van Dijk Mention that ActionMailer::Base.default_url_options is now deprecated ab62aa1
Greg Hurrell doc: form_for does return output rather than merely evaluate its block 198975e
Xavier Noria routing guide: a "photo" resource has by convention paths under "phot…
…os", in plural
Xavier Noria routing guide: say "path" when you mean path b72cc47
Xavier Noria camelize and underscore are sort of inverse of each other, but not in…
… a mathematical sense [#5174 state:resolved]
Xavier Noria Merge remote branch 'rails/master' 919eb20
Mislav Marohnić revise download/installation/support sections in READMEs
 - don't reference ancient gem versions
 - don't link to old API doc subdomains
 - point to GitHub instead of RubyForge
 - point to Lighthouse account for support
Mislav Marohnić improve Action Pack README
 - revise introductory text
 - list modules contained in the package
 - improve examples
 - remove obsolete `scaffold` and `form` examples
Mislav Marohnić improve Active Record README
 - revise introductory text
 - improve examples
 - don't claim that Oracle, SQL Server, or DB2 are supported
 - remove lengthy "simple example"
Mislav Marohnić remove unneeded "Dependencies" section from Action Mailer README
Other READMEs don't have dependencies indicated, and installing a gem
takes care of dependencies automatically. For developers, dependencies
are indicated in the Gemfile.
Mislav Marohnić improve Active Model README
 - fix indentation problems
 - revised introductory text to state right away what the library is
 - improved examples: reduce heavy usage of ellipsis,
   don't mark paragraphs of text as code
Ivan Torres [PATCH] Update guides after Jeremy Kemper's changes on fieldWithErrors
to field_with_errors [#157 state:resolved]
Aaron Patterson adding a test for session save 38734af
Aaron Patterson refactor to use instance methods and be kind to subclasses 97f3c73
Performance optimizations to handle cases of instrumentors that are n…
…ot listened to. Also, fix a possible concurrency issue.
Santiago Pastorino Don't shadow outer local variables 21c4b09
Santiago Pastorino MySQL can't index a TEXT column 1b8cd5f
Santiago Pastorino This is a VARCHAR not a TEXT 7113f20
Santiago Pastorino Makes current adapter decide the syntax of PRIMARY KEY column definition 24f303b
José Valim Merge remote branch 'spastorino/master'
Signed-off-by: José Valim <>
Andrew Kaspick update remote_function docs referencing link_to_remote cf5c2ba
Jeremy Kemper Session data will exceed 255 bytes. Use TEXT. 3ec6759
Santiago Pastorino session_id is a VARCHAR 227680f
Xavier Noria bump required RDoc to >= 2.5.9, and replace the 2.2 horo.rb with Aaro…
…n's gem
Aaron Patterson refactoring class methods to a module da37716
Aaron Patterson refactoring more methods to a class methods module 34ff74f
Aaron Patterson fixing space error 5e6382e
Jul 23, 2010
Santiago Pastorino Makes Rakefile activate rdoc >= 2.5.9
Signed-off-by: Xavier Noria <>
Aaron Patterson brrrrr! freeze is not needed 9b48a94
Aaron Patterson testing sqlbypass destroy. caching connection during destroy 5ebc1d8
Neeraj Singh reformatting sentence 8f638d8
Neeraj Singh shortening the sentences and removing fluff 3416517
Neeraj Singh adding proper markup in comments 4bf6c1c
Aaron Patterson update Rakefiles for RDoc 2.5 b50635a
Neeraj Singh fixing typo 46c7a99
Neeraj Singh making comments sentence more concise 8429e7b
Jul 24, 2010
Jeroen van Dijk Move config_accessor :asset_host from ActionController::Base to Abstr…
…actController which fixes issues with asset_host in ActionMailer

  - Moved mailer objects in separate directory
  - Added two tests for asset_host configuration option
Xavier Noria include the root README.rdoc as main page 728ba20
José Valim Also move asset_path to AbstractController. 2af8fd2
José Valim Clean up AM and AC railties. 76b6136
José Valim Merge branch 'master' of 7a7cbab
Santiago Pastorino Makes restore previosly saved warnings_on_first_load value and avoid …

Signed-off-by: José Valim <>
Santiago Pastorino Removes unused vars
Signed-off-by: José Valim <>
Santiago Pastorino Make this test, test again
Signed-off-by: José Valim <>
Santiago Pastorino make a throwaway value equals to _ to avoid warnings
Signed-off-by: José Valim <>
Neeraj Singh bringing consistency in comments 082ca51
José Valim Get rid of instrumenter.elapsed. 834bd23
jack dempsey Fix small middlewares typo 9a9fb12
Jul 25, 2010
Santiago Pastorino Removing one AS/lib ruby and rake adds to $LOAD_PATH 749948a
Arkadiusz Holko Fixes syntax error in "with_scope" example 7fb7a2b
Sebastian A. Espindola Fixed output_buffer encoding problem [#5179]
Signed-off-by: Santiago Pastorino <>
Signed-off-by: José Valim <>
Santiago Pastorino Change returning with tap
Signed-off-by: José Valim <>
José Valim Move runtime to log subscriber. 82c7ef8
José Valim runtime should be properly initialized. d02f2d2
Aaron Patterson use a hash to collect optional statistics about the instrumentation b7e0408
Aaron Patterson cache the instrumentor for a speed gain fc088d4
Aaron Patterson look up connection once 0d0e793
José Valim Revert the previous three commits.
* AS::Notifications#instrument should not measure anything, it is not its responsibility;

* Adding another argument to AS::Notifications#instrument API needs to be properly discussed;
José Valim Move runtime back to connection. 304c49b
José Valim Cache connection access. 331df84
Xavier Noria application generation: --skip-testunit and --skip-activerecord renam…
…ed to --skip-test-unit and --skip-active-record respectively

Reason is their proper spellings are "Test::Unit" and "Active Record".
Option names and descriptions have been revised, as well as some method
names and minor details here and there.
Carlos Antonio da Silva Add assertion to link_to_function test with block and capture, and mo…
…re expressive test name [#5179 state:resolved]

Signed-off-by: José Valim <>
José Valim Cache instrumenter again as per Aaron's patch. f4200b0
Santiago Pastorino Object#returning removed
Signed-off-by: José Valim <>
Santiago Pastorino CHANGELOG updated Object#returning removed
Signed-off-by: José Valim <>
Xavier Noria AS guide: Object#returning is gone 06853cb
Aaron Patterson do not execute the session tests within transactions df95948
Aaron Patterson fisting warning 53fbbf4
Aaron Patterson using AREL from the environment if it exists 13df581
Santiago Pastorino Changed returning with tap on guides 93e6dd1
Jul 26, 2010
Xavier Noria APIs for individual components are no longer published dcb7832
Xavier Noria Merge remote branch 'docrails/master' 6aa1253
Santiago Pastorino Don't interpolate a blank string, avoid warnings 963c71e
Santiago Pastorino Bump up bundler 8abcd49
Santiago Pastorino Gemfile now makes use of platforms calls with blocks instead of elsif…
… logic to define dependencies over specific platforms
Yehuda Katz Fix a bug where requires inside of autoloads were being added to the …
…autoloaded_constants list, causing mayhem. [#5165 state:resolved]
José Valim Update to latest thor. 9789d22
Neeraj Singh strengthening the rescue_from test suites
Signed-off-by: José Valim <>
Neeraj Singh strengthening the test suite for rescue_from
Signed-off-by: José Valim <>
Greg Hurrell doc: cleanup respond_to documentation
Signed-off-by: Wincent Colaiuta <>
Josef Reidinger fix escaping id and parameters in path [#5137 state:resolved]
Signed-off-by: José Valim <>
Thiago Pradi Removing unnecessary code [#5192 state:resolved]
Signed-off-by: José Valim <>
Łukasz Strzałkowski Removed deprecated APIs in text and number helpers [#5156 state:resol…

They're deprecated since 2008. It's time to get rid of them.

Signed-off-by: José Valim <>
Neeraj Singh No need to check for :uniq
[#5170 state:resolved]

Signed-off-by: José Valim <>
Santiago Pastorino Fixes usage message when running rails without --dev on a cloned rail…
…s repo
Santiago Pastorino This is for making sure const_missing is triggered without warnings 4ea1753
Bernerd Schaefer XmlMini.rename_key emits valid xml with dasherize
This resolves issues for libraries which use '_' prefixed keys in their
attributes hash, such as Mongoid. A key like "_id" or "_type" will no
longer be converted to "<-id>" and "<-type>".

Signed-off-by: wycats <>
Leigh Caplan Override new on proxy objects so that they never wrap nil or false. e56c9ef
Leigh Caplan Test to ensure that falsy objects aren't wrapped by deprecation proxies 37d82f2
Santiago Pastorino Changed returning with tap on guides fd589db
Greg Hurrell doc: cleanup respond_to documentation
Signed-off-by: Wincent Colaiuta <>
Xavier Noria Merge remote branch 'rails/master' b31c0ae
Aaron Patterson fixing space errors 32844cb
José Valim Move runtime back to the Thread.current dd61a81
David Heinemeier Hansson Prep for RC 856fc4b
David Heinemeier Hansson Rails version update e71815b
Santiago Pastorino missing requires added 4ac3ae0
David Heinemeier Hansson Make Rails 3 RC depend on Bundler RC 3bdaa09
David Heinemeier Hansson Spaces, people, spaces! 06b9531
David Heinemeier Hansson Add install script for testing gems locally f79f9a7
Nick Sieger JRuby should not need system_timer, and cannot install it either
Signed-off-by: Santiago Pastorino <>
David Heinemeier Hansson Fix deprecation message on info screen d283ca3
Chad Fowler fix bad logic in determining if in rails app subdir
Signed-off-by: David Heinemeier Hansson <>
Arkadiusz Holko Fixed field_error_proc default example on guides 2e3a86a
Santiago Pastorino This is a hash in 1.9.2 a2ca9cb
Neeraj Singh making comments have a consistent theme of narrative b357aed
Neeraj Singh Merge branch 'master' of c77adb4
Neeraj Singh making comments meaningful by correcting, adding and pruning d214925
Neeraj Singh polishing comments f3409dc
Jul 27, 2010
Xavier Noria prefer %Q() over escaped double quotes 10815e6
Rohit Arondekar Fix app generator so that it uses the right app_name during rails:upd…
…ate rake task. [#5207 state:committed]

Signed-off-by: José Valim <>
Paul Carey amended Contributing to Rails guide to advise to use bundler v1.0 to …
…avoid error messages with bundler
Neeraj Singh adding comments to update_attribute method c9fe3c3
Neeraj Singh Merge branch 'master' of 865d208
Neeraj Singh clarifying description for class_attribute method e7920a3
Brian Smith Frameworks are loaded in application.rb rather than config.rb accordi…
…ng to Rails 3 conventions.
Xavier Noria Revert "Frameworks are loaded in application.rb rather than config.rb…
… according to Rails 3 conventions."

This reverts commit 1793b21.

This commit had no risk, but docrails has a hard rule about touching code.
The contribution is appreciated, I hope you do not mind this technical
revert. I'll apply that to master with proper credit.
Yehuda Katz Add a header that tells Internet Explorer (all versions) to use the b…
…est available standards support. This ensures that IE doesn't go into quirks mode because it has been blacklisted by too many users pressing the incompatible button. It also tells IE to use the ChromeFrame renderer, if the user has installed the plugin.

This guarantees that the best available standards support will be used on the client.
Yehuda Katz Forgot to check in this new file aa24ea4
Aaron Patterson slight performance improvement when grabbing an arel table fe9d7ab
Yehuda Katz Fix middleware test eff0749
Jul 28, 2010
Xavier Noria adds test coverage for edge-cases of Array.wrap, and better documenta…
…tion for how it differs from Kernel#Array
Jon Buda fixed joining of attributes when using find_or_create_by with multipl…
…e attributes through an association

Signed-off-by: Santiago Pastorino <>
Neeraj Singh removing unused variable 194ec3d
Neeraj Singh adding more test cases for expand_cache_key 3265af5
Neeraj Singh test cases for rails_app_version in AS cache.rb 7d29627
Neeraj Singh adding test for respond_to cache_key and cleaning up the ENV settings 4952a80
Neeraj Singh updating description of how class_attribute works f3b50b1
Neeraj Singh adding some comments to cattr_accessor method ff7e17d
Neeraj Singh clarifying the instance_write option with an example eb902d6
Neeraj Singh adding comment specifying that cattr_accessor also supports instance_…
…write and instance_rader option
Neeraj Singh editing a sentence 2d601e4
Neeraj Singh editing the documentation regarding :race_condition_ttl and :expires_…
…in option in AS cache
José Valim More documentation to class_attribute. 7c3d479
Neeraj Singh more documentation for update_attribute 51924d4
Neeraj Singh adding punctuations 31f8a0c
removed ambiguity from autosave description f46e841
Aaron Patterson avoid calling to_sql twice 1c030a3
Aaron Patterson Shouldn't have committed this! Revert "avoid calling to_sql twice"
This reverts commit 1c030a3.
Neeraj Singh superclass_delegating_accessor has been deprecated.
I am working on removing all traces of superclass_delegating_accessor from rails code base.
Neeraj Singh putting receive method under tt 2df3655
Neeraj Singh itsy bitsy changes to ActionMailer documentation daad445
Neeraj Singh itsy bitsy changes to documentation 627d870
Jul 29, 2010
José Valim Revert "Avoid uneeded queries in session stores if sid is not given."
First step to merge Rails and Rack session stores. Rack always expects to receive the SID since it may have different behavior if the SID is nil.

This reverts commit e210895.
Neeraj Singh expanding on the will_change! method in documentation 1a6d762
Neeraj Singh adding documentation regarding time_zone_aware_attributes and skip_ti…
Paul Carey amended rails upgrade plugin instructions to be rails 2.3.x compatibl…
…e instead of former rails 3 format
Paul Carey Merge branch 'master' of 2b2ee22
Neeraj Singh moving time zone related documentation to timestamp.rb from base.rb e429453
Add a missing require in 'active_support/core_ext/string/inflections' d04c6f2
Rodrigo Dominguez link_to_function now expects a piece of javascript code for the oncli…
…ck parameter


Signed-off-by: Santiago Pastorino <>
Neeraj Singh updating documentation about lazy hooks in ActiveSupport a506d5a
Neeraj Singh Adding documentation regarding lazy_load_hooks 3c3ff13
Aaron Patterson PERF: avoiding splat args and reducing function calls f171bc6
Aaron Patterson got the ternary backwards. somehow the sqlite tests passed! a7a6a2f
Tarmo Tänav Don't increment and then decrement the same counter when re-assigning…
… a belongs_to association

[#2786 state:committed]

Signed-off-by: Santiago Pastorino <>
Santiago Pastorino Bump up nokogiri to 55028a7
Santiago Pastorino This version is going to be outdated when new nokogiri versions are r…
Santiago Pastorino Bump up bundler version to rc.2 03fc2f0
Add another missing require in 'active_support/inflector/inflections' d277b82
Jul 30, 2010
Xavier Noria edit pass to apply API guideline wrt the use of "# =>" in example code 755af49
Xavier Noria Merge remote branch 'rails/master' ccd4561
Rohit Arondekar API Docs: Use 'HTTP_AUTHORIZATION' and not :authorize as key in integ…
…ration tests.
Steve Agalloco fix for rails app generator when using --pretend option
[#5245 state:committed]

Signed-off-by: Santiago Pastorino <>
Santiago Pastorino Make options an attr_reader 95e9ced
Arkadiusz Holko Command Line Guide: changes all 'rails app' commands to 'rails new app' 8828651
Neeraj Singh returns not returned . fixing documentation for reflection 0e20e3e
Santiago Pastorino AS gem doesn't depend on nokogiri so shows a nicer error if users hav…
…en't installed
Xavier Noria the main page of the API generated by the doc:rails task is README 05e0fa9
Xavier Noria if there's a Gemfile and doc:guides can't load RedCloth, print instru…
…ctions for bundler
Aaron Patterson reducing function calls and using faster methods for testing d1c53a9
Aaron Patterson fewer method calls, using faster methods when possible ecfb252
Aaron Patterson reverting where() functionality, adding a test 834e304
Jul 31, 2010
Xavier Noria README.rdoc is your first impression, make sure it is clean
* Removes spurious markup from code blocks
* Integrates code blocks into ordinary paragraph flow
* Change link to the Rails Tutorial so that it points directly to the book
* Use proper RDoc markup for links
Xavier Noria Merge remote branch 'rails/master' 3d70998
Xavier Noria use the same amount of left indent in all code blocks of README.rdoc f7f5299
Xavier Noria fixes typo 1d1f810
Johan Lundström DHH forgot to remove JS, CSS in generated index.html [#5261 state:res…

Signed-off-by: Santiago Pastorino <>
Aug 01, 2010
Xavier Noria explains Array.wrap directly, rather by comparison with Kernel#Array …
…which is too obscure, leaves the comparison to document the differences, and adds a comparison with the related idiom that uses the splat operator
Santiago Pastorino Makes form_helper use overriden model accessors
[#3374 state:committed]
Carlos Antonio da Silva Fix label form helper to use I18n and html options, without the need …
…of 'nil' text param:

  Before: f.label :title, nil, :class => 'title'
  After : f.label :title, :class => 'title'

[#5267 state:committed]

Signed-off-by: Santiago Pastorino <>
Santiago Pastorino Use AS::OrderedHash when trusting in the order of the hash 111234e
Prashant Shah Corrected the rake test:units and test:functionals description [#5251

Signed-off-by: Santiago Pastorino <>
Aug 02, 2010
Rohit Arondekar Failing test to check for route file corruption if legacy map paramet…
…er is used. [#5263 state:open]
Santiago Pastorino Makes rails destroy scaffold don't duplicate routes.draw do |map| |ma…
…p| when using the deprecated syntax

[#5263 state:committed]
Kuba Kuźma added failing touch propagation test
Signed-off-by: José Valim <>
José Valim Add an internal (private API) after_touch callback. [#5271 state:reso…
José Valim Merge branch 'master' of 2dfeb7b
Chris Hoffman Add missing require in ActiveSupport::HashWithIndifferentAccess [#5189

Signed-off-by: José Valim <>
Alex Le ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 st…

Signed-off-by: José Valim <>
Fred Wu Improved how AppGenerator generates the application name. It now dete…
…cts the current app name whenever possible. This means that renaming the residing directory will not effect the app name generated by AppGenerator.

[#5225 state:resolved]

Signed-off-by: José Valim <>
José Valim Handle edge cases in the previous patch. 558ee6e
Robert Pankowecki test and fix collection_singular_ids= with string primary keys [#5125

Signed-off-by: José Valim <>
José Valim Tidy up previous commit. e1344bf
Josef Reidinger fix loading of different elements in array then int and string [#5036

Signed-off-by: José Valim <>
Neeraj Singh Eager loading an association should not change the count of children
[#4971 state:resolved]

Signed-off-by: José Valim <>
José Valim Remove duplicated logic. 9effe3c
José Valim Bring returning back to ease migration. 88b5f93
Yehuda Katz Sadly, this segv's in 1.8 :( 8aad678
Aug 17, 2010
Aaron Patterson adding segv test c5a809e