Skip to content


Subversion checkout URL

You can clone with
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
This comparison is big! We’re only showing the most recent 250 commits
Commits on Jul 21, 2010
@josevalim josevalim No need to delegate. Simply include the whole RecordIdentifier module. c565f00
@josevalim josevalim Remove old install.rb files. f1082bd
@josevalim josevalim Improve contribuition guide. cd15368
@josevalim josevalim Rework a bit README files. b70062f
@josevalim josevalim Add .rdoc extension to README files. 508fba9
@josevalim josevalim Reuse already existing classes for ActiveModel tests. 5331061
@josevalim josevalim Fix failing railties tests. 0a729b0
@neerajdotname neerajdotname - without the id test is passing even if I change :allow_destroy from…
… 'false' - adding more tests to strengthen the test suite

Signed-off-by: José Valim <>
@subbarao subbarao In nested_attributes when association is not loaded and association
record is saved and then in memory record attributes should be saved

[#5053 state:resolved]

Signed-off-by: José Valim <>
@szetobo szetobo association load target shouldn't replace records
from db if it is already loaded by nested attributes assignment

[#5053 state:resolved]

Signed-off-by: José Valim <>
@subbarao subbarao Strengthening the test for nested_attribute
Loading the associate target in nested_attributes
should load most recent attributes for child
records marked for destruction

Signed-off-by: José Valim <>
@josevalim josevalim Revert "save on parent should not cascade to child unless child chang…
…ed [#3353 state:open]"

Please check Lighthouse for more information.

This reverts commit 4a0d7c1.
@neerajdotname neerajdotname Timestamp columns of HABTM join table should record timestamps
[#5161 state:resolved]
@josevalim josevalim Ensure all join table attributes will be in the same timestamp. f3e4229
@tchandy tchandy rake db:seed should check if the database have pending migrations [#5163

Signed-off-by: José Valim <>
@neerajdotname neerajdotname update_attribute should not update readonly attributes
[#5106 state:resolved]

Signed-off-by: José Valim <>
@subbarao subbarao eagerly loaded association records should respect default_scope [#2931

Signed-off-by: José Valim <>
@josevalim josevalim Ensure default_scope can be overwriten by association conditions. 7131244
@josevalim josevalim Ensure insert_before in middleware stack raises a meaningful error me…
…ssage [#3679 state:resolved]
@josevalim josevalim Use capture instead of yield in link_to_unless.
[#5162 state:resolved]
@neerajdotname neerajdotname renaming tests by removing proxy_options from names
Signed-off-by: José Valim <>
@jeroenvandijk jeroenvandijk Mention that ActionMailer::Base.default_url_options is now deprecated 24c0bc5
@spastorino spastorino We are doing the same in this conditions
Signed-off-by: José Valim <>
@spastorino spastorino Make config.generators accept string namespaces, you can do now confi…
…g.generators.test_framework 'rspec' for instance

Signed-off-by: José Valim <>
@spastorino spastorino Make use of tap to return a previously used var
Signed-off-by: José Valim <>
@akaspick akaspick remote_function patch with more detailed test
Signed-off-by: wycats <>
@wincent wincent doc: form_for does return output rather than merely evaluate its block 680f045
@spastorino spastorino Change some missing README -> README.rdoc d16c5cc
@heimidal heimidal Fixed a globbed route issue where slashes were being escaped, causing…
… assert_routing to fail. [#5135 state:resolved]

Signed-off-by: José Valim <>
@subbarao subbarao removing unused models from tests
[#5153 state:resolved]

Signed-off-by: José Valim <>
@fxn fxn routing guide: a "photo" resource has by convention paths under "phot…
…os", in plural
@spastorino spastorino Hash#to_param is doesn't use sort anymore, some tests added for Hash#…
@spastorino spastorino Test Hash#to_param escapes keys and values 6cbd085
@fxn fxn routing guide: say "path" when you mean path 5cba663
@fxn fxn camelize and underscore are sort of inverse of each other, but not in…
… a mathematical sense [#5174 state:resolved]
@neerajdotname neerajdotname replacing around with for in the comments for callbacks aa2235b
@mislav mislav correct typos in Routing examples efdfcf1
@neerajdotname neerajdotname expanded comment for update_attribute method 5c13793
@jaimeiniesta jaimeiniesta Active Record Validations and Callbacks guide: Fixed typos and rephra…
…sed some paragraphs for clarity
@jaimeiniesta jaimeiniesta non-singleton true and false should go on regular font 6f7402d
@jeroenvandijk jeroenvandijk Mention that ActionMailer::Base.default_url_options is now deprecated ab62aa1
@wincent wincent doc: form_for does return output rather than merely evaluate its block 198975e
@fxn fxn routing guide: a "photo" resource has by convention paths under "phot…
…os", in plural
@fxn fxn routing guide: say "path" when you mean path b72cc47
@fxn fxn camelize and underscore are sort of inverse of each other, but not in…
… a mathematical sense [#5174 state:resolved]
@fxn fxn Merge remote branch 'rails/master' 919eb20
@tenderlove tenderlove adding tests for sessions and clearing up warnings 1f8edb9
@tenderlove tenderlove initializing instance variables bdbe390
@tenderlove tenderlove starting sql bypass test, fixing create_table and drop_table! ba0d2a9
@tenderlove tenderlove readability is hip 4e6cf42
@tenderlove tenderlove reducing function calls in the session store f5de56f
@tenderlove tenderlove testing new_record? and converting to an attribute 87a319c
@tenderlove tenderlove testing loaded? method and reducing funcalls a78547a
Commits on Jul 22, 2010
@spastorino spastorino options could be of any kind of Hash (Hash, HashWithIndifferentAccess…
… or OrderedHash) this way we keep the properties of the options passed as an argument
@spastorino spastorino These tests are trusting in the order of the elements so use OrderedH…
…ash instead of Hash
@bobbywilson0 bobbywilson0 Changed code style that was incorrectly rendering block style instead…
… of inline.
@mislav mislav revise download/installation/support sections in READMEs
 - don't reference ancient gem versions
 - don't link to old API doc subdomains
 - point to GitHub instead of RubyForge
 - point to Lighthouse account for support
@mislav mislav improve Action Pack README
 - revise introductory text
 - list modules contained in the package
 - improve examples
 - remove obsolete `scaffold` and `form` examples
@mislav mislav improve Active Record README
 - revise introductory text
 - improve examples
 - don't claim that Oracle, SQL Server, or DB2 are supported
 - remove lengthy "simple example"
@mislav mislav remove unneeded "Dependencies" section from Action Mailer README
Other READMEs don't have dependencies indicated, and installing a gem
takes care of dependencies automatically. For developers, dependencies
are indicated in the Gemfile.
@mislav mislav improve Active Model README
 - fix indentation problems
 - revised introductory text to state right away what the library is
 - improved examples: reduce heavy usage of ellipsis,
   don't mark paragraphs of text as code
@mexpolk mexpolk [PATCH] Update guides after Jeremy Kemper's changes on fieldWithErrors
to field_with_errors [#157 state:resolved]
@tenderlove tenderlove adding a test for session save 38734af
@tenderlove tenderlove refactor to use instance methods and be kind to subclasses 97f3c73
Carlhuda Performance optimizations to handle cases of instrumentors that are n…
…ot listened to. Also, fix a possible concurrency issue.
@spastorino spastorino Don't shadow outer local variables 21c4b09
@spastorino spastorino MySQL can't index a TEXT column 1b8cd5f
@spastorino spastorino This is a VARCHAR not a TEXT 7113f20
@spastorino spastorino Makes current adapter decide the syntax of PRIMARY KEY column definition 24f303b
@josevalim josevalim Merge remote branch 'spastorino/master'
Signed-off-by: José Valim <>
@akaspick akaspick update remote_function docs referencing link_to_remote cf5c2ba
@jeremy jeremy Session data will exceed 255 bytes. Use TEXT. 3ec6759
@spastorino spastorino session_id is a VARCHAR 227680f
@fxn fxn bump required RDoc to >= 2.5.9, and replace the 2.2 horo.rb with Aaro…
…n's gem
@spastorino spastorino Makes Rakefile activate rdoc >= 2.5.9
Signed-off-by: Xavier Noria <>
Commits on Jul 23, 2010
@tenderlove tenderlove refactoring class methods to a module da37716
@tenderlove tenderlove refactoring more methods to a class methods module 34ff74f
@tenderlove tenderlove fixing space error 5e6382e
@tenderlove tenderlove brrrrr! freeze is not needed 9b48a94
@tenderlove tenderlove testing sqlbypass destroy. caching connection during destroy 5ebc1d8
@neerajdotname neerajdotname reformatting sentence 8f638d8
@neerajdotname neerajdotname shortening the sentences and removing fluff 3416517
@neerajdotname neerajdotname adding proper markup in comments 4bf6c1c
@tenderlove tenderlove update Rakefiles for RDoc 2.5 b50635a
@neerajdotname neerajdotname fixing typo 46c7a99
@neerajdotname neerajdotname making comments sentence more concise 8429e7b
@jeroenvandijk jeroenvandijk Move config_accessor :asset_host from ActionController::Base to Abstr…
…actController which fixes issues with asset_host in ActionMailer

  - Moved mailer objects in separate directory
  - Added two tests for asset_host configuration option
@fxn fxn include the root README.rdoc as main page 728ba20
@josevalim josevalim Also move asset_path to AbstractController. 2af8fd2
@josevalim josevalim Clean up AM and AC railties. 76b6136
@josevalim josevalim Merge branch 'master' of 7a7cbab
@spastorino spastorino Makes restore previosly saved warnings_on_first_load value and avoid …

Signed-off-by: José Valim <>
@spastorino spastorino Removes unused vars
Signed-off-by: José Valim <>
@spastorino spastorino Make this test, test again
Signed-off-by: José Valim <>
@spastorino spastorino make a throwaway value equals to _ to avoid warnings
Signed-off-by: José Valim <>
Commits on Jul 24, 2010
@neerajdotname neerajdotname bringing consistency in comments 082ca51
@josevalim josevalim Get rid of instrumenter.elapsed. 834bd23
@jackdempsey jackdempsey Fix small middlewares typo 9a9fb12
Commits on Jul 25, 2010
@spastorino spastorino Removing one AS/lib ruby and rake adds to $LOAD_PATH 749948a
@fastred fastred Fixes syntax error in "with_scope" example 7fb7a2b
@sespindola sespindola Fixed output_buffer encoding problem [#5179]
Signed-off-by: Santiago Pastorino <>
Signed-off-by: José Valim <>
@spastorino spastorino Change returning with tap
Signed-off-by: José Valim <>
@josevalim josevalim Move runtime to log subscriber. 82c7ef8
@josevalim josevalim runtime should be properly initialized. d02f2d2
@tenderlove tenderlove use a hash to collect optional statistics about the instrumentation b7e0408
@tenderlove tenderlove cache the instrumentor for a speed gain fc088d4
@tenderlove tenderlove look up connection once 0d0e793
@josevalim josevalim Revert the previous three commits.
* AS::Notifications#instrument should not measure anything, it is not its responsibility;

* Adding another argument to AS::Notifications#instrument API needs to be properly discussed;
@josevalim josevalim Move runtime back to connection. 304c49b
@josevalim josevalim Cache connection access. 331df84
@fxn fxn application generation: --skip-testunit and --skip-activerecord renam…
…ed to --skip-test-unit and --skip-active-record respectively

Reason is their proper spellings are "Test::Unit" and "Active Record".
Option names and descriptions have been revised, as well as some method
names and minor details here and there.
@carlosantoniodasilva carlosantoniodasilva Add assertion to link_to_function test with block and capture, and mo…
…re expressive test name [#5179 state:resolved]

Signed-off-by: José Valim <>
@josevalim josevalim Cache instrumenter again as per Aaron's patch. f4200b0
@spastorino spastorino Object#returning removed
Signed-off-by: José Valim <>
@spastorino spastorino CHANGELOG updated Object#returning removed
Signed-off-by: José Valim <>
@fxn fxn AS guide: Object#returning is gone 06853cb
@fxn fxn APIs for individual components are no longer published dcb7832
@tenderlove tenderlove do not execute the session tests within transactions df95948
@fxn fxn Merge remote branch 'docrails/master' 6aa1253
@spastorino spastorino Don't interpolate a blank string, avoid warnings 963c71e
@spastorino spastorino Bump up bundler 8abcd49
@spastorino spastorino Gemfile now makes use of platforms calls with blocks instead of elsif…
… logic to define dependencies over specific platforms
@tenderlove tenderlove fisting warning 53fbbf4
@tenderlove tenderlove using AREL from the environment if it exists 13df581
@spastorino spastorino Changed returning with tap on guides 93e6dd1
Commits on Jul 26, 2010
@wycats wycats Fix a bug where requires inside of autoloads were being added to the …
…autoloaded_constants list, causing mayhem. [#5165 state:resolved]
@josevalim josevalim Update to latest thor. 9789d22
@neerajdotname neerajdotname strengthening the rescue_from test suites
Signed-off-by: José Valim <>
@neerajdotname neerajdotname strengthening the test suite for rescue_from
Signed-off-by: José Valim <>
@wincent wincent doc: cleanup respond_to documentation
Signed-off-by: Wincent Colaiuta <>
@jreidinger jreidinger fix escaping id and parameters in path [#5137 state:resolved]
Signed-off-by: José Valim <>
@tchandy tchandy Removing unnecessary code [#5192 state:resolved]
Signed-off-by: José Valim <>
@lukaszx0 lukaszx0 Removed deprecated APIs in text and number helpers [#5156 state:resol…

They're deprecated since 2008. It's time to get rid of them.

Signed-off-by: José Valim <>
@neerajdotname neerajdotname No need to check for :uniq
[#5170 state:resolved]

Signed-off-by: José Valim <>
@spastorino spastorino Fixes usage message when running rails without --dev on a cloned rail…
…s repo
@spastorino spastorino This is for making sure const_missing is triggered without warnings 4ea1753
@bernerdschaefer bernerdschaefer XmlMini.rename_key emits valid xml with dasherize
This resolves issues for libraries which use '_' prefixed keys in their
attributes hash, such as Mongoid. A key like "_id" or "_type" will no
longer be converted to "<-id>" and "<-type>".

Signed-off-by: wycats <>
@texel texel Override new on proxy objects so that they never wrap nil or false. e56c9ef
@texel texel Test to ensure that falsy objects aren't wrapped by deprecation proxies 37d82f2
@spastorino spastorino Changed returning with tap on guides fd589db
@wincent wincent doc: cleanup respond_to documentation
Signed-off-by: Wincent Colaiuta <>
@fxn fxn Merge remote branch 'rails/master' b31c0ae
@tenderlove tenderlove fixing space errors 32844cb
@josevalim josevalim Move runtime back to the Thread.current dd61a81
@dhh dhh Prep for RC 856fc4b
@dhh dhh Rails version update e71815b
@spastorino spastorino missing requires added 4ac3ae0
@dhh dhh Make Rails 3 RC depend on Bundler RC 3bdaa09
@dhh dhh Spaces, people, spaces! 06b9531
@dhh dhh Add install script for testing gems locally f79f9a7
@nicksieger nicksieger JRuby should not need system_timer, and cannot install it either
Signed-off-by: Santiago Pastorino <>
@dhh dhh Fix deprecation message on info screen d283ca3
@chad chad fix bad logic in determining if in rails app subdir
Signed-off-by: David Heinemeier Hansson <>
@fastred fastred Fixed field_error_proc default example on guides 2e3a86a
@fxn fxn prefer %Q() over escaped double quotes 10815e6
@spastorino spastorino This is a hash in 1.9.2 a2ca9cb
Commits on Jul 27, 2010
@neerajdotname neerajdotname making comments have a consistent theme of narrative b357aed
@neerajdotname neerajdotname Merge branch 'master' of c77adb4
@neerajdotname neerajdotname making comments meaningful by correcting, adding and pruning d214925
@neerajdotname neerajdotname polishing comments f3409dc
@rohit rohit Fix app generator so that it uses the right app_name during rails:upd…
…ate rake task. [#5207 state:committed]

Signed-off-by: José Valim <>
@paulccarey paulccarey amended Contributing to Rails guide to advise to use bundler v1.0 to …
…avoid error messages with bundler
@neerajdotname neerajdotname adding comments to update_attribute method c9fe3c3
@neerajdotname neerajdotname Merge branch 'master' of 865d208
@neerajdotname neerajdotname clarifying description for class_attribute method e7920a3
@Lytol Lytol Frameworks are loaded in application.rb rather than config.rb accordi…
…ng to Rails 3 conventions.
@fxn fxn Revert "Frameworks are loaded in application.rb rather than config.rb…
… according to Rails 3 conventions."

This reverts commit 1793b21.

This commit had no risk, but docrails has a hard rule about touching code.
The contribution is appreciated, I hope you do not mind this technical
revert. I'll apply that to master with proper credit.
Commits on Jul 28, 2010
@fxn fxn adds test coverage for edge-cases of Array.wrap, and better documenta…
…tion for how it differs from Kernel#Array
@wycats wycats Add a header that tells Internet Explorer (all versions) to use the b…
…est available standards support. This ensures that IE doesn't go into quirks mode because it has been blacklisted by too many users pressing the incompatible button. It also tells IE to use the ChromeFrame renderer, if the user has installed the plugin.

This guarantees that the best available standards support will be used on the client.
@wycats wycats Forgot to check in this new file aa24ea4
@jonbuda jonbuda fixed joining of attributes when using find_or_create_by with multipl…
…e attributes through an association

Signed-off-by: Santiago Pastorino <>
@tenderlove tenderlove slight performance improvement when grabbing an arel table fe9d7ab
@wycats wycats Fix middleware test eff0749
@neerajdotname neerajdotname removing unused variable 194ec3d
@neerajdotname neerajdotname adding more test cases for expand_cache_key 3265af5
@neerajdotname neerajdotname test cases for rails_app_version in AS cache.rb 7d29627
@neerajdotname neerajdotname adding test for respond_to cache_key and cleaning up the ENV settings 4952a80
@neerajdotname neerajdotname updating description of how class_attribute works f3b50b1
@neerajdotname neerajdotname adding some comments to cattr_accessor method ff7e17d
@neerajdotname neerajdotname clarifying the instance_write option with an example eb902d6
@neerajdotname neerajdotname adding comment specifying that cattr_accessor also supports instance_…
…write and instance_rader option
@neerajdotname neerajdotname editing a sentence 2d601e4
@neerajdotname neerajdotname editing the documentation regarding :race_condition_ttl and :expires_…
…in option in AS cache
@josevalim josevalim More documentation to class_attribute. 7c3d479
@neerajdotname neerajdotname more documentation for update_attribute 51924d4
@neerajdotname neerajdotname adding punctuations 31f8a0c
Simon Tokumine removed ambiguity from autosave description f46e841
Commits on Jul 29, 2010
@tenderlove tenderlove avoid calling to_sql twice 1c030a3
@tenderlove tenderlove Shouldn't have committed this! Revert "avoid calling to_sql twice"
This reverts commit 1c030a3.
@neerajdotname neerajdotname superclass_delegating_accessor has been deprecated.
I am working on removing all traces of superclass_delegating_accessor from rails code base.
@neerajdotname neerajdotname putting receive method under tt 2df3655
@neerajdotname neerajdotname itsy bitsy changes to ActionMailer documentation daad445
@neerajdotname neerajdotname itsy bitsy changes to documentation 627d870
@josevalim josevalim Revert "Avoid uneeded queries in session stores if sid is not given."
First step to merge Rails and Rack session stores. Rack always expects to receive the SID since it may have different behavior if the SID is nil.

This reverts commit e210895.
@neerajdotname neerajdotname expanding on the will_change! method in documentation 1a6d762
@neerajdotname neerajdotname adding documentation regarding time_zone_aware_attributes and skip_ti…
@paulccarey paulccarey amended rails upgrade plugin instructions to be rails 2.3.x compatibl…
…e instead of former rails 3 format
@paulccarey paulccarey Merge branch 'master' of 2b2ee22
@neerajdotname neerajdotname moving time zone related documentation to timestamp.rb from base.rb e429453
Carl Lerche Add a missing require in 'active_support/core_ext/string/inflections' d04c6f2
@rorra rorra link_to_function now expects a piece of javascript code for the oncli…
…ck parameter


Signed-off-by: Santiago Pastorino <>
@neerajdotname neerajdotname updating documentation about lazy hooks in ActiveSupport a506d5a
@neerajdotname neerajdotname Adding documentation regarding lazy_load_hooks 3c3ff13
@tenderlove tenderlove PERF: avoiding splat args and reducing function calls f171bc6
@tenderlove tenderlove got the ternary backwards. somehow the sqlite tests passed! a7a6a2f
Commits on Jul 30, 2010
@fxn fxn edit pass to apply API guideline wrt the use of "# =>" in example code 755af49
@fxn fxn Merge remote branch 'rails/master' ccd4561
@tarmo tarmo Don't increment and then decrement the same counter when re-assigning…
… a belongs_to association

[#2786 state:committed]

Signed-off-by: Santiago Pastorino <>
@spastorino spastorino Bump up nokogiri to 55028a7
@spastorino spastorino This version is going to be outdated when new nokogiri versions are r…
@spastorino spastorino Bump up bundler version to rc.2 03fc2f0
Carl Lerche Add another missing require in 'active_support/inflector/inflections' d277b82
@rohit rohit API Docs: Use 'HTTP_AUTHORIZATION' and not :authorize as key in integ…
…ration tests.
@stve stve fix for rails app generator when using --pretend option
[#5245 state:committed]

Signed-off-by: Santiago Pastorino <>
@spastorino spastorino Make options an attr_reader 95e9ced
@fastred fastred Command Line Guide: changes all 'rails app' commands to 'rails new app' 8828651
@neerajdotname neerajdotname returns not returned . fixing documentation for reflection 0e20e3e
@spastorino spastorino AS gem doesn't depend on nokogiri so shows a nicer error if users hav…
…en't installed
@fxn fxn the main page of the API generated by the doc:rails task is README 05e0fa9
@fxn fxn if there's a Gemfile and doc:guides can't load RedCloth, print instru…
…ctions for bundler
@tenderlove tenderlove reducing function calls and using faster methods for testing d1c53a9
@tenderlove tenderlove fewer method calls, using faster methods when possible ecfb252
@tenderlove tenderlove reverting where() functionality, adding a test 834e304
Commits on Jul 31, 2010
@fxn fxn README.rdoc is your first impression, make sure it is clean
* Removes spurious markup from code blocks
* Integrates code blocks into ordinary paragraph flow
* Change link to the Rails Tutorial so that it points directly to the book
* Use proper RDoc markup for links
@fxn fxn Merge remote branch 'rails/master' 3d70998
@fxn fxn use the same amount of left indent in all code blocks of README.rdoc f7f5299
@fxn fxn fixes typo 1d1f810
@johanlunds johanlunds DHH forgot to remove JS, CSS in generated index.html [#5261 state:res…

Signed-off-by: Santiago Pastorino <>
Commits on Aug 01, 2010
@fxn fxn explains Array.wrap directly, rather by comparison with Kernel#Array …
…which is too obscure, leaves the comparison to document the differences, and adds a comparison with the related idiom that uses the splat operator
@spastorino spastorino Makes form_helper use overriden model accessors
[#3374 state:committed]
Commits on Aug 02, 2010
@carlosantoniodasilva carlosantoniodasilva Fix label form helper to use I18n and html options, without the need …
…of 'nil' text param:

  Before: f.label :title, nil, :class => 'title'
  After : f.label :title, :class => 'title'

[#5267 state:committed]

Signed-off-by: Santiago Pastorino <>
@spastorino spastorino Use AS::OrderedHash when trusting in the order of the hash 111234e
@prashants prashants Corrected the rake test:units and test:functionals description [#5251

Signed-off-by: Santiago Pastorino <>
@rohit rohit Failing test to check for route file corruption if legacy map paramet…
…er is used. [#5263 state:open]
@spastorino spastorino Makes rails destroy scaffold don't duplicate routes.draw do |map| |ma…
…p| when using the deprecated syntax

[#5263 state:committed]
@qoobaa qoobaa added failing touch propagation test
Signed-off-by: José Valim <>
@josevalim josevalim Add an internal (private API) after_touch callback. [#5271 state:reso…
@josevalim josevalim Merge branch 'master' of 2dfeb7b
@cehoffman cehoffman Add missing require in ActiveSupport::HashWithIndifferentAccess [#5189

Signed-off-by: José Valim <>
@sr3d sr3d ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 st…

Signed-off-by: José Valim <>
@fredwu fredwu Improved how AppGenerator generates the application name. It now dete…
…cts the current app name whenever possible. This means that renaming the residing directory will not effect the app name generated by AppGenerator.

[#5225 state:resolved]

Signed-off-by: José Valim <>
@josevalim josevalim Handle edge cases in the previous patch. 558ee6e
@paneq paneq test and fix collection_singular_ids= with string primary keys [#5125

Signed-off-by: José Valim <>
@josevalim josevalim Tidy up previous commit. e1344bf
@jreidinger jreidinger fix loading of different elements in array then int and string [#5036

Signed-off-by: José Valim <>
@neerajdotname neerajdotname Eager loading an association should not change the count of children
[#4971 state:resolved]

Signed-off-by: José Valim <>
@josevalim josevalim Remove duplicated logic. 9effe3c
@josevalim josevalim Bring returning back to ease migration. 88b5f93
@wycats wycats Sadly, this segv's in 1.8 :( 8aad678
Commits on Aug 18, 2010
@tenderlove tenderlove adding segv test c5a809e