Skip to content
This repository
  • 8,466 commits
  • 1,741 files changed
  • 52 comments
  • 43 contributors
This comparison is big! We're only showing the most recent 250 commits
Nov 08, 2011
Rahul P. Chaudhari rahul100885 Updated Rakefile as CHANGELOG has been renamed to CHANGELOG.md 8e56866
Vijay Dev vijaydev Merge pull request #3562 from rahul100885/rahul100885_work
Updated Rakefile as CHANGELOG has been renamed to CHANGELOG.md
5b21bfa
Aaron Patterson tenderlove Merge pull request #3572 from amatsuda/ar_exists_uniq_order
exclude ORDER BY clause when querying Relation#exists?
6e87281
Vijay Dev vijaydev Merge pull request #3574 from arunagw/refactor_testing_uncommitted_task
Refactor test:uncommitted task.
2843d3b
Vijay Dev vijaydev Merge pull request #3579 from arunagw/missing_md_in_changelog
CHANGELOG => CHANGELOG.md
fba28ec
Nov 09, 2011
Akira Matsuda amatsuda exclude ORDER BY clause when querying Relation#exists? 74c6e80
Arun Agrawal arunagw Refactor test:uncommitted task.
Thanks to @sobrinho (Gabriel Sobrinho)
5f826ea
Arun Agrawal arunagw CHANGELOG => CHANGELOG.md
I missed these in previous commit
f642724
Akira Matsuda amatsuda Modulize Rails console methods so that other console libraries such a…
…s Pry can include these methods
6d09f27
José Valim josevalim Merge pull request #3509 from amatsuda/console_extend_command_bundle
move Rails console top level methods to IRB context
4857339
José Valim josevalim Use head :no_content on the guides as well. f686d94
José Valim josevalim Merge pull request #3589 from amatsuda/console_extend_command_bundle_fix
Extend IRB right before starting IRB to remove dependency on IRB from Rails::Application
4c59170
José Valim josevalim Deprecated ActiveSupport::MessageEncryptor#encrypt and decrypt. 71e84a3
José Valim josevalim Don't marshal dump twice when using encryptor. a625523
Tyler Coville tylercoville Fixed error with 'rails generate new plugin' where the .gitignore was…
… not properly generated if --dummy-path was used and added test case
4934908
Nov 10, 2011
Akira Matsuda amatsuda Extend IRB right before starting IRB to remove dependency on IRB from…
… Rails::Application
a658fd2
Akira Matsuda amatsuda A test case to ensure that AC::Metal#response_body= always wraps the …
…given value in an Array in both Ruby 1.8 and 1.9 (refs #3581)
be7ab83
Alexey Vakhov avakhov Cosmetic fix in number_to_currency docs 983a2dc
Alexey Vakhov avakhov Fix and simplify highlight regexp b5c3987
Bogdan Gusiev bogdan AS::Callbacks#_define_runner refactored
Incapsulate the logic of keyed callback method definition and execution
in the separated method.
bf6e29e
José Valim josevalim Merge pull request #3581 from amatsuda/metal_response_body_19
AC::Metal#response_body= stores different value in Ruby 1.8 and 1.9
d2cfa98
José Valim josevalim Merge pull request #3593 from bogdan/callbacks
AS::Callbacks._define_runner better abstraction
c778f4e
José Valim josevalim Merge pull request #3591 from tylercoville/fix-plugin-new
Fixed error with 'rails generate new plugin' where the .gitignore was not
909e5cc
José Valim josevalim Merge pull request #3592 from avakhov/av-highlight-regexp
Fix and simplify highlight regexp
bdd76fb
José Valim josevalim self.class.name -> self.name (we are already inside a class). 80f96eb
Bogdan Gusiev bogdan AS::Callbacks.__run_keyed_callback: remove unused cache 08cc49b
Vijay Dev vijaydev Fixes deprecation warning about passing a template handler
in the template name while generating guide related pages
like index, layout and credits
74233d4
Vijay Dev vijaydev Checking the arity of the block passed to create_table
A recent change made to create_table does away with the
need for the block argument. Checking the arity will prevent the
mixing up of the two syntaxes.
b805c71
José Valim josevalim Merge pull request #3600 from vijaydev/migration_arity
Checking the arity of the block passed to create_table
23101de
Jean Boussier byroot Fix a tiny typo in custom validators documentation fd17ffc
Wojciech Wnętrzak morgoth fixed example code indentation 9ce5d51
José Valim josevalim Merge pull request #3603 from vijaydev/change_table_without_block_arg
Modify change_table to remove the need for the block argument
81fad6a
Nov 11, 2011
Vijay Dev vijaydev update ci file name in contributing guide b9aaa31
Vijay Dev vijaydev Modify change_table to remove the need for the block argument. 6e112e4
Vijay Dev vijaydev change_table bulk test case should check if the connection supports b…
…ulk alter
2e5c471
Cheah Chu Yeow chuyeow Fix "in memory" where it should be "in-memory". e34e4d4
Cheah Chu Yeow chuyeow Update Memcached website to its new one at http://memcached.org/. df5c9fd
José Valim josevalim Merge pull request #3607 from bogdan/callbacks
AS::Callbacks.__run_keyed_callback: remove unused cache
7352efa
Noé Froidevaux noefroidevaux Prevent multiple SHOW TABLES calls when a table don't exists in datab…
…ase.
27c5800
Aaron Patterson tenderlove Merge pull request #3609 from noefroidevaux/issue_3595
Prevent multiple SHOW TABLES calls when a table don't exists in database...
1c6d6b6
Vijay Dev vijaydev Revert "Fix "in memory" where it should be "in-memory"."
This reverts commit e34e4d4.

Reason: code changes are not allowed in docrails.
9fd0cd3
Bogdan Gusiev bogdan AS::Callbacks::Callback#_compile_option refactored 8483c7c
José Valim josevalim Merge pull request #3611 from bogdan/compile_options
AS::Callbacks::Callback#_compile_option refactored
b7052a0
Dimitar Dimitrov mitio Fix wording and minor typos in the Responder RDoc a766d83
Xavier Noria fxn Merge pull request #3613 from mitio/fix-actionpack-responder-docs
Fix wording and minor typos in the Responder RDoc
c3035e1
Prem Sichanugrist sikachu For what it's worth; Update `memcache-client` gem name 84908fa
André Arko indirect refactor RemoteIp middleware
- return the last forwarded IP before REMOTE_ADDR to handle proxies
- remove completely superfluous RemoteIpGetter class
- remove duplication of trusted proxies regexp
- remove unused constant from Request
- move comments from Request to where they are actually relevant
- edit comments for clarity of purpose

The original code (confusingly) tried to return REMOTE_ADDR both at the beginning and the end of the chain of options. Since REMOTE_ADDR is _always_ set, this is kind of silly. This change leaves REMOTE_ADDR as the last option, so that proxied requests will be assigned the correct remote IP address.
9432163
Nov 12, 2011
André Arko indirect defer calculating the remote IP until requested 317f4e2
Akira Matsuda amatsuda Unneeded require memoizable b74aedf
Jon Leighton jonleighton Merge pull request #3618 from amatsuda/ad_headers_unmemoizable
Unneeded require 'active_support/memoizable'
8f20d59
Santiago Pastorino spastorino Allow to use ruby-debug in 1.9.3 df300a7
Nov 13, 2011
Cheah Chu Yeow chuyeow Fix "in memory" where it should be "in-memory". a02b40a
Cheah Chu Yeow chuyeow Suggest a workaround for page caching and parameters instead of an un…
…helpful warning.
650ec89
Cheah Chu Yeow chuyeow Clearing cache in action caching is not "the exact same way" as with …
…page caching.
d9703fe
Cheah Chu Yeow chuyeow Fix bad English. f323b42
Jason Noble jasonnoble Add Tip about skipping to Section 3 if they want to come back to the …
…philosophy later
962c55d
Jason Noble jasonnoble Move paragraphs to flow better
- Give the user a way to know they are fully installed and ready to continue
ee10012
Jason Noble jasonnoble Use rails help new instead of rails new -h 6ac65c9
Jason Noble jasonnoble Updated wording on what 'rails new blog' did for the user
- Alphabetized the files/folders created
- Added link to Configuring Rails Applications
b778a7e
Jason Noble jasonnoble Updated wording to read better 194a42e
Jason Noble jasonnoble Move Tip up higher so users who are fine with SQLite can skip to the …
…next section
4bf057b
Jason Noble jasonnoble Fix typo 703d5c2
Jason Noble jasonnoble Update wording to flow better 434fbe4
Jason Noble jasonnoble Update order so they show up in the order they do in the scaffolding …
…output
094bb8e
Jason Noble jasonnoble Update wording to be more explicit on what the timestamp fields track 06a8d16
Jason Noble jasonnoble Update wording to read better 1394c54
Jason Noble jasonnoble Add link to AR Validations and Callbacks to further explain validations fc8f0a8
Jason Noble jasonnoble p.errors.full_messages is a little more human readable cb552f8
Jason Noble jasonnoble Be explicit about changing code 9b96f74
Jason Noble jasonnoble Make the guide more friendly
- Changed Rails 3.0 to 3.0+
3e3872b
Jason Noble jasonnoble Be explicit on where the show.html.erb is located 5e83491
Noé Froidevaux noefroidevaux Fix pull request #3609 bf6efa8
Jason Noble jasonnoble Grammar change c0ee497
Jason Noble jasonnoble Convert tables to table format 0774f22
Jason Noble jasonnoble Add output for add_index command a3156ac
Jason Noble jasonnoble Update guide to use Ruby 1.9 hash syntax 50a9de5
José Valim josevalim Merge pull request #3617 from indirect/remote_ip
refactor RemoteIp middleware
2591cc6
Vijay Dev vijaydev Revert "Update guide to use Ruby 1.9 hash syntax"
This reverts commit 50a9de5.

Reason: Let's keep the guides at 1.8 syntax
e1099eb
Vijay Dev vijaydev Revert "Use rails help new instead of rails new -h"
This reverts commit 6ac65c9.
c8c08bd
Vijay Dev vijaydev Revert "Move Tip up higher so users who are fine with SQLite can skip…
… to the next section"

This reverts commit 4bf057b.

Reason: Prefer to keep the configuration of all databases at the same
level
af51409
Vijay Dev vijaydev copy edits in getting started guide 3012230
Vijay Dev vijaydev Merge branch 'master' of github.com:lifo/docrails e0efe48
Jason Noble jasonnoble Move tooltip on re-running rails new with a different --database option 8971cca
André Arko indirect change tests to expect X-F-F over REMOTE_ADDR 8f0085a
André Arko indirect correctly raise IpSpoofAttackError message 2189bff
André Arko indirect turns out the tests expect remote_addrs.first 2d063c6
André Arko indirect remove ignored flag, fixes warnings 9c4532b
José Valim josevalim Merge pull request #3623 from indirect/remote_ip
Remote IP fixes/cleanup
d37e169
Yehuda Katz wycats Merge pull request #3622 from noefroidevaux/issue_3595
Fix pull request #3609
2ec8d52
Nov 14, 2011
Guillermo Iguaran guilleiguaran Upgrade Sprockets to 2.1.0
This version brings bug fixes for performance and caching.
e0eb229
Jon Leighton jonleighton Sync CHANGELOGs from 3-1-stable da02f79
Jon Leighton jonleighton Add note about syncing CHANGELOGs c7b8468
Jon Leighton jonleighton Merge pull request #3625 from guilleiguaran/sprockets-2.1.0
Upgrade Sprockets to 2.1.0
d023078
Guillermo Iguaran guilleiguaran Added therubyrhino to default Gemfile under JRuby 49cd6a0
Jon Leighton jonleighton Add note about checking postgres tests before release 4d8081b
Jon Leighton jonleighton Sync changelog entry ca3b468
Aaron Patterson tenderlove Merge pull request #3371 from yahonda/fix_ora_00932_error
Fix ORA-00932 error when trying to insert 0 to DATE type columns.
11c9fc9
Oscar Del Ben oscardelben use any? instead of !empty? af64ac4
Jon Leighton jonleighton rake release should push the tag 156784f
Jon Leighton jonleighton Add a note to REALEASING_RAILS about testing the gem locally before r…
…eleasing
be777b3
Yehuda Katz wycats Merge pull request #3628 from oscardelben/refactoring
use any? instead of !empty?
1df22bb
José Valim josevalim Merge pull request #3626 from guilleiguaran/include-therubyrhino-gemfile
Added therubyrhino to default Gemfile under JRuby
2088f1b
José Valim josevalim Speed up attribute invocation by checking if both name and calls are …
…compilable.
9fa329b
André Arko indirect cleaner names 00a0a4d
André Arko indirect memoize the relatively expensive remote IP code cda1a5d
André Arko indirect Return the calculated remote_ip or ip
This was an especially nasty bug introduced in 317f4e2, by the way that an instance of GetIp is not nil, but GetIp#to_s could sometimes return nil. Gross, huh?
4f2bf64
José Valim josevalim Merge pull request #3631 from indirect/remote_ip
Force calculation of remote IP before using || operator
25c9e44
André Arko indirect add test for bug fixed in 4f2bf64 b8c85de
Jon Leighton jonleighton Merge pull request #3632 from indirect/b8c85de
unit test for fix from a few minutes ago
c7ab43f
André Arko indirect GetIp#to_s should never return nil. That's icky. d743954
Gabriel Sobrinho sobrinho Failing test case for issue #3483 e1b79c5
Ryan Naughton RyanNaughton Fixes issue #3483, regarding using a mixture of ranges and discrete v…
…alues in find conditions. Paired with Joey Schoblaska.
63a22ca
Nov 15, 2011
Arun Agrawal arunagw Unused variable removed 76b6027
Sergey Parizhskiy HeeL made url to a github issues a bit shorter - no need in a page param w…
…hen it's a first page
df08273
Yehuda Katz wycats Merge pull request #3640 from indirect/remote_ip
GetIp#to_s should never return nil. That's icky.
6491aad
Jon Leighton jonleighton Revert "Merge pull request #3640 from indirect/remote_ip"
This reverts commit 6491aad, reversing
changes made to 83bf0b6.

See #3640 (comment) for
explanation.
8d1a2b3
rpq added comma bc00514
Nov 16, 2011
Vijay Dev vijaydev refactor test_multiple_of 83bf0b6
Aaron Patterson tenderlove Merge pull request #3634 from RyanNaughton/fixes_3483
Fixes 3483
9364043
Daniel Dyba dyba Changed Commands module to RailsCommands.
This is to avoid a conflict that occurs when you add Rake to
your Gemfile. There is a Commands Object in Rake that conflicts
with the Commands module in plugin.rb. See rails issue #1866.
21c5a0a
Daniel Dyba dyba Substituted RailsCommands for Rails::Commands 325abe9
Aaron Patterson tenderlove bundler treats trunk ruby as ruby 1.9, hack around that for now df5ec41
Aaron Patterson tenderlove fixing tests on PG 61228e9
Jon Leighton jonleighton Switch from marshal format to plain text for the encoding conversions…
… dump. This is for windows compatibility. Fixes #3644.
3a6a10a
Aaron Patterson tenderlove Merge pull request #2948 from atambo/master
schema_format :sql should behave like schema_format :ruby
43821bf
Aaron Patterson tenderlove removing some useless conditionals cef1e14
André Arko indirect Revert "Revert "Merge pull request #3640 from indirect/remote_ip""
This reverts commit 8d1a2b3, because I have fixed the issues this commit caused in the next commit.
f05ccf8
André Arko indirect :facepalm: Request#remote_ip has to work without the middleware 5621abd
Jon Leighton jonleighton Merge pull request #3608 from arunagw/unused_var_remove
Unused variable removed
a152fd3
André Arko indirect the object itself isn't the IP, #to_s is the IP a9044d0
James Adam lazyatom `ActiveRecord::Base#becomes` should retain the errors of the original…
… object.

This commit contains a simple failing test that demonstrates the behaviour we expect, and a fix. When using `becomes` to transform the type of an object, it should retain any error information that was present on the original instance.
73cb0f9
Jon Leighton jonleighton Merge pull request #3438 from lazyatom/becomes-includes-errors
Becomes includes errors
540e929
Jon Leighton jonleighton Merge pull request #3500 from olivierlacan/error-whitespace
CSS fix to prevent error output from being breaking out of body element.
272f2b7
Aaron Patterson tenderlove Move conditionals to separate tasks so they can be reused. 38d26b0
Aaron Patterson tenderlove Reduce schema format tests ca69408
Aaron Patterson tenderlove dbfile isn't supported anymore, so remove b96aaf8
Aaron Patterson tenderlove Join method uses empty string by default, so remove it 97ca635
Aaron Patterson tenderlove Adding a deprecation warning for use of the schema_info table. bb95e81
capps "denoted" instead of "donated"
"parentheses" instead of "use brackets"
64a3175
Aaron Patterson tenderlove No need to `readlines` then `join`, just use `read` :heart: 4c1a193
Aaron Patterson tenderlove Merge pull request #3649 from indirect/remote_ip
Fixes for Request#remote_ip (no middleware, all proxies)
70f9b74
Aaron Patterson tenderlove Initialize our instance variables. e367142
Vijay Dev vijaydev Merge pull request #3656 from arunagw/readline_to_read
No need to `readlines` then `join`, just use `read` :heart:
4148a7c
Vijay Dev vijaydev Merge pull request #3658 from arunagw/fix_initialize_var_name
It should be @calculated_ip not @calculate_ip
e6f3299
Nov 17, 2011
Alexander wildchild Fix impractical I18n lookup in nested fields_for c2b6f63
Arun Agrawal arunagw No need to `readlines` then `join`, just use `read` :heart:
same as 4c1a193
5ccd9bc
Arun Agrawal arunagw It should be @calculated_ip not @calculate_ip
We are using @calculated_ip. 
@calculate_ip is no where used
c3ae1d2
José Valim josevalim Merge pull request #3654 from wildchild/label_i18n
Fix impractical I18n lookup in nested fields_for
e2d3060
Alex Tambellini atambo Move schema_format :sql config setting from test.rb to application.rb
I've moved the schema_format :sql config setting to application.rb because you would
never enable this only for the test environment. If you use database constraints
or database specific data types you would want all of your environments to use them.
0af9308
José Valim josevalim Merge pull request #3663 from atambo/master
Move schema_format :sql config setting from test.rb to application.rb
d8b2b6a
Sunny Ripert sunny Guides: better example to find the last sent email 8d17af2
Oscar Del Ben oscardelben Cleanup of databases.rake psql env variables a89fabb
Aaron Patterson tenderlove Revert "Merge pull request #3603 from vijaydev/change_table_without_b…
…lock_arg"

This reverts commit 81fad6a, reversing
changes made to 23101de.

Conflicts:

	activerecord/test/cases/migration_test.rb
649f251
Aaron Patterson tenderlove Revert "Merge pull request #1163 from amatsuda/sexier_migration_31"
This reverts commit 0e407a9, reversing
changes made to 533a9f8.

Conflicts:

	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
	activerecord/test/cases/migration_test.rb
a2f14e2
Innokenty Mikhailov gregolsen updating API docstring so that user can infer default value 8d83e33
Xavier Noria fxn warn the user values are directly interpolated into _html translation…
… strings
d57d809
Aaron Patterson tenderlove allow people to set a local .Gemfile so that things like ruby-debug a…
…re not required for regular development
a437986
Xavier Noria fxn Revert "warn the user values are directly interpolated into _html tra…
…nslation strings"

Reason: After another round of discussion, it has been
decided to let interpolation deal with unsafe strings
as it should do.

This reverts commit d57d809.
1079724
Sergey Nartimov lest _html translation should escape interpolated arguments e8d57f3
Edward Anderson nilbus Fix a number_with_delimiter :separator example fe88745
Vijay Dev vijaydev Merge pull request #3669 from parndt/patch-1
Fixed typo: expect -> expected
96792d2
Nov 18, 2011
Vijay Dev vijaydev update guide: db:structure:dump produces structure.sql now 9b53406
Philip Arndt parndt Fixed typo: expect -> expected e375970
Philip Arndt parndt Fixed typo: expect -> expected bc9b1e0
Xavier Noria fxn release instructions: new section about docs generation 307fc12
Vijay Dev vijaydev Merge pull request #3666 from oscardelben/databases_rake_cleanup
Cleanup of databases.rake psql env variables
1c4564b
Sam Ruby rubys Stop db:seed from performing a reload of the db
Fix regression introduced by 38d26b0
42954c4
Jon Leighton jonleighton Merge pull request #3680 from rubys/master
This fix causes the AWDwR test to go back to being green on Rails master.
d4119e1
Prem Sichanugrist sikachu Update variable's name in the test case to reflect the class we're te…
…sting
0e2156d
Christos Zisopoulos christos Only used detailed schema introspection when doing a schema dump.
Fixes #3678
280b2b7
Vijay Dev vijaydev Merge pull request #3681 from sikachu/fix_test_variable
Update variable's name in the test case to reflect the class we're testing
581ba1d
Aaron Patterson tenderlove Merge pull request #3683 from christos/schema_introspection_speedup
Only used detailed schema introspection when doing a schema dump.
2debbe1
Vijay Dev vijaydev put back the removed eg 5a2db4c
Vijay Dev vijaydev remove unneeded params from issue tracker url 9d03529
Vijay Dev vijaydev Merge branch 'master' of github.com:lifo/docrails 48b580a
Aaron Patterson tenderlove some refactoring of the match method 76780c3
Aaron Patterson tenderlove breaking match down to smaller methods 494ab25
Aaron Patterson tenderlove pushing hash validation up 7459ba4
Aaron Patterson tenderlove move constants to methods since nothing else is using them 648f611
Aaron Patterson tenderlove stop doing is_a? checks on the resource type 33543ac
Aaron Patterson tenderlove cleaning up variable names to match method parameter names 636405d
Aaron Patterson tenderlove no need for type checking ecbae99
Aaron Patterson tenderlove copy options keys to the right place so that undo will work correctly 3178cc9
Aaron Patterson tenderlove require that all blocks have arity of 2 4589b24
Aaron Patterson tenderlove arity check has been pushed up, so no need for proc wrapping 163b645
Aaron Patterson tenderlove make sure to require the right deprecation warning file a8a4264
Aaron Patterson tenderlove remove the :path feature to redirects, since it cannot work 0809c67
Aaron Patterson tenderlove moving redirection to objects d34efdd
Aaron Patterson tenderlove Refactoring the redirect method for the router api. 99d94f1
Aaron Patterson tenderlove Revert "make sure to require the right deprecation warning file"
This reverts commit 9d725e3.
396ef44
Yehuda Katz wycats Merge pull request #3689 from arunagw/warning_removed_actionpack
Warning removed for shadowing variable
89bbb6c
Nov 19, 2011
Vijay Dev vijaydev mailer guide - update info about using default host. Fixes #3642 dda6787
Toshinori Kajihara kennyj Use `show index from`. We could fix `pk_and_sequence_for` method's pe…
…rformance problem (GH #3678)
f9b9179
Arun Agrawal arunagw Warning removed for shadowing variable d806ea2
Jon Leighton jonleighton Verify that #3690 has been closed by previous changes to the mysql
adapters.

These tests fail on the v3.1.2 tag.

Closes #3690.
9c37416
Jon Leighton jonleighton Merge pull request #3687 from kennyj/fix_3678-2
Use `show index from`. We could fix `pk_and_sequence_for` method's performance problem (GH #3678)
11afb74
Tobias Svensson tobiassvn Meaningful errors for unexpected partial arguments. Fixes #3573 771635e
Jon Leighton jonleighton Bump sprockets to 2.1.1 86b5e81
Jon Leighton jonleighton Don't html-escape the :count option to translate if it's a Numeric. F…
…ixes #3685.
603a679
Jon Leighton jonleighton Add missing CHANGELOG entry for #3678. Closes #3678. 2ef4947
Jon Leighton jonleighton Perf fix
If we're deleting all records in an association, don't add a IN(..)
clause to the query.

Fixes #3672.
fec85cf
Yehuda Katz wycats Merge pull request #3695 from tobiassvn/partial_path_error
Meaningful errors for unexpected partial arguments. Fixes #3573
bc04455
Sergey Nartimov lest fix rails plugin new CamelCasedName bug
refs #3684
39d2251
Sergey Nartimov lest fix warning about instance variable in plugin generator c220b4d
José Valim josevalim Merge pull request #3696 from lest/fix-plugin-generator
fix rails plugin new CamelCasedName bug
43158e5
Santiago Pastorino spastorino Merge pull request #3668 from gregolsen/api_docstring_fix
updating API docstring so that user can infer default value
4cdd44e
Aaron Patterson tenderlove pushing caching and visitors down to the connection bd2f5c0
Aaron Patterson tenderlove adding visitors to the respective adapters 24fa524
Aaron Patterson tenderlove Revert "copy options keys to the right place so that undo will work c…
…orrectly"

This reverts commit 3178cc9.
3d2bd69
Aaron Patterson tenderlove removing deprecated methods 599d7c4
Aaron Patterson tenderlove Merge pull request #3701 from arunagw/arel_bump
Bump Arel
26c542b
Nov 20, 2011
Arun Agrawal arunagw Bump Arel be9d3a2
Aaron Patterson tenderlove fixing tests on ruby 1.8 008abd1
Aaron Patterson tenderlove oops! I suck! :bomb: 5d704fa
Nov 21, 2011
Xavier Noria fxn a couple of spurious spaces I saw in passing 60e3e21
Xavier Noria fxn adds a comment to clarify an edge case 91678a5
Xavier Noria fxn cache entry: options[:compressed] is a regular flag, no need for !! f355477
Xavier Noria fxn tests predicates according to the boolean interpretation of their ret…
…urn value, not expecting specifically true or false
a539a5e
Xavier Noria fxn Revert "tests predicates according to the boolean interpretation of t…
…heir return value, not expecting specifically true or false"

Reason: there were some genuine tests for false when
reading values, going to revise those ones.

This reverts commit a539a5e.
f312e21
José Valim josevalim Deprecate InstanceMethods namespace handling in ActiveSupport::Concern.
This avoids the unnecessary "yo dawg, I heard you like include, so I put a module that includes your module when it is included" approach when building extensions.
401393b
Xavier Noria fxn tests predicates according to the boolean interpretation of their ret…
…urn value, not expecting specifically true or false

Respecting Genuine assert_equal false Edition
8f57bf2
Nov 22, 2011
Vijay Dev vijaydev Remove the -h option to dbconsole which is the shorter form of --header
This is done since the -h option to dbconsole hides the conventional
-h for help and forces users to use --help to see the usage options for
dbconsole.
4c872c0
Sergey Nartimov lest add ActionController::Metal#show_detailed_exceptions? a9e8cf7
Sergey Nartimov lest refactor show exceptions tests c6d6b28
Sergey Nartimov lest move show_detailed_exceptions? to Rescue module 5bcd119
Vijay Dev vijaydev remove nodoc on OrderedHash 8cae31c
Sergey Nartimov lest javascript_include_tag should add '.js' to sources that contain '.' aa491f6
Sergey Nartimov lest deprecation warning, changelog entry 3a1d519
José Valim josevalim Merge pull request #3717 from lest/show-exceptions-refactor
Show exceptions refactor: controller should be responsible for choice to show exceptions
39ecbfd
José Valim josevalim Merge pull request #3718 from lest/fix-javascript-include-tag
javascript_include_tag should add '.js' to sources that contain '.'
b13b49c
Marc-André Lafortune marcandre Make explicit the default media when calling stylesheet_tag and chang…
…e the default generators.
05e02de
Marc-André Lafortune marcandre Fix inconsistencies with Time{WithZone}#{hash,eql?} a491207
Yehuda Katz wycats Merge pull request #3724 from marcandre/media_default
stylesheet_tag default's media is "screen"
9b7be78
Yehuda Katz wycats Merge pull request #3725 from marcandre/twz_eql
Fix inconsistencies with Time{WithZone}#{hash,eql?}
a93ee92
Nov 23, 2011
Olek Janiszewski exviva Fix #3737 AS::expand_cache_key generates wrong key in certain situations
`cache_key` method is never called when the argument is a 1-element array
with something that responds to `cache_key`
d8e6dc9
Olek Janiszewski exviva Fix #3737 AS::expand_cache_key generates wrong key in certain situati…
…ons (part 2)

`nil` and `false` both expand to `""` (empty string), while `true` expands to
`"true"`; `false` should expand to `"false"`
a650dd0
José Valim josevalim Merge pull request #3735 from kennyj/fix_3728
Fix #3728 Remove unreachable code, and add additional testcases.
f62f545
José Valim josevalim Merge pull request #3738 from exviva/issues/3737_AS_cache_expand_cach…
…e_key

Issues/3737 AS::Cache.expand_cache_key
2c568f1
José Valim josevalim Optimize cache expansion by skipping rails cache id in nested keys. 3ee0116
José Valim josevalim Rely on a public contract between railties instead of accessing railt…
…ie methods directly.
fd86a1b
José Valim josevalim Merge branch 'master' into serializers e62de52
José Valim josevalim Add safe_constantize to ActiveSupport::Dependencies. 0536ea8
José Valim josevalim Implement ArraySerializer and move old serialization API to a new nam…
…espace.

The following constants were renamed:

  ActiveModel::Serialization     => ActiveModel::Serializable
  ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON
  ActiveModel::Serializers::Xml  => ActiveModel::Serializable::XML

The main motivation for such a change is that `ActiveModel::Serializers::JSON`
was not actually a serializer, but a module that when included allows the target to be serializable to JSON.

With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer.
8896b4f
José Valim josevalim Remove listings from the serialization guide that won't make 3.2. 6da52c6
José Valim josevalim Rely solely on active_model_serializer and remove the fancy constant …
…lookup.
7fcc8c0
José Valim josevalim Rename UserSerializer to DefaultUserSerializer in tests. 28bcda4
Nov 24, 2011
Toshinori Kajihara kennyj Remove unreachable code, and add additional testcases. ea70e02
Nov 25, 2011
José Valim josevalim Add generators for serializers. ebb8ea2
José Valim josevalim Add a hook for serializers in the scaffold generator (off for now). 6d9f9b3
José Valim josevalim Add docs to serializers. Update CHANGELOGs. 696d01f