Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: rails/rails
...
head fork: rails/rails
This comparison is big! We’re only showing the most recent 250 commits
Commits on Jun 09, 2008
@josh josh Fixed ambiguous first argument warning in ArrayExtTest. d2a3723
@josh josh Fixed deprecated call to Dependencies in plugin loader test. 8b65473
Commits on Jun 10, 2008
@jeremy jeremy Inflector -> ActiveSupport::Inflector 319941e
@jeremy jeremy PostgreSQL: insert looks up pk and sequence name if not given. [#384
…state:resolved]
a065144
Commits on Jun 11, 2008
@granth granth Performance: speed up Hash#except. [#382 state:resolved] a797375
@rubyruy rubyruy TimeZone -> ActiveSupport::TimeZone. [#387 state:resolved] 011b5ed
@DefV DefV Add :validate option to associations. [#301 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
23223ce
@lifo lifo Disable validations for associated belongs_to record by default e25e272
@lifo lifo Update docs to reflect 71bf75 535b988
@DefV DefV Fix FormOptionsHelper tests.
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
25a4327
@lifo lifo Silence TimeZone warning 20442ac
@DefV DefV Added some has_many tests
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
c83a183
Commits on Jun 12, 2008
@acangiano acangiano Fixed non-standard SQL generated by preloading has_and_belongs_to_man…
…y association. [#394 state:resolved]
4689496
@yukster yukster Add :from option to calculations. [#397 state:resolved] 67e8ec0
Commits on Jun 13, 2008
@lifo lifo Make rescue template xhtml compatible [Sam Ruby] [#415 state:resolved] f1a1e55
Commits on Jun 17, 2008
@akaspick akaspick Correct code example in dom_id docs. [#437 state:resolved] 4d83e9d
@adkron adkron verify :redirect_to => :back should redirect to the referrer. [#280 s…
…tate:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
b99c1c9
@oggy oggy Fix observers that use after_find. [#375 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
5c071a7
Luke Redpath Fix url_for with no arguments when default_url_options is not explici…
…tly defined. [#339 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
a83ac48
Commits on Jun 19, 2008
@jeremy jeremy Update Rakefiles to connect to wrath as current user. Use ssh config …
…to set a different user.
6a0929d
@jeremy jeremy Add pdoc task to toplevel Rakefile df98d4b
@jeremy jeremy Generate rdoc for all .rb files except those in vendor 4d45c09
@jeremy jeremy Generate rdoc for all .rb files except those in vendor 99b429f
@jeremy jeremy Exclude lib/actionpack.rb from rdoc 644e2cd
@jeremy jeremy Exclude lib/activeresource.rb from rdoc 8c95c8e
@jeremy jeremy Use native include/exclude instead of doing it by hand 55bd351
@jeremy jeremy Add lib/rails/*.rb to rdoc a4752c6
@jeremy jeremy Use rdoc exclude edb48d6
@jeremy jeremy Add dummy pdoc task to railties a46d09f
@jeremy jeremy Add toplevel rdoc and pdoc tasks 7084e88
@jeremy jeremy Require ssh publisher in toplevel Rakefile 1256bba
@jeremy jeremy fix toplevel pdoc task 271b834
@jeremy jeremy Add toplevel doc to .gitignore 8c0ce21
@bkeepers bkeepers fix eager loading with dynamic finders 7827b07
@technoweenie technoweenie Add the gem load paths before the framework is loaded, so certain gem…
…s like RedCloth and BlueCloth can be frozen. [#320 state:resolved]
924244b
@technoweenie technoweenie Fix discrepancies with loading rails/init.rb from gems. [#324 state:r…
…esolved]
e1bd75a
Commits on Jun 20, 2008
@jeremy jeremy Fall back to #to_s for cache key expansion 5f52da4
Commits on Jun 22, 2008
@jeremy jeremy Horo rdoc template 3a05ba6
@jeremy jeremy Remove incorrect master entries from 2-1-stable CHANGELOGs. Mark upco…
…ming stuff as 2.1.1 (next release) instead of Edge.
4573b7b
@oboxodo oboxodo MySQL: rename_column preserves default values. [#466 state:resolved] 9855d0b
@tarmo tarmo Named bind variables can now be used with postgresql-style typecasts
For example :conditions => ['stringcol::integer = :var', { :var => 10 }]
will no longer raise an exception about ':integer' having a missing value.
4ecc13b
@jeremy jeremy Changelog for 509374e 44656db
Commits on Jun 23, 2008
@tarmo tarmo Fixed that scopes defined with a string name could not be composed b31b6ef
@mraidel mraidel ActiveRecord::Migrator#run records version-state after migrating. [#369
… state:resolved]
7839a83
@iwarshak iwarshak Only use DROP ... IF EXISTS for PostgreSQL 8.2 or later. [#400 state:…
…resolved]
965848e
Tammer Saleh Fixed polymorphic_url to be able to handle singleton resources.
Example usage:
polymorphic_url([:admin, @user, :blog, @post]) # => admin_user_blog_post_url(@user, @post)

[#461 state:resolved]
0304bb1
@markcatley markcatley Fix column collision with named_scope and :joins. [#46 state:resolved] 3558a50
@danielmorrison danielmorrison Partial updates don't update lock_version if nothing changed. [#426 s…
…tate:resolved]
44b8907
@tarmo tarmo Always treat integer :limit as byte length. [#420 state:resolved] a2eab62
@jeremy jeremy Check for mocha gem without requiring the lib. [#403 state:resolved] 8636df7
@jeremy jeremy Revert "Check for mocha gem without requiring the lib. [#403 state:re…
…solved]"

This reverts commit 8636df7.
642b0e9
@chuyeow chuyeow Allow script/about to run in production mode instead of failing with …
…a cryptic const_missing error.

[#370 state:resolved]
c1ae8b9
Commits on Jun 24, 2008
@jeremy jeremy Treat any limit > 4 as bigint fe81af7
@jeremy jeremy Test for tinyint 6051249
Commits on Jun 25, 2008
@jimmybaker jimmybaker Patched HTML::Document#initialize call to Node.parse so that it inclu…
…des the strict argument. [#330 state:resolved]
02ffbc2
Commits on Jun 27, 2008
@DefV DefV Make sure associated has_many/habtm objects get saved even when :vali…
…date => false is used. [#486 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
be099c0
@jeremy jeremy MySQL: treat integer with :limit => 11 as a display width, not byte s…
…ize, for backward-compatibility.
a892af6
@chuyeow chuyeow Allow single quote (the ' character) in the middle of URL when auto_l…
…ink-ing. [#471 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
42612fe
@lifo lifo Ensure observer test inherits from ActiveSupport::TestCase 0fd6371
Commits on Jun 28, 2008
@jeremy jeremy Fix typo in apparently-dead will_unload? method. a42599d
@timchater timchater Dirty: recognize when an integer changes from zero to blank. [#433 st…
…ate:resolved]
692e595
@lifo lifo Ensure FormBuilder date helpers respects html_options. [#506 state:re…
…solved] [Pascal Ehlert]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>

Conflicts:

	actionpack/test/template/date_helper_test.rb
b416c68
Commits on Jul 02, 2008
Scott Stewart Ensure proper output when submit_tag is used with :disabled_with. [#388
… state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
67d5ac9
@lifo lifo Ensure AssociationCollection#size considers all unsaved record. [#305
…state:resolved] [sds]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
25ce688
@timhaines timhaines Make sure render :template works with :locals. [#524 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
6303ba0
Commits on Jul 03, 2008
@NZKoz NZKoz Deprecate define_javascript_functions in favour of javascript_include…
…_tag
a78750f
Commits on Jul 04, 2008
@dfl dfl Add :tokenizer option to validates_length_of. [#507 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
dd89462
@lifo lifo Use ActiveSupport::TimeZone in time:zones rake tasks 9d8fdc9
@jeremy jeremy Fix rdoc for Filters::ClassMethods ef0bd72
Commits on Jul 09, 2008
@NZKoz NZKoz Deprecate the limited follow_redirect in functional tests. If you wis…
…h to follow redirects, use integration tests.
c6a4c17
Commits on Jul 10, 2008
@clemens clemens Added notes to Routing documentation and routes.rb regarding defaults…
… routes opening the whole application for GET requests

Signed-off-by: Michael Koziarski <michael@koziarski.com>
6e58a25
Commits on Jul 15, 2008
@gbuesing gbuesing Fix TimeWithZone unmarshaling: coerce unmarshaled Time instances to u…
…tc, because Ruby's marshaling of Time instances doesn't respect the zone
e6ad7ff
@gbuesing gbuesing TimeWithZone: when crossing DST boundary, treat Durations of days, mo…
…nths or years as variable-length, and all other values as absolute length. A time + 24.hours will advance exactly 24 hours, but a time + 1.day will advance 23-25 hours, depending on the day. Ensure consistent behavior across all advancing methods
b44be6a
@jeremy jeremy PostgreSQL: don't dump :limit => 4 for integers e8c5859
@tarmo tarmo Fixed mysql change_column_default to not make the column always nulla…
…ble.

Also added change_column_null to both mysql and sqlite to keep the api features closer to postgresql.

[#617 state:resolved]
3f48a97
@jeremy jeremy Give more info on missing gems and abort instead of printing a warnin…
…g. App can begin in incomplete state otherwise.
0dcc81a
@ryankinderman ryankinderman Ensure plugins' rake tasks are loaded before application's rake tasks. [
#259 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
fc2fbe5
@lifo lifo Fix that Rails::InfoController tests ea1c1f2
@josh josh Wrap date part value method tests inside a uses mocha block. 88ff9e1
@jeremy jeremy Performance: faster Object.subclasses_of 0a11165
@jeremy jeremy Remove dead, unused vendor/db2.rb 7df1078
Luis Hurtado Fixes parsing deep nested resources from XML. [#380 state:resolved] 70a34cd
@jeremy jeremy PostgreSQL: use 'INSERT ... RETURNING id' for 8.2 and later. 44363ba
@jeremy jeremy Fix quoting in test_counting_with_single_conditions 4c6eed0
@jeremy jeremy Don't dump schema for every test run, just when migrations are run b6d0eba
@tarmo tarmo Oops, already had a postgresql_version method!
Conflicts:

	activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
8477fce
@badcarl badcarl Ensure Rails::Generator quotes file names while generating diff. [#264
…state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
85bd455
@rikas rikas Ensure script/plugin unsource 'Usage' text is correct. [#526 state:re…
…solved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
b27e64f
@NZKoz NZKoz Tighten the rescue clause here to prevent hiding strange mock related…
… errors behind the line offset test
0d96fcc
@NZKoz NZKoz Tighten the rescue clause when dealing with invalid instance variable…
… names in form_helper.
b32790c
@ctcherry ctcherry Allow Infinity (1.0/0.0) to pass validates_numericality_of. [#354 sta…
…te:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
d126600
@josh josh Fixed teardown method typo (plus whitespace) dde5d26
@NZKoz NZKoz Use require_dependency 'application' not require in the console boots…
…traps to avoid requiring application.rb twice
0826384
@tarmo tarmo Fixed that create database statements would always include "DEFAULT N…
…ULL" (Nick Sieger) [#334 status:committed]

Conflicts:

	activerecord/CHANGELOG
275c3ab
@tarmo tarmo Fixed test_rename_nonexistent_column for PostgreSQL
Also fixed ability to run migration_test.rb alone

[#616 state:resolved]
8a548e4
@gtd gtd Add assert_sql helper method to check for specific SQL output in Acti…
…ve Record test suite. [#325 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
97fa854
Tiago Macedo Fix integer quoting issues in association preload. [#602 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
84baada
@tarmo tarmo Fixed postgresql limited eager loading for the case where scoped :ord…
…er was present
aa99bd1
@tarmo tarmo SQLite: rename_column raises if the column doesn't exist.
[#622 state:resolved]
536400b
@jasondew jasondew Add block syntax to HasManyAssociation#build. [#502 state:resolve]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
04f7ac5
@miloops miloops update_counters should update nil values.
This allows counter columns with default null instead of requiring default 0.

[#493 state:resolved]
f253e98
Stefan Kaes Observers not longer add an after_find method to the observed class.
[#625 state:resolved]
6caaa02
Commits on Jul 16, 2008
@dfl dfl requiring rubygems version 1.1.1 97ac788
@josh josh Added Object#metaclass 98dd722
@josh josh Run callbacks from object's metaclass e0846c8
@josh josh Revert "Added Object#metaclass"
This reverts commit 98dd722.
7a84681
@josh josh Revert "Run callbacks from object's metaclass"
This reverts commit e0846c8.
82f3386
Commits on Jul 24, 2008
@tarmo tarmo Use :namespace instead of :path_prefix for finding controller. [#544
…state:resolved]

:namespace is supposed to be the module where controller exists.
:path_prefix can contain anything, including variables, which
makes it unsuitable for determining the module for a controller.

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>

Conflicts:

	actionpack/test/controller/routing_test.rb
Signed-off-by: Michael Koziarski <michael@koziarski.com>
8887f20
Commits on Jul 30, 2008
@josevalim josevalim Initializer skips prepare_dispatcher if Action Controller isn't in us…
…e. [#721 state:resolved]
931d462
@miloops miloops Prototype helpers should generate Element.insert instead of Insertion…
….new, which has been deprecated in Prototype 1.6.
f93e737
@josevalim josevalim Initializer requires ERB explicitly instead of assuming Action Pack l…
…oaded it. [#722 state:resolved]
af92dc5
@NZKoz NZKoz Set config.active_record.timestamped_migrations = false to have migra…
…tions with numeric prefix instead of UTC timestamp. [#446 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
af3f2aa
Commits on Jul 31, 2008
@NZKoz NZKoz Ensure dbconsole includes the -p parameter to mysql as intended 0498d32
Commits on Aug 07, 2008
@jeremy jeremy JRuby: improve constantize performance. [#410 state:resolved] 88eec83
Commits on Aug 12, 2008
@cwninja cwninja Serialized attributes will now always be saved even with partial_upda…
…tes turned on.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#788 state:committed]
decc973
Commits on Aug 13, 2008
@tarmo tarmo Fixed Time/Date object serialization
Time/Date objects used to be converted to_s instead of to_uaml
which made them unserializable.
dc5997f
@packagethief packagethief Account for the possibility of a nil options argument to CompressedMe…
…mCacheStore#read/#write
762ee05
Commits on Aug 15, 2008
@tarmo tarmo Use type_condition method for hmt STI condition 6660206
Commits on Aug 20, 2008
@jeremy jeremy Rely on quieter db:test:load task 482e8fe
Commits on Aug 24, 2008
@tarmo tarmo Don't set "NULL" as a constraint on nullable columns [#398 state:reso…
…lved]

This is already the default and adding it breaks SQL standards compatibility.

Conflicts:

	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
ddb8c9c
@josh josh Namespaced StringQuestioneer under ActiveSupport. 5b6fb7c
@josh josh Renamed StringQuestioneer to StringInquirer.
Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
9e65cbd
@tarmo tarmo Always require activesupport, even if its constant already exists
This is needed because the existance of the ActiveSupport
constant by itself does not guarantee that the whole library
has been loaded.

Also load the StringInquirer in the Rails#env method as
the it might be called inside the initializer block
before activesupport itself has been loaded.
69d9ec3
@jeremy jeremy link_to_function and button_to_function shouldn't modify their option…
…s hashes
99277f5
@chuyeow chuyeow Ensure url_for(nil) falls back to url_for({}). [#472 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
4fa6615
@lifo lifo Slightly faster DateTime#to_json. [#598 state:resolved] [Alex Zepeda] 50c73c2
Ripta Pasay Use fully-qualified controller name when logging. [#600 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
6fbd6c0
@josh josh All 2xx requests are considered successful [#217 state:resolved] 0e10e93
@js js Ensure mail_to label is obfuscated for javascript encoding. [#294 sta…
…te:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
8d61ead
@dguettler dguettler Ensure script/generate finds generators from symlinked plugins. [#449
…state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
84ceff6
@tapajos tapajos Use full path in database tasks so commands will work outside of Rail…
…s root [#612 state:resolved]

Signed-off-by: Joshua Peek <josh@joshpeek.com>
8c8399f
@dhh dhh Fixed that AssetTagHelper#compute_public_path shouldn't cache the ass…
…et_host along with the source or per-request proc's won't run [DHH]
82e6e48
@jgarth jgarth Make sure association preloading works with full STI class name [#465
…state:Resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
c3aad22
@dguettler dguettler Use klass.sti_name to make sure associations take store_full_sti_clas…
…s into account. [#671 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
c2f1918
@azimux azimux Make script/plugin work with svn+ssh urls. [#662 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
5f732b9
@oggy oggy Make observers define #after_find in the model only if needed.
[#676 state:resolved]
Signed-off-by: Michael Koziarski <michael@koziarski.com>
473d8d0
@DefV DefV Fix that label_tag doesn't take a symbol for a name. [#719 state:reso…
…lved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2752ceb
@tarmo tarmo Fixed test_joins_with_namespaced_model_should_use_correct_type for po…
…stgresql

Signed-off-by: Michael Koziarski <michael@koziarski.com>
e6bc5c6
@tarmo tarmo Cast value to string in validates_uniqueness_of if the column is of t…
…ext type

This fixes an error for postgresql where "text_column = 100" fails in version 8.3

Signed-off-by: Michael Koziarski <michael@koziarski.com>
6d8d77e
@tarmo tarmo Fixed negative default integer parsing for Postgresql 8.3.3
Signed-off-by: Michael Koziarski <michael@koziarski.com>
b999bb8
@miloops miloops In javascript helpers option[:type] = :synchronous should work as des…
…cribed in docs.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
4b2826a
@sandofsky sandofsky Make requiring gems optional.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#743 state:resolved]
3b76700
@ernie ernie Fixed AssociationCollection#<< resulting in unexpected values in @target
 when :uniq => true

Signed-off-by: Michael Koziarski <michael@koziarski.com>
e7b00c1
@mpolakis mpolakis Alias subquery used in calculations, to provide better compatibility …
…with databases such as MonetDB

Signed-off-by: Michael Koziarski <michael@koziarski.com>
Signed-off-by: Tom Ward <tom@popdog.net>
[#796 state:committed]
b6ad9a7
@alloy alloy Fix ActiveRecord::NamedScope::Scope#respond_to? [#818 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
56dc039
@tarmo tarmo Fixed STI type condition for eager loading of associations
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
fcc5a6e
@zerowidth zerowidth Updated has_and_belongs_to_many association to fix :finder_sql interp…
…olation. [#848 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
4c071bc
@tarmo tarmo Test for eager loading of STI subclasses from htm associations
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
893d762
@azimux azimux PostgreSQL: fix transaction bug that can occur if you call change_col…
…umn with invalid parameters

[#861 state:resolved]
6e71a35
@ryanb ryanb Support find_all on named scopes. [#730 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
38a0d5c
Jakub Kuźma Fix that has_one natural assignment to already associated record. [#854
… state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2242d3f
@fxn fxn Fix has_many#count_records. [#865 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
0048f55
@phallstrom phallstrom Fix generated WHERE IN query for named scopes. [#583 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2092f26
@cwninja cwninja Fix incorrect signature for NamedScope#respond_to? [#852 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
7688678
@wagenet wagenet Don't interpret decimals as table names in ActiveRecord::Associations…
…::ClassMethods#references_eager_loaded_tables? [#532 state:resolved]

Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
104220e
@tarmo tarmo Properly quote CREATE DATABASE parameters in postgresql [#771 state:r…
…esolved]
a661986
@tarmo tarmo Fixed ordering in test_find_in_association_with_custom_finder_sql_and…
…_multiple_interpolations
8e75057
@reagent reagent Ensure t.timestamps respects options. [#828 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
9c11b96
@tarmo tarmo Clear prefix_parameters cache when setting prefix
Conflicts:

	activeresource/test/base_test.rb
4e5e0b7
@josh josh Update uses_mocha in ActionMailer and ActiveResource 482f6aa
@tarmo tarmo Merge branch '2-1-unsure' into tarmo_2-1-unsure 11d9669
Commits on Aug 25, 2008
@tarmo tarmo Fixed merge mistake for 38a0d5c 0528758
@NZKoz NZKoz Merge commit 'tarmo/2-1-stable' into upgrade f477676
Commits on Aug 26, 2008
@fcheung fcheung Fix preloading of has_one through associations
[#903 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
fdeeeae
@fcheung fcheung Implement old-skool eagerloading for has_one :through
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
bff0f5f
@tarmo tarmo Load the first and not the last has_one result when doing join-based …
…eager loading

This matters when the has_one is defined with an order in which case
there is an expectation that the first one will be loaded.

[#904 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
6ae0a05
@tarmo tarmo Cache migrated versions list in Migrator and use it to fetch the late…
…st migrated version name [#845 state:resolved]

Also optimized Migrator#current_version class method to fetch
only the latest version number and not all of them.

With this change no matter how many migrations there are the
schema_migrations table is only SELECTed from once.

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
7d2b72f
@tarmo tarmo Use DECIMAL instead of INTEGER when casting as mysql doesn't work wit…
…h just "INTEGER" and other databases don't like "UNSIGNED" which mysql requires

And don't mask exceptions.

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
84c10b0
@jeremy jeremy fix tests relying on implicit ordering 698357b
@jeremy jeremy fix another ordering failure 71c53f6
@jeremy jeremy typo 8f03357
@jeremy jeremy um.. yeah 813290d
@tarmo tarmo Include mysql older than 5.1.23 in the 5.1 series in the list of thos…
…e that can't handle NULL defaults

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
ac7a020
@jeremy jeremy PostgreSQL: pg driver expects nil instead of empty string for missing…
… user/pass
d093e90
@tarmo tarmo Create mysql binary_fields table with latin1 character set as with ut…
…f8 all the limits would have to be divided by 3 to get the expected text types

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
eae903a
@jeremy jeremy fix tests relying on implicit ordering eab7611
@jeremy jeremy Include people and readers fixtures to fix test isolation error ad51406
@tarmo tarmo Back to fetching all versions in ruby instead of letting SQL do it as…
… it's difficult to get all databases to convert the text value to a number with the same SQL

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
946067e
@tarmo tarmo Added missing fixtures for tests which fail to run independently if r…
…un after schema reset

Signed-off-by: Michael Koziarski <michael@koziarski.com>
3a59bf0
@tarmo tarmo Just look at sql_type when testing that the correct database-specific…
… type was used

Signed-off-by: Michael Koziarski <michael@koziarski.com>
d92e461
@josh josh Updated bundled TZInfo gem to version 0.3.9 for Ruby 1.9 compat b4d13a9
Commits on Aug 27, 2008
pivotal Fix two has_one :through errors
* Set the association target on assignment;
* Reset target to nil on reset, rather than empty array.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#895 state:committed]
e710902
Luca Guidi Fix Ruby's Time marshaling bug in pre-1.9 versions of Ruby: utc insta…
…nces are now correctly unmarshaled with a utc zone instead of the system local zone [#900 state:resolved]
4d71e99
Commits on Aug 28, 2008
@timhaines timhaines Add TestUploadFile.content_type= to match Request.UploadedFile
[#920 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
dabd8c8
@jeremy jeremy respond_to? passes along splat args to avoid introducing the second a…
…rg if it was omitted
9aa3c59
@larskanis larskanis PostgreSQL: fix quote_string for certain old pg drivers. [#94 state:r…
…esolved]
b23b191
@michaelklishin michaelklishin Request#remote_ip handles the uncommon case that REMOTE_ADDR is a com…
…ma-separated list.

[#523 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
e21ed3e
@cwninja cwninja Dirty: treat two changes resulting in the original value as being unc…
…hanged.

[#798 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
a3a3067
@tarmo tarmo Alias included associations if needed when doing a count
[#302 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
0ed29df
@tarmo tarmo Implement count limit/offset support for has_many associations
[#348 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
367942d
@bfolkens bfolkens Reinstate Range#step default argument.
[#595 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
b090715
Commits on Aug 29, 2008
@jeremy jeremy Work around frozen Date memoization d4e668b
@jeremy jeremy Date#freeze bug doesn't affect Ruby 1.9 e27e1f0
@NZKoz NZKoz Fix NamedScope regex so methods containing "an" get delegated to prox…
…y_found

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#901 state:committed]

Conflicts:

	activerecord/lib/active_record/named_scope.rb
c379001
@NZKoz NZKoz Fix parentheses warnings 08b0c8d
@tarmo tarmo Make case insensitive validates_uniqueness_of use unicode aware downc…
…ase method. [#932 state:resolved]

Signed-off-by: Michael Koziarski <michael@koziarski.com>

Conflicts:

	activerecord/lib/active_record/validations.rb

Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
184ae2c
Commits on Aug 30, 2008
@jeremy jeremy Fix bad merge from e21ed3e e7df4ce
@r6p r6p Format related patches to support serializing data out in the correct…
… format with correct http request headers per http method type [#450 state:resolved]

Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
caabe22
@nbibler nbibler Added optional rake doc:app TITLE environment parameter
[#939 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
c87fea3
@miloops miloops Allow prototype functions to receive position parameter as a symbol.
[#887 state:resolved]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
c364c1f
Commits on Sep 02, 2008
@NZKoz NZKoz Merge rexml-expansion-fix gem into activesupport. 5a56dbb
Commits on Sep 03, 2008
Nigel Ramsay Inline help text was incorrectly telling user to uncomment line to us…
…e default local time. User should comment the line to use default local time.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#960 state:committed]
81d1c29
Commits on Sep 04, 2008
@tarmo tarmo Don't run 32bit dependant assertions in 64bit environments
Signed-off-by: Michael Koziarski <michael@koziarski.com>
40990e2
@technoweenie technoweenie use mocha for TimeZone mocking in Form Options helper tests
Signed-off-by: Tarmo Tänav <tarmo@itech.ee>
Signed-off-by: Michael Koziarski <michael@koziarski.com>
d278d6d
@josh josh Stub out timestamped_migrations in generator tests ae378b9
@FooBarWidget FooBarWidget Plugin locator: sort directory listing because we can't assume that t…
…he OS will do it for us. This fixes some unit test failures.
011cbbc
@NZKoz NZKoz Handle the case where there is no ivar set.
This happens on jruby due to a bug, but also on historically marshalled data.
cf51b17
@dhh dhh Push to temporary gem server until Wrath is back in shape 7398874
@dhh dhh Prepare for release of 2.1.1 02d610b
@dhh dhh Forgot to resolve one file d4eb3c0
Commits on Sep 07, 2008
@al2o3cr al2o3cr Ensure routing optimizations are cleared when new routes are added [#981
 state:resolved]

Signed-off-by: Joshua Peek <josh@joshpeek.com>
d4ef590
Commits on Sep 09, 2008
@NZKoz NZKoz Remove the Version check as it's not always available. 2689445
@NZKoz NZKoz Interpolation requires double quotes 437d716
Commits on Sep 10, 2008
@dhh dhh Add back version check for REXML but account for different constants 8f38577
@dhh dhh Add back version check for REXML but account for different constants …
…[state:committed #969]
0f98b3b
@dhh dhh Merge branch '2-1-stable' of git@github.com:rails/rails into 2-1-stable e48c62f
@dhh dhh Fixed FormTagHelper#submit_tag with :disable_with option wouldn't sub…
…mit the button's value when was clicked #633 [Jose Fernandez]
e3df552
@dhh dhh Remove merge clutter 42cfffc
rsl fixed association preloading to use = instead of IN when there's only…
… one record

[#1013 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
ba342c2
Commits on Sep 11, 2008
wmoxam Fixes validates_uniquness_of problem with case insensitive string con…
…taining newline characters

Signed-off-by: Michael Koziarski <michael@koziarski.com>
91c14e9
Commits on Sep 13, 2008
@mislav mislav Ensure Hash#except is allowed on a frozen hash. References #382
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
980c298
Commits on Sep 14, 2008
@gbuesing gbuesing Multiparameter attributes skip time zone conversion for time-only col…
…umns [#1030 state:resolved]
8bd62e3
Commits on Sep 18, 2008
@NZKoz NZKoz Revert API breaking changes in ActiveResource in preparation for 2.1.2
Revert "Format related patches to support serializing data out in the correct format with correct http request headers per http method type"

This reverts commit 16b9a55.
fd284d2
@tarmo tarmo Fix incorrect validates_uniqueness_of doc claiming default case_insen…
…sitivity [#883 state:resolved]

Signed-off-by: Michael Koziarski <michael@koziarski.com>
3f8c42b
@NZKoz NZKoz Deprecate country_select for 2.1, it's gone in 2.2
You can install the country_select plugin to obtain the same, possibly controversial, list of countries.
2d4e596
Commits on Sep 20, 2008
@adevadeh adevadeh applied patch to fix the associations with blocks in modules bug from…
… an old trac ticket
413c3f8
@technoweenie technoweenie Merge branch '2-1-stable' of git@github.com:rails/rails into 2-1-stable 2075824
Commits on Sep 22, 2008
@NZKoz NZKoz Bump the Version constants to align with the *next* release rather th…
…an the previous release.

This allows people tracking non-release gems or git submodules to use the constants.
f10e60f
Commits on Sep 23, 2008
adam Adds failed test case for slicing hash with indifferent access with s…
…ymbol keys

Signed-off-by: Michael Koziarski <michael@koziarski.com>
57e45ad
@NZKoz NZKoz slice now returns indifferent hash if called on one
Signed-off-by: Michael Koziarski <michael@koziarski.com>

[#1096 state:committed]

Conflicts:

	activesupport/lib/active_support/core_ext/hash/slice.rb
3b9c2fd
@NZKoz NZKoz Revert "Performance: faster Object.subclasses_of" as it breaks jruby.
This reverts commit 0a11165.
ec39711
Commits on Sep 24, 2008
@NZKoz NZKoz Handle quoting multibyte strings with newlines.
[#999 state:committed]
c75e711
@NZKoz NZKoz Partially revert 185fe2e
We shouldn't quote the unpack command's requirement as it's passed through GemRunner which takes care of it for us.
7d2201d
Commits on Sep 26, 2008
@tarmo tarmo Ignore all exceptions for validates_acceptance_of columns fetch so it…
… can run even without a database connection

Signed-off-by: Michael Koziarski <michael@koziarski.com>
4526e35
Commits on Sep 29, 2008
@willbryant willbryant wrote a test showing eager loading's misbehavior (sanitizing against …
…the wrong table) when the association has a :conditions hash

Signed-off-by: Michael Koziarski <michael@koziarski.com>
e34e6d6
@willbryant willbryant fix eager loading's :condition sanitizing expanding against the wrong…
… table

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1101 state:commited]
7823c50
Commits on Oct 03, 2008
@NZKoz NZKoz Remove AS for oracle compatibility 6370ff3
Commits on Oct 04, 2008
@lifo lifo Ensure Model.sum and Model.avg typecast appropriately. [#1066 state:r…
…esolved]

Model.sum delegates typecasting to the column being summed. If that's not feasible, returns a string.
Model.avg always returns big decimal.
78feaf6
Commits on Oct 05, 2008
@NZKoz NZKoz Reference more detailed documentation on the country_select issue rat…
…her than just recommending the country_select plugin.
03a6f74
@NZKoz NZKoz Update to 2.2 in the warnings cebfb5c
Commits on Oct 09, 2008
@al2o3cr al2o3cr Fix script/console --sandbox warning. [#1194 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
bbb2fda
Commits on Oct 17, 2008
@lifo lifo Fix Brasilia timezone. [#1180 state:resolved] 4a256d7
Commits on Oct 19, 2008
@NZKoz NZKoz Sanitize the URLs passed to redirect_to to prevent a potential respon…
…se spli

CGI.rb and mongrel don't do any sanitization of the contents of HTTP headers
9f9a6c4
Commits on Oct 20, 2008
@gbuesing gbuesing Bundle TzInfo version 0.3.11 75b017c
@gbuesing gbuesing TimeWithZone#freeze: preload instance variables so that we can actual…
…ly freeze
3f3e3eb
@geoffgarside geoffgarside Bump active_support/vendor.rb tzinfo version number [#1237 state:reso…
…lved]
318beb5
Commits on Oct 21, 2008
@lifo lifo Fix script/generate warning d956280
Commits on Oct 23, 2008
@dhh dhh Make ready for the 2.1.2 release 4cf5f9a
@dhh dhh Fix changelog for 2.1.1, all the 2.2.0 changes had snuck in there e929d74
@dhh dhh Latest release.rb script 15af6b3