Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: rails/rails
...
head fork: rails/rails
Checking mergeability… Don't worry, you can still create the pull request.
This comparison is big! We're only showing the most recent 250 commits
Commits on Aug 10, 2010
@fxn fxn fixes a typo reported by rymai b2eaac2
@josevalim josevalim Revert "require_dependency should require using the normal mechanism …
…if possible to avoid double-requires"

This was causing double requires since 991cd59 was reverted.
This reverts commit 8bf7973.
6f88b82
@goncalossilva goncalossilva added support for more printers d9b77dd
Commits on Aug 11, 2010
@nicksieger nicksieger Missed one spot for --skip-active-record, which means that new Gemfil…
…e isn't set up right

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
43b8722
José Valim & Carlos Antonio da Silva layout_for works again with objects as specified in the documentation…
… and Rails 2.3 [#5357 state:resolved]
1fbcd5f
@josevalim josevalim Ensure @config is not a reserved instance variable in controllers. [#…
…5342 state:resolved]
e1b85c3
@tenderlove tenderlove stop using private methods 8464ee0
@tenderlove tenderlove unless Array#empty? is faster than if Array#present? dac2b37
@tenderlove tenderlove avoiding tap saves us time a56ee4c
@tenderlove tenderlove dry up the hash dup and avoid sending nil values 5352a89
@tenderlove tenderlove avoid multiple hash lookups ff760dd
@fxn fxn no need to assign if we are gonna return bfd7281
@fxn fxn AS guide: some revisions 36cb62e
@tenderlove tenderlove subtracting blank strings is slightly faster than blank? c8509d5
@pavlos pavlos Raising exception if fixture file can't be found 1c970b8
Commits on Aug 12, 2010
@wycats wycats Replace snowman with utf8=✓ f2d22ec
@amerine amerine fixed indentation in test cases
Signed-off-by: wycats <wycats@gmail.com>
7325dd2
@josevalim josevalim Make update_attribute behave as in Rails 2.3 and document the behavio…
…r intrinsic to its implementation.
30ea923
@neerajdotname neerajdotname adding more documentation for autosave option 06af291
@neerajdotname neerajdotname updating documentation for named_scope and default_scope 198bffe
@fxn fxn commit review: applies guidelines to "# =>" 1e6e868
@pacoguzman pacoguzman applied guidelines to "# =>" ab68d4b
@fxn fxn revises some autosave docs, style and content 4dcce5d
@neerajdotname neerajdotname Ensure we can nest include calls [#5285 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
9528aa9
@gcampbell gcampbell Add missing ActiveModel::Validations require
[#5311 state: resolved]

ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport.  (This wasn't showing up in the tests, because it was
required in the helper, and was also required in
ActiveModel::Serialization).

Signed-off-by: José Valim <jose.valim@gmail.com>
d03a124
@subbarao subbarao tidy up validations length code [#5297 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
9df2279
@subbarao subbarao no callbacks should be created for empty array [#5289 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
fe2d658
@fxn fxn be more precise re :validate and :autosave 91ae6e9
@jeremy jeremy It's snowing! e428300
Commits on Aug 13, 2010
@tenderlove tenderlove symbol to proc is slow, we should avoid it fb6edb1
@tenderlove tenderlove do not use arel constants directly abd9736
@tenderlove tenderlove avoiding symbol to proc again e86b758
@tenderlove tenderlove removing references to arel constants bacf781
@tenderlove tenderlove avoid direct use of arel constants 108179b
@spastorino spastorino Moves local_request? to require.local?
[#5361 state:committed]
3698da6
@tenderlove tenderlove removing a lolinject 79e15f0
@sikachu sikachu Removing most of the symbol to proc usage in Active Record
This will hopefully make Active Record run a bit more faster.
433d7a2
@tenderlove tenderlove converting to a symbol is not necessary 59e63e7
Commits on Aug 14, 2010
@spastorino spastorino This method is actually not used, it's implemented on the concrete ad…
…apters

[#5331 state:committed]
6373dd4
@spastorino spastorino Makes AR use AMo to_key implementation ccd4364
@spastorino spastorino Deletes trailing whitespaces (over text files only find * -type f -ex…
…ec sed 's/[ \t]*$//' -i {} \;)
3270c58
@spastorino spastorino Fixes some ActionMailer tests 05ba082
@subbarao subbarao Adding missing required statement
[#5056 state:resolved]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
76c91a2
@spastorino spastorino deprected -> deprecated b3ece73
@mhayes mhayes in Rendering objects with RecordIdentifier example, locals should ref…
…erence @account not @buyer
f6f7ae4
@spastorino spastorino object/try should be required after abstract_unit to have AS in the l…
…oad path
677564f
@spastorino spastorino Both tests are using the same model, move the model to another file a…
…nd add the missing require
ecf59b4
@spastorino spastorino Add missing model 707248a
@spastorino spastorino Should be Boolean there a036999
Commits on Aug 15, 2010
@spastorino spastorino MySQL2 added to CI 477a9d4
@spastorino spastorino Makes topics.written_on null => true back again some tests rely on that 0f1b9bb
@spastorino spastorino connection reader is defined later 6d68cde
@spastorino spastorino Revert "connection reader is defined later"
This reverts commit f4cce71.
df8a941
@spastorino spastorino remove already defined method to avoid warnings ae7732f
@spastorino spastorino Makes use of class << self instead of def self. 5f7bfb1
@spastorino spastorino This is not needed anymore bdeeca3
@mikel mikel Making time_zone_options_for_select return a html_safe string
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
88fc37f
@josevalim josevalim to_key should return all exists keys (if any exists), regardless if t…
…he object is persisted or not. If you need it to reflect persistance, you should use to_param.
f224c66
@spastorino spastorino Revert "Makes AR use AMo to_key implementation"
This reverts commit ccd4364.
10177d3
@amerine amerine make rake routes print the name of a Rack endpoint app [#5338 state:r…
…esolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
ebf7447
@josevalim josevalim Improve routes task code and print the application as :to => RackApp. [
…#5338 state:resolved]
8520045
@brycethornton brycethornton Allow for any possible TLD when using the :all option with the cookie…
… session store. This works for subdomain.mysite.local, google.co.uk, google.com.au, etc. [#5147 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
1091a6e
@subbarao subbarao select tags coerce the :selected option, options to strings before co…
…mparison [#5056 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
dbe5ae4
@wycats wycats render :file in 2.3 behaved like render :template in Rails 3 (adding …
…the current controller as a prefix)
19fb031
@wycats wycats headers["X-Foo-Count"] = 2 is deprecated properly now 6883681
@wycats wycats find .text.html and .text.plain files, and deprecate it b8ec4ea
@wycats wycats Add back #callback and deprecate it a34dce9
@fxn fxn routing guide: wildcard segments are quite flexible, go beyond the si…
…mple use case
c330e96
@wycats wycats Test callbacks 83cb532
@wycats wycats Make sure apps upgrading from 2.3 get defaulted to UTF-8 (ht: parndt) 452a56a
Commits on Aug 16, 2010
@josevalim josevalim annoted_source_code may return nil if an erro rhappens during templat…
…e compiling.
047e411
@rsim rsim added dependencies in Gemfile for running ActiveRecord tests with Ora…
…cle database
d148092
@rsim rsim Replaced hardcoded SessionStore table creation SQL with calls to Acti…
…veRecord adapter migration methods

Otherwise hardcoded table creation SQL was failing on Oracle database
1d2e075
Commits on Aug 17, 2010
@fxn fxn the (public) routing DSL does not accept symbols for get|post|put|del…
…ete|match
14be178
@tobi tobi Added test case to verify that transaction callbacks are correctly pr…
…opagated to class observers

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
141634d
@spastorino spastorino assert_equal here 020aeb6
@fxn fxn code gardening: we have assert_(nil|blank|present), more concise, wit…
…h better default failure messages - let's use them
5f5c508
@wagenet wagenet Class Attribute setter returns set value
Signed-off-by: wycats <wycats@gmail.com>
b9281e8
@amerine amerine added testcase for belongs_to with a counter_cache and touch
[#5365 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
fc43c62
@spastorino spastorino Restore pet -> owner relationship to the previous state 6f478b0
@spastorino spastorino recommended is the right word here 22d242c
@josiahivey josiahivey Debugging Guide: Improve grammar for the RJS section 21063e5
@tsdbrown tsdbrown Added an example and explaination for using an optional path scope fo…
…r the locale
c11ba42
@fxn fxn debugging guide: revises the section on debugging RJS 4b21dfe
@Jeff-Lawson Jeff-Lawson Bug Fix -- clean up connection after stored procedure [#3151 state:re…
…solved]
90176a6
@Jeff-Lawson Jeff-Lawson Bug Fix -- clean up connection after stored procedure [#3151 state:re…
…solved]
82a58ab
Matthew Mongeau to_sentence should return a duplicate 92f4cca
@treybean treybean Missing object for comparison in ActiveModel::EachValidator example c…
…ode.
017840b
@fxn fxn you rarely want ^ or $ in validations, use \A when you mean \A 23303d6
@indirect indirect Allow member actions (get, etc) to accept strings, with test c40856c
@wycats wycats Sadly, this segv's in 1.8 :( 0a41ece
@wycats wycats 1.8 block variable shadowing strikes again 588ac71
Commits on Aug 18, 2010
@spastorino spastorino Bump up rdoc to 2.5.10 82eff0f
Javier Martín Don't pluralize resource methods [#4704 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
12f7f7a
@tenderlove tenderlove call to present? is not necessary 7e85b16
@tenderlove tenderlove refactoring to remove duplicate logic 2f6383e
@wycats wycats Revert "It's snowing!"
This reverts commit e428300.
0663257
Commits on Aug 19, 2010
@fxn fxn get rid of the warning "+ after local variable is interpreted as bina…
…ry operator even though it seems like unary operator" in Ruby 1.9.2
ddce48a
@fxn fxn avoids a ton o warnings activesupport/lib/active_support/dependencies…
….rb:239: warning: loading in progress, circular require considered harmful ... activesupport/lib/active_support/core_ext/hash/indifferent_access.rb while running the suite in Ruby 1.9.2
6580c6d
@fxn fxn now for real, the suite loads everything and these went unpatched 632a224
@fxn fxn avoids warnings about mismatched indentations in Ruby 1.9.2 6fb6ddb
@tenderlove tenderlove refactor if / else to ||= a16ec2f
@jeremy jeremy Memoize STI class lookups for the duration of a request 64f4dc6
@spastorino spastorino We need bundle update only here bef90f8
@tenderlove tenderlove we should wrap strings as sql literals 1ef9b98
@tenderlove tenderlove removing useless ternary 49e406e
@spastorino spastorino Bump up rack-mount to 0.6.10 21c9795
@neerajdotname neerajdotname While creating a new record using has_many create method default scop…
…e of child should be respected.

author.posts.create should take into account default_scope
defined on post.

[#3939: state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
758f01d
@pixeltrix pixeltrix Move edit route before show route so that it will have precedence if …
…the :id parameter allows slashes [#5409 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
1031fe1
@pixeltrix pixeltrix Move regexps in options hash to :constraints hash so that they are pu…
…shed into the scope [#5208 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
6b52a58
@josevalim josevalim Use attribute readers as they are faster in general. 8f2b278
@pixeltrix pixeltrix Optimize find_sti_class when store_full_sti_class is true
[#5403]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
ad06326
Commits on Aug 20, 2010
@tenderlove tenderlove updates return number of rows matched rather than number of rows affe…
…cted
e509d4a
@spastorino spastorino Bump up tzinfo to 0.3.23 ac66de4
@tenderlove tenderlove fisting after_rollback and after commit callbacks 809a04b
@fxn fxn the pdoc task is no longer needed d033b23
@fxn fxn deletes the rdoc task of each component, they are no longer published…
… separately
20088f6
@pixeltrix pixeltrix Allow symbols for :path resource(s) option [#5306 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
c6391e6
@pixeltrix pixeltrix Don't add the standard https port when using redirect in routes.rb an…
…d ensure that request.scheme returns https when using a reverse proxy.

[#5408 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
47280f0
@neerajdotname neerajdotname after_validation should be called irrespective of the result of valid…
…ation.

I confirmed that this is the behavior on 2.3.x .

[5419 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
8f72ddc
@tenderlove tenderlove adding FOUND_ROWS to the connect flags for mysql2 612c233
@pixeltrix pixeltrix Support routing constraints in functional tests
Extend assert_recognizes and assert_generates to support passing
full urls as the path argument. This allows testing of routing
constraints such as subdomain and host within functional tests.

[#5005 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
47f6d8b
@nicksieger nicksieger Fix hash modification during iteration in Mapper [#5420]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
b4a5208
Commits on Aug 21, 2010
@fxn fxn requires horo 1.0.2 9011f8f
@fxn fxn prevent RDoc from autolinking "Rails" in the API home page 68e2d1e
@jeremy jeremy Revert "Just add connection management middleware if running in a con…
…current environment."

This reverts commit 6b29dc8.
d0e3323
@brianmario brianmario reload bob after his journy to a new timezone 7dbc99e
@Raphomet Raphomet Trifling typos
[#5422 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
b4e5da6
Commits on Aug 22, 2010
@spastorino spastorino Move encoding settings for testing purposes to abstract_unit file 11e9883
@spastorino spastorino Set default_internal and default_external on AM for testing purposes e88f8be
@spastorino spastorino Set default_internal and default_external on AS for testing purposes 2106782
@pixeltrix pixeltrix Cache the symbolized path parameters using a instance variable in the…
… request object rather than the environment hash. This it to prevent stale parameters in later routing constraints/redirects as only the normal path parameters are set by Rack::Mount.

Also if a constraint proc arity is more than one, pass the symbolized path parameters
as the first argument to match redirect proc args and provide easier access.

[#5157 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
df0a7bf
@spastorino spastorino Fix namespace problem on object which inherit from ActiveSupport::Bas…
…icObject
7cb44a5
@spastorino spastorino Silence warnings for Encoding.default_external= and Encoding.default_…
…internal=
0579963
@tenderlove tenderlove removing duplicate tests 6ca6ef2
@spastorino spastorino type fixed 8235c92
@spastorino spastorino Bump up rack-mount to 0.6.12 6edae45
@rsim rsim updated test_should_record_timestamp_for_join_table for Oracle bedf6a0
@rsim rsim Do not use time zone in test_read_attributes_before_type_cast_on_date…
…time for Oracle database

As currently string_to_time method is not doing time zone conversion to database time zone
2c81a31
Commits on Aug 23, 2010
@fxn fxn adds USAGE to the generator generator USAGE (not sure this meta thing…
… is any good at 8:12 AM with little coffee)
d125687
@fxn fxn generators guide: edit pass b97ad85
@fxn fxn removes words moved in previous edit of the generator generator USAGE 2570fda
@rsim rsim use database from ARUNIT_DB_NAME environment variable when running te…
…sts on Oracle
f10fb1c
@brianmario brianmario no need to depend on mysql2 master anymore
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
ab64dc9
@brianmario brianmario mysql2 adapter is being maintained in the mysql2 gem itself
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
ce04ea9
@tenderlove tenderlove we should mark strings as SQL Literal values eeb9b37
@tenderlove tenderlove sql literal strings should be marked as sql literal strings 1cc653f
@tenderlove tenderlove we should mark sql strings as sql literals 6a1ea88
Commits on Aug 24, 2010
@josevalim josevalim Update CHANGELOG for ActionPack. a1ca2e0
@tenderlove tenderlove marking sql literals as sql literals 36fcc99
@spastorino spastorino Config is deprecated on 1.8.8 and 1.9.3 use RbConfig c8b84a1
@dhh dhh Prep for RC2 8931dd1
@dhh dhh Prefer the mysql2 gem for MySQL database.ymls fc6db62
@dhh dhh Depend on latest Bundler RC 880eaa1
@spastorino spastorino Point guides to bundler 1.0.0.rc.6 aafb290
@dhh dhh Depend on latest arel RC bc61196
@dhh dhh Bump rails version 04aa14f
@dhh dhh mysql db defaults to mysql2 gem 822fa17
Krekoten' Marjan Fix test of generated Gemfile with mysql selected as DB driver
[#5435 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
5708412
@pixeltrix pixeltrix When custom resource actions are specified using strings add the defa…
…ult name and action if the string is a valid ruby method name.

[#5431 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
8feb285
@josevalim josevalim Fix a bug where symbols and strings were not behaving the same in the…
… router. [#5431 state:resolved]
7a7012c
@wincent wincent Add test case for ActiveRecord::Base.record_timestamps = false
This is a failing test case for Lighthouse ticket #5440:

  https://rails.lighthouseapp.com/projects/8994/tickets/5440

Signed-off-by: José Valim <jose.valim@gmail.com>
5ccdb36
@josevalim josevalim Ensure timestamps are not generated when explicitly set to false [#5440
… state:resolved]
c857bd2
@tilsammans tilsammans fix broken relative links [#5415 state:committed]
Signed-off-by: Xavier Noria <fxn@hashref.com>
a32f46d
@josevalim josevalim Ensure prefix in routes are generated properly. 6579173
@pixeltrix pixeltrix Reset symbolized path parameters when a test request is recycled [#5437
… state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
78486cb
@neerajdotname neerajdotname @user.touch should not fail if User does not have updated_at/updated_…
…on column.

[#5439 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
aa384de
@ktheory ktheory Bump rake dependency to 0.8.4. [#5279 state:resolved]
This rake version adds the Rake::RDocTask#rdoc_task_name method, used in
railties/lib/rails/tasks/documentation.rake

Signed-off-by: José Valim <jose.valim@gmail.com>
d8196bf
@spastorino spastorino Allow actions which start with A-Za-z_ only 7830f8d
@josevalim josevalim Fix how routes inside namespaces are generated. 6d1e87b
@josevalim josevalim Hide internal apps from rake routes [#5443 state:resolved] 6b54a6a
@josevalim josevalim Ensure shortcuts inside resources also generates helpers. 91916e6
@josevalim josevalim Finally fix the bug where symbols and strings were not having the sam…
…e behavior in the router.

If you were using symbols before for methods like match/get/post/put/delete, it is likely that this commit will break your routes.
Everything should behave the same if you are using strings, if not, please open up a ticket.
0d7b8f8
@josevalim josevalim Allow format to be skipped. This is used internally by mount. 3a831cb
@neerajdotname neerajdotname unscoped does not work when chained with named_scope 2ae4f01
@trevorturk trevorturk Note about how to exit the console in the Getting Started guide 174d5cd
@neerajdotname neerajdotname touch operationg if used along with belongs_to will also be invoked o…
…n associated objects
78f6f0d
@fxn fxn edit pass to a recent doc patch 5deeb43
@fxn fxn :nodoc:s #unscoped until its behavior is more clear, now sometimes wo…
…rks, sometimes not
30dcac2
Commits on Aug 25, 2010
@pixeltrix pixeltrix Use nested scope for routes defined at the :resources scope level (as…
… in Rails 2.3)

Signed-off-by: José Valim <jose.valim@gmail.com>
37467bf
@mikel mikel Make ActiveResource::InvalidRequestError more user friendly
Signed-off-by: Xavier Noria <fxn@hashref.com>
d887dbc
@pixeltrix pixeltrix Remove rails info route from rake routes output [#5452 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
55c1f35
@mackuba mackuba better callstack reporting in deprecation messages
now the reported line is the first line in the stack
that's outside Rails, which is the one that actually
caused the problem in the first place

[#5231 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
aec0849
@tenderlove tenderlove mark SQL literals as SQL literals e991f39
@tenderlove tenderlove run tests in verbose mode bfe956d
@tenderlove tenderlove refactor select { is_a? } to grep() da7a280
@tenderlove tenderlove no need to send on a public method 3dc9880
@tenderlove tenderlove use blank? instead of present?, mark SQL literals as SQL literals 9ba46cf
@pixeltrix pixeltrix Catch mysql2 access denied errors in rake db:create [#5432 state:reso…
…lved]

Signed-off-by: Xavier Noria <fxn@hashref.com>
241dfa3
@fxn fxn AS guide: Array.wrap vs splat is only valid for 1.8 8bad8ac
@neerajdotname neerajdotname minor formatting fixes 61292a1
@rymai rymai Fixed a missing simple quote. e12ff5b
@rymai rymai Restore consistency with the rest of the doc. d810854
@tilsammans tilsammans remove unwanted linebreak 2722c82
@tilsammans tilsammans change rdoc to conform to api guidelines 908544c
@tilsammans tilsammans fixed capitalization 3b3cfa4
@tilsammans tilsammans Restored top-level documentation for ActionController::Base.
This information was lost in commit bd6b61b.
This might have been intentional, but this class does represent the starting
point for all things related to actions, and as such should document it.

I couldn't find any trace of this documentation, which seems like a waste.
Updated parts here and there to conform to current best practices.
6a03509
@bensie bensie Fix typo, favour => favor d7f1226
@bensie bensie mysql2 is now the default, typos 59cd141
@bensie bensie to_json => as_json 3ecbae0
@apohllo apohllo - Fix non-ascii characters in headers
Signed-off-by: Xavier Noria <fxn@hashref.com>
6068547
@fxn fxn adds missing require for #parameterize 27512c2
Commits on Aug 26, 2010
@fxn fxn Revert "to_json => as_json"
This reverts commit 7a6d8e4.

Reason: The method that gives you a Ruby string with JSON source code is #to_json
dcdb8ba
@jaimeiniesta jaimeiniesta Fix capture_helper.rb api documentation, unescaped script tag was bre…
…aking it on the content_for explanation
217fb3e
@jaimeiniesta jaimeiniesta lifecycle should be two words, life cycle a316109
@jaimeiniesta jaimeiniesta change 'a SQL' to 'an SQL' as suggested by the api documentation guid…
…elines
1c2a2f7
@fxn fxn revises a few link texts ace0f87
@fxn fxn getting started guide: revises text wrt bundler 9df512b
@josevalim josevalim Ensure templates like template.html are found but still uses the prop…
…er virtual path.
b780113
@josevalim josevalim Add clear_helpers as a way to clean up all helpers added to this cont…
…roller, maintaing just the helper with the same name as the controller.
52e9620
@josevalim josevalim Update CHANGELOG. daf2f95
@josevalim josevalim Do not modify frozen strings in place. d806aa2
@josevalim josevalim Doh, be sure to store the string modification. 473feeb
@josevalim josevalim Be sure to call helper :all just on direct children. (Tests by Jesse …
…Storimer)
a2d3e6e
@fxn fxn getting started guide: adds a reference to Michael Hartl's free onlin…
…e book in the what's next section
2af7f29
@fxn fxn updates de title of the generators guide in the home and index 983a5e2
Commits on Aug 27, 2010
@carlosantoniodasilva carlosantoniodasilva Removing some unuseful begin/end and refactor prompt_option_tag a bit
[#5469 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
39f2f18
@jeremy jeremy Ruby 1.9: be sure to explicitly reference toplevel constants within B…
…asicObject deprecation proxies
e8a083e
@spastorino spastorino Make InstanceTagMethods#value_before_type_cast raise if the model don…
…'t respond to attr_before_type_cast or attr method

[#3374] [#5471 state:committed]
3ba8e31
@josevalim josevalim Add missing require. dbbf198
@saarons saarons Fix em_mysql2 error in rake db:create
Signed-off-by: José Valim <jose.valim@gmail.com>
ba03dd4
@fxn fxn adds a comment in cli.rb so that it is clear that exec_script_rails! …
…performs an exec call
e2d73f0
@fxn fxn solves everything in guides raised by WARNINGS=1 (except for one whic…
…h is abandoned atm)
c144f50
@tilsammans tilsammans expand cookie examples with signed and permanent methods 6c84fd8
@tilsammans tilsammans mention the alert and notice accessors on the flash 5502a78
@tilsammans tilsammans escape constants that should not be linked to 8da4576
@tilsammans tilsammans Use common terminology 0c87873
Commits on Aug 28, 2010
@pixeltrix pixeltrix Read the route name directly from the route instead of looking it up …
…in the named routes hash

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
7f83aef
@spastorino spastorino type="password" for password_fields bf35d1e
@tchandy tchandy Fixing typo [#5485 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
cc5a9c6
@yury yury Micro optimization for build_named_route_call in PolymorphicRoutes:
1. use map instead of inject
2. use [].join("_") instead of '<<'. It is a little bit faster for ruby 1.9.2 and x2 faster for ruby 1.8.7. http://gist.github.com/548143

[#5450 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
331234e
@fredwu fredwu Fixed the session name generated by the app_generator. Also refactore…
…d the corresponding test suites to be cleaner. [#5434 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
3edd3d0
@jstorimer jstorimer Ensure that inherited helper_methods are available after calling clea…
…r_helpers [#5348 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
ef01f88
@jeremy jeremy Clean up CHANGELOGs 0f94ca3
@mperham mperham Support pluggable cache stores.
[#5486 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
90d4a19
Commits on Aug 29, 2010
@spastorino spastorino PERF: Avoid two method calls 15e9b53
@josevalim josevalim Ensure we are not calling length on nil. a2c547f
@rubys rubys Make rake routes gracefully handle routes with no name
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
829df80
@dhh dhh Prep for final release 851552b
@dhh dhh Depend on Bundler 1.0 w/ tiny fixes 647ed22
@dhh dhh Depend on ARel 1.0 w/ tiny fixes b63b6c4
@dhh dhh No more build 9f9c50f
@spastorino spastorino No more beta or rc on guides ca73b5b
@spastorino spastorino Make CI install bundler stable since 1.0 is out a8a9f00
@spastorino spastorino -v=1.0.0 not needed 3d0c928
@fxn fxn revises a deprecation message c7106e8
@fxn fxn implements String#strip_heredoc e38fa05
@lsegal lsegal Add .yardopts so YARD can document Rails 9891ca8
Commits on Oct 13, 2010
@NZKoz NZKoz Revert 0c0b0aa which introduced a security vulnerability.
This addresses  CVE-2010-3933
2d96bcc
Commits on Oct 14, 2010
@NZKoz NZKoz Prepare for the 3.0.1 release bac6ba9