Skip to content
This repository
  • 330 commits
  • 301 files changed
  • 53 contributors
This comparison is big! We're only showing the most recent 250 commits
Aug 10, 2010
Xavier Noria fixes a typo reported by rymai b2eaac2
José Valim Revert "require_dependency should require using the normal mechanism …
…if possible to avoid double-requires"

This was causing double requires since 991cd59 was reverted.
This reverts commit 8bf7973.
Gonçalo Silva added support for more printers d9b77dd
Aug 11, 2010
Nick Sieger Missed one spot for --skip-active-record, which means that new Gemfil…
…e isn't set up right

Signed-off-by: Santiago Pastorino <>
layout_for works again with objects as specified in the documentation…
… and Rails 2.3 [#5357 state:resolved]
José Valim Ensure @config is not a reserved instance variable in controllers. [#…
…5342 state:resolved]
Aaron Patterson stop using private methods 8464ee0
Aaron Patterson unless Array#empty? is faster than if Array#present? dac2b37
Aaron Patterson avoiding tap saves us time a56ee4c
Aaron Patterson dry up the hash dup and avoid sending nil values 5352a89
Aaron Patterson avoid multiple hash lookups ff760dd
Aaron Patterson subtracting blank strings is slightly faster than blank? c8509d5
Raising exception if fixture file can't be found 1c970b8
Yehuda Katz Replace snowman with utf8=✓ f2d22ec
Mark Turner fixed indentation in test cases
Signed-off-by: wycats <>
Aug 12, 2010
Xavier Noria no need to assign if we are gonna return bfd7281
Xavier Noria AS guide: some revisions 36cb62e
José Valim Make update_attribute behave as in Rails 2.3 and document the behavio…
…r intrinsic to its implementation.
Neeraj Singh adding more documentation for autosave option 06af291
Neeraj Singh updating documentation for named_scope and default_scope 198bffe
Xavier Noria commit review: applies guidelines to "# =>" 1e6e868
Paco Guzmán applied guidelines to "# =>" ab68d4b
Xavier Noria revises some autosave docs, style and content 4dcce5d
Neeraj Singh Ensure we can nest include calls [#5285 state:resolved]
Signed-off-by: José Valim <>
Greg Campbell Add missing ActiveModel::Validations require
[#5311 state: resolved]

ActiveModel::Validations uses Hash#except, but does not require it from
ActiveSupport.  (This wasn't showing up in the tests, because it was
required in the helper, and was also required in

Signed-off-by: José Valim <>
Subba Rao Pasupuleti tidy up validations length code [#5297 state:resolved]
Signed-off-by: José Valim <>
Subba Rao Pasupuleti no callbacks should be created for empty array [#5289 state:resolved]
Signed-off-by: José Valim <>
Xavier Noria be more precise re :validate and :autosave 91ae6e9
Jeremy Kemper It's snowing! e428300
Aug 13, 2010
Aaron Patterson symbol to proc is slow, we should avoid it fb6edb1
Aaron Patterson do not use arel constants directly abd9736
Aaron Patterson avoiding symbol to proc again e86b758
Aaron Patterson removing references to arel constants bacf781
Aaron Patterson avoid direct use of arel constants 108179b
Santiago Pastorino Moves local_request? to require.local?
[#5361 state:committed]
Aaron Patterson removing a lolinject 79e15f0
Prem Sichanugrist Removing most of the symbol to proc usage in Active Record
This will hopefully make Active Record run a bit more faster.
Aaron Patterson converting to a symbol is not necessary 59e63e7
Santiago Pastorino This method is actually not used, it's implemented on the concrete ad…

[#5331 state:committed]
Santiago Pastorino Makes AR use AMo to_key implementation ccd4364
Aug 14, 2010
Santiago Pastorino Deletes trailing whitespaces (over text files only find * -type f -ex…
…ec sed 's/[ \t]*$//' -i {} \;)
Santiago Pastorino Fixes some ActionMailer tests 05ba082
Subba Rao Pasupuleti Adding missing required statement
[#5056 state:resolved]

Signed-off-by: Santiago Pastorino <>
Santiago Pastorino deprected -> deprecated b3ece73
Mark Hayes in Rendering objects with RecordIdentifier example, locals should ref…
…erence @account not @buyer
Santiago Pastorino object/try should be required after abstract_unit to have AS in the l…
…oad path
Santiago Pastorino Both tests are using the same model, move the model to another file a…
…nd add the missing require
Santiago Pastorino Add missing model 707248a
Santiago Pastorino Should be Boolean there a036999
Santiago Pastorino MySQL2 added to CI 477a9d4
Aug 15, 2010
Santiago Pastorino Makes topics.written_on null => true back again some tests rely on that 0f1b9bb
Santiago Pastorino connection reader is defined later 6d68cde
Santiago Pastorino Revert "connection reader is defined later"
This reverts commit f4cce71.
Santiago Pastorino remove already defined method to avoid warnings ae7732f
Santiago Pastorino Makes use of class << self instead of def self. 5f7bfb1
Santiago Pastorino This is not needed anymore bdeeca3
Mikel Lindsaar Making time_zone_options_for_select return a html_safe string
Signed-off-by: Santiago Pastorino <>
José Valim to_key should return all exists keys (if any exists), regardless if t…
…he object is persisted or not. If you need it to reflect persistance, you should use to_param.
Santiago Pastorino Revert "Makes AR use AMo to_key implementation"
This reverts commit ccd4364.
Mark Turner make rake routes print the name of a Rack endpoint app [#5338 state:r…

Signed-off-by: José Valim <>
José Valim Improve routes task code and print the application as :to => RackApp. [
…#5338 state:resolved]
Bryce Thornton Allow for any possible TLD when using the :all option with the cookie…
… session store. This works for subdomain.mysite.local,,, etc. [#5147 state:resolved]

Signed-off-by: José Valim <>
Subba Rao Pasupuleti select tags coerce the :selected option, options to strings before co…
…mparison [#5056 state:resolved]

Signed-off-by: José Valim <>
Yehuda Katz render :file in 2.3 behaved like render :template in Rails 3 (adding …
…the current controller as a prefix)
Yehuda Katz headers["X-Foo-Count"] = 2 is deprecated properly now 6883681
Yehuda Katz find .text.html and .text.plain files, and deprecate it b8ec4ea
Yehuda Katz Add back #callback and deprecate it a34dce9
Yehuda Katz Test callbacks 83cb532
Yehuda Katz Make sure apps upgrading from 2.3 get defaulted to UTF-8 (ht: parndt) 452a56a
Aug 16, 2010
Xavier Noria routing guide: wildcard segments are quite flexible, go beyond the si…
…mple use case
José Valim annoted_source_code may return nil if an erro rhappens during templat…
…e compiling.
Tobias Lütke Added test case to verify that transaction callbacks are correctly pr…
…opagated to class observers

Signed-off-by: Santiago Pastorino <>
Santiago Pastorino assert_equal here 020aeb6
Peter Wagenet Class Attribute setter returns set value
Signed-off-by: wycats <>
Mark Turner added testcase for belongs_to with a counter_cache and touch
[#5365 state:committed]

Signed-off-by: Santiago Pastorino <>
Santiago Pastorino Restore pet -> owner relationship to the previous state 6f478b0
Aug 17, 2010
Raimonds Simanovskis added dependencies in Gemfile for running ActiveRecord tests with Ora…
…cle database
Raimonds Simanovskis Replaced hardcoded SessionStore table creation SQL with calls to Acti…
…veRecord adapter migration methods

Otherwise hardcoded table creation SQL was failing on Oracle database
Xavier Noria the (public) routing DSL does not accept symbols for get|post|put|del…
Xavier Noria code gardening: we have assert_(nil|blank|present), more concise, wit…
…h better default failure messages - let's use them
Santiago Pastorino recommended is the right word here 22d242c
Josiah Ivey Debugging Guide: Improve grammar for the RJS section 21063e5
Luke brown Added an example and explaination for using an optional path scope fo…
…r the locale
Xavier Noria debugging guide: revises the section on debugging RJS 4b21dfe
Jeff-Lawson Bug Fix -- clean up connection after stored procedure [#3151 state:re…
Jeff-Lawson Bug Fix -- clean up connection after stored procedure [#3151 state:re…
to_sentence should return a duplicate 92f4cca
Yehuda Katz Sadly, this segv's in 1.8 :( 0a41ece
Yehuda Katz 1.8 block variable shadowing strikes again 588ac71
Aug 18, 2010
Trey Bean Missing object for comparison in ActiveModel::EachValidator example c…
Xavier Noria you rarely want ^ or $ in validations, use \A when you mean \A 23303d6
André Arko Allow member actions (get, etc) to accept strings, with test c40856c
Santiago Pastorino Bump up rdoc to 2.5.10 82eff0f
Don't pluralize resource methods [#4704 state:resolved]
Signed-off-by: Santiago Pastorino <>
Aaron Patterson call to present? is not necessary 7e85b16
Aaron Patterson refactoring to remove duplicate logic 2f6383e
Yehuda Katz Revert "It's snowing!"
This reverts commit e428300.
Aaron Patterson refactor if / else to ||= a16ec2f
Aug 19, 2010
Xavier Noria get rid of the warning "+ after local variable is interpreted as bina…
…ry operator even though it seems like unary operator" in Ruby 1.9.2
Xavier Noria avoids a ton o warnings activesupport/lib/active_support/dependencies…
….rb:239: warning: loading in progress, circular require considered harmful ... activesupport/lib/active_support/core_ext/hash/indifferent_access.rb while running the suite in Ruby 1.9.2
Xavier Noria now for real, the suite loads everything and these went unpatched 632a224
Xavier Noria avoids warnings about mismatched indentations in Ruby 1.9.2 6fb6ddb
Jeremy Kemper Memoize STI class lookups for the duration of a request 64f4dc6
Santiago Pastorino We need bundle update only here bef90f8
Aaron Patterson we should wrap strings as sql literals 1ef9b98
Aaron Patterson removing useless ternary 49e406e
Santiago Pastorino Bump up rack-mount to 0.6.10 21c9795
Neeraj Singh While creating a new record using has_many create method default scop…
…e of child should be respected.

author.posts.create should take into account default_scope
defined on post.

[#3939: state:resolved]

Signed-off-by: José Valim <>
Andrew White Move edit route before show route so that it will have precedence if …
…the :id parameter allows slashes [#5409 state:resolved]

Signed-off-by: José Valim <>
Andrew White Move regexps in options hash to :constraints hash so that they are pu…
…shed into the scope [#5208 state:resolved]

Signed-off-by: José Valim <>
José Valim Use attribute readers as they are faster in general. 8f2b278
Andrew White Optimize find_sti_class when store_full_sti_class is true

Signed-off-by: Jeremy Kemper <>
Aaron Patterson updates return number of rows matched rather than number of rows affe…
Aug 20, 2010
Santiago Pastorino Bump up tzinfo to 0.3.23 ac66de4
Aaron Patterson fisting after_rollback and after commit callbacks 809a04b
Xavier Noria the pdoc task is no longer needed d033b23
Xavier Noria deletes the rdoc task of each component, they are no longer published…
… separately
Andrew White Allow symbols for :path resource(s) option [#5306 state:resolved]
Signed-off-by: José Valim <>
Andrew White Don't add the standard https port when using redirect in routes.rb an…
…d ensure that request.scheme returns https when using a reverse proxy.

[#5408 state:resolved]

Signed-off-by: José Valim <>
Neeraj Singh after_validation should be called irrespective of the result of valid…

I confirmed that this is the behavior on 2.3.x .

[5419 state:resolved]

Signed-off-by: José Valim <>
Aaron Patterson adding FOUND_ROWS to the connect flags for mysql2 612c233
Andrew White Support routing constraints in functional tests
Extend assert_recognizes and assert_generates to support passing
full urls as the path argument. This allows testing of routing
constraints such as subdomain and host within functional tests.

[#5005 state:resolved]

Signed-off-by: José Valim <>
Nick Sieger Fix hash modification during iteration in Mapper [#5420]
Signed-off-by: Santiago Pastorino <>
Jeremy Kemper Revert "Just add connection management middleware if running in a con…
…current environment."

This reverts commit 6b29dc8.
Brian Lopez reload bob after his journy to a new timezone 7dbc99e
Aug 21, 2010
Xavier Noria requires horo 1.0.2 9011f8f
Xavier Noria prevent RDoc from autolinking "Rails" in the API home page 68e2d1e
Raphael Lee Trifling typos
[#5422 state:committed]

Signed-off-by: Santiago Pastorino <>
Santiago Pastorino Move encoding settings for testing purposes to abstract_unit file 11e9883
Santiago Pastorino Set default_internal and default_external on AM for testing purposes e88f8be
Aug 22, 2010
Santiago Pastorino Set default_internal and default_external on AS for testing purposes 2106782
Andrew White Cache the symbolized path parameters using a instance variable in the…
… request object rather than the environment hash. This it to prevent stale parameters in later routing constraints/redirects as only the normal path parameters are set by Rack::Mount.

Also if a constraint proc arity is more than one, pass the symbolized path parameters
as the first argument to match redirect proc args and provide easier access.

[#5157 state:resolved]

Signed-off-by: José Valim <>
Santiago Pastorino Fix namespace problem on object which inherit from ActiveSupport::Bas…
Santiago Pastorino Silence warnings for Encoding.default_external= and Encoding.default_…
Aaron Patterson removing duplicate tests 6ca6ef2
Santiago Pastorino Bump up rack-mount to 0.6.12 6edae45
Aug 23, 2010
Santiago Pastorino type fixed 8235c92
Raimonds Simanovskis updated test_should_record_timestamp_for_join_table for Oracle bedf6a0
Raimonds Simanovskis Do not use time zone in test_read_attributes_before_type_cast_on_date…
…time for Oracle database

As currently string_to_time method is not doing time zone conversion to database time zone
Xavier Noria adds USAGE to the generator generator USAGE (not sure this meta thing…
… is any good at 8:12 AM with little coffee)
Xavier Noria generators guide: edit pass b97ad85
Xavier Noria removes words moved in previous edit of the generator generator USAGE 2570fda
Brian Lopez no need to depend on mysql2 master anymore
Signed-off-by: Santiago Pastorino <>
Brian Lopez mysql2 adapter is being maintained in the mysql2 gem itself
Signed-off-by: Santiago Pastorino <>
Aaron Patterson we should mark strings as SQL Literal values eeb9b37
Aaron Patterson sql literal strings should be marked as sql literal strings 1cc653f
Aaron Patterson we should mark sql strings as sql literals 6a1ea88
José Valim Update CHANGELOG for ActionPack. a1ca2e0
Aaron Patterson marking sql literals as sql literals 36fcc99
Santiago Pastorino Config is deprecated on 1.8.8 and 1.9.3 use RbConfig c8b84a1
David Heinemeier Hansson Prep for RC2 8931dd1
David Heinemeier Hansson Prefer the mysql2 gem for MySQL database.ymls fc6db62
David Heinemeier Hansson Depend on latest Bundler RC 880eaa1
Santiago Pastorino Point guides to bundler 1.0.0.rc.6 aafb290
David Heinemeier Hansson Depend on latest arel RC bc61196
David Heinemeier Hansson Bump rails version 04aa14f
David Heinemeier Hansson mysql db defaults to mysql2 gem 822fa17
Aug 24, 2010
Raimonds Simanovskis use database from ARUNIT_DB_NAME environment variable when running te…
…sts on Oracle
Fix test of generated Gemfile with mysql selected as DB driver
[#5435 state:committed]

Signed-off-by: Santiago Pastorino <>
Andrew White When custom resource actions are specified using strings add the defa…
…ult name and action if the string is a valid ruby method name.

[#5431 state:resolved]

Signed-off-by: José Valim <>
José Valim Fix a bug where symbols and strings were not behaving the same in the…
… router. [#5431 state:resolved]
Greg Hurrell Add test case for ActiveRecord::Base.record_timestamps = false
This is a failing test case for Lighthouse ticket #5440:

Signed-off-by: José Valim <>
José Valim Ensure timestamps are not generated when explicitly set to false [#5440
… state:resolved]
Joost Baaij fix broken relative links [#5415 state:committed]
Signed-off-by: Xavier Noria <>
José Valim Ensure prefix in routes are generated properly. 6579173
Andrew White Reset symbolized path parameters when a test request is recycled [#5437
… state:resolved]

Signed-off-by: José Valim <>
Neeraj Singh @user.touch should not fail if User does not have updated_at/updated_…
…on column.

[#5439 state:resolved]

Signed-off-by: José Valim <>
Aaron Suggs Bump rake dependency to 0.8.4. [#5279 state:resolved]
This rake version adds the Rake::RDocTask#rdoc_task_name method, used in

Signed-off-by: José Valim <>
Santiago Pastorino Allow actions which start with A-Za-z_ only 7830f8d
José Valim Fix how routes inside namespaces are generated. 6d1e87b
José Valim Hide internal apps from rake routes [#5443 state:resolved] 6b54a6a
José Valim Ensure shortcuts inside resources also generates helpers. 91916e6
José Valim Finally fix the bug where symbols and strings were not having the sam…
…e behavior in the router.

If you were using symbols before for methods like match/get/post/put/delete, it is likely that this commit will break your routes.
Everything should behave the same if you are using strings, if not, please open up a ticket.
José Valim Allow format to be skipped. This is used internally by mount. 3a831cb
Andrew White Use nested scope for routes defined at the :resources scope level (as…
… in Rails 2.3)

Signed-off-by: José Valim <>
Aug 25, 2010
Neeraj Singh unscoped does not work when chained with named_scope 2ae4f01
Trevor Turk Note about how to exit the console in the Getting Started guide 174d5cd
Neeraj Singh touch operationg if used along with belongs_to will also be invoked o…
…n associated objects
Xavier Noria edit pass to a recent doc patch 5deeb43
Xavier Noria :nodoc:s #unscoped until its behavior is more clear, now sometimes wo…
…rks, sometimes not
Mikel Lindsaar Make ActiveResource::InvalidRequestError more user friendly
Signed-off-by: Xavier Noria <>
Andrew White Remove rails info route from rake routes output [#5452 state:resolved]
Signed-off-by: José Valim <>
Jakub Suder better callstack reporting in deprecation messages
now the reported line is the first line in the stack
that's outside Rails, which is the one that actually
caused the problem in the first place

[#5231 state:resolved]

Signed-off-by: José Valim <>
Aaron Patterson mark SQL literals as SQL literals e991f39
Aaron Patterson run tests in verbose mode bfe956d
Aaron Patterson refactor select { is_a? } to grep() da7a280
Aaron Patterson no need to send on a public method 3dc9880
Aaron Patterson use blank? instead of present?, mark SQL literals as SQL literals 9ba46cf
Andrew White Catch mysql2 access denied errors in rake db:create [#5432 state:reso…

Signed-off-by: Xavier Noria <>
Xavier Noria AS guide: Array.wrap vs splat is only valid for 1.8 8bad8ac
Aug 26, 2010
Neeraj Singh minor formatting fixes 61292a1
Rémy Coutable Fixed a missing simple quote. e12ff5b
Rémy Coutable Restore consistency with the rest of the doc. d810854
Joost Baaij remove unwanted linebreak 2722c82
Joost Baaij change rdoc to conform to api guidelines 908544c
Joost Baaij fixed capitalization 3b3cfa4
Joost Baaij Restored top-level documentation for ActionController::Base.
This information was lost in commit bd6b61b.
This might have been intentional, but this class does represent the starting
point for all things related to actions, and as such should document it.

I couldn't find any trace of this documentation, which seems like a waste.
Updated parts here and there to conform to current best practices.
James Miller Fix typo, favour => favor d7f1226
James Miller mysql2 is now the default, typos 59cd141
James Miller to_json => as_json 3ecbae0
Aleksander Pohl - Fix non-ascii characters in headers
Signed-off-by: Xavier Noria <>
Xavier Noria adds missing require for #parameterize 27512c2
Xavier Noria Revert "to_json => as_json"
This reverts commit 7a6d8e4.

Reason: The method that gives you a Ruby string with JSON source code is #to_json
Jaime Iniesta Fix capture_helper.rb api documentation, unescaped script tag was bre…
…aking it on the content_for explanation
Jaime Iniesta lifecycle should be two words, life cycle a316109
Jaime Iniesta change 'a SQL' to 'an SQL' as suggested by the api documentation guid…
Xavier Noria revises a few link texts ace0f87
Xavier Noria getting started guide: revises text wrt bundler 9df512b
José Valim Ensure templates like template.html are found but still uses the prop…
…er virtual path.
José Valim Add clear_helpers as a way to clean up all helpers added to this cont…
…roller, maintaing just the helper with the same name as the controller.
José Valim Update CHANGELOG. daf2f95
José Valim Do not modify frozen strings in place. d806aa2
José Valim Doh, be sure to store the string modification. 473feeb
José Valim Be sure to call helper :all just on direct children. (Tests by Jesse …
Xavier Noria getting started guide: adds a reference to Michael Hartl's free onlin…
…e book in the what's next section
Jeremy Kemper Ruby 1.9: be sure to explicitly reference toplevel constants within B…
…asicObject deprecation proxies
Aug 27, 2010
Xavier Noria updates de title of the generators guide in the home and index 983a5e2
Carlos Antonio da Silva Removing some unuseful begin/end and refactor prompt_option_tag a bit
[#5469 state:committed]

Signed-off-by: Santiago Pastorino <>
Santiago Pastorino Make InstanceTagMethods#value_before_type_cast raise if the model don…
…'t respond to attr_before_type_cast or attr method

[#3374] [#5471 state:committed]
José Valim Add missing require. dbbf198
Sam Aarons Fix em_mysql2 error in rake db:create
Signed-off-by: José Valim <>
Xavier Noria adds a comment in cli.rb so that it is clear that exec_script_rails! …
…performs an exec call
Xavier Noria solves everything in guides raised by WARNINGS=1 (except for one whic…
…h is abandoned atm)
Andrew White Read the route name directly from the route instead of looking it up …
…in the named routes hash

Signed-off-by: Jeremy Kemper <>
Aug 28, 2010
Joost Baaij expand cookie examples with signed and permanent methods 6c84fd8
Joost Baaij mention the alert and notice accessors on the flash 5502a78
Joost Baaij escape constants that should not be linked to 8da4576
Joost Baaij Use common terminology 0c87873
Santiago Pastorino type="password" for password_fields bf35d1e
Thiago Pradi Fixing typo [#5485 state:resolved]
Signed-off-by: José Valim <>
Yury Korolev Micro optimization for build_named_route_call in PolymorphicRoutes:
1. use map instead of inject
2. use [].join("_") instead of '<<'. It is a little bit faster for ruby 1.9.2 and x2 faster for ruby 1.8.7.

[#5450 state:resolved]

Signed-off-by: José Valim <>
Fred Wu Fixed the session name generated by the app_generator. Also refactore…
…d the corresponding test suites to be cleaner. [#5434 state:resolved]

Signed-off-by: José Valim <>
Jesse Storimer Ensure that inherited helper_methods are available after calling clea…
…r_helpers [#5348 state:resolved]

Signed-off-by: José Valim <>
Jeremy Kemper Clean up CHANGELOGs 0f94ca3
Mike Perham Support pluggable cache stores.
[#5486 state:committed]

Signed-off-by: Jeremy Kemper <>
Santiago Pastorino PERF: Avoid two method calls 15e9b53
José Valim Ensure we are not calling length on nil. a2c547f
Aug 29, 2010
Sam Ruby Make rake routes gracefully handle routes with no name
Signed-off-by: Santiago Pastorino <>
David Heinemeier Hansson Prep for final release 851552b
David Heinemeier Hansson Depend on Bundler 1.0 w/ tiny fixes 647ed22
David Heinemeier Hansson Depend on ARel 1.0 w/ tiny fixes b63b6c4
David Heinemeier Hansson No more build 9f9c50f
Santiago Pastorino No more beta or rc on guides ca73b5b
Santiago Pastorino Make CI install bundler stable since 1.0 is out a8a9f00
Santiago Pastorino -v=1.0.0 not needed 3d0c928
Xavier Noria revises a deprecation message c7106e8
Xavier Noria implements String#strip_heredoc e38fa05
Aug 30, 2010
Loren Segal Add .yardopts so YARD can document Rails 9891ca8
Oct 13, 2010
Michael Koziarski Revert 0c0b0aa which introduced a security vulnerability.
This addresses  CVE-2010-3933
Oct 15, 2010
Michael Koziarski Prepare for the 3.0.1 release bac6ba9