Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: rails/rails
...
head fork: rails/rails
Checking mergeability… Don't worry, you can still create the pull request.
This comparison is big! We're only showing the most recent 250 commits
Commits on May 11, 2012
@arunagw arunagw Update performance profiler to work with latest ruby-prof 9d616ea
@arunagw arunagw Ruby-Prof works with ruby-1.9.3 also. 4b59961
@alexeymuranov alexeymuranov Remove unused private method yaml_fixtures_key 5ecd14c
@spastorino spastorino Merge pull request #6262 from arunagw/ruby_prof_fix
Ruby prof fix
9cead4a
Commits on May 12, 2012
Erich Menge Update 'getting started' guides for new whitelist security implementa…
…tion. Closes #6286.
ccf80c2
@rafaelfranca rafaelfranca Merge pull request #6292 from erichmenge/3-2-stable-docfix
3 2 stable guides fix
41e7a2a
Commits on May 13, 2012
Francesco Rodriguez adding examples and docs 2f4696d
@vijaydev vijaydev Merge pull request #6294 from frodsan/docs_backport
Adding examples and docs [3-2-stable]
3d0e7ad
@guilleiguaran guilleiguaran Upgrade sprockets to 2.1.3 62b74b1
@Mik-die Mik-die :foreign_key option should be on has_many side of association 3f7ed52
@spastorino spastorino Merge pull request #6299 from guilleiguaran/upgrade-sprockets-3-2-stable
Upgrade sprockets to 2.1.3
8a5b51e
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6306 from erichmenge/3-2-stable-guide-fix
3 2 stable guide fix [ci skip]
e7d5ba3
@rafaelfranca rafaelfranca Merge pull request #3237 from sakuro/data-url-scheme
Support data: url scheme
9ff97b0
@rafaelfranca rafaelfranca Deprecate `:mouseover` options for `image_tag` helper. 1aff772
Commits on May 14, 2012
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6266 from alexeymuranov/remove_unused_private_method
Remove unused private method
9199ddf
@homakov homakov Update railties/lib/rails/generators/rails/app/templates/config/appli…
…cation.rb

Signed-off-by: José Valim <jose.valim@gmail.com>
4588684
@josevalim josevalim Default escape_html_entities_in_json to true in new apps ec68258
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6018 from lest/patch-1
mailer can be anonymous
2506d4a
Carlos Galdino + Rafael Mendonça França Deprecate `:disable_with` in favor of `'data-disable-with'` option fo…
…r `button_to` and `submit_tag` helpers.
21141e7
Carlos Galdino + Rafael Mendonça França Fix typo d47d6e7
Carlos Galdino + Rafael Mendonça França Deprecate `:disable_with` for `button_tag` too e9051e2
Commits on May 15, 2012
Francesco Rodriguez Backporting some docs on core_ext/hash b2f73c4
@vijaydev vijaydev Merge pull request #6321 from frodsan/backport_docs
Backporting docs
007539d
@acapilleri acapilleri clean the errors if an object that includes validations errors is dup…
…ed,for 3-2-stable

It Fixes #5953 in 3-2-stable, it's the same pull request of #6284
396e383
@rafaelfranca rafaelfranca Merge pull request #6324 from acapilleri/dup_validation_3_2
Dup validation 3 2
9a868a0
@carlosantoniodasilva carlosantoniodasilva Fix indent from previous merge 2dfa8b5
Angelo Capilleri add backport for the pull request #6324 e885b18
@rafaelfranca rafaelfranca Merge pull request #6329 from acapilleri/backport_dup_validation_3_2
Backport dup validation 3 2
8470fdb
Commits on May 16, 2012
@bcardarella bcardarella Changing the indentation level of the block comment close for SASS
If one wants to use use SASS for application.css.sass the comment block indentation is invalid.
9f4c4f6
@tenderlove tenderlove Merge pull request #6340 from bcardarella/patch-3
Changing the indentation level of the block comment close for Sass
e3033e3
Commits on May 17, 2012
@drogus drogus Fix CollectionAssociation#replace to return new target (closes #6231)
Conflicts:

	activerecord/test/cases/associations/has_many_associations_test.rb
0f43592
Francesco Rodriguez fix validations docs 4bbd05c
@vijaydev vijaydev Merge pull request #6367 from frodsan/fix_validators_docs
Fix validators docs [3-2-stable]
75e8e77
Commits on May 18, 2012
@iHiD iHiD Deprecate old APIs for highlight, excerpt and word_wrap 616c91d
@rafaelfranca rafaelfranca Merge pull request #6377 from ihid/depreciate_old_text_helper_apis
Deprecate old APIs for highlight, excerpt and word_wrap
2802ad0
@jonleighton jonleighton Perf: Don't load the association for #delete_all.
Bug #6289

Conflicts:

	activerecord/test/cases/associations/has_many_associations_test.rb
b98d1e2
@jonleighton jonleighton fix #delete_all with habtm with :delete_sql 855fabc
@ernie ernie Fix HABTM syntax error in Ruby 1.8.x 3b444ee
@rafaelfranca rafaelfranca Merge pull request #6390 from ernie/invalid-ruby18-syntax-in-habtm
Invalid ruby18 syntax in habtm
8ad8f61
@josevalim josevalim Merge pull request #5020 from KL-7/fix-blank-image_tag-source
Render img tag with empty src if empty string is passed to image_tag.
4dd4621
Commits on May 19, 2012
@drogus drogus Ensure that CollectionAssociation#replace returns proper target
The fix commited in e2a070c was returning the `new_target`, as
a try to return whatever user replaced association with. The
problem is, the resulting association target may be ordered
differently. In such case we want to return the target that
will be later used for that association.
d641646
@tenderlove tenderlove Merge pull request #6398 from pmahoney/threadsafe-connection-pool
Synchronize read and modification of @reserved_connections
879611f
@carlosantoniodasilva carlosantoniodasilva Use right option for excerpt text helper in tests, fix build
`excerpt` text helper uses `:radius`, not `line_width` (that is used by
`word_wrap` helper).

Also cleanup some whitespaces.
c520504
Commits on May 20, 2012
@drogus drogus Fix `validates_uniqueness_off :field, :allow_nil => false`
Closes (#5853)

Uniqueness validator was not properly checking if there are any existing
records, when value was `nil` and column was text type. `nil` was
converted to string, which resulted in queries looking like:

```sql
SELECT 1 FROM "posts" WHERE "posts"."title" = '' LIMIT 1
```

instead of

```sql
SELECT 1 FROM "posts" WHERE "posts"."title" IS NULL LIMIT 1
```
f7d01ec
@drogus drogus Fix uniqueness validator with `allow_nil: false` also for mysql
MySQL's adapter was changing value for case sensitive comparison. We
don't need to do it for `nil`.
0d73d6e
@drogus drogus Improve docs for `try` by adding note on `BasicObject`
[ci skip] closes #5790
6ef9fda
@pinetops pinetops Prevent concurrent compilation of templates - closes #6400 565c1b0
@Bodacious Bodacious Fixed tag_helper data-attribute bug with BigDecimals 39b9c94
@josevalim josevalim Merge pull request #6407 from pinetops/565c1b0a0772ac6cf91c77e9285806…
…f7b028614c

Template concurrency fixes
fe9731e
@rafaelfranca rafaelfranca Merge pull request #6410 from Bodacious/tag_helper_data_fix_3-2-stable
TagHelper creates invalid data attributes when value is a BigDecimal
68a454c
Commits on May 21, 2012
@drogus drogus Fix generators to help with ambiguous `ApplicationController` issue
In development mode, dependencies are loaded dynamically at runtime,
using `const_missing`. Because of that, when one of the constants is
already loaded and `const_missing` is not triggered, user can end up
with unexpected results.

Given such file in an Engine:

```ruby
module Blog
  class PostsController < ApplicationController
  end
end
```

If you load it first, before loading any application files, it will
correctly load `Blog::ApplicationController`, because second line will
hit `const_missing`. However if you load `ApplicationController` first,
the constant will be loaded already, `const_missing` hook will not be
fired and in result `PostsController` will inherit from
`ApplicationController` instead of `Blog::ApplicationController`.

Since it can't be fixed in `AS::Dependencies`, the easiest fix is to
just explicitly load application controller.

closes #6413
b0f8355
@drogus drogus More info on commit messages in contributing guide
Add more info on how to write a good commit messages along with
example showing nicely formatted commit message.

Rails git history does not look too well when you try to figure out why
particular changes were introduced. We can do much better than that and
it's never too late to start.
64e12ff
@pwnall pwnall Postgresql doesn't accept limits on binary (bytea) columns. 36fdb72
@lest lest Assets: don't add extension if other given and file exists
We should lookup if asset without appended extension exists.
When sprockets are disabled the asset tag helpers incorporate
this logic. When sprockets are enabled we should have the same
logic.

For example, we have style.ext file in app/assets/stylesheets and
we use stylesheet_link_tag in the layout. In this case we should
have /assets/style.ext instead of /assets/style.ext.css in the
output.

Closes #6310
39f9f02
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6423 from lest/patch-2
assets: don't add extension if other given and file exists
f051071
@tenderlove tenderlove Merge pull request #6418 from pwnall/pgsql_bytea_limit3
Postgresql doesn't accept limits on binary (bytea) columns (for 3-2-stable)
5d6cca1
Commits on May 22, 2012
@drogus drogus Use require_dependency in generated controllers
Using require in development mode will prevent required files from
reloading, even if they're changed. In order to keep namespaced
application_controller reloadable, we need to use require_dependency
instead of require.
56b86a3
@chancancode chancancode Restore the frozen state on rollback. Fixes #6417.
This is a 3-2-stable backport for #6420 which was merged into master.

Currently, when saving a frozen record, an exception would be thrown
which causes a rollback. However, there is a bug in active record that
"defrost" the record as a side effect:

    >> t = Topic.new
    => #<Topic id: nil, ...>
    >> t.freeze
    => #<Topic id: nil, ...>
    >> t.save
    RuntimeError: can't modify a frozen Hash
    >> t.frozen?
    => false
    >> t.save
    => true

This patch fixes the bug by explictly restoring the frozen state on the
attributes Hash after every rollback.
a543002
@rafaelfranca rafaelfranca Merge pull request #6445 from chancancode/3-2-stable_restore_frozen_s…
…tate_on_rollback

Restore the frozen state on rollback. (Backports #6420)
9ee8528
@chancancode chancancode Fixes the build break caused by 9ee8528 in #6445.
Ruby 1.8 raises a TypeError when trying to modify a frozen Hash, while
Ruby 1.9 raises a RuntimeError instead. Also, Ruby < 1.9.3 uses a
lowercase 'hash' in the exception message while Ruby >= 1.9.3 uses an
uppercase 'Hash' instead. This commit normalizes those issues in the
test case.
d3715f6
@rafaelfranca rafaelfranca Merge pull request #6451 from chancancode/3-2-stable_restore_frozen_s…
…tate_on_rollback

Fixes the build break caused by 9ee8528 in #6445.
ff3cddf
Commits on May 23, 2012
@Juanmcuello Juanmcuello Use Shellwords to scape arguments in db:structure:dump for PostgreSQL.
fixes #5913
587de84
Andrew Selder Synchronize the ConnectionPool#release method to avoid thread safety …
…issues [#6464]

Fixes #6464

Synchronize the contents of the release method in ConnectionPool due to
errors when running in high concurrency environments.

    Detected invalid hash contents due to unsynchronized modifications
with concurrent users
    org/jruby/RubyHash.java:1356:in `keys'
/usr/local/rvm/gems/jruby-1.6.7@new_import/gems/activerecord-3.2.3/lib/a
ctive_record/connection_adapters/abstract/connection_pool.rb:294:in
`release'

/usr/local/rvm/gems/jruby-1.6.7@new_import/gems/activerecord-3.2.3/lib/a
ctive_record/connection_adapters/abstract/connection_pool.rb:282:in
`checkin'
e663aa3
@tenderlove tenderlove Merge pull request #6467 from aselder/3-2-stable
Synchronize the body of the ConnectionPool#release method to improve thread safety.
356f2a6
Commits on May 24, 2012
@carlosantoniodasilva carlosantoniodasilva Merge pull request #5925 from Juanmcuello/pg_structure_dump
Quote arguments in db:structure:dump for PostgreSQL.
a9af9f1
Commits on May 25, 2012
@rafaelfranca rafaelfranca Merge pull request #5244 from fotos/myqsl2_wait_timeout
Maximum wait_timeout on Windows is 2147483
c90f3de
Commits on May 26, 2012
@bdurand bdurand remove unnecessary memcache equire in ActionDispatch::Session::CacheS…
…tore
ba6d935
Commits on May 27, 2012
@josevalim josevalim Merge pull request #6494 from pwim/no-memcache-require
memcache require not needed for cache store
81ad94e
@drogus drogus Fix railties_order when application object is passed
railites_order method, introduced in 40b19e0, had a bug that was causing
loading application instance twice in initializers if railties_order
already included application instance. So for example

    railties_order = [Foo::Engine, :main_app, Bar::Engine]

would result in such railties array:

    [MyApp::Application, Foo::Engine, MyAppApplication, Bar::Engine]

In order to fix it, we need to check for existence of application in
both railties_order and railties arrays.
0e69705
Commits on May 28, 2012
@bkzl bkzl Display annotations from .coffee files in `rake notes` 4ababde
@tenderlove tenderlove bumping to 3.2.4.rc1 fe4dfdd
Commits on May 29, 2012
@floehopper floehopper Exceptions like Interrupt should not be rescued in tests.
This is a back-port of rails/rails#6525. See the commit notes there for
details.
0813b45
@rafaelfranca rafaelfranca Merge pull request #6531 from freerange/3-2-stable-minitest-passthrou…
…gh-exceptions

Exceptions like Interrupt should not be rescued in tests.
12e5c72
Commits on May 30, 2012
@oscardelben oscardelben Remove irrelevant assertion 2f71d40
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6519 from oscardelben/3-2-stable
Display annotations in coffee files
f09ae85
Erich Menge True, False, and Nil should be represented in as_json as themselves.
Conflicts:

	activesupport/lib/active_support/json/encoding.rb
	activesupport/test/json/encoding_test.rb
624f801
@tenderlove tenderlove Merge pull request #5810 from kennyj/fix_5797
Fix #5797. Error calling dup method on AR model with serialized field
Conflicts:
	activerecord/lib/active_record/core.rb
c470001
Erich Menge Deprecate ActiveSupport::JSON::Variable bcfa013
@drogus drogus Merge pull request #6553 from erichmenge/3-2-stable-json-patch
3 2 stable json patch
9f1b689
@rafaelfranca rafaelfranca Merge pull request #6477 from steveklabnik/close_discovered_pg_connec…
…tion

Properly discover a connection is closed in postgresql_adapter
b6727a1
@tenderlove tenderlove predicate builder should not recurse for determining where columns.
Thanks to Ben Murphy for reporting this

CVE-2012-2661
71f7917
@tenderlove tenderlove Strip [nil] from parameters hash.
Thanks to Ben Murphy for reporting this!

CVE-2012-2660
dff6db1
Commits on May 31, 2012
@parndt parndt Revert "Removes unneeded caching from ActiveRecord::Base.relation"
This reverts commit ebfa58a.

This change caused a regression in my application's tests:

* Failing build http://travis-ci.org/#!/resolve/refinerycms/builds/1461242

Broken tests pass after this change is reverted.
4ce7f98
@tenderlove tenderlove Merge pull request #6558 from parndt/fix_regression
Fix regression
4c8805d
@tenderlove tenderlove Merge pull request #6558 from parndt/fix_regression
Fix regression
ac465d5
Martin O'Connor Changed symbol platform to platforms for the commented out call to ge…
…m 'therubyracer'.

Dependency.rb expects the symbol to be named :platforms as opposed to platform. RubyMine's inspections indicate that the symbol should be named :platforms.
Updating tests.
9bbdceb
@rafaelfranca rafaelfranca Merge pull request #6562 from martinoconnor/generator-fix-stable
3-2-stable Changed symbol platform to platforms for the commented out call to gem 'therubyracer'.
f8f6ad6
@tenderlove tenderlove updating changelogs d3e5d1c
@tenderlove tenderlove Merge branch '3-2-stable-sec' into 3-2-rel
* 3-2-stable-sec:
  Strip [nil] from parameters hash. Thanks to Ben Murphy for reporting this!
  predicate builder should not recurse for determining where columns. Thanks to Ben Murphy for reporting this
7182748
@tenderlove tenderlove adding security notifications to CHANGELOGs 44aca7b
@tenderlove tenderlove bumping to 3.2.4 febd652
@tenderlove tenderlove Merge branch '3-2-stable-sec' into 3-2-stable
* 3-2-stable-sec:
  Strip [nil] from parameters hash. Thanks to Ben Murphy for reporting this!
  predicate builder should not recurse for determining where columns. Thanks to Ben Murphy for reporting this
  bumping to 3.2.4.rc1
d66fd08
@tenderlove tenderlove Merge branch '3-2-rel' into 3-2-stable
* 3-2-rel:
  bumping to 3.2.4
  adding security notifications to CHANGELOGs
  updating changelogs
  Merge pull request #6558 from parndt/fix_regression
4df9680
Commits on Jun 01, 2012
@pixeltrix pixeltrix Restore behavior of Active Record 3.2.3 scopes
A series of commits relating to preloading and scopes caused a regression.
Cloning the relation calls initialize_copy which resets a number of instance
variables to nil. Without this the scope thinks that it is already loaded
when it is called again.

Reverts the following commits:
13f1401
8491740
dffbb52

Fixes #6575, #6576 & #6577
7056079
@tenderlove tenderlove bumping to 3.2.5 b57fa0b
@amatsuda amatsuda remove unneeded blank line from !namespeced? controller generators 8984bc2
@rafaelfranca rafaelfranca Merge pull request #6587 from amatsuda/controller_generator_remove_bl…
…ank_line_32

Backporting #6586 patch to 3-2-stable
ecd1722
@drogus drogus Include routes.mounted_helpers into integration tests
In integration tests, you might want to use helpers from engines that
you mounted in your application. It's not hard to add it by yourself,
but it's unneeded boilerplate. mounted_helpers are now included by
default. That means that given engine mounted like:

    mount Foo::Engine => "/foo", :as => "foo"

you will be able to use paths from this engine in tests this way:

    foo.root_path #=> "/foo"

(closes #6573)
8d4f63a
@rafaelfranca rafaelfranca Add release date of 3.2.5 on the CHANGELOG b13d89e
@nbibler nbibler Use to_model delegates for polymorphic route generation 537ede9
@josevalim josevalim Merge pull request #6588 from nbibler/polymorphic_to_model
Correct the use of to_model in polymorphic routing
5b6b0df
@yahonda yahonda Skip test_remove_column_with_array_as_an_argument_is_deprecated with …
…Oracle adapter.

Because Oracle adapter supports only remove_column :table_name, :column_name syntax
and it has never supported remove_column :table_name, [:column_name].
7544c7a
@drogus drogus Allow to use mounted helpers in ActionView::TestCase
Similarly to 6525002, this allows to use routes helpers for mounted
helpers, but this time in ActionView::TestCase
f550d4d
@rafaelfranca rafaelfranca Merge pull request #6593 from yahonda/skip_test_remove_column_with_ar…
…ray_as_an_argument_is_deprecated

Skip test_remove_column_with_array_as_an_argument_is_deprecated with Oracle
43f0af4
Commits on Jun 04, 2012
@earnold earnold Add failing test for 3.2.5 datetime attribute regression bebbdb5
@kennyj kennyj Fix #6591. If a field with timezone isn't changed, we don't call will…
…_change!.
510ef2b
@rafaelfranca rafaelfranca Merge pull request #6622 from kennyj/fix_6591-32
[3-2-stable back ported] Fix #6591 Rails 3.2.5 Regression: incorrect _changed? for datetimes
9f52d15
Commits on Jun 05, 2012
@carlosgaldino carlosgaldino Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` op…
…tion

This deprecation applies to:
`button_to`
`button_tag`
`image_submit_tag`
`link_to`
`submit_tag`

As :confirm is an UI specific option is better to use the data attributes,
teaching users about unobtrusive JavaScript and how Rails works with it.
fc092a9
@rafaelfranca rafaelfranca Merge pull request #6613 from carlosgaldino/3-2-data-confirm
Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` option
6347554
@rafaelfranca rafaelfranca Add test to flash sweep after two redirects
This test is needed to avoid regressions in the way that flash works
now (swept in every request).
f7cde3e
@rafaelfranca rafaelfranca Revert "fix the Flash middleware loading the session on every request…
… (very dangerous especially with Rack::Cache), it should only be loaded when the flash method is called"

This reverts commits e3069c6 and 2b2983d.

Reason: This add a non-backward compatible change in the way that flash
works now (swept in every request).
3cba6ee
Commits on Jun 06, 2012
@kuroda kuroda Fix human attribute_name to handle deeply nested attributes
This is a back-port of b0e2fc8 to Rails 3.2.
See #5843 and #3859 also.
029936e
@josevalim josevalim Merge pull request #6642 from kuroda/3-2-activemodel-translation-patch
Fix human attribute_name to handle deeply nested attributes
6b6c1de
Commits on Jun 07, 2012
@jonleighton jonleighton Revert "Perf: Don't load the association for #delete_all."
This reverts commit b98d1e2.

Closes #6609

Conflicts:

	activerecord/lib/active_record/associations/has_and_belongs_to_many_association.rb
959fb8e
@jonleighton jonleighton Make test cover previous reversion 68d3e1f
@drogus drogus Fix asset tags for files with more than one dot
After the fix done in 39f9f02, there are cases that will not work
correctly. If you have file with "2 extensions", like foo.min.js and you
reference the file without extension, like:

    javascript_include_tag "foo.min"

it will fail because sprockets finds foo.min.js with foo.min argument.

This commit fixes this case and will get the right file even when
referrencing it without extension.

(closes #6598)
5b0a891
@drogus drogus Fix railties test suite
Apparently asset_environment should not be invoked if it's not needed.
This fixes broken build by getting back to the code more similar to the
version changed here: 5b0a891
fa352c4
Commits on Jun 08, 2012
@arunagw arunagw Removed protected as we already doing it above. 7ad5f8b
@arunagw arunagw We should not include engine.rake file into rake
if we are passing -T which is skip_test_unit

See issue #6673 for more details.

I saw that we are not creating dummy app even if 
we do skip_test_unit. 

Fixes #6673
8b1d475
@rafaelfranca rafaelfranca Merge pull request #6677 from arunagw/3-2-stable
Removed protected as we already doing it above.
dfb1ebe
@rafaelfranca rafaelfranca Merge pull request #6678 from arunagw/fix_issue_6673
Fix issue 6673
0e4d16f
@drogus drogus Don't add sqlite3 to gemspec with -O on rails plugin new
(closes #6672)
8475cdd
Commits on Jun 09, 2012
@tiegz tiegz ActiveRecord#attributes optimization: minimize objects created 6e4a064
@achamian achamian buffered logger is initialized with the log level passed trough the i…
…nitializer
01f8f29
@arunagw arunagw Duplicate tests removed. f36fd0e
@pixeltrix pixeltrix Merge pull request #6689 from arunagw/duplicate_test_removed
Duplicate test removed
6900a4e
@josevalim josevalim Merge pull request #6687 from tiegz/3-2-optimizations
ActiveRecord#attributes optimization: minimize objects created
eaeebc2
Commits on Jun 10, 2012
@jkraemer jkraemer fix namespace collision with test-unit-activesupport e66c240
@josevalim josevalim Merge pull request #6693 from jkraemer/3-2-stable
Bugfix: Namespace collision with test-unit-activesupport 1.0.0
6cc941d
@rafaelfranca rafaelfranca Merge pull request #6695 from kennyj/fix_6635
Fix #6635. We should call Scoping methods, before calling Array methods.
5dfb01e
@rafaelfranca rafaelfranca Merge pull request #6688 from c42engineering/buffered_logger_level_wh…
…ile_creation

BufferedLogger level while creation
35c89a4
@iaddict iaddict Minimal change to query generation of exists? that makes SQLServer an…
…d others happy that do not work without a column alias.

Conflicts:
	activerecord/lib/active_record/relation/finder_methods.rb
dd286a4
@rafaelfranca rafaelfranca Add test to column alias in `exists?` SQL.
This behavior was added in dd286a4

Closes #1139.

Fixes #2553, #1141, #1623 and #2062.
179276e
@rafaelfranca rafaelfranca Remove warning 9e6eb8b
Commits on Jun 11, 2012
@rafaelfranca rafaelfranca Merge pull request #6521 from Empact/throw-result
Fix that #exists? can blow up with ThrowResult exception
Conflicts:
	activerecord/lib/active_record/relation/finder_methods.rb
bbec883
@rafaelfranca rafaelfranca Merge pull request #6698 from yahonda/address_ora_911_master
Address ORA-00911 errors because of the heading underscore.
c9f27e3
@rafaelfranca rafaelfranca Merge pull request #6690 from suginoy/fix-templates-copy
Fix: 'rake rails:templates:copy' doesn't work
Conflicts:
	railties/test/application/rake_test.rb
0391ae9
@kennyj kennyj Fix GH #3163. Should quote database on mysql/mysql2.
Conflicts:

	activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
22994b2
@kennyj kennyj Change the string to use in test case.
Conflicts:

	activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
	activerecord/test/cases/adapters/mysql2/schema_test.rb
0ccdeeb
@ernie ernie Additional fix for CVE-2012-2661
While the patched PredicateBuilder in 3.1.5 prevents a user
from specifying a table name using the `table.column` format,
it doesn't protect against the nesting of hashes changing the
table context in the next call to build_from_hash. This fix
covers this case as well.
cc2903d
@tenderlove tenderlove Array parameters should not contain nil values. 38edea0
@tenderlove tenderlove updating changelogs 301974a
@tenderlove tenderlove updating changelogs with security fixes ceb8ec3
@tenderlove tenderlove bumping version numbers ee4209a
Commits on Jun 12, 2012
@acapilleri acapilleri Fix the the backport of the object dup with the ruby 1.9.3p194.
At the end of initialize_dup was added the call to super if it exists,
so it also works with 1.8.7 where initialize_dup doesn't exist.
This issu was introduced with the pull request #6324
b97e0a1
@rafaelfranca rafaelfranca Merge pull request #6682 from acapilleri/dup_validation_fix_backport_…
…for_1_9_3

Dup validation fix backport for 1 9 3
6522a12
@rafaelfranca rafaelfranca Merge pull request #6676 from aurelian/master
Don't assign the attributes if the list is empty
32709ea
@rafaelfranca rafaelfranca Merge pull request #6715 from arunagw/add_asserts
Need a assert here in tests
5dd2cfc
@tenderlove tenderlove updating changelogs 8381d39
@tenderlove tenderlove Merge branch '3-2-stable-rel' into 3-2-stable
* 3-2-stable-rel:
  updating changelogs
  bumping version numbers
  updating changelogs with security fixes
  updating changelogs
  Array parameters should not contain nil values.
  Additional fix for CVE-2012-2661
10cdbbc
Francesco Rodríguez Fix build eed1cfe
@rafaelfranca rafaelfranca Merge pull request #6716 from frodsan/patch-2
Fix Build
966371a
Commits on Jun 13, 2012
@spastorino spastorino ActionController::Caching depends on RackDelegation and AbstractContr…
…oller::Callbacks
7f93791
Commits on Jun 14, 2012
@tenderlove tenderlove adding a test for #6459 e7d1849
@steveklabnik steveklabnik Deprecate update_attribute.
Historically, update_attribute and update_attributes are similar, but
with one big difference: update_attribute does not run validations.
These two methods are really easy to confuse given their similar
names. Therefore, update_attribute is being deprecated in favor of
update_column, and will be removed in Rails 4.

See the discussion on rails-core here:
https://groups.google.com/d/topic/rubyonrails-core/BWPUTK7WvYA/discussion
b081f6b
@fxn fxn Merge pull request #6739 from steveklabnik/3-2-stable
Deprecate update_attribute
63bcfbb
@fxn fxn registers the deprecation of update_attribute in the CHANGELOG 2109fd5
@rafaelfranca rafaelfranca Remove unneded tests.
Before b081f6b, this test are
asserting that update_attribute does the dirty tracking. Since we
deprecated this method and update_column write in the database directly
this tests will always fail.
a8e22ae
Commits on Jun 15, 2012
@route route ActionController::Metal doesn't have logger method, check it and then…
… delegate
3b1ea3d
@route route Added test for case when view doesn't have logger method when using A…
…ctionController::Metal controller.
4717c2f
Commits on Jun 16, 2012
@rafaelfranca rafaelfranca Merge pull request #6752 from steveklabnik/fix_5680
Respect absolute paths in compute_source_path.
52d0963
@arunagw arunagw It should also include text/css => Build Fix 909a4a5
@rafaelfranca rafaelfranca Merge pull request #6756 from arunagw/build_fix_ap
Build fix actionpack
ed93c86
Commits on Jun 18, 2012
Francesco Rodríguez bump AS deprecation_horizon to 4.0 a556c7e
@rafaelfranca rafaelfranca Merge pull request #6764 from frodsan/patch-4
bump AS deprecation_horizon to 4.0
284ebf2
@josevalim josevalim Use strict_args_position! if available from Thor 83451be
@steveklabnik steveklabnik Deprecating composed_of in ActiveRecord
This feature adds a lot of complication to ActiveRecord for dubious
value. Let's talk about what it does currently:

class Customer < ActiveRecord::Base
  composed_of :balance, :class_name => "Money", :mapping => %w(balance
amount)
end

Instead, you can do something like this:

    def balance
      @balance ||= Money.new(value, currency)
    end

    def balance=(balance)
      self[:value] = balance.value
      self[:currency] = balance.currency
      @balance = balance
    end

Since that's fairly easy code to write, and doesn't need anything
extra from the framework, if you use composed_of today, you'll
have to add accessors/mutators like that.

This feature will be removed in Rails 4.
44b313b
@rafaelfranca rafaelfranca Merge pull request #6742 from steveklabnik/deprecate_composed_of
Deprecate composed of
ffcecf2
Commits on Jun 19, 2012
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6649 from route/logger_in_metal_3_2
Logger in metal backport for 3.2
2363aaf
@josevalim josevalim Merge pull request #6758 from caironoleto/master
Fixing load config in some tasks
Conflicts:
	activerecord/lib/active_record/railties/databases.rake
94489a2
Commits on Jun 21, 2012
@rafaelfranca rafaelfranca Merge branch 'acapilleri-update_nested_attributes'
Closes #6675

Conflicts:
	activerecord/lib/active_record/attribute_methods/dirty.rb
40617c7
@rafaelfranca rafaelfranca Remove waning of unused variable 200e6a6
Commits on Jun 24, 2012
@rafaelfranca rafaelfranca Merge pull request #6842 from ernie/handle-non-strings-in-grouped-cal…
…culations

Stop assuming strings for grouped calculations
Conflicts:
	activerecord/lib/active_record/relation/calculations.rb
12ac977
Commits on Jun 25, 2012
@carlosantoniodasilva carlosantoniodasilva Ensure Arel columns are typecasted properly when grouping with calcul…
…ation

Fix build issue with postgresql.

Conflicts:
	activerecord/lib/active_record/relation/calculations.rb
	activerecord/test/cases/calculations_test.rb
f8f4ac9
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6857 from rsutphin/as_core_ext_time_missing_require
Missing require breaks Time.=== when selectively loading ActiveSupport core_exts in 3.2.4+
3fccf6a
Commits on Jun 28, 2012
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6900 from cbandy/issue-6898
Require URI in ConnectionSpecification
Conflicts:
	activerecord/lib/active_record/connection_adapters/connection_specification.rb
10e5685
@rafaelfranca rafaelfranca Merge pull request #6878 from masarakki/master
fix bug in limit of enum columns of mysql

Closes #6432
48601c2
Commits on Jun 29, 2012
@fxn fxn make sure the inflection rules are loaded when cherry-picking active_…
…support/core_ext/string/inflections.rb [fixes #6884]
9e0b3fc
Commits on Jul 02, 2012
Francesco Rodriguez Backport #3329 to 3-2-stable
Fix bug with autosave collection association on new record with a marked
for destroy record in autosave collection.

Fixes #6918.
b1e509a
@rafaelfranca rafaelfranca Merge pull request #6935 from frodsan/b1e509ad7a8c8264544f10f4666705c…
…d806b5408

Backport #3329 to 3-2-stable
dacc947
Commits on Jul 03, 2012
@mjtko mjtko Fix NumberHelper options wrapping to prevent verbatim blocks being re…
…ndered instead of line continuations. While I'm at it, wrap long comment lines consistently.

Conflicts:
	actionpack/lib/action_view/helpers/number_helper.rb

There was just one conflict related to the addition of the :format
option to number_to_percentage.
7faa620
Commits on Jul 05, 2012
@route route Show in log correct wrapped keys ffdca21
@rafaelfranca rafaelfranca Merge pull request #6973 from route/wrapped_keys_in_log_for_3_2
MIssed backport for 3.2
c7afc42
Commits on Jul 06, 2012
@josevalim josevalim Since Rails 3.2, use layout false to render no layout 03dcdc3
@rafaelfranca rafaelfranca Merge pull request #6985 from sidonath/disable-query-cache-for-locks
Disable query cache for lock queries
Conflicts:
	activerecord/lib/active_record/connection_adapters/abstract/query_cache.rb
7adc4f2
Commits on Jul 09, 2012
@sikachu sikachu Update coding convention from master 904eace
@fxn fxn Merge pull request #7015 from sikachu/3-2-stable-code-style
Update coding convention from master
45d78a3
Commits on Jul 10, 2012
@rustygeldmacher rustygeldmacher Fixed bug creating invalid HTML in select options
When a select tag is created for a field with errors, and that select
tag has :prompt or :include_blank options, then the inserted first
option will errantly have a <div class="field_with_errors"> wrapping
it.

See #7017
27c8deb
@rafaelfranca rafaelfranca Merge pull request #7025 from rustygeldmacher/select_options_valid_html
Select options valid html
3b1de4a
Commits on Jul 11, 2012
@robbkidd robbkidd Update psql adapter to rename a default pkey sequence during rename_t…
…able.
8d3eafe
@drogus drogus Merge pull request #7031 from robbkidd/rename_sequences_too_backport_…
…to_3-2

Back-port #6874 to 3.2: psql adapter should rename a default pk sequence during rename_table
e72d876
Commits on Jul 13, 2012
@jeremycole jeremycole Only use prepared statements when bind variables are present
Prepared statements (prepare/execute/close) were being used unnecessarily
when no bind variables were present, and disabling prepared statement using
prepared_statements:false was principally broken. While bind variables were
correctly substituted with prepared_statements:false, the prepared statement
interface was still used, costing an extra two round trips per query.

In addition to making this behavioral change, I also cleaned up the internals
of exec_stmt and exec_without_stmt so that they behave the same (calling log
and constructing the ActiveRecord::Result in the same way).

Moving the check for binds.empty? to exec_query also will mean that several
code paths explicitly calling exec_without_stmt could be cleaned up to once
again call exec_query instead. I have also left the check for binds.empty? in
exec_stmt, since it is not a private method and could be called directly with
an empty binds array. For the sake of clarity in this patch, I have not made
those changes.

= The previous behavior =

When issuing a Foo.find(1) with prepared_statements:true, the bind variable
is present in the prepared query, and execute shows a value passed:

    Connect	root@localhost on rails_test
    Query	SET SQL_AUTO_IS_NULL=0
    Statistics
    Query	SHOW FULL FIELDS FROM `foos`
    Query	SHOW TABLES LIKE 'foos'
    Query	SHOW CREATE TABLE `foos`
    Prepare	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = ? LIMIT 1
    Execute	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
    Close stmt
    Quit

When issuing a Foo.find(1) with prepared_statements:false, the bind variable
has already been removed and substituted with the value, but the prepared
statement interface is used anyway:

    Connect	root@localhost on rails_test
    Query	SET SQL_AUTO_IS_NULL=0
    Statistics
    Query	SHOW FULL FIELDS FROM `foos`
    Query	SHOW TABLES LIKE 'foos'
    Query	SHOW CREATE TABLE `foos`
    Prepare	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
    Execute	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
    Close stmt
    Quit

= With this patch applied =

When issuing a Foo.find(1) with prepared_statements:true, the bind variable
is present in the prepared query, and execute shows a value passed:

    Connect	root@localhost on rails_test
    Query	SET SQL_AUTO_IS_NULL=0
    Statistics
    Query	SHOW FULL FIELDS FROM `foos`
    Query	SHOW TABLES LIKE 'foos'
    Query	SHOW CREATE TABLE `foos`
    Prepare	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = ? LIMIT 1
    Execute	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
    Close stmt
    Quit

When issuing a Foo.find(1) with prepared_statements:false, the bind variable
has been removed and substituted with the value, and the query interface is
used instead of the prepared statement interface:

    Connect	root@localhost on rails_test
    Query	SET SQL_AUTO_IS_NULL=0
    Statistics
    Query	SHOW FULL FIELDS FROM `foos`
    Query	SHOW TABLES LIKE 'foos'
    Query	SHOW CREATE TABLE `foos`
    Query	SELECT  `foos`.* FROM `foos`  WHERE `foos`.`id` = 1 LIMIT 1
    Quit
e4ef90a
@jeremycole jeremycole Fixing texts; down to three failing tests. 8f43230
@tenderlove tenderlove fixing tests to deal with data differences between prepared statement…
…s and non-prepared statements
f7ef7ca
Commits on Jul 14, 2012
@fxn fxn adds a missing require [fixes #6896]
This file uses Time.zone, which is defined in
active_support/core_ext/time/zones.rb.
b3693bf
Commits on Jul 16, 2012
@jmazzi jmazzi Update documentation for Rails::Application#env_config c6ad167
Commits on Jul 17, 2012
@rafaelfranca rafaelfranca Merge pull request #4396 from kennyj/fix_4259
Fix GH #4259. When we execute schema dumper, we must remove table_name_prefix and table_name_suffix.
e23ec4c
@pixeltrix pixeltrix Add support for optional root segments containing slashes
Optional segments with a root scope need to have the leading slash
outside of the parentheses, otherwise the generated url will be empty.
However if the route has non-optional elements then the leading slash
needs to remain inside the parentheses otherwise the generated url
will have two leading slashes, e.g:

Blog::Application.routes.draw do
  get '/(:category)', :to => 'posts#index', :as => :root
  get '/(:category)/author/:name', :to => 'posts#author', :as => :author
end

$ rake routes
  root GET /(:category)(.:format)              posts#index
author GET (/:category)/author/:name(.:format) posts#author

This change adds support for optional segments that contain a slash,
allowing support for urls like /page/2 for the root path, e.g:

Blog::Application.routes.draw do
  get '/(page/:page)', :to => 'posts#index', :as => :root
end

$ rake routes
root GET /(page/:page)(.:format) posts#index

Fixes #7073
(cherry picked from commit d8745de)
71d274d
@jfirebaugh jfirebaugh AR::Integration must be included after AM::Conversion
Integration's definition of #to_param must override
Conversion's. Otherwise, there is a regression from
3.1 in the behavior of a non-persisted AR::Base instance
which nevertheless has an id.
9b5309f
@jonleighton jonleighton Merge pull request #7080 from jfirebaugh/to_param_regression
AR::Integration must be included after AM::Conversion
827f369
Commits on Jul 19, 2012
@arunagw arunagw Bumping mocha!
Reason:- 0.12.0 introduced a bug where you got a exception
which is now in 0.12.1 is a warning only!
89dee0e
@rafaelfranca rafaelfranca Merge pull request #7108 from arunagw/mocha_bump
Bumping mocha!
22880de
Commits on Jul 20, 2012
@carlosantoniodasilva carlosantoniodasilva Merge pull request #6616 from dpassage/fix_resolver_test_sqlite3
Resolver tests fail if mysql adapter not installed
b16e7ed
@jonleighton jonleighton Deprecate :finder_sql, :counter_sql, :insert_sql, :delete_sql. a79bfa9
@rafaelfranca rafaelfranca `validates_inclusion_of` and `validates_exclusion_of` now accept
`:within` option as alias of `:in` as documented.

Fix #7118
089371a
Commits on Jul 21, 2012
@fxn fxn Hash#fetch(fetch) is not the same as doing hash[key] a37b90c
Commits on Jul 23, 2012
@pixeltrix pixeltrix Bump Journey requirements to 1.0.4
There are some Action Pack tests for regressions from 3.1 that require
a later version of Journey to pass so bump to the current version.
6b7d26c
@tenderlove tenderlove updating changelogs 125dfdf
@tenderlove tenderlove updating the version 753c546
Commits on Jul 25, 2012
@smartinez87 smartinez87 New #update_columns method. f27a8eb
@parndt parndt Suggest using update_columns instead of update_column.
update_column is deprecated in Rails 4.0 so it makes no sense to
recommend adopting it only to require changing to update_columns
in the very next release.
a0b85b9
@tenderlove tenderlove Merge pull request #7159 from parndt/update_columns
Backport update_columns to Rails 3.2
def9c85
Commits on Jul 26, 2012
@carlosantoniodasilva carlosantoniodasilva Fix AR#update_columns tests on Ruby 1.8.7 17a64de
@parndt parndt Switched update_column recommendation in changelog to update_columns
This is related to #7159
9fa06c3
@rafaelfranca rafaelfranca Merge pull request #7164 from parndt/patch-4
Switched update_column recommendation in changelog to update_columns
3dae440
@tenderlove tenderlove * Do not convert digest auth strings to symbols. CVE-2012-3424 27311fe
@tenderlove tenderlove updating the changelog fb89f6f
@tenderlove tenderlove bumping to 3.2.7 21bcac1
@tenderlove tenderlove updating release date d1b9cf2
@tenderlove tenderlove Merge branch '3-2-rel' into 3-2-stable
* 3-2-rel:
  updating release date
  bumping to 3.2.7
  updating the changelog
  * Do not convert digest auth strings to symbols. CVE-2012-3424
  updating the version
  updating changelogs
133754e
Commits on Jul 27, 2012
@rafaelfranca rafaelfranca Only require the `:rails_env` task where is needed.
`:rails_env` tasks is not needed in all the tasks that depends of
`load_config`, only in the tasks that uses `Rails.env`.

Since `:rails_env` task set the `Rails.env` to be "development" if it is
not set we don't need the `||` statements too

Fix #7175.
4b8b8c1
@fxn fxn adds a missing require from Active Support
This file uses mattr_accessor.
db340da
Commits on Jul 28, 2012
@fxn fxn missing require: the AR session store depends on the AP abstract store
This require makes the dependency even more clear.
In particular we are eager loading the session
store but that does not work if AR is used
outside Rails, this patch is preliminary work
in fixing #7160.
bf16456
Francesco Rodriguez Backport #6995 to 3-2 stable
Update `test_help` to config properly turn natural language option.
Last versions of Turn don't monkey patch MiniTest to setup
the natural language option. Here is an [example](https://github.com/TwP/turn/blob/master/try/test_autorun_minitest.rb#L3).

This patches the following behaviour:

    $ rake test:units
    `<top (required)>': undefined method `use_natural_language_case_names='
    for MiniTest::Unit:Class (NoMethodError)
3326b8b
@rafaelfranca rafaelfranca Merge pull request #7187 from frodsan/fix_test_help
Backport #6995 to 3-2 stable
be408d6
@fxn fxn removes the AR session store from eager loaded code [fixes #7160]
See the comment in the file activerecord/lib/active_record.rb
added by this patch for the rationale.
cc712f2
Commits on Jul 30, 2012
@rafaelfranca rafaelfranca Revert "Add update_columns and the suggestion of using update_columns
instead of update_column"

This reverts commit 9fa06c3.

This reverts commit 17a64de.

This reverts commit def9c85, reversing
changes made to 6b7d26c.

Reason: This was supposed to be released with 3.2.7 before the
suggestion to use update_column. Since it was not release now is not
good to suggest to use another method because it will confusing the
people.
2f930df
Commits on Jul 31, 2012
@rafaelfranca rafaelfranca Add CHANGELOG entry [ci skip] a893672
Commits on Aug 01, 2012
@rafaelfranca rafaelfranca Merge pull request #7147 from pferdefleisch/scaffold_controller_docs
Updated scaffold_controller generator docs #7146
69fd0e8
@rafaelfranca rafaelfranca Merge pull request #7070 from jmazzi/3-2-stable
Update documentation for Rails::Application#env_config
3e01a2a
@spastorino spastorino Add missing CHANGELOG entries
[ci skip]
6764b7b
@jonleighton jonleighton Revert "Deprecate :finder_sql, :counter_sql, :insert_sql, :delete_sql."
This reverts commit a79bfa9.

Conflicts:
	activerecord/CHANGELOG.md

We shouldn't introducing deprecations in point releases.
It will be deprecated in 4.0 instead.
0c52702
@rafaelfranca rafaelfranca Revert "Deprecating composed_of in ActiveRecord"
This reverts commit 44b313b.
736bf14
@rafaelfranca rafaelfranca Revert "Deprecate `:confirm` in favor of `:data => { :confirm => 'Tex…
…t' }` option"

Revert "Deprecate `:disable_with` in favor of `'data-disable-with'` option for `button_to` and `submit_tag` helpers."

This reverts commit fc092a9.
This reverts commit e9051e2.
This reverts commit d47d6e7.
This reverts commit 21141e7.
89177ba
@fxn fxn revises the deprecation warning of update_attribute
We have decided not to drop this important method in 4.0 and give
it a longer deprecation cycle. On the other hand we do not expect
to have update_column around for a long time, it is going to be
replaced in favor of update_columns.
f203be9
@fxn fxn removes the deprecation of update_attribute
Applying the new policy here to not deprecate stuff in point releases.
81542f9
@rafaelfranca rafaelfranca Fix CHANGELOGS 857697b
@rafaelfranca rafaelfranca Revert "Deprecate ActiveSupport::JSON::Variable"
This reverts commit bcfa013.
af65b8c
@rafaelfranca rafaelfranca Revert "Deprecate `:mouseover` options for `image_tag` helper."
This reverts commit 1aff772.

Conflicts:
	actionpack/CHANGELOG.md
e826a5c
@rafaelfranca rafaelfranca Revert "Deprecate link_to_function and button_to_function helpers"
This reverts commit 9dc57fe.
f50a5d2
@spastorino spastorino Bump to 3.2.8.rc1 fcccbac
@spastorino spastorino This entry is wrong 74cf196
Commits on Aug 02, 2012
@ffmike ffmike Fix ActiveSupport integration with Mocha > 0.12.1
Mocha 0.12.2 renames the Integration module to
MonkeyPatching. This breaks the code Rails uses
to retrieve the assertion counter from Mocha.
5c42889
@rafaelfranca rafaelfranca Do not consider the numeric attribute as changed if the old value is
zero and the new value is not a string.

Before this commit this was the behavior

r = Review.find_by_issue(0)
r.issue
=> 0
r.changes
=> {}
r.issue = 0
=> 0
r.changed?
=> true
r.changes
=> {"issue"=>[0,0]}

Fixes #7237
55e05d4
@rafaelfranca rafaelfranca Use `:data => { :confirm => "Text" }` syntax instead of `:confirm` at
the ERB scaffold generator.

We are trying to teach the data attributes as best practices and
`:confirm` will be deprecated in 4.0.
9c1b1bd
@spastorino spastorino html_escape should escape single quotes
https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content
Closes #7215

Conflicts:
	actionpack/test/template/erb_util_test.rb
	actionpack/test/template/form_tag_helper_test.rb
	actionpack/test/template/text_helper_test.rb
	actionpack/test/template/url_helper_test.rb
	activesupport/lib/active_support/core_ext/string/output_safety.rb
28f2c6f
@rafaelfranca rafaelfranca Fix html_escape with Ruby 1.8 ebddf75
@rafaelfranca rafaelfranca More `:rails_env` cleanup.
`Rails.env` already use development if ENV["RAILS_ENV"] is not present.
469d885
Commits on Aug 03, 2012
@spastorino spastorino Add CHANGELOG entry 5f9ae95
@spastorino spastorino Bump to 3.2.8.rc2 65b5e35