Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: rails/rails
...
head fork: rails/rails
Commits on Feb 19, 2012
@pwnall pwnall Removed (outdated?) config.action_view.logger from configuration guide. 64fa7f7
Commits on Feb 22, 2012
@tenderlove tenderlove Merge pull request #5084 from johndouthat/patch-1
Remove reference to rails_legacy_mapper, which isn't compatible with 3.2...
fadad9f
@tenderlove tenderlove Merge pull request #5087 from pwnall/no_view_logger
Remove reference to config.action_view.logger from Rails configuration guide
c5c3274
Commits on Feb 23, 2012
@josevalim josevalim Avoid inspecting the whole route set, closes #1525 419040f
@tenderlove tenderlove Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_pr…
…epare

Fix usage of psql in db:test:prepare
6dbf6f3
Commits on Feb 25, 2012
@arunagw arunagw Build fix for ruby187-p358 99fa8e5
@fxn fxn Merge pull request #5164 from arunagw/build_fix_ruby187-p358
Build fix ruby187 p358
5661dab
@arunagw arunagw Checking headers in a better way. as doing here 0bfcd4f
@fxn fxn Merge pull request #5166 from arunagw/3-2-stable
3 2 stable
8125304
@arunagw arunagw assert => assert_equal a9b1397
@spastorino spastorino Merge pull request #5170 from arunagw/3-2-stable
assert => assert_equal
0a1357b
@noahhendrix noahhendrix Fixed typo in composed_of example with Money#<=>, was comparing amoun…
…t itself instead of other_money.amount
e1f799a
@glitterfang glitterfang Fix typo in match :to docs b229bc7
@RalphShnelvar RalphShnelvar Fixing Windows asset tag helper test failure
In asset_tag_helper_test.rb there is an assert on the number of bytes in a
concatenated file.  This test failed because Windows converts \n to \r\n as
the default for "w".  This is different than in *nix systems where there is
no conversion done.

THe test that failed was test_caching_stylesheet_link_tag_when_caching_on

Using bin mode fixes this behavior on windows and makes no change on the
*nix systems.
06dc8ed
Commits on Feb 26, 2012
@pixeltrix pixeltrix Adding tests for non-optional glob parameters b8c4f2d
@rafaelfranca rafaelfranca Revert "No need to pass options which is never used"
Options is needed for some Rails extensions to determine when
referential integrity should be disabled

This reverts commit bcb466c.

Fixes #5052
663904f
Commits on Feb 27, 2012
@rafaelfranca rafaelfranca Add a new line after the textarea opening tag.
Closes #393
2b4e7a7
@tenderlove tenderlove Merge pull request #5179 from RalphShnelvar/Binary_mode_Window_bug
Binary mode window bug
b543f8f
@tenderlove tenderlove Merge pull request #5190 from rafaelfranca/fix-393-3-2-stable
[3-2-stable] Add a new line after the textarea opening tag.
210c33f
@tenderlove tenderlove call binmode on the tempfile for Ruby 1.8 compatibility 72ae0b4
Commits on Feb 28, 2012
@kennyj kennyj Fix type_to_sql with text and limit on mysql/mysql2. Fix GH #3931. f1f2e8c
Commits on Feb 29, 2012
@tenderlove tenderlove Merge pull request #5206 from kennyj/fix_5173-32
[3-2-stable] Fix type_to_sql with text and limit on mysql/mysql2. Fix GH #3931
5bb5780
Commits on Mar 01, 2012
@tenderlove tenderlove Merge branch '3-2-2' into 3-2-stable
* 3-2-2:
  bumping to 3.2.2
  Ensure [] respects the status of the buffer.
  Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_prepare
  Merge pull request #5084 from johndouthat/patch-1
  updating RAILS_VERSION
  delete vulnerable AS::SafeBuffer#[]
  use AS::SafeBuffer#clone_empty for flushing the output_buffer
  add AS::SafeBuffer#clone_empty
  fix output safety issue with select options
c289790
Commits on Mar 02, 2012
@fxn fxn revert setting NOT NULL constraints in add_timestamps
Commit 3dbedd2 added NOT NULL constraints both to table
creation and modification. For creation the new default
makes sense, but the generic situation for changing a
table is that there exist records. Those records have
no creation or modification timestamps, and in the
general case you don't even know them, so when updating
a table these constraints are not going to work. See
a bug report for this use case in #3334.
bbe7dac
@drogus drogus Fix #5238, rendered_format is not set when template is not rendered 1a71e84
@carlosantoniodasilva carlosantoniodasilva Stop SafeBuffer#clone_empty from issuing warnings
Logic in clone_empty method was dealing with old @dirty variable, which
has changed by @html_safe in this commit:
139963c

This was issuing a "not initialized variable" warning - related to:
#5237

The logic applied by this method is already handled by the [] override,
so there is no need to reset the variable here.
5fd3601
@spastorino spastorino Add CHANGELOG entry 8674823
@tenderlove tenderlove only log an error if there is a logger. fixes #5226
Conflicts:

	activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
af02291
Commits on Mar 03, 2012
@spastorino spastorino Turn off verbose mode of rack-cache, we still have X-Rack-Cache to ch…
…eck that info

Closes #5245
520571a
@vijaydev vijaydev CSS fix for guides. Closing #5028 [ci skip]
In Ubuntu Chrome, in the last lines of code blocks, the underscore isn't
visible. Increasing the line height slightly seems to fix this. This
problem doesn't exist in Firefox even on Ubuntu. Too lazy to test in
any other OS-browser combo :)
23ca13a
Commits on Mar 04, 2012
@larskanis larskanis fix associations when using per class databases
would get ConnectionNotEstablished error because it always tried to use
ActiveRecord::Base's connection, even though it should be using the connection
of the model whose context we're operating in
f6d478a
@carlosantoniodasilva carlosantoniodasilva Only run binary type cast test with encode! on Ruby 1.9 864d755
@NZKoz NZKoz Whitelist all attribute assignment by default.
Change the default for newly generated applications to whitelist all attribute assignment.  Also update the generated model classes so users are reminded of the importance of attr_accessible.
06a3a8a
Commits on Mar 05, 2012
@rafaelfranca rafaelfranca Only add the whitelist_attributes option if ActiveRecord is present
Conflicts:

	railties/test/generators/app_generator_test.rb
	railties/test/isolation/abstract_unit.rb
f604a63
@rafaelfranca rafaelfranca Now all the models need to explicitly declare the accessible attributes 2a6b7e5
@NZKoz NZKoz Merge pull request #5278 from rafaelfranca/fix-build-3-2
[3-2-stable] Fix build
ebc5a19
@byroot byroot Fix #5069 - Protect foreign key from mass assignment throught associa…
…tion builder
e1a882a
Commits on Mar 06, 2012
@mariovisic mariovisic Failing test for mime responder respond_with using a block. 5b73a3a
@sikachu sikachu Always passing a respond block from to responder
We should let the responder to decide what to do with the given
overridden response block, and not short circuit it.

Fixes #5280
82a8698
@josevalim josevalim Merge pull request #5299 from sikachu/3-2-stable-fix-responder
Always passing a respond block from to responder
688e4f0
@mikel mikel Increasing minimum version of mail due to security vulnerability foun…
…d in Mail 2.4.1 for sendmail or exim
0d2798e
@josevalim josevalim Use latest rack-cache. 9c56401
@spastorino spastorino Deprecate ActionController::SessionManagement 74fe7e1
Commits on Mar 07, 2012
@josevalim josevalim Just change the formats on first render, closes #5307, closes #5308. bcea8cd
@josevalim josevalim Set the rendered_format on respond_to. e7560bc
@carlosantoniodasilva carlosantoniodasilva Add test case for #5307 b35fd40
@josevalim josevalim Remove usage of deprecated module. 3775058
@josevalim josevalim Merge pull request #5316 from Jacobkg/master
Update ActiveRecord::AttributeMethods#attribute_present? to return false for empty strings
524e8a1
@kuahyeow kuahyeow Add tests to test that through associations are not readonly, and we …
…can update the records we retrive from the association
9bcd662
Commits on Mar 08, 2012
@mreinsch mreinsch fix ArgumentError being raised in case of invalid byte sequences 55cac81
@carlosantoniodasilva carlosantoniodasilva Improve docs for attr_accessible|protected related to Hash#except|slice e63f04c
@Mik-die Mik-die typo 1f2224d
@swanandp swanandp Fixed a slightly misleading equivalent SQL code on the 3.2 query inte…
…rface.
30feb8c
@bschaeffer bschaeffer Fix doc examples for has_and_belongs_to_many association 357e288
@mattreduce mattreduce Fix typo in asset pipeline guide 061f8ae
@caius caius Fix typo in isolated engine docs 22a8433
@coreyhaines coreyhaines Left off a : when specifying the :namespace option for a :controller
path segment
df755d4
@vijaydev vijaydev In a nested resource route, the parent resource param is <resource_na…
…me>_id

This fix was made by @coreyhaines on docrails and merged in master.
Cleanly cherry picking into 3-2-stable wasn't possible.
c1a01c7
@vijaydev vijaydev changelog updates [ci skip] 3bfd651
@vijaydev vijaydev update changelogs for gems without changes too [ci skip] 263d842
@tenderlove tenderlove make active_connection? return true only if there is an open connecti…
…on in use for the current thread. fixes #5330
cff19cf
Commits on Mar 09, 2012
@tenderlove tenderlove ensure that released connections move between threads 94b2c8c
@rafaelfranca rafaelfranca Add test case to has_many through association when mass_assignment_sa…
…nitizer is

:strict

Conflicts:

	activerecord/test/models/person.rb
7cd4063
@rafaelfranca rafaelfranca Not need to pass join attributes to association build f18c054
@rafaelfranca rafaelfranca Fix my name in the CHANGELOG to follow the convention
Also add missing entries and use the formating convention
db743ff
@vijaydev vijaydev Merge pull request #5350 from rafaelfranca/changelog-fix-3-2
Changelog fix 3 2
9814420
@josevalim josevalim Merge pull request #5347 from rafaelfranca/fix-has_many_association-3-2
[3-2-stable] Fix has many through associations when mass_assignment_sanitizer is :strict
2b9041b
Commits on Mar 12, 2012
@pixeltrix pixeltrix Add dynamic find_or_create_by_{attribute}! method.
(cherry picked from commit 5282485d310d1a6ffcf55e4e7f56ab234e16880d)

Conflicts:

	activerecord/CHANGELOG.md
	activerecord/lib/active_record/dynamic_finder_match.rb
90d9635
@pixeltrix pixeltrix Add documentation for find_or_create_by_{attribute}! method. a01f0ab
@jrochkind jrochkind inline docs for clear_active_connections! no longer says it cleans de…
…ad threads, it doesn't since 3.2.0
bb8f4c2
@tenderlove tenderlove Merge pull request #5391 from jrochkind/connection_pool_doc
ConnectionPooll#clear_active_connections! rdoc inaccuracy since 3.2.0
da0595d
@tenderlove tenderlove make sure connections returned after close are marked as in_use 5f26ce6
Commits on Mar 13, 2012
@parndt parndt Fixes issue #5193 using the instructions provided in the issue. f665e20
@parndt parndt Fixed problem when fixture_path is not always defined (incidentally, …
…only when ActiveRecord is according to test_help.rb).
5ef8069
@denisj denisj fix activerecord query_method regression with offset into Fixnum
add test to show offset query_methods on mysql & mysql2

change test to cover public API
f67944e
@josevalim josevalim Merge pull request #5400 from arunagw/issue_4409
Issue 4409
a9320f7
@josevalim josevalim Merge pull request #5398 from parndt/fix_issue_5193
Fix issue 5193
d2ac18a
@rafaelfranca rafaelfranca Do not use the attributes hash in the scaffold functional tests 5bed0e5
@rafaelfranca rafaelfranca Use the attributes hash explicitly ac8469d
@rafaelfranca rafaelfranca Use Ruby 1.8 hash syntax c1610eb
@josevalim josevalim Merge pull request #5410 from rafaelfranca/fix-scaffold-3-2
[3-2-stable] Do not use the attributes hash in the scaffold functional tests
dfbbf31
@kennyj kennyj [3-2-stable] Fix GH #5399. connection_pools's keys are ActiveRecord::…
…Base::ConnectionSpecification objects.
21d9c0f
@avakhov avakhov Fix layout method doc formatting 5f28145
@britto britto Close string quotes a782fea
@tenderlove tenderlove Merge pull request #5417 from kennyj/fix_5399-32
[3-2-stable] Fix GH #5399. connection_pools's keys are ActiveRecord::Base::ConnectionSpecification objects.
596ecf7
@jrochkind jrochkind ConnectionPool.checkout takes account of ruby using 'non-blocking con…
…dition variables' in mutex ConditionVariables
41563b4
Commits on Mar 14, 2012
@tenderlove tenderlove Merge pull request #5423 from jrochkind/checkout_account_for_monitor_…
…model

ConnectionPool.checkout needs to be restructured to take account of ruby's "non-blocking" strategy for mutex ConditionVariables
f2aea24
@dhh dhh Do not include the authenticity token in forms where remote: true as …
…ajax forms use the meta-tag value
16ee611
@dhh dhh Allow you to force the authenticity_token to be rendered even on remo…
…te forms if you pass true
e50abba
Commits on Mar 15, 2012
@drogus drogus Remove ActionController::TestCase#rescue_action_in_public!
This method has no effect since exception handling was
moved to middlewares and ActionController tests do not
use any middlewares.
ccf4ff0
@drogus drogus Check for existence of exactly the called `fixture_path=` method 9dfb41f
@tenderlove tenderlove Merge pull request #5338 from mreinsch/3-2-static_invalid_byte_sequence
3 2 static invalid byte sequence
f918137
@tenderlove tenderlove Merge pull request #5437 from kennyj/fix_5430
Fix GH #5430. A Payload name for schema_search_path should be SCHEMA.
bd3e1ed
@tenderlove tenderlove Merge pull request #5456 from brianmario/redirect-sanitization
Strip null bytes from Location header
f52ad6c
@tenderlove tenderlove Merge pull request #5457 from brianmario/typo-fix
Fix typo in redirect test
e135ff1
Commits on Mar 17, 2012
@drogus drogus Fix #5440 - multiple render_to_string breaks partials formats
This fixes situation where rendering template to string
sets `rendered_format` to the format rendered there.
This is ok to have consistent formats rendered in partials,
but it breaks on next renders if format is explicitly set
or on last render where default format does not necessarily
need to be the format of first rendered template.
1eb6189
@drogus drogus Add missing test for #5308 7130f91
@josevalim josevalim Merge pull request #5480 from drogus/rendering-issues
Fix for #5440
e5b46cf
@josevalim josevalim Ensure load hooks can be called more than once with different contexts. c0a5b85
@drogus drogus Rubyracer does not work on ruby, so add it to Gemfile with :ruby plat…
…form only
41815f5
Commits on Mar 18, 2012
@kennyj kennyj Fix GH #5435. db:structure:dump should be re-enable. f4f9ec1
@drogus drogus Merge pull request #5493 from kennyj/fix_5435-32
[3-2-stable] Fix GH #5435. db:structure:dump should be re-enable.
d9355be
@arunagw arunagw Build fix for app_generator_test.rb 9451201
@josevalim josevalim Merge pull request #5498 from arunagw/build_fix_app_generator_test_3-…
…2-stable

Build fix app generator test 3 2 stable
c8fbd48
Commits on Mar 19, 2012
@mikel mikel Increase minimum version of mail.
  Second security vulnerability found in mail file delivery method
  patched in version 2.4.4.
74b7829
@arunagw arunagw Build fix for ruby1.8.7-358 fcc8743
@josevalim josevalim Merge pull request #5505 from arunagw/build_fix_1.8.7-3-2-stable
Build fix 1.8.7 3 2 stable
358333f
Commits on Mar 20, 2012
@dhh dhh We dont need to merge in the parameters as thats all being reset by t…
…he rack headers (and its causing problems for Strong Parameters attempt of wrapping request.parameters because it will change in testing)
275ee0d
Commits on Mar 21, 2012
@mhfs mhfs [3-2-stable] Remove blank line from generated migration 57c6b4c
@kennyj kennyj migrate(:down) method with table_name_prefix 565bfb9
@josevalim josevalim Merge pull request #5533 from mhfs/migration_blank_line_3_2
[3-2-stable] Remove blank line from generated migration
f829515
@mhfs mhfs [3-2-stable] Port of #5522 'Fix adding/removing field's index when ge…
…nerating migration'
35bf748
Commits on Mar 22, 2012
@drogus drogus Merge pull request #5542 from mhfs/port_5522_to_32stable
Port of #5522 'Fix adding/removing field's index when generating migration'
89f8866
@kennyj kennyj Fix GH #5411. When precompiling, params method is undefined. 8c262f7
@josevalim josevalim Merge pull request #5525 from kennyj/fix_5411
Fix GH #5411. When precompiling, params method is undefined.
b714140
Commits on Mar 23, 2012
@carlosantoniodasilva carlosantoniodasilva Add order to tests that rely on db ordering, to fix failing tests on pg
Also skip persistente tests related to UPDATE + ORDER BY for postgresql

PostgreSQL does not support updates with order by, and these tests are
failing randomly depending on the fixture loading order now.
b332891
@tenderlove tenderlove Merge pull request #5557 from carlosantoniodasilva/fix-build-3-2
Fix build for branch 3-2-stable
ea4e021
@carlosantoniodasilva carlosantoniodasilva Fix identity map tests 0879ebd
@drogus drogus Merge pull request #5558 from carlosantoniodasilva/fix-build-3-2
Fix build for branch 3-2-stable - Part 2
ef48cea
@tenderlove tenderlove Merge pull request #5537 from kennyj/fix_4399-32
[3-2-stable] migrate(:down) method with table_name_prefix
0382e44
@tenderlove tenderlove chdir before globbing so that we don't need to escape directory names.
fixes #5521
eb0d8ee
Commits on Mar 24, 2012
@carlosantoniodasilva carlosantoniodasilva Return the same session data object when setting session id
Make sure to return the same hash object instead of returning a new one.
Returning a new one causes failures on cookie store tests, where it
tests for the 'Set-Cookie' header with the session signature.

This is due to the hash ordering changes on Ruby 1.8.7-p358.
907bcce
Commits on Mar 26, 2012
@abevoelker abevoelker Fix 'Security#Mass Assignment' URL typo ed7567c
@lest lest apply form_for namespace option to date_select bd8a970
@drogus drogus Merge pull request #5596 from lest/patch-3
apply form_for namespace option to date_select
3f1b8c6
@josevalim josevalim Merge pull request #5597 from carlosantoniodasilva/fix-build-3-2
Fix build for branch 3-2-stable - return the same session hash object
0e916ae
Commits on Mar 27, 2012
@tenderlove tenderlove Merge pull request #2621 from icco/master
Issue with schema dump
3eb5be6
@drogus drogus If partial is rendered in controller, grab format from template
Previously `rendered_format` was set only based on mime types
passed in Accept header, which was wrong if first type from
Accept was different than rendered partial. The fix is to simply
move setting rendered_format to the place where template
is available and grab format from the template. If it fails
we can fallback to formats passed by Accept header.
449a4fc
@josevalim josevalim Merge pull request #5603 from drogus/fix-rendered-format-for-render-p…
…artial

Fix rendered format for render partial
e31ec47
@spastorino spastorino Bumping to 3.2.3.rc1 5f37260
@spastorino spastorino Merge pull request #5619 from jcoleman/textarea-newline-fix-breaks-haml
Textarea newline fix breaks haml (3-2-stable)
4f66586
Commits on Mar 28, 2012
@spastorino spastorino Merge pull request #5633 from drogus/embed-auth-token-in-remote-forms
Embed auth token in remote forms
84ca8c8
@drogus drogus Cover one more case in auth_token and remote forms
If embedding auth_token in remote forms is off and we
pass a value for auth_token it should respect it.
db2c135
@spastorino spastorino Set proper rendered_format when doing render :inline
Closes #5632
87825a6
Commits on Mar 29, 2012
@vijaydev vijaydev fix incorrect url in the deprecation message for vendor/plugins [ci s…
…kip]
921c404
@spastorino spastorino Add missing CHANGELOG entry dd69076
@spastorino spastorino Add missing CHANGELOG entry b395ca1
@spastorino spastorino Bumping to 3.2.3.rc2 5284e65
Commits on Mar 30, 2012
@spastorino spastorino Remove the leading \n added by textarea on assert_select 5c7bb86
@spastorino spastorino Bump up to 3.2.3 45d6cd9