Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
Commits on Jun 01, 2012
@amatsuda amatsuda remove unneeded blank line from !namespeced? controller generators 8984bc2
@rafaelfranca rafaelfranca Merge pull request #6587 from amatsuda/controller_generator_remove_bl…

Backporting #6586 patch to 3-2-stable
@drogus drogus Include routes.mounted_helpers into integration tests
In integration tests, you might want to use helpers from engines that
you mounted in your application. It's not hard to add it by yourself,
but it's unneeded boilerplate. mounted_helpers are now included by
default. That means that given engine mounted like:

    mount Foo::Engine => "/foo", :as => "foo"

you will be able to use paths from this engine in tests this way:

    foo.root_path #=> "/foo"

(closes #6573)
@rafaelfranca rafaelfranca Add release date of 3.2.5 on the CHANGELOG b13d89e
@nbibler nbibler Use to_model delegates for polymorphic route generation 537ede9
@josevalim josevalim Merge pull request #6588 from nbibler/polymorphic_to_model
Correct the use of to_model in polymorphic routing
@yahonda yahonda Skip test_remove_column_with_array_as_an_argument_is_deprecated with …
…Oracle adapter.

Because Oracle adapter supports only remove_column :table_name, :column_name syntax
and it has never supported remove_column :table_name, [:column_name].
@drogus drogus Allow to use mounted helpers in ActionView::TestCase
Similarly to 6525002, this allows to use routes helpers for mounted
helpers, but this time in ActionView::TestCase
@rafaelfranca rafaelfranca Merge pull request #6593 from yahonda/skip_test_remove_column_with_ar…

Skip test_remove_column_with_array_as_an_argument_is_deprecated with Oracle
Commits on Jun 04, 2012
@earnold earnold Add failing test for 3.2.5 datetime attribute regression bebbdb5
@kennyj kennyj Fix #6591. If a field with timezone isn't changed, we don't call will…
@rafaelfranca rafaelfranca Merge pull request #6622 from kennyj/fix_6591-32
[3-2-stable back ported] Fix #6591 Rails 3.2.5 Regression: incorrect _changed? for datetimes
Commits on Jun 05, 2012
@carlosgaldino carlosgaldino Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` op…

This deprecation applies to:

As :confirm is an UI specific option is better to use the data attributes,
teaching users about unobtrusive JavaScript and how Rails works with it.
@rafaelfranca rafaelfranca Merge pull request #6613 from carlosgaldino/3-2-data-confirm
Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` option
@rafaelfranca rafaelfranca Add test to flash sweep after two redirects
This test is needed to avoid regressions in the way that flash works
now (swept in every request).
@rafaelfranca rafaelfranca Revert "fix the Flash middleware loading the session on every request…
… (very dangerous especially with Rack::Cache), it should only be loaded when the flash method is called"

This reverts commits e3069c6 and 2b2983d.

Reason: This add a non-backward compatible change in the way that flash
works now (swept in every request).
Commits on Jun 06, 2012
@kuroda kuroda Fix human attribute_name to handle deeply nested attributes
This is a back-port of b0e2fc8 to Rails 3.2.
See #5843 and #3859 also.
@josevalim josevalim Merge pull request #6642 from kuroda/3-2-activemodel-translation-patch
Fix human attribute_name to handle deeply nested attributes
Commits on Jun 07, 2012
@jonleighton jonleighton Revert "Perf: Don't load the association for #delete_all."
This reverts commit b98d1e2.

Closes #6609


@jonleighton jonleighton Make test cover previous reversion 68d3e1f
@drogus drogus Fix asset tags for files with more than one dot
After the fix done in 39f9f02, there are cases that will not work
correctly. If you have file with "2 extensions", like foo.min.js and you
reference the file without extension, like:

    javascript_include_tag "foo.min"

it will fail because sprockets finds foo.min.js with foo.min argument.

This commit fixes this case and will get the right file even when
referrencing it without extension.

(closes #6598)
@drogus drogus Fix railties test suite
Apparently asset_environment should not be invoked if it's not needed.
This fixes broken build by getting back to the code more similar to the
version changed here: 5b0a891
Commits on Jun 08, 2012
@arunagw arunagw Removed protected as we already doing it above. 7ad5f8b
@arunagw arunagw We should not include engine.rake file into rake
if we are passing -T which is skip_test_unit

See issue #6673 for more details.

I saw that we are not creating dummy app even if 
we do skip_test_unit. 

Fixes #6673
@rafaelfranca rafaelfranca Merge pull request #6677 from arunagw/3-2-stable
Removed protected as we already doing it above.
@rafaelfranca rafaelfranca Merge pull request #6678 from arunagw/fix_issue_6673
Fix issue 6673
@drogus drogus Don't add sqlite3 to gemspec with -O on rails plugin new
(closes #6672)
Commits on Jun 09, 2012
@tiegz tiegz ActiveRecord#attributes optimization: minimize objects created 6e4a064
@achamian achamian buffered logger is initialized with the log level passed trough the i…
@arunagw arunagw Duplicate tests removed. f36fd0e
@pixeltrix pixeltrix Merge pull request #6689 from arunagw/duplicate_test_removed
Duplicate test removed
@josevalim josevalim Merge pull request #6687 from tiegz/3-2-optimizations
ActiveRecord#attributes optimization: minimize objects created
Commits on Jun 10, 2012
@jkraemer jkraemer fix namespace collision with test-unit-activesupport e66c240
@josevalim josevalim Merge pull request #6693 from jkraemer/3-2-stable
Bugfix: Namespace collision with test-unit-activesupport 1.0.0
@rafaelfranca rafaelfranca Merge pull request #6695 from kennyj/fix_6635
Fix #6635. We should call Scoping methods, before calling Array methods.
@rafaelfranca rafaelfranca Merge pull request #6688 from c42engineering/buffered_logger_level_wh…

BufferedLogger level while creation
@iaddict iaddict Minimal change to query generation of exists? that makes SQLServer an…
…d others happy that do not work without a column alias.

@rafaelfranca rafaelfranca Add test to column alias in `exists?` SQL.
This behavior was added in dd286a4

Closes #1139.

Fixes #2553, #1141, #1623 and #2062.
@rafaelfranca rafaelfranca Remove warning 9e6eb8b
Commits on Jun 11, 2012
@rafaelfranca rafaelfranca Merge pull request #6521 from Empact/throw-result
Fix that #exists? can blow up with ThrowResult exception
@rafaelfranca rafaelfranca Merge pull request #6698 from yahonda/address_ora_911_master
Address ORA-00911 errors because of the heading underscore.
@rafaelfranca rafaelfranca Merge pull request #6690 from suginoy/fix-templates-copy
Fix: 'rake rails:templates:copy' doesn't work
@kennyj kennyj Fix GH #3163. Should quote database on mysql/mysql2.

@kennyj kennyj Change the string to use in test case.

@ernie ernie Additional fix for CVE-2012-2661
While the patched PredicateBuilder in 3.1.5 prevents a user
from specifying a table name using the `table.column` format,
it doesn't protect against the nesting of hashes changing the
table context in the next call to build_from_hash. This fix
covers this case as well.
@tenderlove tenderlove Array parameters should not contain nil values. 38edea0
@tenderlove tenderlove updating changelogs 301974a
@tenderlove tenderlove updating changelogs with security fixes ceb8ec3
@tenderlove tenderlove bumping version numbers ee4209a
Commits on Jun 12, 2012
@tenderlove tenderlove updating changelogs 8381d39