ActionDispatch::ParamsParser#parse_formatted_parameters does not rewind input #10840

Closed
dblock opened this Issue Jun 4, 2013 · 2 comments

Comments

Projects
None yet
3 participants

dblock commented Jun 4, 2013

This is a regression from Rails 3.x, but it could be by design: ActionDispatch::ParamsParser#parse_formatted_parameters will read the input via ActionDispatch::Request, and not rewind it.

It broke Grape mounted on Rails, see intridea/grape#417.

I think it might make sense to preserve input data in this case so that other middleware or consumers can read it. At least in Rails 3.2 this wasn't an issue since this data wasn't read.

Contributor

sorentwo commented Aug 6, 2013

This looks to have been fixed in f6746c0, as covered by rails/rails#11345. Can you confirm and close?

Owner

rafaelfranca commented Aug 6, 2013

RIght. Thank you for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment