ActiveModel's confirmation validator fix should be merged into 3.0 stable #1152

Closed
joevandyk opened this Issue May 19, 2011 · 5 comments

Projects

None yet

3 participants

Contributor

This should be merged into the stable branch: be9883b#activemodel/lib/active_model/validations/confirmation.rb

I have an ActiveModel class that has a method email_address_confirmation. This method is being overwritten by the method defined in the Confirmation validator.

Member

Could you please provide a patch and include tests?

Contributor

Should there be two patches, one for 3-0-stable (containing the fix and the test) and one for master (containing the test)?

Member

No need for the tests on 3-0-stable as it is going to only security releases
mode.

@joevandyk joevandyk pushed a commit to joevandyk/rails that referenced this issue May 24, 2011
@bjeanes bjeanes Initial nested_has_many_through support [#1152] b689834
Contributor

Sorry, I'm confused -- why wouldn't tests be necessary for 3-0-stable if a change is being made?

Contributor
dmathieu commented Jul 6, 2011

The 3-0-stable patch still hasn't been applied for this. Could you make a pull request ?

@josevalim josevalim closed this in be8485e Nov 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment