coding guidelines #1211

Closed
comboy opened this Issue May 22, 2011 · 1 comment

2 participants

@comboy

hello,
It's really tiny issue so if you feel like changing the world, please move on.

Textwidth. Is there any suggested max line size for rails code? I haven't found such information anywhere. 80 seems to be a bit too little for most cases currently I guess, and of course I don't mean having absolute limit, just having some common value everywhere which makes it easier to minimize scrolling and to make better use of screen. In some files it seems like somebody was trying to cut at 120, in some 90, it varies a a lot.

So is there any suggested line size? If not do you think it's worth having one? If yes then possibly it could be nice to add it to contributing guide.

have a nice time

@dhh
Ruby on Rails member

There's not a fixed length, but I generally like 120.

@dhh dhh closed this May 23, 2011
@jake3030 jake3030 pushed a commit to jake3030/rails that referenced this issue Jun 28, 2011
@hardbap hardbap Implement ActiveRecord#reset_counter_cache
[#1211 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
50c28e7
@jake3030 jake3030 pushed a commit to jake3030/rails that referenced this issue Jun 28, 2011
@gtd gtd Replace reset_counter_cache with reset_counters that has API inline w…
…ith existing update_counters method

[#1211 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
3239589
@svenfuchs svenfuchs pushed a commit to svenfuchs/rails that referenced this issue Jul 2, 2011
@hardbap hardbap Implement ActiveRecord#reset_counter_cache
[#1211 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
1db3a27
@svenfuchs svenfuchs pushed a commit to svenfuchs/rails that referenced this issue Jul 2, 2011
@gtd gtd Replace reset_counter_cache with reset_counters that has API inline w…
…ith existing update_counters method

[#1211 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
43d2cb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment