SprocketsHelper doesn't respect the old helpers api #1237

Closed
lucasmazza opened this Issue May 23, 2011 · 3 comments

Comments

Projects
None yet
3 participants
@lucasmazza
Member

lucasmazza commented May 23, 2011

sprockets_javascript_include_tag doesn't respect the api defined by javascript_include_tag when adding multiple sources, as in javascript_include_tag 'one', 'two', 'three' - I believe that the same happens with the stylesheet helpers.

@josh

This comment has been minimized.

Show comment
Hide comment
@josh

josh May 23, 2011

Member

This is an intention change. You really shouldn't need to have 10 script tag links because you can declare them to be all part of the same bundle.

Member

josh commented May 23, 2011

This is an intention change. You really shouldn't need to have 10 script tag links because you can declare them to be all part of the same bundle.

@josh josh closed this May 23, 2011

@lucasmazza

This comment has been minimized.

Show comment
Hide comment
@lucasmazza

lucasmazza May 23, 2011

Member

Anyway, the lack of flexibility gets in the way of a more modular usage (2/3 tags per page, maybe).

Member

lucasmazza commented May 23, 2011

Anyway, the lack of flexibility gets in the way of a more modular usage (2/3 tags per page, maybe).

@spohlenz

This comment has been minimized.

Show comment
Hide comment
@spohlenz

spohlenz May 30, 2011

Contributor

+1 to allowing multiple scripts/stylesheets. Whilst bundles are fine for most situations, this seems like a pointless regression in functionality.

Contributor

spohlenz commented May 30, 2011

+1 to allowing multiple scripts/stylesheets. Whilst bundles are fine for most situations, this seems like a pointless regression in functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment