[4.1.0.beta1] Generator calling `generate` hangs #13381

jcoyne · 2013-12-18T15:40:37Z

When I send an INT here's the trace:

    generate  blacklight:assets
^C/Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/spring-1.0.0/lib/spring/client/run.rb:74:in `gets': Interrupt
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/spring-1.0.0/lib/spring/client/run.rb:74:in `run_command'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/spring-1.0.0/lib/spring/client/run.rb:24:in `call'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/spring-1.0.0/lib/spring/client/command.rb:7:in `call'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/spring-1.0.0/lib/spring/client/rails.rb:23:in `call'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/spring-1.0.0/lib/spring/client/command.rb:7:in `call'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/spring-1.0.0/lib/spring/client.rb:23:in `run'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/spring-1.0.0/bin/spring:31:in `<top (required)>'
    from bin/rails:9:in `load'
    from bin/rails:9:in `<main>'
/Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/thor-0.18.1/lib/thor/actions.rb:252:in `system': Interrupt
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/thor-0.18.1/lib/thor/actions.rb:252:in `run'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/thor-0.18.1/lib/thor/actions.rb:264:in `run_ruby_script'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/railties-4.1.0.beta1/lib/rails/generators/actions.rb:193:in `block in generate'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/thor-0.18.1/lib/thor/actions.rb:192:in `block in in_root'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/thor-0.18.1/lib/thor/actions.rb:182:in `block in inside'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/2.0.0/fileutils.rb:125:in `chdir'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/2.0.0/fileutils.rb:125:in `cd'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/thor-0.18.1/lib/thor/actions.rb:182:in `inside'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/thor-0.18.1/lib/thor/actions.rb:192:in `in_root'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/railties-4.1.0.beta1/lib/rails/generators/actions.rb:193:in `generate'
    from /Users/justin/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/blacklight-4.5.0/lib/generators/blacklight/blacklight_generator.rb:42:in `copy_public_assets'

Here's the code: https://github.com/projectblacklight/blacklight/blob/v4.5.0/lib/generators/blacklight/blacklight_generator.rb#L42

The text was updated successfully, but these errors were encountered:

jcoyne · 2013-12-18T16:27:14Z

Works fine in Rails 3.2 and 4.0

jcoyne · 2013-12-18T18:36:07Z

/cc @jonleighton can you determine if this is a spring issue?

we4tech · 2013-12-22T06:50:22Z

@jcoyne just experienced the same problem. After forcefully killing all existing spring processes it worked.

jonleighton · 2013-12-28T21:42:08Z

@jcoyne can you give me instructions on how to reproduce the problem please?

jcoyne · 2013-12-29T03:48:01Z

@jonleighton Here's a generator that causes the hang:

https://github.com/jcoyne/spring_bug/commit/be686db81e5e1e5c90dd5787bdb8d3d2384b1621

clone and then run

$ rails g bug

ApplicationManager#with_child wants to be able to detect an error on the socket so that we know that the application process is no longer available. It seems that merely closing the socket here is not enough to cause the error (I'm not exactly sure why), so use shutdown instead. This problem was demonstrated by rails/rails#13381, where we have spring running a rails generator, which then shells out and calls back into spring a second time (mind blown). This would be fine except for the fact that the generator changes the gemfile, which causes the application process to want to start exiting, only it can't completely exit because it's still running the generator. That's why we need to shut down the socket so that the spring server knows to start up another application process.

jonleighton · 2014-01-04T22:12:14Z

Thanks, that's very helpful. The above commit prevents the hanging here, but the devise:install bit will just silently fail, so this fix is still a WIP.

A spring command should be able to change the Gemfile and then call back into spring, with the Gemfile changes reflected. See rails/rails#13381

jonleighton · 2014-01-17T14:58:11Z

I've just release Spring 1.1.0 which fixes this.

liorsion · 2014-05-04T11:20:26Z

FYI just happened to me. Using spring (1.1.2)

robin850 · 2014-05-04T14:37:19Z

@liorsion : Could you please report to the spring repository with a way to reproduce if this still a problem for you ? Thanks!

jaake · 2014-07-17T18:04:14Z

Spring 1.1.3 >
/home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/client/run.rb:54:in gets': Interrupt from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/client/run.rb:54:inverify_server_version'
from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/client/run.rb:25:in call' from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/client/command.rb:7:incall'
from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/client/rails.rb:23:in call' from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/client/command.rb:7:incall'
from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/client.rb:26:in run' from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/bin/spring:48:in<top (required)>'
from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/binstub.rb:11:in load' from /home/jaake/.rvm/gems/ruby-2.1.1/gems/spring-1.1.3/lib/spring/binstub.rb:11:in<top (required)>'
from /home/jaake/Projects/yachamps/bin/spring:16:in require' from /home/jaake/Projects/yachamps/bin/spring:16:in<top (required)>'
from bin/rails:3:in load' from bin/rails:3:in

'

Just hangs there forever...

vidbina · 2014-07-20T14:37:19Z

I just peeked in the rep and noticed that the problem ocurred in the verify_server_version call. I stopped spring (using spring stop) and retried the generate command which subsequently restarted spring. This seemed to resolve the issue for me. Apparently a mismatch between versions. 😉

conraddecker · 2014-07-31T18:10:56Z

@vidbina That did the trick for me as well. Thank you!

allcentury · 2014-08-15T13:14:22Z

thanks @vidbina - solved it for me as well

jondlm · 2014-08-23T22:48:51Z

@vidbina I had the exact same issue and running spring stop fixed it as well. 👍

alde · 2014-08-27T06:37:09Z

Great, thanks!

spring stop fixed this for me aswell.

rustanacexd · 2014-09-03T22:04:14Z

spring stop fixed for mine as well thanks!

adjiganoff · 2014-09-12T12:22:52Z

spring stop did the trick, cheers!

laerciocrestani · 2014-11-04T18:38:03Z

spring stop +1

armahillo · 2014-11-19T04:48:58Z

spring stop FTW.

ghost assigned jonleighton Jan 1, 2014

jonleighton added a commit to rails/spring that referenced this issue Jan 10, 2014

Handle recursively executing spring commands better

541048b

A spring command should be able to change the Gemfile and then call back into spring, with the Gemfile changes reflected. See rails/rails#13381

jonleighton closed this as completed Jan 17, 2014

rails locked and limited conversation to collaborators Nov 19, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.1.0.beta1] Generator calling `generate` hangs #13381

[4.1.0.beta1] Generator calling `generate` hangs #13381

jcoyne commented Dec 18, 2013

jcoyne commented Dec 18, 2013

jcoyne commented Dec 18, 2013

we4tech commented Dec 22, 2013

jonleighton commented Dec 28, 2013

jcoyne commented Dec 29, 2013

jonleighton commented Jan 4, 2014

jonleighton commented Jan 17, 2014

liorsion commented May 4, 2014

robin850 commented May 4, 2014

jaake commented Jul 17, 2014

vidbina commented Jul 20, 2014

conraddecker commented Jul 31, 2014

allcentury commented Aug 15, 2014

jondlm commented Aug 23, 2014

alde commented Aug 27, 2014

rustanacexd commented Sep 3, 2014

adjiganoff commented Sep 12, 2014

laerciocrestani commented Nov 4, 2014

armahillo commented Nov 19, 2014

[4.1.0.beta1] Generator calling generate hangs #13381

[4.1.0.beta1] Generator calling generate hangs #13381

Comments

jcoyne commented Dec 18, 2013

jcoyne commented Dec 18, 2013

jcoyne commented Dec 18, 2013

we4tech commented Dec 22, 2013

jonleighton commented Dec 28, 2013

jcoyne commented Dec 29, 2013

jonleighton commented Jan 4, 2014

jonleighton commented Jan 17, 2014

liorsion commented May 4, 2014

robin850 commented May 4, 2014

jaake commented Jul 17, 2014

vidbina commented Jul 20, 2014

conraddecker commented Jul 31, 2014

allcentury commented Aug 15, 2014

jondlm commented Aug 23, 2014

alde commented Aug 27, 2014

rustanacexd commented Sep 3, 2014

adjiganoff commented Sep 12, 2014

laerciocrestani commented Nov 4, 2014

armahillo commented Nov 19, 2014

[4.1.0.beta1] Generator calling `generate` hangs #13381

[4.1.0.beta1] Generator calling `generate` hangs #13381