Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails Guides - Getting Started #13764

Closed
SandyFischler opened this issue Jan 19, 2014 · 8 comments · Fixed by #13774
Closed

Rails Guides - Getting Started #13764

SandyFischler opened this issue Jan 19, 2014 · 8 comments · Fixed by #13774
Labels

Comments

@SandyFischler
Copy link

Hi, just wanted to THANK YOU for this great resource and pass along something that I found confusing....

Being a total newbie to rails and going through the first exercises of creating a blog, I keep getting confused between post as a method and post as a resource. It might be more helpful if the resource in the example was named something other than "post" for clarity.

For example, in this section I'm not sure whether we are talking about the resource post or the the action post.

def create
@post = Post.new(post_params)

@post.save
redirect_to @post
end

private
def post_params
params.require(:post).permit(:title, :text)
end

@chancancode
Copy link
Member

Thanks for reporting this, I wouldn't have realized that but now that you pointed it out I can see that could indeed cause confusion, especially in cases like post_params, and for people coming from more "low level" frameworks.

I don't see why we couldn't substitute that with something like "article" (as in blog article). Do you think that would work?

cc @fxn

@fxn
Copy link
Member

fxn commented Jan 19, 2014

That is a good point, 👍 on using a different model.

@senny
Copy link
Member

senny commented Jan 20, 2014

I'm 👍 on this. I like Article.

@prathamesh-sonpatki
Copy link
Member

I would like to take up this issue. I assume this means changing the Getting Started app code also /cc @senny

@senny
Copy link
Member

senny commented Jan 20, 2014

@prathamesh-sonpatki yes it does.

@prathamesh-sonpatki
Copy link
Member

@fxn i saw that you have updated Gemfile in Getting Started app to use Rails 4.1.0. How can i do that locally? Building gems by rake build and rake install created 4.1.0.beta1 versions of all gems

@fxn
Copy link
Member

fxn commented Jan 20, 2014

I did it by hand, because it cannot be edited after release.

@fxn
Copy link
Member

fxn commented Jan 20, 2014

Oh by the way, I have in mind deleting that sample app, it does not seem to be well maintained.

prathamesh-sonpatki added a commit to prathamesh-sonpatki/rails that referenced this issue Jan 25, 2014
- Used Article model instead of Post as it may confuse with 'post'
  requests
- Tried to wrap the guide to 80 chars lines as much as possible.
- Removed unused image
- Fixes rails#13764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants