Skip to content

Loading…

Sanitize helper method not working properly with html comments. #14104

Closed
krunal opened this Issue · 5 comments

6 participants

@krunal

Following is the example of sanitize method.

>> helper.sanitize("<!-- Script Start --><p>krunal test2</p>")
=> "&lt;!-- Script Start --><p>krunal test2</p>"

We can see in the above code that "html comment" tag get changed in output.

@tomkadwill

cc @krunal @pftg @rafaelfranca I've tested this against #11218 and sanitize correctly ignores HTML comments. Can we close this issue?

@laurocaetano

Hi @tomkadwill!

I think we should wait until #11218 gets merged.

@rails-bot rails-bot added the stale label
@rails-bot

This issue has been automatically marked as stale because it has not been commented on for at least
three months.

The resources of the Rails team are limited, and so we are asking for your help.

If you can still reproduce this error on the 4-1-stable, 4-0-stable branches or on master,
please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions.

@rafaelfranca
Ruby on Rails member

It should be fixed with 4.2. If not please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.