ActionView::Digestor doesn't account for variants #14242

Closed
dhh opened this Issue Mar 1, 2014 · 2 comments

Comments

Projects
None yet
2 participants
Owner

dhh commented Mar 1, 2014

We forgot to deal with variants in regards to the ActionView::Digestor. Needs to be considered just like format.

dhh added this to the 4.1.0 milestone Mar 1, 2014

lukaszx0 was assigned by dhh Mar 1, 2014

Member

lukaszx0 commented Mar 1, 2014

I'll take care of it tomorrow.

@pch pch added a commit to pch/rails that referenced this issue Mar 1, 2014

@pch pch Variants in ActionView::Digestor
Take variants into account when calculating template digests in ActionView::Digest

Fixes #14242
fda8b41

@pch pch added a commit to pch/rails that referenced this issue Mar 3, 2014

@pch pch Variants in ActionView::Digestor
Take variants into account when calculating template digests in
ActionView::Digest.

Digestor#digest now takes a hash as an argument to support variants and
allow more flexibility in the future. Old-style arguments have been
deprecated.

Fixes #14242
89470ae

@pch pch added a commit to pch/rails that referenced this issue Mar 3, 2014

@pch pch Variants in ActionView::Digestor
Take variants into account when calculating template digests in
ActionView::Digest.

Digestor#digest now takes a hash as an argument to support variants and
allow more flexibility in the future. Old-style arguments have been
deprecated.

Fixes #14242
7c3e6d3

@pch pch added a commit to pch/rails that referenced this issue Mar 3, 2014

@pch pch Variants in ActionView::Digestor
Take variants into account when calculating template digests in
ActionView::Digest.

Digestor#digest now takes a hash as an argument to support variants and
allow more flexibility in the future. Old-style arguments have been
deprecated.

Fixes #14242
a2b79e0

@pch pch added a commit to pch/rails that referenced this issue Mar 4, 2014

@pch pch Variants in ActionView::Digestor
Take variants into account when calculating template digests in
ActionView::Digest.

Digestor#digest now takes a hash as an argument to support variants and
allow more flexibility in the future. Old-style arguments have been
deprecated.

Fixes #14242
1858cc6

dhh closed this in #14243 Mar 4, 2014

lukaszx0 added the actionview label Mar 4, 2014

Member

lukaszx0 commented Mar 5, 2014

It's not yet completely solved. Variants implementation is missing few things, this needs to be fixed before 4.1 final release. Reopening.

lukaszx0 reopened this Mar 5, 2014

@pch pch added a commit to pch/rails that referenced this issue Mar 8, 2014

@pch pch Ensure LookupContext in Digestor selects correct variant
Related to: #14242 #14243 14293

Variants passed to LookupContext#find() seem to be ignored, so
I've used the setter instead: `finder.variants = [ variant ]`.

I've also added some more test cases for variants. Hopefully this
time passing tests will mean it actually works.
25f1454

@pch pch added a commit to pch/rails that referenced this issue Mar 8, 2014

@pch pch Ensure LookupContext in Digestor selects correct variant
Related to: #14242 #14243 14293

Variants passed to LookupContext#find() seem to be ignored, so
I've used the setter instead: `finder.variants = [ variant ]`.

I've also added some more test cases for variants. Hopefully this
time passing tests will mean it actually works.
61f8cd8

@pch pch added a commit to pch/rails that referenced this issue Mar 9, 2014

@pch pch Ensure LookupContext in Digestor selects correct variant
Related to: #14242 #14243 14293

Variants passed to LookupContext#find() seem to be ignored, so
I've used the setter instead: `finder.variants = [ variant ]`.

I've also added some more test cases for variants. Hopefully this
time passing tests will mean it actually works.
99ebb32

@pch pch added a commit to pch/rails that referenced this issue Mar 9, 2014

@pch pch Ensure LookupContext in Digestor selects correct variant
Related to: #14242 #14243 14293

Variants passed to LookupContext#find() seem to be ignored, so
I've used the setter instead: `finder.variants = [ variant ]`.

I've also added some more test cases for variants. Hopefully this
time passing tests will mean it actually works.
025c691

lukaszx0 closed this Mar 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment